Fix fBackBitmap and items of fVectorIcons were not released.
Change-Id: I8bf974a9f11852c4b1092490e699b46bd79997eb
Reviewed-on: https://review.haiku-os.org/c/haiku/+/3879
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>
There was a bug in the version of this class previously used by MediaPlayer,
and as a result we have settings where uint32 fields are stored as int32.
If the uint32 version is not found, try the int32 version.
Fixes#16922.
Using the CK505 clock source may need some more checks or configuration
we currently don't do, leading to a blank screen in some systems.
Whatever the reason, disabling it makes the driver work on my machine.
Fixes#16357
Change-Id: If207ffdddcf6e6eb73bc69ce5a8bd2842fd2141b
Reviewed-on: https://review.haiku-os.org/c/haiku/+/3867
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>
Allow for multiple programs to watch for changes in the state
of input devices connected to the system. Previously only one program
at a time could watch input devices. While this functionality was not
implemented in BeOS R5, it was at least documented in the BeBook.
Also added some API documentation where necessary for the function
and related constants.
Change-Id: Icd927998cffcab212bb63bcf10c64c620e9da9a2
Reviewed-on: https://review.haiku-os.org/c/haiku/+/3872
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>
Whenever a device is removed, let usb_raw cancel all its pending
transfers. Does not seems to help with the issue I'm getting however.
Change-Id: Ie2856e68ea402c9f1cc352ac47bbca624e17d3dc
Reviewed-on: https://review.haiku-os.org/c/haiku/+/1424
Reviewed-by: waddlesplash <waddlesplash@gmail.com>
Reviewed-by: Fredrik Modéen <fredrik@modeen.se>
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>
implemented using same pattern as Screen preferences
made corrections from review
Fixes#4262
Change-Id: I658baebcdc6ef7809d871b61db75d0b4099937ed
Reviewed-on: https://review.haiku-os.org/c/haiku/+/3870
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>
Many translatable strings are used in both classes.
Use same B_TRANSLATION_CONTEXT to avoid duplicated
translation efforts.
Change-Id: I514a380de4ac8d414634555c25b90650f370a2cb
Reviewed-on: https://review.haiku-os.org/c/haiku/+/3865
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>
Currently, when trying to change settings in Screen preferences on
a system which uses VESA driver on UEFI system, the displayed error
message is "Invalid argument". This commit simply changes returned
error code to B_UNSUPPORTED, so that in the UI we show
"Operation not supported" error.
Change-Id: I2a654d6f652c7b24ecd23969e04e477456235aa0
Reviewed-on: https://review.haiku-os.org/c/haiku/+/3858
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>
* Move SettingsMessage
* Remove SettingsMessage from MediaPlayer and WebPositive
* Use the central SettingsMessage in MediaPlayer and WebPositive (Later Bluetooth)
* Fix a Jam file.
Change-Id: I3bb82a40082c5ece5c2aea2468a77bcd9f15ce77
Reviewed-on: https://review.haiku-os.org/c/haiku/+/3856
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>
Implemented the xfs_access hook and we now check for permissions where
required.
Change-Id: Idaa71f300e0a73951d13073b66cb9ff37dbfa3ec
Reviewed-on: https://review.haiku-os.org/c/haiku/+/3151
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>
* Inactiveate button and things that don't do anything.
* Those button and controlles that hade any actions in the Bluetooth Pref now saves in settings.
* Fix some windows/views.
* Fix Copyright in last Bluetooth commit.
* Last commit before we move saving settings with BMessage.
* Changed PoupMenu to BOptionPopUp
Change-Id: I32b85f1985b558d24b294a184665e08e6ce18a7d
Reviewed-on: https://review.haiku-os.org/c/haiku/+/3829
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>
As 'blocklisting' sounds weird, esp. when used as verb, call the
option "Disable system componets". Also, "components" is less
technical than "entries".
Change-Id: Ia6dbbbe6ebc800e2017e0fb4b0393d19f07afbc5
Reviewed-on: https://review.haiku-os.org/c/haiku/+/3833
Reviewed-by: Fredrik Holmqvist <fredrik.holmqvist@gmail.com>
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>
These changes add text parameters support to DefaultMediaTheme
for the BParameterWeb class.
Change-Id: I6ec04109af73011f84bb7c1fd5210c5c8842c2cb
Reviewed-on: https://review.haiku-os.org/c/haiku/+/3828
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>
These are the changes using tool clang-format with argument --style=haiku and the changes that were not according to guidelines have been removed.
Change-Id: I2d34370e1e0a112da895001bd220bb82b7086e90
Reviewed-on: https://review.haiku-os.org/c/haiku/+/3827
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>
* Rename "Tools" to "HaikuDepot"
* Move "Settings..." and "Quit" from the new and not well fitting
"Window" menu to "HaikuDepot"
* Add the SettingsWindow to DoCatalogs
Change-Id: I14ca7b6304772555cc440998438e38e3e507214c
Reviewed-on: https://review.haiku-os.org/c/haiku/+/3831
Reviewed-by: Andrew Lindesay <apl@lindesay.co.nz>
This is not my code but from ticket #9265
* Made a picture of how it looks, old left andnew right. https://imagebin.ca/v/5wIe6TIMzw4C
* Think we have a bug somewhere and don't store the name of the Bluetooth device (shown i the image).
* I have made som small changes but other than that it's the same code as in the ticket
* Ran the src/tools/checkstyle/checkstyle.py to get som style stuff, probably missed some anyway.
Change-Id: Ifeb75c8ad890f541e100cdcf78b394675a48ada9
Reviewed-on: https://review.haiku-os.org/c/haiku/+/3825
Reviewed-by: Fredrik Modéen <fredrik@modeen.se>
Various projects, both commercial and OSS, began to use inclusive
terminology. There is no reason to not do it.
In Haiku, bootloader uses Blacklist, which is recommended to replace
with Denylist or Blocklist. I think Blocklist is appropriate here,
since it's a list used to block offending driver at boot.
Some strings remain unchanged for compatibility with previous naming,
but this change prepares for later removal of these (once everyone has
updated their kernel and bootloader).
Change-Id: Id9105ff5e9fcb866000355089b5ef97bf63ee854
Reviewed-on: https://review.haiku-os.org/c/haiku/+/3145
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>
* Should fix#14346. Uploaded executable there doesn't work anymore,
but this patch is prepared for case in #16040, and fixes
#16680 too.
* The issue is that if lambda parameters use an alias, this alias
has that lambda as a parent. Specifically the compiler generates
operator() subprogram, Debugger tries to resolve types for its
parameters, but at the same time it is a parent namespace for
those types.
* Call chain: operator()( -> type 1 -> namespace: operator()( ->
type 1 -> namespace: operator()( -> ...
Change-Id: I7aad150a8d9de4f0c01ae0c1db5e486416b72112
Reviewed-on: https://review.haiku-os.org/c/haiku/+/3824
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>
The code paths for creating a new partition and editing an existing one
are more mixed together than I thought:
- CreateParametersPanel reuses a method from ChangeParametersPanel which
I had modified.
- In the storage kit, the code to create the parameter editor is also
shared between the two.
The problem is that when creating a partition, we have only the parent
BPartition. When modifying parameters, we have the child, and we need
to get some things from the child (the current parameters), and some
from the parent (the parameter editor).
Fixes#16859.
Change-Id: I5978386978c79a351e94c098c065fd43c422eb51
Reviewed-on: https://review.haiku-os.org/c/haiku/+/3822
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>
It is hard to know what is wrong otherwise.
Change-Id: I47658502221dfd7f320ae873cc92f683d7ae3548
Reviewed-on: https://review.haiku-os.org/c/haiku/+/3821
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>
BOOT_VOLUME_BOOTED_FROM_IMAGE is for booting from floppy images
(or CD equivalent) where you can't provide all details.
BOOT_METHOD_CD is also for when all you know that it is a "disc".
UEFI can always give partition offset and checksum, so we can
use BOOT_METHOD_HARD_DISK directly.
Change-Id: Iede9beef2f00eadd7883be0a739caf4eb11969c1
Reviewed-on: https://review.haiku-os.org/c/haiku/+/3820
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>
a protection_max attribute is added in VMArea.
a read-only opened file already can't be mapped shared read-write at the moment,
but can later be changed to read-write with mprotect() or set_area_protection().
When creating the VMArea, the actual maximum protection is stored in the area,
so that it can be checked when needed.
this fixes a VM TODO.
Change-Id: I33b144c192034eeb059f1dede5dbef5af947280d
Reviewed-on: https://review.haiku-os.org/c/haiku/+/3804
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>
