Aren/haiku
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

intel partition map: use more specific errors

Browse Source 
It is hard to know what is wrong otherwise.

Change-Id: I47658502221dfd7f320ae873cc92f683d7ae3548
Reviewed-on: https://review.haiku-os.org/c/haiku/+/3821
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>
This commit is contained in:
Adrien Destugues 2021-03-23 22:46:25 +01:00 committed by Adrien Destugues
parent f97357a6ed
commit 7534e5870d
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/add-ons/disk_systems/intel/PartitionMapAddOn.cpp
View File

@ -357,11 +357,11 @@ PartitionMapHandle::ValidateCreateChild(off_t* _offset, off_t* _size,
// check type
PartitionType type;
if (!type.SetType(typeString) || type.IsEmpty())
return B_BAD_VALUE;
return B_BAD_TYPE;
if (type.IsExtended() && fPartitionMap.ExtendedPartitionIndex() >= 0) {
// There can only be a single extended partition
return B_BAD_VALUE;
return B_NAME_IN_USE;
}
// check name
@ -377,7 +377,7 @@ PartitionMapHandle::ValidateCreateChild(off_t* _offset, off_t* _size,
// do we have a spare primary partition?
if (fPartitionMap.CountNonEmptyPrimaryPartitions() == 4)
return B_BAD_VALUE;
return B_BAD_INDEX;
// check the free space situation
BPartitioningInfo info;
@ -388,7 +388,7 @@ PartitionMapHandle::ValidateCreateChild(off_t* _offset, off_t* _size,
// any space in the partition at all?
int32 spacesCount = info.CountPartitionableSpaces();
if (spacesCount == 0)
return B_BAD_VALUE;
return B_DEVICE_FULL;
// check offset and size
off_t offset = sector_align(*_offset, Partition()->BlockSize());