Eduard Mielieshkin
a785fd9c4a
formatted using clang-format
2023-09-14 12:02:26 +02:00
Eduard Mielieshkin
4dcf35c0cb
PoC: waiting until an AVD instance is up
2023-09-14 12:02:26 +02:00
David Fort
1afaaa82d3
[core,arm] Various fixes and adjustements for #9363
...
Treat the case where the publicIpAddress is there but empty.
Don't try RDSTLS if the password has not been been provided.
When RDSTLS is what we will do, disengage all the other security kinds.
2023-09-14 09:00:46 +02:00
akallabeth
7a17671cc9
[codec,h264] first update sizes before checking
2023-09-11 12:53:35 +02:00
akallabeth
d93c4fea2c
[codec,interleaved] fix compiler warning
2023-09-11 12:53:35 +02:00
Armin Novak
517ca5c714
[primitives] fix neon use of WINPR_RESTRICT
2023-09-11 10:04:56 +02:00
Armin Novak
730c621699
[codec,interleaved] fix type definition
2023-09-08 14:44:22 +02:00
akallabeth
9a9db5b7f3
[codec,progressive] expose progressive simple
...
server implementations might require serializing messages to a simple
tile, so expose this function.
2023-09-05 11:40:09 +02:00
Armin Novak
5f8f69512b
[core,orders] fix reading order number field
...
the field for delta rectangles/points/... are only transmitted if they
changed from the previous order of the same type. So keep the original
value and update only if a new one is read.
2023-09-04 12:24:57 +02:00
Armin Novak
12e6bbe13b
[core,orders] log order fields not in packet
2023-09-04 11:32:35 +02:00
Armin Novak
1a1f422d79
[core,orders] unify delta point buffer allocation
2023-09-04 11:32:35 +02:00
Armin Novak
36b58c0688
[core,orders] abort if required filed is not found
2023-09-04 11:32:35 +02:00
Armin Novak
618102b28f
[core,orders] update log message
2023-09-04 11:32:35 +02:00
David Fort
8a39859612
[arm] various improvements
...
This patch moves the ARM configuration before starting the connection process, so
that we can do some provisioning of the FreeRDP settings with the items retrieved
from Azure.
Most notably that allows us to connect directly using RDSTLS security.
2023-09-04 10:24:56 +02:00
David Fort
361da15eed
[crypto] extend base64 to output crLf when encoding
...
Some windows APIs do put \r\n every 64 characters of the output of a
base64 encoded blob. The extended version of crypto_base64_encode allows
to do the same.
2023-09-04 10:24:56 +02:00
akallabeth
ce41d514ab
[core,info] fix rdp_read_info_string
...
* Use proper freerdp_set_string* functions to set string
* In case of failure clean up existing string values
2023-09-02 07:56:21 +02:00
akallabeth
b4ce44c290
[settings] add freerdp_settings_take_string
...
this function can take an allocated value, set the settings string to it
and free it up once replaced by something else.
2023-09-02 07:56:21 +02:00
akallabeth
2102fa907a
[core,connection] use dynamic logger rdp->log
...
for state transition logging use dynamic logger instead.
2023-09-02 07:56:21 +02:00
akallabeth
54021b50b0
[core,peer] fix initial state transitions
...
update initial state transitions according to [MS-RDPBCGR]
the diagram is misleading, some of the text below ambigious, but
1.3.1.1 Connection Sequence phase 10 description lists the dependencies
of server initiated messages.
2023-09-02 07:56:21 +02:00
akallabeth
4461219497
[core,rdp] make monitor layout PDU optional
...
the PDU might arrive or not, do not get stuck if not.
2023-09-02 07:56:21 +02:00
akallabeth
539546a6be
[cmake] correctly link WinPR to FreeRDP
2023-08-31 11:39:22 +02:00
Armin Novak
3ea38175b4
[locale,keyboard] fix keyboard mapping on apple
2023-08-31 11:39:22 +02:00
Armin Novak
d6f9d33a7d
[codec,planar] fix reset
2023-08-30 11:12:09 +02:00
akallabeth
ab31e8ba6a
[codec,h264] ensure context buffer update
...
if realloc is called with 0 size update the pointers and do not fail
2023-08-30 11:11:58 +02:00
akallabeth
17d64237ef
[codec,yuv] check rectangles for validity
...
the decoder needs to check bounds for supplied rectangles for both,
input and output buffers.
2023-08-28 14:26:10 +02:00
akallabeth
e04e28def9
[primitives,yuv] clean up code, assert arguments
2023-08-28 14:26:10 +02:00
Armin Novak
16141a30f9
[codec,ncrush] fix index checks
...
properly verify all offsets while decoding data.
2023-08-28 13:35:45 +02:00
Armin Novak
1bbed81041
[core,orders] fix checks for multi opaque rect
2023-08-28 13:07:28 +02:00
Armin Novak
031c8bacfa
[codec,zgfx] fix cBitsRemaining calculation
...
fixed out of bound read reported by @pwn2carr
2023-08-28 12:50:55 +02:00
akallabeth
cd1da25a87
[codec,nsc] fix input length validation
2023-08-28 09:13:59 +02:00
akallabeth
60dd48e698
[api] fix integer overflow warnings
2023-08-25 14:36:05 +02:00
akallabeth
d350b89fe3
[emu,scard] fix return type
2023-08-25 14:36:05 +02:00
akallabeth
bb5345c60e
[freerdp,api] add FREERDP_ENTRY_POINT
...
C requires prototypes or compilers will complain about them missing. Our
library entry points do not have such, therefore add the macro
FREERDP_ENTRY_POINT which declares the function prototype automatically
before the function.
2023-08-25 14:36:05 +02:00
akallabeth
b608be19e4
[codec,color] WINPR_RESTRICT for copy operations
2023-08-25 14:13:30 +02:00
akallabeth
63cb0b5f19
[codec,rfx] use WINPR_RESTRICT keyword
2023-08-25 14:13:30 +02:00
akallabeth
3dcd702676
[primitives,yuv] use WINPR_RESTRICT
2023-08-25 14:13:30 +02:00
akallabeth
4e824b243f
[winpr] add WINPR_ATTR_FORMAT_ARG
...
this macro declares the function argument (pos,arg) to be a printf
style format string and enables compiler checks for that.
2023-08-25 12:56:36 +02:00
akallabeth
9cee9b3c08
[c standard] use WINPR_FALLTHROUGH
...
use the macro to silence intentional switch fallthrough locations
2023-08-25 12:56:36 +02:00
akallabeth
0a90e9214e
[core,aad] fix type mismatch warning
2023-08-25 12:56:36 +02:00
akallabeth
e975daec20
[codec,clear] fix missing bounds checks
2023-08-25 12:30:15 +02:00
akallabeth
576f836348
[codec,progressive] fix missing destination checks
2023-08-25 12:16:22 +02:00
akallabeth
11461a1b6d
[codec,interleaved] fix bounds checks
2023-08-25 12:01:05 +02:00
akallabeth
feb5ab52cb
[core,rdp] add log messages for unexpected data
2023-08-25 08:42:31 +02:00
akallabeth
8995241ff5
[utils,passphrase] fix type mismatch
2023-08-24 13:17:57 +02:00
akallabeth
d3ba8ebf00
[core,update] log BeginPaint/EndPaint failure
2023-08-23 14:27:51 +02:00
akallabeth
023c2dba6e
[core,autodetect] log unknown message types
2023-08-23 14:27:51 +02:00
akallabeth
769ffbd8a0
[core,fastpat] add logging for failures
2023-08-23 14:27:51 +02:00
akallabeth
74b1d5da89
[core,redirection] add logging
...
add log messages for all possible failure causes
2023-08-23 14:27:51 +02:00
akallabeth
3e744e13c3
[smartcard] clean up function table wrapper
2023-08-23 12:26:27 +02:00
Marc-André Moreau
30c31d64e8
WinSCard dynamic API loading with /winscard-module cli argument
2023-08-23 12:26:27 +02:00
akallabeth
7a71441476
[warnings] fix integer multiplications
...
Ensure the integer width for size arguments is 64bit in a
multiplication. Leading 64bit constant 1ull expands width, a trailing
one is ignored.
2023-08-22 11:55:00 +02:00
liuxiaojun
6e5f74e462
optimize idwt extrapolate decoder with neon
2023-08-22 10:54:48 +02:00
akallabeth
859b1b5f0b
[codec,nsc] ensure integer width
...
ensure multiplication result is 64bit
2023-08-22 10:26:56 +02:00
Rubycat
68b1614b66
Do not fail on certificates without subject
...
It is possible to implement an rdp client that accepts certificates by
fingerprint by using VerifyCertificateEx. In case the server uses a
certificate without subject (which, apparently, is not mandated by X509)
freerdp_certificate_data_load_cache fails and the certificate is refused
even before calling VerifyCertificateEx. This commit changes
freerdp_certificate_data_load_cache to consider that missing subject is
the same as an empty string.
Also downgrade the log message complaining about missing subject and
issuer to a warning.
2023-08-21 16:03:36 +02:00
Armin Novak
65a05fc490
[core,server] set freed pointer NULL
...
Fixes #9271 : after freeing the memory reset it to NULL to signal it was
already handled.
2023-08-21 13:35:36 +02:00
2fly2
bce9f1cbe6
[core,settings] default disable ThinClient setting
...
fixes show black window when connect transparent app in
windows server 2012r2
2023-08-21 13:03:56 +02:00
Marc-André Moreau
c691ef9c8d
allow selecting smartcard emulator at runtime rather than link time
2023-08-21 12:00:17 +02:00
Armin Novak
9f967b4942
[codec,color] fix freerdp_image_fill
...
in case width or height == 0 out of bounds write might happen.
reported by @pwn2carr
2023-08-21 11:43:50 +02:00
Armin Novak
e204fc8be5
[coded,rfx] check indices are within range
...
reported by @pwn2carr
2023-08-21 11:41:06 +02:00
Armin Novak
1ca6362498
[codec,rfx] free content of currentMessage on fail
2023-08-21 11:39:40 +02:00
Armin Novak
10a29dbc99
[codec,nsc] fix missing plane length check
...
reported by @pwn2carr
2023-08-21 11:38:13 +02:00
Marc-André Moreau
8c670b177b
fix freerdp_key_generate for some versions of OpenSSL (null key->evp)
2023-08-15 15:00:49 +02:00
akallabeth
63a2f65618
[codec,rfx] fix possible out of bound read
...
Allows malicious servers to crash FreeRDP based clients
reported by @pwn2carr
2023-08-04 15:09:59 +02:00
akallabeth
22fffdd5ea
[freerdp,api] log NULL IFCALL/IFCALLRET calls
2023-08-04 12:59:11 +02:00
akallabeth
e51a5b33fb
[core,orders] fix undefined variable, unify log strings
2023-08-03 13:54:03 +02:00
ehdgks0627
2496037f03
Standardize failure messages for order functions
2023-08-03 13:54:03 +02:00
ehdgks0627
105ce6c56b
Update error message when update_read* function failed
2023-08-03 13:54:03 +02:00
Kai Pastor
5ecc011c13
Export interface include directories
2023-08-01 11:12:46 +02:00
Armin Novak
0cd36c1526
[build] fix Wmissing-prototypes
2023-08-01 08:37:58 +02:00
Kai Pastor
21cfc456f5
find_dependency for exported cmake config
2023-08-01 08:13:30 +02:00
Joan Torres
c843e35b75
[codec] encode messages considering endianness
...
The byte order of the pixels is affected by endianness, use bitwise
operations to access those bytes so the endiannes won't affect the final
result.
2023-08-01 07:56:16 +02:00
Joan Torres
a332db7cf5
[libfreerdp] fix endianness issues
...
There were some fields sent without considering endianness, making the
clients fail when parsing those fields.
Use Data_Write_XXX functions so the endiannes won't affect the byte order
and the clients will read properly the fields.
2023-08-01 07:56:16 +02:00
Richard Markiewicz
f59c98eebe
[core,info] Fix rdp_info_read_string conversion check
2023-08-01 07:15:59 +02:00
Armin Novak
ef5c0e78ab
[build] use define WINPR_FALLTHROUGH
...
with c17 compatible compilers annotate with [[fallthrough]]
2023-07-31 23:46:53 +02:00
Armin Novak
e7c2a75e1e
[gateway,rpc] return FREERDP_ERROR_CONNECT_ACCESS_DENIED
...
unify http and rpc gateway return codes
2023-07-31 16:51:14 +02:00
Armin Novak
c656bb9d1d
[core,gateway] ensure '\0' termination of http response
2023-07-31 16:51:14 +02:00
Armin Novak
de6aaded94
[core,gateway] improve http_response_print
...
print out all response data.
2023-07-31 08:46:57 +02:00
Armin Novak
4e1781740c
[codec,test] fix wrong format string
2023-07-31 08:32:43 +02:00
Armin Novak
0afa2e88b5
[crypto,cert] imrove logged warnings for certificates
2023-07-31 08:32:43 +02:00
Armin Novak
1618677e13
[codec,progressive] fix warnings
2023-07-31 08:32:43 +02:00
Armin Novak
8be9a3a5dd
[core,gateway] unify http response logging
2023-07-31 08:32:43 +02:00
Armin Novak
03b78dd57b
[aad] print http status response message
2023-07-28 16:42:23 +02:00
Armin Novak
cd7cb514a8
[core,gateway] unify http response logging
2023-07-28 16:42:23 +02:00
Armin Novak
0bdb62e9b5
[libfreerdp] fix integere narrow warnings
2023-07-28 15:48:32 +02:00
ehdgks0627
d04ba8d6ef
Correct typos and formatting errors in format strings
...
In several files, fixed typos in format strings that were causing unexpected output and formatting issues.
2023-07-28 15:34:46 +02:00
Armin Novak
c4528d58bc
[codec,rfx] fix shift bitwidth warnings
2023-07-28 13:42:12 +02:00
Armin Novak
4fef924531
[codec,interleaved] fix type width warnings
2023-07-28 13:42:12 +02:00
Armin Novak
c728bb9647
[codec,ncrush] fix type cast warnings
2023-07-28 13:42:12 +02:00
Armin Novak
077aff0217
[core] fix cast warnings
2023-07-28 13:42:12 +02:00
Armin Novak
9d5e95c60b
[core] fix unary minus warnings
2023-07-28 13:42:12 +02:00
Armin Novak
60dc504494
[codec,rfx] fix sign warnings
2023-07-28 13:42:12 +02:00
Armin Novak
0aab55d492
[codec,progressive] fixed sign warnings
2023-07-28 13:42:12 +02:00
Armin Novak
7dc8a4a51d
[codec,planar] fixed sign warnings
2023-07-28 13:42:12 +02:00
Armin Novak
32b9eeb3c0
[winpr,sysinfo] deprecage GetVersionInfoEx
...
the function is deprecated under windows, so deprecate it in WinPR too
and remove/replace usage
2023-07-28 13:42:12 +02:00
Armin Novak
1e0ca536c7
[ci,nightly] use internal MD4, MD5 and RC4 on windows
2023-07-28 13:42:12 +02:00
Armin Novak
6c6eaf5144
[primitives,yuv] fix pointer cast warnings
2023-07-28 13:42:12 +02:00
Armin Novak
b1dee0f56c
[codec,rfx] fix sign warnings
2023-07-27 21:05:43 +02:00
Armin Novak
64f4fe397c
[crypto,tls] fixed sign warnings
2023-07-27 21:05:43 +02:00
Armin Novak
76169c26cd
[core,caps] fix warnings
2023-07-27 20:02:43 +02:00
Armin Novak
723056dab3
[codec,audio] fix warnings
2023-07-27 20:02:43 +02:00
Armin Novak
6c01433f6a
[core,smartcardlogon] fix warnings
2023-07-27 20:02:43 +02:00
Armin Novak
e61880d077
[standard] replace __FUNCTION__ with __func__
2023-07-27 20:02:43 +02:00
Martin Fleisz
bb9c32ed72
gateway: Allow authentication using a NULL (current user) identity
2023-07-26 16:35:36 +02:00
Armin Novak
70ddb6518a
[PathCchAppend] fix missing return checks
2023-07-26 10:57:42 +02:00
fifthdegree
8330aa1ac4
Log aad authentication_result as hex and string
2023-07-26 09:44:17 +02:00
ehdgks0627
3589e2468d
Refactor: Improve error message in is_within_surface function
...
In the function is_within_surface, the error message for out-of-bounds command rectangles has been enhanced for better clarity. The code has been modified to display the rectangle coordinates and surface dimensions in the error message. This change aims to make debugging easier and improve the overall code quality.
2023-07-25 20:12:10 +02:00
Armin Novak
a5ea634516
[core] fix cJSON compat
...
* only export used symbols, provide prototypes when required
* clean up some length checks
2023-07-24 09:54:49 +02:00
akallabeth
830d1e17b6
[utils] improve http request logging
2023-07-21 14:53:19 +02:00
akallabeth
14d0ec9335
[core] move http status to string to utils
...
freerdp_http_status_string and freerdp_http_status_string_format are now
exposed as public API functions to work with http status codes
2023-07-21 14:53:19 +02:00
Michael Saxl
bc2caa8504
[util,http] set sni on the ssl connection
2023-07-21 09:50:02 +02:00
dev
80c7818f99
fix warning
2023-07-21 09:14:54 +02:00
Armin Novak
3d1bb4e1d9
[client,common] allow forcing default callbacks
...
All clients can implement their own callbacks for
certificate/credential/smartcard/... but there is a common (default)
implementation for all clients.
with the new setting FreeRDP_UseCommonStdioCallbacks it is now possible
to force these over the client implementation provided ones
2023-07-20 14:25:08 +02:00
akallabeth
a0d38914d6
[core,aad] refactor use of cJSON
...
* link cJSON public to FreeRDP
* export compatibility functions for older versions of cJSON
2023-07-20 14:20:28 +02:00
akallabeth
5d8e21927c
[warnings] fix compiler warnings
2023-07-20 14:20:28 +02:00
Armin Novak
15fc803981
[utils,http] add openssl 1.1 compatibility
2023-07-20 14:20:28 +02:00
akallabeth
ee078cdda4
[warnings] fix format string warnings
2023-07-20 14:20:28 +02:00
akallabeth
1d94ae9cc0
[utils,http] fix parser checks
2023-07-20 14:20:28 +02:00
akallabeth
734117351d
[aad,avc] unify callbacks to GetAccessToken
...
The AAD and AVD authentication mechanisms both need an OAuth2 token.
They only differ in the provided arguments, so unify the callbacks into
a single one with variable argument lists.
2023-07-20 14:20:28 +02:00
fifthdegree
d309fcd6e8
Restructure Azure AD related stuff
...
- Move responsibility for obtaining access tokens to clients
- Add function for getting access tokens for AVD
- Get correct server hostname during AVD setup
- Add utility function for doing http requests
2023-07-20 14:20:28 +02:00
Pascal Nowack
4d7d136d1a
core/server: Remove invalid cast
...
The context of wMessage is already a pointer, so the cast into UINT_PTR
is wrong here.
Additionally, casts from void pointers are superfluous.
2023-07-20 11:36:11 +02:00
Armin Novak
6d9d118593
[core,nego] remove AUTHZ_RESULT from nego header
2023-07-13 09:25:45 +02:00
Armin Novak
555fa2c98a
[core,nla] print name of error code in log
2023-07-13 09:25:45 +02:00
Armin Novak
10e010329c
[client,file] add WebAuthN rdp file parsing support
2023-07-10 10:45:28 +02:00
akallabeth
e18918356f
[core,rdp] set logger context
2023-07-06 15:51:56 +02:00
Martin Fleisz
a5aad5159c
core: Fix issues in settings copy code
...
This code fixes an issue where some settings were lost when copying
settings around. I.e. the device count was first set but then calling
`freerdp_settings_set_pointer_len` caused the device count to be reset
to 0 because we passed `NULL` for the data value.
This means the count got lost upon the first copy and further copies
also resulted in losing the array data (because the count was set to 0).
This PR fixes this issue by first resetting the array and afterwards
setting the correct count value.
2023-07-06 14:26:38 +02:00
Bernhard Miklautz
9961570c9d
[utils] use select instead of poll to read passphrases on macOS
...
According to the man page on macOS poll currently doesn't support
devices. This includes `/dev/tty`.
In this use case poll will returned immediately indicating that
something can be read but the following read returned `-1`
(with errno set to EAGAIN).
Using select on macOS for passphrase reading prevents this problem.
2023-07-06 08:03:53 +02:00
akallabeth
4c862892b4
[core,gateway] clean up websocket transport
2023-07-05 13:18:54 +02:00
akarl10
76abdcdabf
[core,gateway] cleanup http response
2023-07-05 10:43:27 +02:00
akallabeth
18185e9dbc
[test] disable TestConnect on windows
...
build directories are different and the test logic can not find the
binaries necessary to launch
2023-07-05 08:46:00 +02:00
akallabeth
d9b03b45ed
[test] add executable suffix for TestConnect
2023-07-05 08:46:00 +02:00
Michael Saxl
a5a60c888b
[core,transport] free wst transport after use
2023-07-04 20:33:13 +02:00
Martin Fleisz
622a2a8df0
misc: More int to BOOL conversion fixes
...
This is a follow up to #9129 .
This PR fixes some problematic `int` to `BOOL` conversions that might
cause overflows when checking for bit flags.
2023-07-04 09:45:20 +02:00
Martin Fleisz
37f9d5b494
core: Fix flag check to enable/disable RDSTLS security
...
On some platforms (i.e. Mac) the BOOL type might be narrower than the
`RedirectionFlags` type leading to an overflow when just assigning the
logical AND result to the setting. This fix makes sure that the value is
correctly set to either `TRUE` or `FALSE`.
2023-07-04 09:17:05 +02:00
akallabeth
a01f3ec5ab
[client,common] allow adding a named keyboard pipe
...
This allows starting FreeRDP clients with a named pipe that will type in
text written to the named pipe as keyboard input
2023-07-03 13:21:43 +02:00
Armin Novak
382ef13b1d
[locale,xkb] cleaned up variant detection
2023-07-03 10:19:34 +02:00
akallabeth
32b60ae438
[pointer] unify mouse pointer settings
2023-07-03 10:00:29 +02:00
Michael Saxl
132ce797db
[core,gateway,wst] fix use after free in wst_connect
2023-07-03 10:00:12 +02:00
Konrad Bucheli
d4e2129cd4
the default Swiss keyboard layout is German, French is a variant
2023-07-03 09:52:14 +02:00
akallabeth
e03b6596c6
[build] fix unused but set variable warnings
2023-06-29 18:34:51 +02:00
akallabeth
2d16985d68
[primitives] fix typo, reading wrong buffer
2023-06-29 18:34:51 +02:00
akallabeth
851f9cce2d
[core,nla] fix unused variable warning
2023-06-29 18:34:51 +02:00
akallabeth
5dcd9fcb8a
[core,gateway] eliminate intermediate buffer
2023-06-29 18:34:51 +02:00
akallabeth
4fb7035242
[common,assistance] fix shadowed variable
2023-06-29 18:34:51 +02:00
Armin Novak
66cb8c68d4
[core,nego] change nego_set_routing_token argument
...
Use void* instead of BYTE* as the real type is unknown and warnings can
be avoided
2023-06-29 14:46:41 +02:00
akallabeth
37d9c891b4
[core,gateway] fix return value checks
2023-06-29 14:30:09 +02:00
akallabeth
b9ec4ef60d
[core,info] fix stream read check
...
read into variable of wrong type, fixed that.
2023-06-29 14:30:09 +02:00
Armin Novak
de7fea7347
[core,gcc] gcc_read_client_data_blocks update checks
...
* Update checks for stream consumed
* Update log messages, use stringified version of block type
2023-06-29 08:09:53 +02:00
akarl10
8d707adcb2
[core,gateway] make http authentication work again for websocket transport
2023-06-28 11:40:22 +02:00
David Fort
27a5ea64f0
[codecs] fix R and B inversion when decoding planar
2023-06-28 10:57:55 +02:00
akarl10
7f19fab76e
[core,gateway] only encode a cookie line if there is a cookie
2023-06-28 10:47:47 +02:00
akallabeth
3f78b3c379
[build] fix unused compiler warnings
2023-06-28 09:45:09 +02:00
Armin Novak
4d807a0bf0
[core,gateway] fix check for authentication
2023-06-27 21:15:08 +02:00
Armin Novak
ea66b23631
[core,gateway] fix various issues with arm transport
...
* fix possible leaks
* split big functions
* fix missing NULL checks
2023-06-27 21:15:08 +02:00
akallabeth
ca47058e8c
[core,gateway] use custom copy for listdictionary
2023-06-27 21:15:08 +02:00
akallabeth
84fabc49e2
[core,gateway] fix locking in http_encode_cookie_line
2023-06-27 21:15:08 +02:00
akarl10
d62b088527
[gateway,wst] Update log about supported url types
2023-06-27 21:15:08 +02:00
akarl10
1108d88fc4
[gateway,wst] make WWW-Authenticate: NTLM (without data) work again
...
This happens in wst.c because the first try is always anonymous
2023-06-27 21:15:08 +02:00
Michael Saxl
d55e035260
[gateway,arm] Azure Virtual Desktop Gateway support
...
This PR creates a new /gateway:type:arm transport.
It depends on CJSON
The arm transport is not a transport by itself but is responsible
for getting the websocket endpoint from a configuration url derived from
the configured gateway host in the rdpw file or cmdline
2023-06-27 21:15:08 +02:00
Vic Lee
5fffaf6cd2
[codec,rfx] missing palette setting api.
2023-06-27 08:54:54 +02:00
akallabeth
40dd43cb01
[core,gcc] use static substream for client data
2023-06-26 19:17:55 +02:00
akallabeth
b69c259967
[core,gcc] dump unknown GCC types with trace log
2023-06-26 19:17:55 +02:00
Hugues LEFEBVRE
b67afecf0f
CredSSP with early user auth (nla_ext) support
2023-06-26 11:53:46 +02:00
akallabeth
ff2b57c634
[core,peer] fixed invalid pointer to log function
2023-06-26 10:53:43 +02:00
akallabeth
4d350978dd
[core] assert rdp->context
2023-06-26 10:53:43 +02:00
akarl10
63c80423a9
[multitransport] Ignore unknown data
...
If the reserved filed is not 0 the request PDU seems to contain
some extra data. Two bytes of 0 (probably a version field) followed by a
JSON payload (not null terminated, until the end of the packet. There
seems to be no dedicated length field)
2023-06-26 09:09:47 +02:00
Armin Novak
52ec17309a
[core,caps] use settings getter/setter for unicode
2023-06-23 08:18:16 +02:00
Michael Saxl
44c1ec3276
[gateway,websocket] implement plain websocket transport
...
* factor out most websocket specific code parts into websocket.c
* create wst.c (Websocket Transport) as gateway transport implementation
* introduce GatewayUrl setting that holds the websocket url
* introduce GatewayHttpExtAuthBearer that holds the HTTP Bearer
* GatewayHttpExtAuthBearer can be used by both rdg and wst
2023-06-22 09:21:42 +02:00
Michael Saxl
6478edda5b
rdg bearer support
2023-06-22 09:21:42 +02:00
akallabeth
1fc0d5b4b1
[winpr] remove casts for winpr_RAND calls
2023-06-21 09:57:52 +02:00
Armin Novak
e264512220
[common,assistance] fix missing NULL check
2023-06-19 09:24:18 +02:00
Armin Novak
84320903c3
[common,assistance] add test case
2023-06-19 09:24:18 +02:00
fifthdegree
80f357ddcb
Add missing arg to aad token request format string
2023-06-19 08:42:33 +02:00
akallabeth
18df3176e1
[common,assistance] fix assistance file parser
...
* ensure a valid delimiter is following the token searched for
* add a test case to ensure this works
2023-06-16 09:14:10 +02:00
Armin Novak
df3c78a91d
[server,core] add CheckPeerAcceptRestrictions
...
the new (optional) callback CheckPeerAcceptRestrictions is used to check
for server implementation specific connection requirements before
accepting a client.
2023-06-14 17:15:21 +02:00
Richard Markiewicz
946cfb1068
[core,license] Fix build on msvnc with WITH_DEBUG_LICENSE
2023-06-14 17:14:45 +02:00
Armin Novak
3fd78adaed
[utils] fix variable name in wait_for_fd
...
if build without WINPR_HAVE_POLL_H there was a mistyped variable.
2023-06-14 13:50:59 +02:00
Armin Novak
010e1252c4
[common,assistance] fix NULL argument for strstr
2023-06-14 13:50:59 +02:00
Mikhail Kashin
aeb6ec6f97
[core] fix handling loadbalanceinfo tsv://MS Terminal Services Plugin
2023-06-14 09:06:50 +02:00
Marc-André Moreau
4d4dcd4511
Fix usage of explicit server name when different from connection host
2023-06-13 09:20:17 -04:00
akallabeth
89bbed83db
[common,assistance] clean up assistance file parser
2023-06-13 10:03:57 +02:00
fifthdegree
53023a0627
Fix AAD token request body
2023-06-13 07:39:49 +02:00
akallabeth
6121ace62a
[codec,rfx] unify tile allocation
2023-06-12 16:32:23 +02:00
akallabeth
93d8a93556
[codec,rfx] assert rfx_write_tile arguments
...
Ensure that in all paths the function arguments are valid.
2023-06-12 16:32:23 +02:00
akallabeth
a64dd36073
[build] fixed const warnings
2023-06-12 16:32:23 +02:00
akallabeth
45a54b1883
[core] fix typo in debug string
2023-06-12 11:13:43 +02:00
Armin Novak
b05eacb99e
[build] fixed compilation warnings
2023-06-08 08:13:16 +02:00
Armin Novak
381183f421
[core,gateway] align RPC_FAULT_CODES
...
some architectures require alignment (apple looking at you)
2023-06-08 08:11:05 +02:00
Armin Novak
47e9503385
[codec,dsp] fix unused variable warning
2023-06-08 08:11:05 +02:00
Armin Novak
970f0c54e8
[stream] use const correct Stream_Pointer access
2023-06-08 08:09:33 +02:00
Armin Novak
d0c5b1ae42
[codec,dsp] fix ffmpeg deprecations
2023-06-08 08:09:33 +02:00
Armin Novak
81e95e51ca
[winpr,ncrypt] log problems during cert enumeration
2023-06-07 23:05:54 +02:00
Sergey Bronnikov
62697e58d9
[libfreerdp] Pass a zero-terminated string to freerdp_assistance_parse_file_buffer
...
```
READ of size 2 at 0x602000000091 thread T0
SCARINESS: 14 (2-byte-read-heap-buffer-overflow)
#0 0x4c6fb9 in StrstrCheck(void*, char*, char const*, char const*) /src/llvm-project/compiler-rt/lib/asan/../sanitizer_common/sanitizer_common_interceptors.inc:580:5
#1 0x4c6df1 in strstr /src/llvm-project/compiler-rt/lib/asan/../sanitizer_common/sanitizer_common_interceptors.inc:597:5
#2 0x56c9ba in freerdp_assistance_parse_file_buffer /src/FreeRDP/libfreerdp/common/assistance.c:743:6
#3 0x56b58e in parse_file_buffer /src/FreeRDP/libfreerdp/common/test/TestFuzzCommonAssistanceParseFileBuffer.c:11:11
#4 0x56b58e in LLVMFuzzerTestOneInput /src/FreeRDP/libfreerdp/common/test/TestFuzzCommonAssistanceParseFileBuffer.c:20:2
#5 0x43f5e3 in fuzzer::Fuzzer::ExecuteCallback(unsigned char const*, unsigned long) /src/llvm-project/compiler-rt/lib/fuzzer/FuzzerLoop.cpp:611:15
#6 0x440994 in fuzzer::Fuzzer::ReadAndExecuteSeedCorpora(std::__Fuzzer::vector<fuzzer::SizedFile, std::__Fuzzer::allocator<fuzzer::SizedFile> >&) /src/llvm-project/compiler-rt/lib/fuzzer/FuzzerLoop.cpp:804:3
```
2023-06-07 14:25:57 +02:00
Sergey Bronnikov
3266dc984a
[libfreerdp] Fix TestFuzzCommonAssistanceHexStringToBin
...
Test breaks contract in freerdp_assistance_hex_string_to_bin():
function expects zero-terminated string. Patch fixes that.
2023-06-07 14:25:57 +02:00
Sergey Bronnikov
d8254c5ff3
[libfreerdp] Fix msan's use-of-uninitialized-value
...
Uninitialized bytes in __interceptor_strlen at offset 0 inside [0x701000000040, 1)
==220==WARNING: MemorySanitizer: use-of-uninitialized-value
#0 0x535c13 in freerdp_assistance_hex_string_to_bin /src/FreeRDP/libfreerdp/common/assistance.c:711:11
#1 0x533deb in LLVMFuzzerTestOneInput /src/FreeRDP/libfreerdp/common/test/TestFuzzCommonAssistanceHexStringToBin.c:5:15
#2 0x43f5f3 in fuzzer::Fuzzer::ExecuteCallback(unsigned char const*, unsigned long) /src/llvm-project/compiler-rt/lib/fuzzer/FuzzerLoop.cpp:611:15
#3 0x4409a4 in fuzzer::Fuzzer::ReadAndExecuteSeedCorpora(std::__Fuzzer::vector<fuzzer::SizedFile, std::__Fuzzer::allocator<fuzzer::SizedFile> >&) /src/llvm-project/compiler-rt/lib/fuzzer/FuzzerLoop.cpp:804:3
#4 0x440e79 in fuzzer::Fuzzer::Loop(std::__Fuzzer::vector<fuzzer::SizedFile, std::__Fuzzer::allocator<fuzzer::SizedFile> >&) /src/llvm-project/compiler-rt/lib/fuzzer/FuzzerLoop.cpp:857:3
#5 0x4304df in fuzzer::FuzzerDriver(int*, char***, int (*)(unsigned char const*, unsigned long)) /src/llvm-project/compiler-rt/lib/fuzzer/FuzzerDriver.cpp:912:6
#6 0x459b32 in main /src/llvm-project/compiler-rt/lib/fuzzer/FuzzerMain.cpp:20:10
#7 0x7effc08bb082 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x24082) (BuildId: 1878e6b475720c7c51969e69ab2d276fae6d1dee)
#8 0x420f1d in _start (/tmp/not-out/tmpu5o6go0a/TestFuzzCommonAssistanceHexStringToBin+0x420f1d)
2023-06-07 14:25:57 +02:00
Armin Novak
a4c6b36a19
[build] fix memory sanitizer stack frame warnings
2023-06-07 09:14:45 +02:00
Armin Novak
b40e20ce85
[gateway,rdg] fix a leak and NULL access in RDG
2023-06-05 15:47:05 +02:00
Sergey Bronnikov
b1ae467ae2
[libfreerdp/common] Add fuzzing tests
...
Part of #5063
Closes #6681
2023-06-05 11:28:48 +02:00
Sergey Bronnikov
1c0c804981
[cmake] Introduce a target for building fuzzing tests
...
Part of #5063
2023-06-05 11:28:48 +02:00
Armin Novak
9a7aa8dbac
[core,rdp] log rdp_read_share_control_header
...
in rdp_read_share_control_header read and log all available header data
before checking remaining length.
2023-06-05 11:07:30 +02:00
Armin Novak
d0bf018e95
[test] fix uninitialized variables in test case
2023-05-31 17:44:41 +02:00