mirrors/FreeRDP
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[core,gateway] fix return value checks

Browse Source
This commit is contained in:
akallabeth 2023-06-29 13:46:24 +02:00 committed by akallabeth
parent b9ec4ef60d
commit 37d9c891b4
1 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
libfreerdp/core/gateway/rts.c
View File

@ -1196,8 +1196,8 @@ static BOOL rts_write_pdu_header(wStream* s, const rpcconn_rts_hdr_t* header)
return TRUE;
}
static int rts_receive_window_size_command_read(rdpRpc* rpc, wStream* buffer,
UINT32* ReceiveWindowSize)
static BOOL rts_receive_window_size_command_read(rdpRpc* rpc, wStream* buffer,
UINT32* ReceiveWindowSize)
{
UINT32 val;
@ -1205,12 +1205,12 @@ static int rts_receive_window_size_command_read(rdpRpc* rpc, wStream* buffer,
WINPR_ASSERT(buffer);
if (!Stream_CheckAndLogRequiredLength(TAG, buffer, 4))
return -1;
return FALSE;
Stream_Read_UINT32(buffer, val);
if (ReceiveWindowSize)
*ReceiveWindowSize = val; /* ReceiveWindowSize (4 bytes) */
return 4;
return TRUE;
}
static BOOL rts_receive_window_size_command_write(wStream* s, UINT32 ReceiveWindowSize)
@ -1626,13 +1626,13 @@ BOOL rts_recv_CONN_C2_pdu(rdpRpc* rpc, wStream* buffer)
return FALSE;
rc = rts_version_command_read(rpc, buffer);
if (rc < 0)
if (!rc)
return rc;
rc = rts_receive_window_size_command_read(rpc, buffer, &ReceiveWindowSize);
if (rc < 0)
if (!rc)
return rc;
rc = rts_connection_timeout_command_read(rpc, buffer, &ConnectionTimeout);
if (rc < 0)
if (!rc)
return rc;
WLog_DBG(TAG,
"Receiving CONN/C2 RTS PDU: ConnectionTimeout: %" PRIu32 " ReceiveWindowSize: %" PRIu32