mirrors/FreeRDP
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[core,gateway,wst] fix use after free in wst_connect

Browse Source
This commit is contained in:
Michael Saxl 2023-07-01 22:17:20 +02:00 committed by akallabeth
parent d4e2129cd4
commit 132ce797db
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
libfreerdp/core/gateway/wst.c
View File

@ -364,6 +364,7 @@ static BOOL wst_handle_ok_or_forbidden(rdpWst* wst, HttpResponse** ppresponse, D
WLog_DBG(TAG, "Got Affinity cookie %s", affinity);
http_context_set_cookie(wst->http, "ARRAffinity", affinity);
http_response_free(*ppresponse);
*ppresponse = NULL;
/* Terminate this connection and make a new one with the Loadbalancing Cookie */
int fd = BIO_get_fd(wst->tls->bio, NULL);
if (fd >= 0)
@ -483,14 +484,14 @@ BOOL wst_connect(rdpWst* wst, DWORD timeout)
default:
break;
}
const BOOL isWebsocket = http_response_is_websocket(wst->http, response);
http_response_free(response);
if (!success)
return FALSE;
if (StatusCode == HTTP_STATUS_SWITCH_PROTOCOLS)
if (isWebsocket)
{
if (!http_response_is_websocket(wst->http, response))
return FALSE;
wst->wscontext.state = WebsocketStateOpcodeAndFin;
wst->wscontext.responseStreamBuffer = NULL;
return TRUE;