Commit Graph

58255 Commits

Author SHA1 Message Date
Jérôme Duval
7760bb460f ntfs: fake_read_attrib used the user buffer directly
It now uses user_strlcpy()
2018-04-24 20:06:05 +02:00
Jérôme Duval
b0bcd96bd7 fat: use the return value of strlcpy instead of strlen. 2018-04-24 19:54:00 +02:00
Fredrik Holmqvist
e3becd53ee Ternary operator proper precedence.
Going through PVS Studio blogs on Haiku.
2018-04-23 23:25:16 +02:00
Jérôme Duval
3a764d6a12 kernel: x86: add some msr and cpuid features
* for arch capabilities.
* for spec ctrl and pred cmd.
2018-04-22 18:03:16 +02:00
Axel Dörfler
7750fdcf18 vfs: _user_flock() did not use FS advisory locking calls
* The kernel's advisory locking implemenation must not be used if the
  file system has its own (ie. network file systems).
* Added ASSERT to free_vnode() that assures there is no locking left;
  I recently had a lot of them around.
2018-04-22 15:13:29 +02:00
Fredrik Holmqvist
58c99ce4d4 malloc_referenced adds +1 to int32 pointer so use its release 2018-04-22 12:47:30 +02:00
Fredrik Holmqvist
c0ceea9c79 Remove unused var and always true check. Clean redeclaration. 2018-04-22 12:09:56 +02:00
Fredrik Holmqvist
aa2c061c3d cppcheck: Shifting 32-bit value by 63 bits is undefined. 2018-04-22 11:47:15 +02:00
Fredrik Holmqvist
99400bbed0 Objs in array was deleted, but not array itself. 2018-04-22 00:12:08 +02:00
Zoltán Mizsei
c74be242c4 iwn: add working pci id for Intel 6235 2018-04-21 22:06:04 +00:00
Fredrik Holmqvist
c7fad27a8b Free ci on error 2018-04-21 23:37:01 +02:00
Fredrik Holmqvist
29208af825 Redundant '(' 2018-04-21 23:36:04 +02:00
Fredrik Holmqvist
5676dce83c memcmp on sizeof(x)==0 bytes fix 2018-04-21 23:34:16 +02:00
Adrien Destugues
1b4fdf606d intel_extreme: fix C++ syntax.
Thanks to tqh and cpcheck for finding this.
2018-04-21 22:12:26 +02:00
Jérôme Duval
853a76f1f3 vt612x: sync with FreeBSD 11.1. 2018-04-21 22:07:48 +02:00
Jérôme Duval
e68394b978 ar81xxx: sync with FreeBSD 11.1. 2018-04-21 21:55:58 +02:00
Jérôme Duval
dde876f9f8 kernel: pae paging: align *TableEntry() with 64bit paging
use SetTableEntry() in PutPageTableInPageDir() and PutPageTableEntryInTable().
2018-04-21 10:06:51 +00:00
Automatic Committer
6675afbae2 Update translations from Pootle 2018-04-21 07:13:23 +02:00
Automatic Committer
76a3fe60e2 Update translations from Pootle 2018-04-21 07:13:23 +02:00
Jérôme Duval
03df8bfcf2 kernel: vm: reduce stack usage in swap_init_post_modules().
* avoid a struct copy in PartitionScorer.
* reduce stack usage in get_mount_point().

Change-Id: I60a3161ba39e9a50eaae972b7ff5b4a26d6292fa
2018-04-18 12:37:02 +00:00
Jérôme Duval
1fb59be1d1 Fix some usages of BStackOrHeapArray.
Validates the buffer with IsValid() before actually using it. Thanks Rene!
2018-04-16 14:30:34 +00:00
Augustin Cavalier
43f5f35a80 configure: Make sure the output directory exists before running xattr tests. 2018-04-14 20:30:05 -04:00
Jérôme Duval
4b588b36ad virtio_scsi: avoid unbounded stack usage in ExecuteRequest(). 2018-04-11 23:45:50 +00:00
Jérôme Duval
48c1ae929e libroot: avoid excessive stack usage in __find_directory()
create_path() is inlined in __find_directory().
2018-04-11 23:44:22 +00:00
Jérôme Duval
70422d06a9 ipv6: avoid unbounded stack usage in send_fragments(). 2018-04-11 23:43:47 +00:00
Jérôme Duval
df4bea7d7c usb_hid: add a list blacklisted devices 2018-04-09 22:06:55 +02:00
Alexander Coers
272475393c Changed PNG translator config view
Removed workaround for already fixed bug 4217 and removed the call
to SetExplicitPreferredSize(), since the layout system was always able 
to calculate good values for PreferredSize.
So for me the call seems to be superfluous.

Fixes #13353
2018-04-09 13:01:26 +00:00
krish_iyer
f960e7e9a2 Support kit: Fixed issues in BString unit tests
1: Changed CPPUNIT_ASSERT -> CPPUNIT_ASSERT_EQUAL
2: Fixed coding style: Added two lines after including libraries, maintained 80 characters(MAX) in each line and space at comment start
3: Fixed the failure for "BString::Search" test "i != 0 by chaning the testing method(StartsWith->IStartsWith) and changed the string to be searched(sT->st)

Change-Id: I1237d1f2d0e3af7757963cc940bae929f487f088
2018-04-07 16:52:44 +00:00
Jérôme Duval
509c7718dd fat: dosfs_read_attr used the user buffer directly
It now uses user_strlcpy().
2018-04-07 17:53:47 +02:00
Automatic Committer
fbc298d331 Update translations from Pootle 2018-04-07 07:30:14 +02:00
Michael Lotz
a113ad395f Cleanup: Remove debug leftover introduced in hrev51871. 2018-04-06 21:28:33 +02:00
Michael Lotz
9c4845e767 kernel: Implement wait info count limit in wait_for_objects.
Since wait_for_objects can wait on sems, threads and ports in addition
to FDs, limiting to RLIMIT_NOFILES as in the select/poll case does not
work. Since space is allocated for the wait objects in kernel memory,
limiting their number to a valid range is still desireable.

The limit is now placed at the sum of max sem, thread and port count
plus RLIMIT_NOFILES.

This also fixes a signed vs. unsigned comparison warning in
check_max_fds introduced in hrev51866.
2018-04-06 21:20:11 +02:00
Barrett17
80e9e5f3e7 Add new tests to MediaTest 2018-04-06 02:33:26 +02:00
Barrett17
5ba361f8bf ffmpeg: Fix warning about setting stream timebase
Spotted by jackburton, doesn't fix #13407.
2018-04-06 02:33:26 +02:00
Jérôme Duval
b1f1332ebb PackageKit: use the correct kernel headers.
The debug build of the packagefs kernel addon failed because user_memcpy had no type.
Using the correct headers for user_memcpy and IS_USER_ADDRESS fixed the issue.
2018-04-05 17:51:13 +02:00
Jérôme Duval
ae5821e892 Set the image size for debug releases to 1GB. 2018-04-04 19:18:19 +02:00
hyche
0a4cbf0d1e btrfs: Fix stack corruption on MakeReference()...
because it needs extra space for storing data, and flexible array member o
doesn't do this.
I thought it was...

Change-Id: If64c06827809a4e021581c6adf8e0f198cf47450
2018-04-04 06:19:55 +00:00
Michael Lotz
c101b57682 kernel: Implement FD limit check for select/poll.
The amount of FDs that can be selected/polled needs to be limited by
the RLIMIT_NOFILES.
2018-04-04 00:09:23 +02:00
Michael Lotz
321372e3ef kernel: Make size argument to create_area_etc() size_t.
It was limited to a uint32 and could for example be overflown by the
slab MemoryManager that uses size_t on a 64 bit system.

This aligns the signature with create_area() that already uses size_t
for the size argument.

Note that the function is currently private, so the impact should be
limited.
2018-04-04 00:07:59 +02:00
Jérôme Duval
e1ceb339a0 kernel: override access control in user_[un]block_thread()...
when reading/writing the wait_status in userland. fixes #14067.
2018-04-03 22:42:14 +02:00
Jérôme Duval
048796e140 hda: sync snoop quirk pci ids list based on alsa. 2018-04-03 16:49:11 +02:00
Kim Brown
cb3445aa2a Installer: WorkerThread: Add syslog to ignored paths
A new install should start with an empty syslog. Adding
the syslog path to the set of ignored paths will prevent
an existing syslog file from being copied into the new
install.

Fixes #8373
Change-Id: I79ecf95773a34360185d38ee4ef0c8337b062e7a
2018-04-02 21:05:47 +00:00
Automatic Committer
ca675593e4 Update translations from Pootle 2018-03-31 07:36:23 +02:00
François Revol
4498948fcf recover: Work around use-after-free
Inode::_FindPath() always deletes the inode it uses regardless
the source, including when it's from the HashtableInodeSource.

But the later returned the inode object directly from the hashtable
when it's inside, so it gets deleted bu _FindPath… then reused later on
when searching the hashtable again.

I'm not sure it's the correct solution but at least malloc_debug doesn't
complain anymore.
2018-03-27 23:14:32 +02:00
Andrew Lindesay
b45e8b1ef9 HaikuDepot : additional debugging for json-rpc invocations 2018-03-25 05:44:19 +00:00
Jérôme Duval
823466613f usb_raw: the command struct wasn't copied back in some cases.
hopefully fixes #14050 after e2e571c035.
2018-03-24 20:03:47 +01:00
Automatic Committer
8e27fff0df Update translations from Pootle 2018-03-24 07:52:09 +01:00
Jérôme Duval
a25f7264b6 BString: fix Split() for multiple characters separators...
as suggested by Janus in #14045. Thanks!
* add a unit test for BString::Split().
2018-03-22 21:29:43 +01:00
hy che
7cf48d4e51 TextView: Remove redundant check in ScrollToOffset as PointAt() already does the check.
Change-Id: I2bf541fca84ef27749484ee1be05fb9debac32e2
2018-03-22 10:28:44 +00:00
Andrew Lindesay
d13c3d8967 HaikuDepot : Handling for Depot Name Anomalies
There is a problem primarily manifesting itself in
the x86_64 build where the packages' names from the
solver are not correlating with the names of the
as-configured depots.  There was also a problem
with a local variable being the same name as a function
parameter.  This does not fix the underlying problem,
but avoids further anomalies in the HaikuDepot UI.

Possibly related trac #11317, #11674, #13940.
Change-Id: Ic140f114bbe38e59c78760213843bf492ff7a270
2018-03-22 10:14:34 +00:00