Aren/haiku
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

ntfs: fake_read_attrib used the user buffer directly

Browse Source 
It now uses user_strlcpy()
This commit is contained in:
Jérôme Duval 2018-04-24 20:05:33 +02:00
parent b0bcd96bd7
commit 7760bb460f
1 changed files with 8 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
src/add-ons/kernel/file_systems/ntfs/fake_attributes.c
View File

@ -274,6 +274,7 @@ fake_read_attrib(fs_volume *_vol, fs_vnode *_node, void *_cookie,
vnode *node = (vnode *)_node->private_node;
int result = B_NO_ERROR;
ssize_t length;
LOCK_VOL(ns);
@ -294,9 +295,13 @@ fake_read_attrib(fs_volume *_vol, fs_vnode *_node, void *_cookie,
goto exit;
}
strncpy(buffer, node->mime + pos, *_length - 1);
((char *)buffer)[*_length - 1] = 0;
*_length = strlen(buffer) + 1;
length = user_strlcpy(buffer, node->mime + pos, *_length);
if (length < B_OK) {
result = B_BAD_ADDRESS;
goto exit;
}
if (length < *_length)
*_length = length + 1;
exit: