Commit Graph

52253 Commits

Author SHA1 Message Date
Adrien Destugues
42272d2342 OutlineListView: yet another list/fullList mismatch.
Fixes #5817.
2014-11-26 13:48:52 +01:00
Adrien Destugues
83b732c732 checkstyle.vim: add catch to checked keywords
* Check catch() without space
* Check }\ncatch () with newline
* Remove false positive on area_for() and other functions ending with a keyword
2014-11-26 13:27:33 +01:00
Adrien Destugues
4c581823cd Style fix. 2014-11-26 13:18:48 +01:00
Adrien Destugues
52051a08de ActivityMonitor: catch the exception
Having the app abort because of an uncaught exception when out of memory
is not user friendly. Just stop drawing the graphs if that ever happens.
2014-11-26 12:24:05 +01:00
Adrien Destugues
3f57b13504 ActivityMonitor: don't draw graph with negative width.
The computation of the graph width could overflow leading to an absurdly
high count of lines to be drawn. This would freeze with BShape trying to
realloc the array to bigger and bigger sizes as lines were added to it
(by increment of 256, but still), or trigerred a bad_alloc in
BeginLineArray which allocates them upfront after I converted the code
to use that (it is more appropriate).

Add sanity checks to avoid the overflow, now you can have hundreds of
graphs without problems (much more than I can fit on my screen anyway,
which I think is good enough).

Fixes #6841.
2014-11-26 12:16:57 +01:00
Adrien Destugues
31f5b8b5d2 BView::BeginLineArray: leave object in consistent state
We allow this method to throw bad_alloc exceptions as there is no other
way to report errors. However we left the object in a broken state
(maxCount set, but array not initialized) which would crash when calling
either AddLine or EndLineArray.

Initialize the count to 0 before throwing the exception so now
EndLineArray can be called and operations resumed safely after an
allocation failure.
2014-11-26 12:14:36 +01:00
Adrien Destugues
d9354cdedc Mouse prefs: truncated string in Suomi translation
* Set the minimal size of the double click test area so the string fits,
in any language.
* Fixes #5746.
2014-11-26 10:57:52 +01:00
Adrien Destugues
3d01d427ae Keymap preferneces: improve deadkey handling logic
* The key down message is not delivered when completing a dead key, so
act on key up instead.
* Pressing a character after a dead key would leave the keymap in "dead
key" mode, and that mode would be exited only by pressing a dead key
again.

Fixes #5734.
2014-11-26 10:35:43 +01:00
Adrien Destugues
1abd97e225 Add SerialConnect to DeskBar menu.
It works well enough now.
2014-11-26 10:12:44 +01:00
Adrien Destugues
c278afdec1 BOptionPopUp: build fix. 2014-11-26 09:48:57 +01:00
Adrien Destugues
d47ada16bc BOptionPopUp: don't offset when there is no label.
We add a 8 pixel space between the label and the menu, but we shouldn't
do that when the label is empty. This matches BMenuField behavior.

Fixes part of #10734.
2014-11-26 09:29:48 +01:00
dsizzle
d67977a5ae CharacterMap: avoid jumping window size
set explicit minimum width of character view to be a bit larger than
fCodeView so that there isn't jumping of the pane sizes when fCodeView's
contents are too long

Signed-off-by: Adrien Destugues <pulkomandy@gmail.com>

Fixes #3651 part 9.
2014-11-26 08:34:05 +01:00
dsizzle
c3205c10d7 CharacterMap: show font family and style
Signed-off-by: Adrien Destugues <pulkomandy@gmail.com>

Fixes #3651 item 2.
2014-11-26 08:34:04 +01:00
Adrien Destugues
aca8c0ceb2 HaikuWebkit 1.4.7. 2014-11-26 08:23:37 +01:00
François Revol
2d764efa49 Update libassuan packages 2014-11-26 01:15:52 +01:00
Adrien Destugues
b2e91cc3e7 Network prefs: save interfaces to file.
Fixes #11496.
2014-11-25 14:47:32 +01:00
Adrien Destugues
af218cc4e1 Notifications default to enabled on first boot.
* The server did this right, but the preflet would not check the
checkbox when there was no settings file.
2014-11-25 08:50:47 +01:00
dsizzle
74d9b875c2 CharacterMap: select Unicode block for current character
* Scrolling the list of characters now selects the currently visible
block in the blocks list.

Signed-off-by: Adrien Destugues <pulkomandy@gmail.com>

Fixes #3651, part 1
2014-11-25 08:30:08 +01:00
François Revol
67d659f26e Update gpgme packages and add gcc2 version 2014-11-25 03:34:48 +01:00
François Revol
0e38333732 Update libassuan packages 2014-11-25 03:30:05 +01:00
François Revol
187e6ae426 Add packages for gpgme 2014-11-25 03:05:00 +01:00
Adrien Destugues
c254f99c36 BApplication: remove AboutRequested implementation
The Be Book says this is a hook method, so the default behavior should
be to do nothing (didn't test BeOS, my install is currently broken).

Showing an alert with just the application thread name is less than
helpful anyway, and this was causing crashes.

Fixes #5554.
2014-11-24 17:36:31 +01:00
Adrien Destugues
03ad73fc87 More uses of BMessageFormat
ZipOMatic, DiskUsage, MediaConverter, MediaPlayer, ShowImage,
WebPositive, Screen preferences, Tracker, string_for_size.

Thanks to KapiX for reporting those!
2014-11-24 15:42:52 +01:00
Adrien Destugues
2824c5d3a4 Fix various typos and inconsistencies in strings
DiskProbe, DriveSetup, Icon-O-Matic, Installer, Login,
PackageInstaller, Screenshot, Translation Inspector, BootManager,
CharacterMap, CodyCam, BPrintJob

DiskUsage: removed useless translation, used only for layouting purposes

Thanks to KapiX for spotting these problems.
2014-11-24 09:42:26 +01:00
Adrien Destugues
46d4471af7 PoorMan: better labelling of button
According to the HIG, button labels should be verbs implying actions.
Replace the "default" button with "create public_html", which is what
will happen if you click it.

Thanks to KapiX for the suggestion.
2014-11-24 08:44:17 +01:00
Michael Lotz
176854ba4b Update transmission package to fix provides on x86_gcc2. 2014-11-23 18:05:26 +01:00
Michael Lotz
9f46451dd0 Add packages for transmission and its (build) dependencies.
* Packages for transmission and libevent for x86[_gcc2|_64].
* Build dependency packages intltool, xml_parser and file for x86[_64].
2014-11-23 16:49:21 +01:00
Rene Gollent
8b27b73055 BCLV: Adjust arrow key behavior.
- Left/right arrow can now be used to collapse/expand the focus
  row. Holding shift reverts to the previous behavior of scrolling
  the view.
2014-11-23 09:57:18 -05:00
Rene Gollent
6136e4303c Debugger: Cleanups.
VariablesView:
- Remove unused member variable.
- Add optional presentation name field to ModelNode, which allows
  overriding the name of its underlying ValueNode for display purposes.
  Used to ensure that a top-level node for an expression always shows
  the expression string itself, even when the returned result is a value
  node with a different name.
2014-11-23 09:13:06 -05:00
Rene Gollent
0690178786 Debugger: Further improvements to expression handling.
VariablesView:
- ModelNode now acquires a reference to its target variable. This
  is necessary because in the case of expression variables, the
  model node is ultimately the only one aware of it, and therefore
  needs to manage its lifetime.
- AddSyntheticNode() now discriminates between the case where it
  needs to create a node child on behalf of the caller versus when
  it's given an already created one, as is the case when an expression
  resolves to a value node. Consequently it also detects whether
  it needs to request value resolution or not, and handles accordingly.
- _AddExpressionNode() now supports value node results and handles
  them accordingly.
2014-11-23 00:18:14 -05:00
Rene Gollent
b4a861136b Debugger: Adjust VariablesView for new expression API.
- Simplify handling of expression nodes. For primitive results, we now
  construct a Variable object that represents the expression result, and
  then add that as we would any other local variable. This simplifies handling,
  and also allows saving/restoration of their view state to be handled the
  same as other nodes. Complex expression results aren't yet handled properly,
  pending some further work in progress on the evaluator.
2014-11-22 17:08:51 -05:00
Rene Gollent
81c848a14a Debugger: Rework expression parsing API.
ExpressionInfo:
- No longer stores an explicit result type (this is inferred from
  evaluation of the expression itself now).
- Introduce class ExpressionResult for returning the result of an
  expression computation. This can currently take the form of either
  a primitive value, or a value node object.
- Adjust UserInterfaceListener and ExpressionInfo::Listener to take
  the above changes into account, and correspondingly adjust all
  callers/listeners.

CLanguageExpressionEvaluator:
- Introduce child class Operand. This subsumes the functionality that
  was previously in the separate Number class, and can represent a
  primitive value, a value node or  a type. Also has functionality to
  implicity handle type promotion/inferring when performing calculations
  between operands.
- Adjust expression parser to operate in terms of Operands rather than
  Numbers. This allows a number of improvements, most notably that an
  expression can now return a value node as a result rather than only
  a primitive number. This capability isn't yet fully used, but paves
  the way for future uses such as an expression that evaluates to a data
  member, a global variable, or an arbitrary pointer of a particular type.
- Various cleanups/simplifications that were possible as a result of the above
  changes.

ExpressionEvaluationWindow/ExpressionPromptWindow:
- Remove type menu field, since the expression API no longer uses it.

Adding/removing expressions in the VariablesView is temporarily disabled,
pending some further rework there to properly handle the new result object.
2014-11-22 17:06:48 -05:00
autonielx
8d48eb9311 Update translations from Pootle 2014-11-22 06:34:05 +01:00
Adrien Destugues
4011cb5d30 BootManager: different error when no MBR is found
We were using the same "no space available" message used when the first
partition starts too early. Be more specific here to make it clearer
what the problem is.

Fixes #7087.
2014-11-21 18:14:10 +01:00
Adrien Destugues
1f8b3fdb7e Storage Kit tests: apply relevant parts of #7025
Patch by Karvjorm. Picked only the code changes as it seems the Jamfile
changes were not needed or already done.
* Use BObjectList instead of BList
* Add some more directory constants to FindDirectory tests.
2014-11-21 17:44:11 +01:00
Adrien Destugues
ec1395bda9 pc_serial: trace when ignoring the kernel debug port.
* Since it is currently ignored even when serial debug is disabled in
the settings file, this was a bit confusing.
2014-11-21 17:44:10 +01:00
Adrien Destugues
fbf05ef15b Update libsolv package for now public fopencookie
* mmu_man added the function in Haiku, and now it conflicts with the
redeclaration that was hacked in libsolv, breaking the build.
2014-11-21 15:45:26 +01:00
Adrien Destugues
d433a61aa2 GLTeapot: wait for retrace.
Rendering at 200+fps is useless when your display can't handle it.
Now we can spin many more teapots while demo'ing Haiku without wasting
as much CPU.
2014-11-21 13:31:19 +01:00
Adrien Destugues
21e5fc49a7 Update the hardware view on Pulse()
This lets the network stats update in realtime.
Fixes #11395.
2014-11-21 11:18:43 +01:00
Adrien Destugues
ea68c29709 Network Services: rename DNS to "DNS Client" and localize.
Fixes #11421.
2014-11-21 10:35:05 +01:00
Adrien Destugues
5148d5f549 AboutSystem: fix duplicate credit. 2014-11-20 21:35:18 +01:00
Adrien Destugues
0e750c3aa6 Remove netfs, userlandfs from 64bit package repo
* They are not building, yet.
2014-11-20 16:02:37 +01:00
Adrien Destugues
1e4a6aa2e5 DiskProbe: style fixes... 2014-11-20 15:08:09 +01:00
Adrien Destugues
b0ee8bf20a Mandelbrot: mouse wheel zooming.
Fixes #9533.
2014-11-20 15:01:45 +01:00
Adrien Destugues
c2a13372aa DiskProbe: don't set a maximal size for the data view
We want the view to expand and fill the horizontal space as much as
possible.
2014-11-20 14:12:10 +01:00
Adrien Destugues
23b89f011f DiskProbe: fix crash when trying to edit a package directory
/system and /home/config would crash diskprobe because DataEditor would
be left in an incompletely initialized state.

Also fix a memory leak: fAttribute was never freed, but is allocated with
strdup.

Fixes #10428.
2014-11-20 14:07:11 +01:00
Adrien Destugues
1581d4ef08 UserlandFS: another 64bit fix. 2014-11-20 13:26:56 +01:00
Adrien Destugues
afd7ded01e Debug Server: kill team when debug alert is escaped
B_CLOSE_ON_ESCAPE makes alert->Go return -1. Handle this correctly and
kill the team.

Fixes #9983.
2014-11-20 11:02:06 +01:00
Adrien Destugues
9b8e5185da UserlandFS: 64bit fix. 2014-11-20 10:50:35 +01:00
Murai Takashi
932b333fa2 Fix called C++ object pointer is null
Signed-off-by: Adrien Destugues <pulkomandy@gmail.com>

Fixes #9904.
2014-11-20 10:45:15 +01:00