Aren/NetBSD
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
196,748 Commits 606 Branches 0 Tags 3.1 GiB
d7852f7e49
Commit Graph

107855 Commits

Author SHA1 Message Date
jruoho
1dee4ee9e2 We use config_defer(9) now when scanning power resource and wake-up 
capabilities, so do not fail in acpi_power_register() if ACPI_DEVICE_POWER is
not set in struct acpi_devnode::ad_flags.
 2011-01-09 14:56:06 +00:00
is
ea61b20fd5 some more 8187B variants. From OpenBSD 2011-01-09 14:30:36 +00:00
pooka
574a31f2de Shortcircuit remote 0-len copyin/out already in the kernel. 2011-01-09 14:12:37 +00:00
pooka
35e989d694 accept '\0' as a valid string 2011-01-09 13:49:57 +00:00
jruoho
7ce8997e79 Don't use SYSCTL_SETUP in a driver. 2011-01-09 13:01:03 +00:00
pooka
9a17e75e0e Autoconfigure 127.0.0.1 for lo0. 
(testing bind/connect/etc. is now possible on a virgin rump kernel
without the need to ifconfig anything)
 2011-01-09 12:22:34 +00:00
pooka
284c651488 Separate interface init and domain adding. 2011-01-09 12:20:53 +00:00
pooka
74e0a75b03 Allow multiple RUMP_COMPONENT() in one file. 2011-01-09 12:20:10 +00:00
jruoho
c40255f958 Print a message if ACPI 4.0 functionality is present (in which case the 
driver should be updated).
 2011-01-09 09:47:55 +00:00
jruoho
a134245aa1 Remove APM. (Already commented out.) 2011-01-09 08:05:47 +00:00
jruoho
74a4ee7fc0 Rearrange (use two tabs). 2011-01-09 05:06:17 +00:00
jruoho
f422341f8e Regen. 2011-01-09 04:59:00 +00:00
jruoho
04e39f05b5 Add INTC0102 (Intel TPM chip). From ThinkPad T500. 2011-01-09 04:58:34 +00:00
kochi
90a1aa9207 Try reading MAC addr from register if it fails to read from EEPROM. 
Copied from FreeBSD driver.

Without this my JMC261 doesn't get MAC address properly.

OK'ed by bouyer@
 2011-01-09 00:12:45 +00:00
is
6d77db8f4e Realtek 8187B 2011-01-08 22:02:49 +00:00
christos
f79b6ffa09 Add two sysctls one that does verbose transaction logging and a second one 
that disables flushing the disk cache (which is fast but dangerous for
data integrity). From simon a long while back.
 2011-01-08 20:37:05 +00:00
christos
27ec421326 fix sysctl again. 2011-01-08 20:29:13 +00:00
pooka
712b80467f SIGPIPE is generated internally by the kernel, so include it in 
the list of "no panic" sigs.
 2011-01-08 14:01:04 +00:00
tsutsui
71bca1aa09 Update some items to reflect reality. 2011-01-08 09:44:37 +00:00
pooka
6d44fb2799 Do a minidehumanizenumber for RUMP_MEMLIMIT. Now you can set it 
to e.g. 16m instead of having to type out 16777216.
 2011-01-08 09:40:05 +00:00
jym
4c59a64111 Move if_xname setting earlier for xvif creation, so we can grab domid 
and handle values sooner for error cases.
 2011-01-08 05:23:19 +00:00
christos
b9d27ca2f7 PR/44340: Brian Buhrow: Raid sets containing wedges cannot be unconfigured 
and reconfigured without a reboot.
 2011-01-07 19:52:18 +00:00
jmcneill
0e137f7821 fix compilation when _MODULE is not defined 2011-01-07 18:24:53 +00:00
jmcneill
c82905f94c add hdaudio and hdafg modules 2011-01-07 15:32:11 +00:00
jmcneill
4608557aab modularize hdaudio and hdafg drivers 2011-01-07 15:30:29 +00:00
pooka
3a382dc397 Avoid double init of tty_lock if rumpkern_tty is included. LOCKDEBUG 
does not tolerate double inits.

pointed out by njoly
 2011-01-07 15:10:22 +00:00
tsutsui
38b3ed96cc Put .set noreorder so that BDslots are properly filled. 2011-01-07 14:50:27 +00:00
cegger
21fd508d09 use aprint_error_dev 2011-01-07 14:08:29 +00:00
pooka
f9736ee54f Censor no-longer-relevant flags which may be passed down from 
somewhere (e.g. an older kernel).  We really can't do anything
about new flags or flags changing meaning, though.
 2011-01-07 11:27:53 +00:00
pooka
46b37b0509 regen: fix PARAMASK 2011-01-07 11:25:43 +00:00
pooka
b5ac5e4fe9 fix PARAMASK 2011-01-07 11:25:10 +00:00
jmcneill
413c4ec645 support building cas(4) as a module 2011-01-07 11:17:22 +00:00
jakllsch
0e590a108e Add schide(4). 2011-01-07 00:31:34 +00:00
jruoho
ef2b108701 Fix a comment. 2011-01-06 18:57:22 +00:00
tsutsui
28707b7779 Move pmap_aliasmask initialization from pmap_bootstrap.c 
to machdep.c:hp300_init() before the first pmap(9) use.
 2011-01-06 14:19:54 +00:00
tsutsui
1e4ed35788 Use #ifdef CACHE_HAVE_VAC rather than #ifdef M68K_MMU_HP where 
the pmap code indends.
(though currently only MMU_HP machines have VAC in pmap_motorola ports)
 2011-01-06 13:49:16 +00:00
pooka
97936d4ea0 antipasto 2011-01-06 13:36:48 +00:00
tsutsui
9e8faec263 Move VA allocation of ledbase to leds.c just before pmap_enter(9) 
to reduce MD quirk in pmap_bootstrap.c.
 2011-01-06 13:25:32 +00:00
pooka
04056e47b5 give the outside world some idea of if we have LOCKDEBUG or not 2011-01-06 13:09:17 +00:00
tsutsui
3012955196 Move bootinfo address initialization to locore.s and machdep.c 
to reduce MD quirks in pmap_bootstrap.c.
Also print bootinfo_pa in consinit() so that we can see
at least MMU is properly enabled after boot.

Tested on HP382.
 2011-01-06 13:03:47 +00:00
pooka
cd73d116db Support LOCKDEBUG. To use it, compile sys/rump with RUMP_LOCKDEBUG=yes. 
requested by martin (sparc64 gdb cannot reliably produce a stack trace)
 2011-01-06 11:22:54 +00:00
cegger
f150925704 recognize Radeon HD 4200. This lets radeondrm(4) attach. 
"go ahead" macallan@
 2011-01-06 11:07:48 +00:00
pooka
51426b1ada cwdi0 lock is now initialized in proc0_init() 2011-01-06 10:20:57 +00:00
macallan
5e7d981582 clear the screen before redrawing on reentering text mode 2011-01-06 07:43:05 +00:00
jruoho
0af1ebd4ab Split the code that makes a string from ACPI_DEVICE_INFO::Name to a function. 2011-01-06 07:05:00 +00:00
jruoho
1bb3132df6 Move the ACPI_ACTIVATE_DEV block around for clarity. 2011-01-06 06:49:12 +00:00
enami
eaefa873fe Fix bugs introduced by previous commit; allocated page needs to be bound 
with the anon, and uvmfault_anonget may be called with ufi NULL.
 2011-01-06 05:51:57 +00:00
jym
6da35ef6e8 bnx(4) SERDES NICs will definitely work better with the PHY initialization 
code... rather than without.

(forgot to commit it two weeks ago -- should be part of the BCM 5709S
patch)
 2011-01-06 03:37:55 +00:00
jakllsch
dc93c72587 Pacify Clang -Wformat-security. 2011-01-06 02:45:13 +00:00
jym
53a9d61cb0 Reflect 5709S support in bnx(4) (comment fix) 2011-01-06 02:02:43 +00:00
jakllsch
a5fb435357 Support booting from GPT-partioned disks on PC-BIOS-compatible systems. 
Much of the work in this commit was done by Mike Volokhov during GSoC 2009.
 2011-01-06 01:08:48 +00:00
jakllsch
6808b172e4 Pass a 64-bit boot partition base LBA into x86 /boot, 
while maintaining compatibility with existing bootxx code.
 2011-01-05 23:13:01 +00:00
jmcneill
1dc6287662 reserve a major number for kmixer 2011-01-05 22:35:08 +00:00
jakllsch
1d66d108be NetBSD/x86 BIOS Boot 5.6: now with GUID Partition Table support. 2011-01-05 22:28:05 +00:00
jakllsch
749ebb6927 Note stack/heap changes made in revision 1.47 of Makefile.boot with version 5.5. 2011-01-05 22:24:02 +00:00
jakllsch
ae42e83402 Teach BIOS disk driver about GPT partition tables. 
Inspired by Mike Volokhov's GPT booting GSoC project.
 2011-01-05 22:06:59 +00:00
jakllsch
4b66284eab Let the compiler determine the correct type for sizeof(). 
From Mike Volokhov's GPT booting GSoC.
 2011-01-05 21:44:23 +00:00
enami
7b2a66bec9 Fix format string; use PRIu64 for uint64_t. 2011-01-05 21:20:44 +00:00
jruoho
b1ee05a7c3 Add build files for acpipmtr(4) module. 2011-01-05 20:15:52 +00:00
jruoho
e067d18bf0 Add a driver for ACPI power meters. 2011-01-05 20:08:12 +00:00
martin
5a52026e31 Avoid NULL deref inside a KASSERT, as discussed on tech-kern. 2011-01-05 19:34:27 +00:00
matt
d9539bd215 Use regnames (%rX %crX), use m[ft]sprg[0-9]. No binary difference. 2011-01-05 18:47:28 +00:00
jmcneill
baabc4744e d_type is now d_flag, update comment to match 2011-01-05 17:00:25 +00:00
jnemeth
a98aacd7f2 - the atari et device has been renamed et4k 
- a new MI et device was added
 2011-01-05 15:39:19 +00:00
sketch
4f0bf5bf27 Use aprint_verbose_dev. 2011-01-05 14:55:10 +00:00
martin
81136a86ea Duh, actually make it modular 2011-01-05 13:29:27 +00:00
martin
8d1ce9f395 Untill modules are first class citizens, we need to run MODULAR kernels 
insecure.
 2011-01-05 12:59:33 +00:00
jnemeth
278bc6467a Sample MODULAR kernel configuration. 
approved by: martin@
 2011-01-05 10:34:49 +00:00
jruoho
d982261b67 Adjust previous slightly. 2011-01-05 08:08:47 +00:00
jruoho
740a9e0c0e Make a two-pass scan for acpinodebus. This should ensure that devices such 
as acpiec(4) are attached before anything else. Numerous bugs are expected
to be fixed with this change.
 2011-01-05 07:58:04 +00:00
skrll
4ad49271c4 Unwrap short line. 2011-01-05 07:40:16 +00:00
pgoyette
a8cb084374 Define KERN_SA when building the module 2011-01-04 20:52:53 +00:00
pgoyette
f54a432784 Fix the build breakage, at least on amd64 2011-01-04 20:23:40 +00:00
pooka
4b258054be Add NetBSD 5 compat wrapping for *utimes() 2011-01-04 17:00:19 +00:00
jakllsch
6bbd1c4558 Relocate buffers to not coincide with new location of executable text. 2011-01-04 16:53:05 +00:00
pooka
a9dcf542ce Add SMP support for all architectures. 
tested on sparc64 by martin
 2011-01-04 16:23:35 +00:00
kiyohara
926c5ddd8d Fix to build failure. Include uvm/uvm_extern.h for pmap_extract(). 2011-01-04 11:41:24 +00:00
matt
c247b65c80 Turn off VERBOSE_ARM_INIT 2011-01-04 11:38:58 +00:00
matt
b99d2248b0 Need to deal with msg_iov in netbsd32_to_msghdr. 2011-01-04 11:00:31 +00:00
matt
701acb9073 Make the SA support as optional as is possible. 2011-01-04 10:59:28 +00:00
skrll
2e4617519c Centralise the PDC procedure calls into one file and use a minimal set of 
kernel data for PDC results.

Remove the filler components from the PDC structures as a result.

Other tidyups while here.
 2011-01-04 10:42:33 +00:00
jruoho
9844967b1c Stop using aprint_debug(9) in an interrupt handler. 2011-01-04 10:40:17 +00:00
pooka
da5a203b0b Need to check for VNOVAL when setting attrs. 2011-01-04 09:49:16 +00:00
matt
09ed1cd16b Add audio for uaudio 2011-01-04 09:13:56 +00:00
matt
f895d49c52 Add ukphy (makes MIIVERBOSE happier) 2011-01-04 09:13:19 +00:00
matt
3af5634626 Supply a hook at allow an RAMDISK image to automagically inserted into a 
newly built kernel.
 2011-01-04 08:58:59 +00:00
matt
4d8e8a7e36 Add better color matching selecting free pages. KM pages will now allocated 
so that VA and PA have the same color.  On a page fault, choose a physical
page that has the same color as the virtual address.

When allocating kernel memory pages, allow the MD to specify a preferred
VM_FREELIST from which to choose pages.  For machines with large amounts
of memory (> 4GB), all kernel memory to come from <4GB to reduce the amount
of bounce buffering needed with 32bit DMA devices.
 2011-01-04 08:26:33 +00:00
matt
5d3db402fb Add a MD hook to indicate a change of vmspace due to exec. (This is useful 
to update any cpu flag due to a change to/from a 64bit and a 32bit address
space).  This can set the state needed for copyout/copyin before setregs
is invoked.
 2011-01-04 08:21:18 +00:00
matt
b3322481fa Print the number of page colors in use with db> show uvm 2011-01-04 08:17:01 +00:00
dholland
5382c59ae1 Tsort functions and remove a small #if 0 block leftover from earlier cleanup. 
No functional change.
 2011-01-04 07:43:42 +00:00
jruoho
c96fe4ba5e Revert the changes made in the commit: 
"Do not queue functions via sysmon_taskq(9) in the pmf(9) resume hooks.
   There is a small and unlikely race when the drivers are loaded as modules;
   suspend, resume, queue a function, and immediately unload the module."

Queueing the checks in the resume hooks was observed to improve the resume
time by several seconds (!) on a system with poorly implemented AML code.
The observed race condition is a wider issue related to modules; things like
sysmon_taskq(9) should be modified to allow cancelling of queued functions.
 2011-01-04 05:48:48 +00:00
jruoho
a26fa60e11 Fix previous. 2011-01-04 04:28:48 +00:00
nisimura
aa74cd0406 withdraw my name from the copyright notice as there is little code 
substance made by me.
 2011-01-04 02:50:08 +00:00
tsutsui
43e8a97158 Add options P1003_1B_SEMAPHORE. 2011-01-04 02:19:32 +00:00
matt
802fd8b955 If using a kernel ldscript, make sure it's added to the list of kernel 
dependencies.
 2011-01-04 01:52:30 +00:00
matt
833bb81cc5 add support for autostarting watchdogs (wdog was started by firmware 
and can't be disabled).  Add critical pool hooks for kernel tickled
watchdogs.
 2011-01-04 01:51:06 +00:00
matt
1cf358c3b4 When determining max/min sym value, ignore ABS symbols which don't 
have a type.  This stops ksym thinking that the _KERNEL_OPT symbols
could actually be useful.
 2011-01-04 01:40:19 +00:00
matt
9d740604de Switch back to malloc since kmem isn't softintr safe. 2011-01-04 01:37:55 +00:00
matt
1bab34e59d Use LIST_FOREACH when possible. 2011-01-04 01:29:01 +00:00
matt
3bedd50982 Make this support the DS1553 as well. Add support for the centry reg which 
newer RTCs seem to have.
 2011-01-04 01:28:15 +00:00
matt
dfbd1e0d55 Add the new mpc85xx/booke device names. 2011-01-04 01:26:22 +00:00
matt
d4c26fdc30 Add a generic Motorola/Freescale i2c driver. This was taken from sandpoint 
and heavily modified.  It works on most Freescale PowerPC and ARM SoCs.
 2011-01-04 01:24:56 +00:00
pooka
41cdab1b22 Don't try to change the size of non-reg nodes or when vattr doesn't 
contain a new size.

from njoly
 2011-01-04 00:09:43 +00:00
skrll
9ed174ca8e Reformat comment. 2011-01-03 19:20:11 +00:00
pooka
7766a79555 kqueue signal filters are not supported, so be explicit about it. 2011-01-03 14:57:06 +00:00
pooka
a27f30410a update comment 2011-01-03 13:22:32 +00:00
drochner
bccb285ad5 destroy mutex/cv before freeing the struct holding them, fixes 
LOCKDEBUG panic
 2011-01-03 13:12:40 +00:00
jruoho
6a3b9e2cde Scan for devices that are "hot-pluggable". 2011-01-03 08:50:23 +00:00
tsutsui
ee16ecf67d Add (commented out) options MODULAR. Confirmed working on XM6i. 2011-01-03 06:15:16 +00:00
tsutsui
a9ce633ac2 Xref module(7) in comments. 2011-01-03 06:07:42 +00:00
tsutsui
7790fd94ea Enable options DDB. Ok from isaki@ 2011-01-03 03:43:22 +00:00
jakllsch
71481e188f Zero the in-memory super block after allocation. It contains a pointer 
that, if not properly initialized, could be improperly deallocated.
 2011-01-02 21:37:01 +00:00
christos
d232460a0a kern/44310: Alexander Nasonov: write to /dev/bpf truncates size_t to int 2011-01-02 21:03:45 +00:00
christos
7e1e338bd2 Simplify and avoid kernel segv when the list is NULL. 2011-01-02 20:50:55 +00:00
matt
d24d5902b3 Kernels modules are c99 (gnu99) just like the kernel. 
Add(move) -std=gnu99 to CPPFLAGS (from COPTS).
 2011-01-02 19:24:47 +00:00
tsutsui
6542895ee1 Tidy up common comments. (Yes, too many dup code...) 2011-01-02 18:48:04 +00:00
tsutsui
ba49f620d3 Pull code that maps the kernel segment table cache invalidated for 040/060, 
to reduce diffs from other m68k ports.

Compile test only. (any working machine for these port?)
 2011-01-02 18:39:11 +00:00
tsutsui
d0f75d9074 Pull code that maps the kernel segment table cache invalidated for 040/060, 
to reduce diffs from other m68k ports.

Tested on LC630 (with 68LC040) upto single user.
 2011-01-02 18:16:59 +00:00
skrll
cc800d12bd Remove last references to __HAVE_SIGINFO 2011-01-02 18:12:01 +00:00
skrll
4e5433fc00 __HAVE_SIGINFO has not been required/used for a long time now. 
Prompted by uwe@
 2011-01-02 18:07:02 +00:00
pooka
afa6c20325 regen: rump_lwproc_rfork 2011-01-02 12:53:13 +00:00
pooka
8b69e65f3e There is a use case where preserving the parent's fd table is 
relevant, so to accommodate that change rump_lwproc_newproc() to
rump_lwproc_rfork().  The new interface has the rfork() fd table
semantics.  The equivalent of rump_lwproc_newproc() is
rump_lwproc_rfork(RUMP_RFCFDG).
 2011-01-02 12:52:25 +00:00
mbalmer
ec2d803578 Cap h.loc.count at MAXKEYCODE instead of bailing out. This lets some obscure/ 
roque keyboards attach.

From loganaden@devio.us (Loganaden Velvindron), thanks!
 2011-01-02 12:36:41 +00:00
he
1445b77a3f Make this build again by removing the const qualifier on the 
local pcb0 variable in mips_init_lwp0_uarea().
 2011-01-02 12:17:28 +00:00
jruoho
6248a51d8a Adjust error messages for the previous commit. 2011-01-02 12:06:02 +00:00
mrg
de80fec71b add the normal DKWEDGE* options, and enable drvctl. 2011-01-02 11:25:31 +00:00
mrg
546f8cf55d now that it's optional, kill schizo_pci_find_ino(). 
prepare to enable the tomatillo iocache.
 2011-01-02 10:43:18 +00:00
hannken
111bde084e layer_inactive: With specnodes introduced during vmlocking2 
it is safe to cache device nodes.

Tested with nullfs only as unionfs with device nodes panics.
 2011-01-02 10:38:02 +00:00
tsutsui
1566040d94 Switch mvmeppc bootloader to using MI libsa and libkern for maintainability. 
Mostly taken from mvme68k.

Compile test only, but no functional changes.
 2011-01-02 09:40:51 +00:00
tsutsui
3beadbf115 Misc cosmetics to reduce diff among hp300 derived m68k ports. 
XXX: too many quirks to merge...
 2011-01-02 08:40:54 +00:00
tsutsui
61ec97e196 Add a dummy <machine/bus.h> which nows seems to be mandatory in MI code 
including <sys/bus.h> even if a port doesn't use it. Taken from sbmips.
 2011-01-02 08:22:35 +00:00
tsutsui
7e5fe04d25 Explicitly include <machine/bus.h> here for bus_space_tag_t and bus_dma_tag_t. 2011-01-02 08:19:03 +00:00
tsutsui
180ea1e5f3 Fix one more fatal typo. Umm. 2011-01-02 07:51:02 +00:00
tsutsui
600906f486 Misc cosmetics to reduce diffs among these ports. 2011-01-02 07:03:46 +00:00
dholland
6422814ed0 Remove references to SAVESTART and SAVENAME in comments. 2011-01-02 06:58:45 +00:00
tsutsui
19cecafc81 Some cosmetics to reduce diffs from other m68k ports. 2011-01-02 06:25:23 +00:00
tsutsui
46705dc7b5 Remove "last kernel PT page" stuff derived from hp300 where PA != VA. 
Compile test only, but same changes as other PA == VA m68k ports like
luna68k, news68k, and x68k used for a decade.
 2011-01-02 06:15:04 +00:00
jruoho
e008cf160e Use "real" device names for the hw.acpi.wake and hw.acpi.power sysctl(8) 
trees. For instance, instead of hw.acpi.wake.DURT, we have hw.acpi.wake.wm0
for wm(4). This is a temporary solution, but without solving the big
abstraction questions, this is the best we can do.
 2011-01-02 06:05:47 +00:00
jruoho
9a11653a7b Print a warning if the BIOS thinks that the timer is unreliable. However, do 
not touch the quality of the timecounter(9) based on this information.
 2011-01-02 05:48:55 +00:00
tsutsui
ba426c081d Switch mvme68k standalone problams to using MI libsa and libkern 
for maintainablility. Also bump version for note.

Compile test only, but no functional changes.
 2011-01-02 05:30:11 +00:00
tsutsui
0d6929ab07 Make pmap_aliasmask unsigned and declare it in <m68k/pmap_motorola.h>. 
XXX: does anyone still have working HP320 or HP350 with 020+HP_MMU+VAC?
 2011-01-02 05:21:11 +00:00
tsutsui
65021e823c Pull code that maps the kernel segment table cache invalidated for 040/060, 
to reduce diffs from other m68k ports.

Tested on HP362 (030) and HP382 (040), and no visible performance difference.
(what should we do per "for the 68040 not strictly necessary but
 recommended by Motorola" comment?)
 2011-01-02 05:18:04 +00:00
dholland
3822046d71 5.99.43: R.I.P. SAVESTART. 2011-01-02 05:13:53 +00:00
dholland
a2770d1fb4 Final regen for tonight. 2011-01-02 05:12:56 +00:00
dholland
6d2ff39e83 Remove remaining references to SAVESTART. 2011-01-02 05:12:33 +00:00
dholland
201ce42cd0 Regen yet again. 2011-01-02 05:09:50 +00:00
dholland
13fc777536 Remove the special refcount behavior (adding an extra reference to the 
parent dir) associated with SAVESTART in relookup().

Check all call sites to make sure that SAVESTART wasn't set while
calling relookup(); if it was, adjust the refcount behavior. Remove
related references to SAVESTART.

The only code that was reaching the extra ref was msdosfs_rename,
where the refcount behavior was already fairly broken and/or gross;
repair it.

Add a dummy 4th argument to relookup to make sure code that hasn't
been inspected won't compile. (This will go away next time the
relookup semantics change, which they will.)
 2011-01-02 05:09:30 +00:00
tsutsui
04a4956fe1 Remove disabled code for VAC. No such news68k models. 2011-01-02 05:09:27 +00:00
dholland
bf71879ee8 Regen again. 2011-01-02 05:05:42 +00:00
dholland
b845056678 Add an INRELOOKUP namei flag. Sigh. (We don't need more namei flags.) 
However, because of a protocol deficiency puffs relies on being able
to keep track of VOP_LOOKUP calls by inspecting their contents, and
this at least allows it to use something vaguely principled instead of
making wild guesses based on whether SAVESTART is set.

Update libp2k to use INRELOOKUP instead of SAVESTART.
 2011-01-02 05:04:58 +00:00