Go to file
aliguori f4af02ed1b fix bug in block-qcow2.c:alloc_cluster_offset() (Shahar Frank)
During the debugging of the new revision of the zero dedup patch I
stepped on the following bug in block-qcow2.c:alloc_cluster_offset(). I
am not sure what the exact damage this bug can do, but it may be very
nasty because you way not notice it effects until you will do some
snapshot operations or similar actions that rely on the reference
counting.

The bug is easy to spot using the new "check" verb I added to the
qemu-img in one of the previous patches. I will resend the qemu-img
patch again with the new version of the zero dedup.

Signed-off-by: Shahar Frank <shaharf@qumranet.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>



git-svn-id: svn://svn.savannah.nongnu.org/qemu/trunk@5313 c046a42c-6fe2-441c-8c8c-71466251a162
2008-09-24 16:52:15 +00:00
audio Revert a part of r5087 that didn't need fixing (thanks to malc for spotting) 2008-08-27 18:43:53 +00:00
darwin-user variable dynamic translation buffer size 2008-05-28 12:30:31 +00:00
fpu Suppress gcc 4.x -Wpointer-sign (included in -Wall) warnings 2008-09-20 08:07:15 +00:00
hw pflash: Add missing parenthesis in error message. 2008-09-24 14:33:07 +00:00
keymaps fixing keymap for Windows keys (Stefano Stabellini) 2008-09-22 19:45:36 +00:00
linux-user Band-aid vfork() emulation (Kirill Shutemov). 2008-09-21 02:39:45 +00:00
pc-bios Update OpenBIOS images to SVN r237. 2008-09-18 19:41:28 +00:00
slirp Suppress gcc 4.x -Wpointer-sign (included in -Wall) warnings 2008-09-20 08:07:15 +00:00
target-alpha Suppress gcc 4.x -Wpointer-sign (included in -Wall) warnings 2008-09-20 08:07:15 +00:00
target-arm Fix ARM NEON vdup and vtbl bugs. 2008-09-22 00:52:42 +00:00
target-cris CRIS: Improve ASID related TLB flushes. 2008-09-22 20:51:28 +00:00
target-i386 Add signed versions of save/load functions 2008-09-20 08:04:11 +00:00
target-m68k Fix swapped mvz/mvs instructions. 2008-09-05 12:33:31 +00:00
target-mips Use concet TCG instructions in the MIPS target. 2008-09-22 21:54:00 +00:00
target-ppc Add concat_i32_i64 op. 2008-09-21 13:48:32 +00:00
target-sh4 Add concat_i32_i64 op. 2008-09-21 13:48:32 +00:00
target-sparc Add software and timer interrupt support 2008-09-22 19:50:28 +00:00
tcg Fix tcg_gen_concat32_i64 on 64-bit hosts. 2008-09-23 22:31:10 +00:00
tests Support out-of-the-tree building of tests 2008-09-22 01:39:29 +00:00
.gitignore Add gitignore file 2008-09-09 17:15:28 +00:00
a.out.h 64bit->win32 cross build fix. 2007-03-04 00:52:16 +00:00
aes.c Fix miscellaneous minor things, by Andre Przywara. 2007-12-17 03:15:52 +00:00
aes.h AES crypto support 2004-08-01 21:54:53 +00:00
aio.c Refactor AIO to allow multiple AIO implementations 2008-09-22 19:17:18 +00:00
alpha-dis.c find -type f | xargs sed -i 's/[\t ]$//g' # on most files 2007-09-16 21:08:06 +00:00
alpha.ld alpha support 2003-04-29 20:53:42 +00:00
arm-dis.c Update ARM disassembler. 2007-11-10 17:38:00 +00:00
arm-semi.c Add missing return in arm-semi, by Laurent Desnogues. 2008-07-01 16:40:04 +00:00
arm.ld Link ARM prologue closer to code segment to avoid a build failure 2008-07-10 17:21:31 +00:00
block_int.h Fix warnings that would be caused by ld flag --warn-common 2008-09-17 19:04:14 +00:00
block-bochs.c Split block API from vl.h. 2007-11-11 02:51:17 +00:00
block-cloop.c Split block API from vl.h. 2007-11-11 02:51:17 +00:00
block-cow.c Split block API from vl.h. 2007-11-11 02:51:17 +00:00
block-dmg.c Add qemu_realloc(), by Gerd Hoffmann. 2008-08-06 08:37:17 +00:00
block-nbd.c Remove unnecessary #includes from block-nbd.c 2008-08-19 19:10:38 +00:00
block-parallels.c Split block API from vl.h. 2007-11-11 02:51:17 +00:00
block-qcow2.c fix bug in block-qcow2.c:alloc_cluster_offset() (Shahar Frank) 2008-09-24 16:52:15 +00:00
block-qcow.c Remove dead-code (else-block) from block-qcow.c, by Marc Bevand. 2008-06-05 22:00:45 +00:00
block-raw-posix.c Relax posix-aio restrictions on newer glibcs 2008-09-23 02:57:00 +00:00
block-raw-win32.c Refactor AIO to allow multiple AIO implementations 2008-09-22 19:17:18 +00:00
block-vmdk.c Fix warnings that would be caused by gcc flag -Wwrite-strings 2008-09-14 06:45:34 +00:00
block-vpc.c Fix char* signedness, by Andre Przywara. 2007-12-16 03:16:05 +00:00
block-vvfat.c Fix OpenBSD linker warnings 2008-08-21 17:58:08 +00:00
block.c Refactor AIO to allow multiple AIO implementations 2008-09-22 19:17:18 +00:00
block.h Refactor AIO to allow multiple AIO implementations 2008-09-22 19:17:18 +00:00
bswap.h e1000: fix unaligned access 2008-03-28 22:30:48 +00:00
Changelog Update 2008-06-08 01:55:07 +00:00
check_ops.sh Fixes for s/390 host support, by Bastian Blank. 2007-11-18 21:22:10 +00:00
cocoa.m Let the USB tablet reach the far bottom and right pixels 2008-03-10 19:34:27 +00:00
compatfd.c Add missing files from previous commit. 2008-09-10 18:18:38 +00:00
compatfd.h Fix the build on non-Linux systems 2008-09-11 14:18:56 +00:00
configure Enable ld flag --warn-common 2008-09-17 19:05:19 +00:00
console.c Reintroduce TEXT_CONSOLE_FIXED_SIZE and TEXT_CONSOLE for resizable vc's. 2008-09-24 03:32:33 +00:00
console.h Reintroduce TEXT_CONSOLE_FIXED_SIZE and TEXT_CONSOLE for resizable vc's. 2008-09-24 03:32:33 +00:00
COPYING distribution patches 2003-03-23 20:17:16 +00:00
COPYING.LIB update 2003-05-25 16:41:52 +00:00
cpu-all.h Revert incorrect part of r4574 to avoid unaligned traps with i386 target 2008-09-14 13:56:10 +00:00
cpu-defs.h Move interrupt_request and user_mode_only to common cpu state. 2008-07-01 20:01:19 +00:00
cpu-exec.c SH4: Privilege check for instructions 2008-09-15 08:49:15 +00:00
cris-dis.c Teach the CRIS disassembler to stay within the provided buffer. 2008-05-06 08:45:10 +00:00
curses_keys.h Typo in curses_keys.h. 2008-03-18 06:55:27 +00:00
curses.c Reintroduce TEXT_CONSOLE_FIXED_SIZE and TEXT_CONSOLE for resizable vc's. 2008-09-24 03:32:33 +00:00
cutils.c Prevent guest reusing host memory allocations. 2008-06-09 13:47:45 +00:00
d3des.c Some little fixes on QEMU 2008-09-06 16:31:30 +00:00
d3des.h Actually add d3des implementation files. 2007-08-25 02:09:50 +00:00
dis-asm.h Fix OpenBSD linker warnings 2008-08-21 17:58:08 +00:00
disas.c Fix warnings that would be generated by gcc -Wstrict-prototypes 2008-08-17 20:21:51 +00:00
disas.h monitor_disas() prototype change 2005-11-21 23:35:10 +00:00
dyngen-exec.h Preliminary OpenBSD host support (based on OpenBSD patches by Todd T. Fries) 2008-08-15 18:33:42 +00:00
dyngen.c Fix some warnings that would be generated by gcc -Wmissing-prototypes 2008-08-17 20:26:25 +00:00
elf_ops.h Add statics and missing #includes for prototypes. 2007-11-18 01:44:38 +00:00
elf.h Fix most warnings that would be caused by gcc flag -Wundef 2008-09-06 17:47:39 +00:00
exec-all.h Move offsetof to osdep.h, remove local defintions. 2008-09-16 13:36:57 +00:00
exec.c 64 bit truncation in code_gen_buffer_size calculation (Jes Sorensen) 2008-09-24 14:10:36 +00:00
gdbstub.c Move the active FPU registers into env again, and use more TCG registers 2008-09-18 11:57:27 +00:00
gdbstub.h Fix warnings that would be caused by gcc flag -Wwrite-strings 2008-09-14 06:45:34 +00:00
gen-icount.h Spelling fixes, spotted by Stuart Brady. 2008-06-30 17:22:19 +00:00
host-utils.c Code used by the linux-user targets should not use vl.h. 2007-11-05 13:01:41 +00:00
host-utils.h Fix always_inline definition for Darwin, by Andreas Faerber. 2008-06-05 22:55:54 +00:00
hostregs_helper.h Fix 64-bit host register corruption. 2007-02-04 13:37:44 +00:00
hpet.h Add a local copy of hpet.h. 2007-09-16 20:03:23 +00:00
hppa-dis.c HPPA (PA-RISC) host support 2008-04-12 20:14:54 +00:00
hppa.ld HPPA (PA-RISC) host support 2008-04-12 20:14:54 +00:00
i386-dis.c Revert broken part of r5044 (thanks to Igor Kovalenko for spotting) 2008-08-26 17:07:04 +00:00
i386.ld Add TLS sections. 2008-05-31 16:21:33 +00:00
ia64.ld ia64 host support (David Mosberger) 2005-04-07 22:20:31 +00:00
keymaps.c Miscellaneous VNC related fixes from Xen forwarded by Matthew Kent. 2007-10-30 22:38:53 +00:00
kqemu.c Fix error reporting under Win32 (CreateFile does not set errno) 2008-06-08 01:55:09 +00:00
kqemu.h kqemu API change - allow use of kqemu with 32 bit QEMU on a 64 bit host 2008-05-30 20:48:25 +00:00
LICENSE use the TCG code generator 2008-02-01 10:50:11 +00:00
loader.c Remove most uses of phys_ram_base (initial patch by Ian Jackson) 2008-05-12 17:22:13 +00:00
m68k-dis.c Fix warnings that would be caused by gcc flag -Wwrite-strings 2008-09-14 06:45:34 +00:00
m68k-semi.c Break up vl.h. 2007-11-17 17:14:51 +00:00
m68k.ld m68k host port (Richard Zidlicky) 2003-08-10 22:14:22 +00:00
MAINTAINERS Update maintainers list. 2008-08-25 22:26:03 +00:00
Makefile Add missing dependencies for qemu-doc.* (Stefan Weil) 2008-09-24 01:13:40 +00:00
Makefile.target Refactor AIO to allow multiple AIO implementations 2008-09-22 19:17:18 +00:00
mips-dis.c Fix most warnings that would be caused by gcc flag -Wundef 2008-09-06 17:47:39 +00:00
mips.ld Linker scripts for MIPS hosts. 2007-05-05 19:24:38 +00:00
mipsel.ld Linker scripts for MIPS hosts. 2007-05-05 19:24:38 +00:00
monitor.c Add "info uuid" command to monitor (Gleb Natapov) 2008-09-18 18:30:20 +00:00
nbd.c Use common objects for qemu-img and qemu-nbd 2008-09-15 15:51:35 +00:00
nbd.h qemu-nbd: remove useless parameter from nbd_negotiate() (Laurent Vivier) 2008-09-10 15:23:19 +00:00
net-checksum.c Add IP checksumming functions to qemu (Gerd Hoffmann) 2008-07-29 19:40:04 +00:00
net.h Add IP checksumming functions to qemu (Gerd Hoffmann) 2008-07-29 19:40:04 +00:00
osdep.c Use common objects for qemu-img and qemu-nbd 2008-09-15 15:51:35 +00:00
osdep.h Move offsetof to osdep.h, remove local defintions. 2008-09-16 13:36:57 +00:00
ppc64.ld Correct version of Heikki Lindholms ppc64.ld script 2008-08-20 22:39:24 +00:00
ppc-dis.c find -type f | xargs sed -i 's/[\t ]$//g' # on most files 2007-09-16 21:08:06 +00:00
ppc.ld Update ppc.ld to work with newer binutils. 2007-04-28 19:00:30 +00:00
qemu_socket.h Use common objects for qemu-img and qemu-nbd 2008-09-15 15:51:35 +00:00
qemu-aio.h Refactor AIO to allow multiple AIO implementations 2008-09-22 19:17:18 +00:00
qemu-binfmt-conf.sh Code provision for n32/n64 mips userland emulation. Not functional yet. 2007-09-30 01:58:33 +00:00
qemu-char.h qemu-char.h: Fix IOCTL values 2008-08-22 21:25:00 +00:00
qemu-common.h Add qemu_realloc(), by Gerd Hoffmann. 2008-08-06 08:37:17 +00:00
qemu-doc.texi Add image format option for USB mass-storage devices 2008-08-21 22:24:32 +00:00
qemu-img.c Fix OpenBSD linker warnings in qemu-img 2008-08-24 10:30:33 +00:00
qemu-img.texi New qemu-img convert -B option, by Marc Bevand. 2008-06-05 21:53:49 +00:00
qemu-lock.h Multithreaded locking fixes. 2008-06-07 20:50:51 +00:00
qemu-log.h Fix some warnings that would be generated by gcc -Wredundant-decls 2008-08-30 09:51:20 +00:00
qemu-malloc.c Fix error introduced by r5044 2008-08-25 20:03:28 +00:00
qemu-nbd.c qemu-nbd: remove useless parameter from nbd_negotiate() (Laurent Vivier) 2008-09-10 15:23:19 +00:00
qemu-nbd.texi Fix formatting of documentation (Stefan Weil) 2008-09-22 20:41:57 +00:00
qemu-tech.texi Spelling fixes, by Stefan Weil. 2008-06-03 19:51:57 +00:00
qemu-timer.h Break up vl.h. 2007-11-17 17:14:51 +00:00
qemu-tool.c Use common objects for qemu-img and qemu-nbd 2008-09-15 15:51:35 +00:00
readline.c Handle history additions properly, by Andreas Schwab. 2007-12-17 20:31:43 +00:00
README update 2005-02-10 21:46:47 +00:00
s390-dis.c Revert licensing to "GPLv2 or later", by Ulrich Hecht. 2008-01-17 13:56:59 +00:00
s390.ld update 2003-04-29 21:34:02 +00:00
sdl_keysym.h Windows keys support with keymaps 2005-03-01 21:43:42 +00:00
sdl.c add DisplayState->idle (Samuel Thibault) 2008-08-21 20:08:55 +00:00
sh4-dis.c Fix warnings that would be caused by gcc flag -Wwrite-strings 2008-09-14 06:45:34 +00:00
softmmu_defs.h Fix some warnings that would be generated by gcc -Wredundant-decls 2008-08-30 09:51:20 +00:00
softmmu_exec.h Fix some warnings that would be generated by gcc -Wredundant-decls 2008-08-30 09:51:20 +00:00
softmmu_header.h Fix some warnings that would be generated by gcc -Wredundant-decls 2008-08-30 09:51:20 +00:00
softmmu_template.h Add instruction counter. 2008-06-29 01:03:05 +00:00
softmmu-semi.h Suppress gcc 4.x -Wpointer-sign (included in -Wall) warnings 2008-09-20 08:07:15 +00:00
sparc64.ld Map code buffers below 2G on Sparc64 2008-07-26 15:05:57 +00:00
sparc-dis.c More detabification 2007-10-06 11:28:21 +00:00
sparc.ld More detabification 2007-10-06 11:28:21 +00:00
sys-queue.h Move audio/sys-queue.h => sys-queue.h 2008-07-29 20:08:37 +00:00
sysemu.h Add -uuid command line option (Gleb Natapov) 2008-09-18 18:29:08 +00:00
tap-win32.c Use WIN32_LEAN_AND_MEAN, by Stefan Weil. 2007-12-17 04:42:29 +00:00
texi2pod.pl Update texi2pod.pl. 2008-02-04 14:47:49 +00:00
thunk.c Fix attempt to inline recursive functions. 2007-11-19 01:06:24 +00:00
thunk.h Fix attempt to inline recursive functions. 2007-11-19 01:06:24 +00:00
TODO update 2008-05-13 18:26:52 +00:00
translate-all.c Small cleanup of gen_intermediate_code(_internal), by Laurent Desnogues. 2008-07-18 18:01:29 +00:00
uboot_image.h Simple u-boot image loading support. 2007-03-06 23:52:01 +00:00
usb-linux.c Don't use sprintf() or strcpy() 2008-09-22 15:04:31 +00:00
VERSION version change 2008-01-06 17:10:54 +00:00
vgafont.h Some little fixes on QEMU 2008-09-06 16:31:30 +00:00
vl.c Remove unnecessary call to qemu_aio_init (called from bdrv_init) 2008-09-22 16:29:18 +00:00
vnc_keysym.h Improve jp106 keyboard support, by Akio Takebe. 2008-07-07 19:29:49 +00:00
vnc.c Fix compiler warning when _VNC_DEBUG isn't defined. 2008-09-24 15:17:57 +00:00
vnchextile.h vnc dynamic resolution (Stefano Stabellini) 2008-09-15 16:03:41 +00:00
x86_64.ld update 2005-01-06 20:50:00 +00:00
x_keymap.c Add statics and missing #includes for prototypes. 2007-11-18 01:44:38 +00:00

Read the documentation in qemu-doc.html.

Fabrice Bellard.