Philippe Mathieu-Daudé 8729856c19 hw/net/can/xlnx-zynqmp: Avoid underflow while popping RX FIFO ... Per https://docs.xilinx.com/r/en-US/ug1085-zynq-ultrascale-trm/Message-Format Message Format The same message format is used for RXFIFO, TXFIFO, and TXHPB. Each message includes four words (16 bytes). Software must read and write all four words regardless of the actual number of data bytes and valid fields in the message. There is no mention in this reference manual about what the hardware does when not all four words are read. To fix the reported underflow behavior, I choose to fill the 4 frame data registers when the first register (ID) is accessed, which is how I expect hardware would do. Reported-by: Qiang Liu <cyruscyliu@gmail.com> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org> Reviewed-by: Francisco Iglesias <francisco.iglesias@amd.com> Reviewed-by: Vikram Garhwal <vikram.garhwal@amd.com> Message-id: 20231124183325.95392-3-philmd@linaro.org Fixes: 98e5d7a2b7 ("hw/net/can: Introduce Xilinx ZynqMP CAN controller") Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1427 Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org> Reviewed-by: Francisco Iglesias <francisco.iglesias@amd.com> Reviewed-by: Vikram Garhwal <vikram.garhwal@amd.com> Signed-off-by: Peter Maydell <peter.maydell@linaro.org> Reviewed-by: Peter Maydell <peter.maydell@linaro.org>		2023-11-27 15:27:38 +00:00
..
can	hw/net/can/xlnx-zynqmp: Avoid underflow while popping RX FIFO	2023-11-27 15:27:38 +00:00
fsl_etsec	net: Provide MemReentrancyGuard * to qemu_new_nic()	2023-11-21 15:42:34 +08:00
rocker	net: Provide MemReentrancyGuard * to qemu_new_nic()	2023-11-21 15:42:34 +08:00
allwinner_emac.c	net: Provide MemReentrancyGuard * to qemu_new_nic()	2023-11-21 15:42:34 +08:00
allwinner-sun8i-emac.c	net: Provide MemReentrancyGuard * to qemu_new_nic()	2023-11-21 15:42:34 +08:00
cadence_gem.c	net: Provide MemReentrancyGuard * to qemu_new_nic()	2023-11-21 15:42:34 +08:00
dp8393x.c	net: Provide MemReentrancyGuard * to qemu_new_nic()	2023-11-21 15:42:34 +08:00
e1000_common.h	e1000: Split header files	2023-03-10 15:35:38 +08:00
e1000_regs.h	hw/net: spelling fixes	2023-09-20 07:54:34 +03:00
e1000.c	net: Provide MemReentrancyGuard * to qemu_new_nic()	2023-11-21 15:42:34 +08:00
e1000e_core.c	e1000e: rename e1000e_ba_state and e1000e_write_hdr_to_rx_buffers	2023-09-18 14:36:13 +08:00
e1000e_core.h	e1000e: Notify only new interrupts	2023-05-23 15:20:15 +08:00
e1000e.c	net: Provide MemReentrancyGuard * to qemu_new_nic()	2023-11-21 15:42:34 +08:00
e1000x_common.c	e1000x: Take CRC into consideration for size check	2023-05-23 15:20:15 +08:00
e1000x_common.h	e1000x: Share more Rx filtering logic	2023-05-23 15:20:15 +08:00
e1000x_regs.h	hw/net: spelling fixes	2023-09-20 07:54:34 +03:00
eepro100.c	net: Provide MemReentrancyGuard * to qemu_new_nic()	2023-11-21 15:42:34 +08:00
etraxfs_eth.c	net: Provide MemReentrancyGuard * to qemu_new_nic()	2023-11-21 15:42:34 +08:00
ftgmac100.c	net: Provide MemReentrancyGuard * to qemu_new_nic()	2023-11-21 15:42:34 +08:00
i82596.c	net: Provide MemReentrancyGuard * to qemu_new_nic()	2023-11-21 15:42:34 +08:00
i82596.h	hw/net: Make NetCanReceive() return a boolean	2020-03-31 21:14:35 +08:00
igb_common.h	igb: Add a VF reset handler	2023-11-13 15:33:37 +08:00
igb_core.c	igb: Add a VF reset handler	2023-11-13 15:33:37 +08:00
igb_core.h	igb: Add a VF reset handler	2023-11-13 15:33:37 +08:00
igb_regs.h	hw/net: spelling fixes	2023-09-20 07:54:34 +03:00
igb.c	net: Provide MemReentrancyGuard * to qemu_new_nic()	2023-11-21 15:42:34 +08:00
igbvf.c	igb: Add Function Level Reset to PF and VF	2023-11-13 15:33:37 +08:00
imx_fec.c	net: Provide MemReentrancyGuard * to qemu_new_nic()	2023-11-21 15:42:34 +08:00
Kconfig	kconfig: Add PCIe devices to s390x machines	2023-07-14 11:10:57 +02:00
lan9118.c	net: Provide MemReentrancyGuard * to qemu_new_nic()	2023-11-21 15:42:34 +08:00
lance.c	Drop more @errp parameters after previous commit	2020-05-15 07:08:14 +02:00
lasi_i82596.c	Do not include sysemu/sysemu.h if it's not really necessary	2021-05-02 17:24:50 +02:00
mcf_fec.c	net: Provide MemReentrancyGuard * to qemu_new_nic()	2023-11-21 15:42:34 +08:00
meson.build	hw/xen: update Xen PV NIC to XenDevice model	2023-11-07 08:54:20 +00:00
mipsnet.c	net: Provide MemReentrancyGuard * to qemu_new_nic()	2023-11-21 15:42:34 +08:00
msf2-emac.c	net: Provide MemReentrancyGuard * to qemu_new_nic()	2023-11-21 15:42:34 +08:00
mv88w8618_eth.c	net: Provide MemReentrancyGuard * to qemu_new_nic()	2023-11-21 15:42:34 +08:00
ne2000-isa.c	net: Provide MemReentrancyGuard * to qemu_new_nic()	2023-11-21 15:42:34 +08:00
ne2000-pci.c	net: Provide MemReentrancyGuard * to qemu_new_nic()	2023-11-21 15:42:34 +08:00
ne2000.c	hw/net: ne2000: Remove the logic of padding short frames in the receive path	2023-07-07 16:35:12 +08:00
ne2000.h	Include hw/hw.h exactly where needed	2019-08-16 13:31:52 +02:00
net_rx_pkt.c	igb: Strip the second VLAN tag for extended VLAN	2023-05-23 15:20:15 +08:00
net_rx_pkt.h	igb: Strip the second VLAN tag for extended VLAN	2023-05-23 15:20:15 +08:00
net_tx_pkt.c	igb: Implement Tx SCTP CSO	2023-05-23 15:20:15 +08:00
net_tx_pkt.h	igb: Implement Tx SCTP CSO	2023-05-23 15:20:15 +08:00
npcm7xx_emc.c	net: Provide MemReentrancyGuard * to qemu_new_nic()	2023-11-21 15:42:34 +08:00
opencores_eth.c	net: Provide MemReentrancyGuard * to qemu_new_nic()	2023-11-21 15:42:34 +08:00
pcnet-pci.c	include/hw/pci: Split pci_device.h off pci.h	2023-01-08 01:54:22 -05:00
pcnet.c	net: Provide MemReentrancyGuard * to qemu_new_nic()	2023-11-21 15:42:34 +08:00
pcnet.h	net: Replace TAB indentations with spaces	2022-11-11 09:39:03 +01:00
rtl8139.c	net: Provide MemReentrancyGuard * to qemu_new_nic()	2023-11-21 15:42:34 +08:00
smc91c111.c	net: Provide MemReentrancyGuard * to qemu_new_nic()	2023-11-21 15:42:34 +08:00
spapr_llan.c	net: Provide MemReentrancyGuard * to qemu_new_nic()	2023-11-21 15:42:34 +08:00
stellaris_enet.c	net: Provide MemReentrancyGuard * to qemu_new_nic()	2023-11-21 15:42:34 +08:00
sungem.c	net: Provide MemReentrancyGuard * to qemu_new_nic()	2023-11-21 15:42:34 +08:00
sunhme.c	net: Provide MemReentrancyGuard * to qemu_new_nic()	2023-11-21 15:42:34 +08:00
trace-events	igb: Add a VF reset handler	2023-11-13 15:33:37 +08:00
trace.h	trace: switch position of headers to what Meson requires	2020-08-21 06:18:24 -04:00
tulip.c	net: Provide MemReentrancyGuard * to qemu_new_nic()	2023-11-21 15:42:34 +08:00
tulip.h	Use OBJECT_DECLARE_SIMPLE_TYPE when possible	2020-09-18 14:12:32 -04:00
vhost_net-stub.c	virtio-net: add support for configure interrupt	2023-01-08 01:54:22 -05:00
vhost_net.c	hw/net/vhost_net: Silence compiler warning when compiling with -Wshadow	2023-10-06 10:56:54 +02:00
virtio-net.c	net: Provide MemReentrancyGuard * to qemu_new_nic()	2023-11-21 15:42:34 +08:00
vmware_utils.h	hw/net/vmxnet3: Fix code to work on big endian hosts, too	2017-11-20 11:08:00 +08:00
vmxnet3_defs.h	include/hw/pci: Split pci_device.h off pci.h	2023-01-08 01:54:22 -05:00
vmxnet3.c	net: Provide MemReentrancyGuard * to qemu_new_nic()	2023-11-21 15:42:34 +08:00
vmxnet3.h	hw/net: spelling fixes	2023-09-20 07:54:34 +03:00
vmxnet_debug.h	Clean up ill-advised or unusual header guards	2016-07-12 16:20:46 +02:00
xen_nic.c	net: Provide MemReentrancyGuard * to qemu_new_nic()	2023-11-21 15:42:34 +08:00
xgmac.c	net: Provide MemReentrancyGuard * to qemu_new_nic()	2023-11-21 15:42:34 +08:00
xilinx_axienet.c	net: Provide MemReentrancyGuard * to qemu_new_nic()	2023-11-21 15:42:34 +08:00
xilinx_ethlite.c	net: Provide MemReentrancyGuard * to qemu_new_nic()	2023-11-21 15:42:34 +08:00