Variation 1:
Steps to reproduce:
* create empty .iso file (touch foo.iso)
* run 'mc' and press enter on empty .iso
Expected result: some error about invalid file format (sililar to what
F3 view would yield).
Actual result: mc elters a file as if it would be empty valid file.
Variation 2:
Steps to reproduce:
* pick valid .iso file
* deinstall all helper tools that handle .sio (isoinfo, xorriso, etc.)
* run 'mc' and press enter on empty .iso
Expected result: some error about invalid file format (sililar to what
F3 view would yield)
Actual result: mc enters a file as if it would be empty valid file
Variation 2 is especially confusing for users as it does not hint them
that they should install a tool to get it working. They just observe
silently broken behaviour.
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
...to fix the warning:
sfs.c:281:10: warning: declaration of 'sfs_info' shadows a global declaration [-Wshadow]
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
* 3955_cleanup:
Update po/*.po files.
src/vfs/extfs/helpers/Makefile.am: clarify condition.
VFS: move src/vfs/extfs/helpers/sfs.ini to src/vfs/sfs.
src/vfs/sfs/sfs.c: refactor flags and options.
(sfs_init): refactor loop.
(sfs_vfmake): use gboolean instead of int for boolean variable was_percent.
src/vfs/sfs/sfs.c: fix coding style.
src/vfs/local/local.c: fix coding style.
VFS: trivial optimization
VFS: move flush member from vfs_s_subclass to vfs_class.
VFS: move logfile member from vfs_s_subclass to vfs_class.
VFS: change vfs_class::nothingisopen members
vfs_class::nothingisopen: return gboolean instead of int.
Rename VFS module initialization functions.
lib/vfs/gc.c: yet another fixups
VFS: invalidate file descriptors after close.
Always use vfs_s_subclass as base class for VFS modules.
(vfs_path_from_str_uri_parser): get rid of extra type cast.
Ticket #3955: code cleanup before 4.8.23 release.
* (vfs_s_opendir): test if path is invalid or not ASAP.
* (vfs_s_readlink): likewise.
* (vfs_s_open): likewise.
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
* 212_menu_keybind:
Menubar: support Home and End actions for Menubar.
Menu: implement drop/execute menu by hotkey.
Ticket #212: implement keybinding for menu.
- Group commands coming from eclasses
- Add common Makefile variables
Signed-off-by: Lars Wendler <polynomial-c@gentoo.org>
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
* 3955_cleanup: (43 commits)
Update po/*.po files.
(mcview_execute_cmd): regroup actions.
lib/tty/key.c: fix coding style.
(setup_mc): clarify call of add_select_channel().
lib/tty/key.c: (SelectList): rename to select_t and refactor using GSList.
src/editor/edit.c: cleanup unused include.
(ftpfs_get_proxy_host_and_port): ret rid of host name duplcation.
(ftpfs_open_socket): fix memory leak in case of proxy usage
src/vfs/ftpfs/ftpfs.c: fix coding style.
src/vfs/ftpfs/ftpfs.c: use gboolean instead of int where reasonable.
(tar_read_header): refactor loop. Get rid of goto.
tar.c: move header decoding to separate function.
tar.c: lots of renaming to be close with the GNU tar source code.
extfs: change some function arguments.
extfs: refactoring: use standard VFS structures.
extfs: refactoring of open and read archive.
(extfs_find_entry_int): minor optimization.
VFS: make vfs_file_handler related macros more readable.
VFS: derive VFS-specific file handler class from vfs_file_handler_t.
VFS: make vfs_super related macros more readable.
...
