akallabeth
f264cc729c
[coverity] 1543240 Dereference before null check
2024-04-12 12:41:42 +02:00
akallabeth
be4fb7f6dd
[coverity] 1543187 Dereference before null check
2024-04-12 12:41:42 +02:00
akallabeth
600c7a8999
[coverity] 1543080 Dereference before null check
2024-04-12 12:41:42 +02:00
akallabeth
d18585b8cc
[coverity] 1543058 Dereference before null check
2024-04-12 12:41:42 +02:00
akallabeth
5862537471
[coverity] 1543139 Resource leak
2024-04-12 09:45:09 +02:00
akallabeth
dc488c5e23
[coverity] 1543148 Resource leak
2024-04-12 09:45:09 +02:00
akallabeth
285bea320d
[coverity] 1543217 Resource leak
2024-04-12 09:45:09 +02:00
akallabeth
8d9244cb3d
[coverity] 1543259 Resource leak
2024-04-12 09:45:09 +02:00
akallabeth
1affbd0655
[coverity] 1543285 Resource leak
2024-04-11 12:04:07 +02:00
akallabeth
0905796cd7
[core,gateway[ fix use after free
2024-04-06 09:17:17 +02:00
Ilya Shipitsin
309509808c
libfreerdp/core/gateway/rdg.c: handle malloc failure
2024-04-05 09:59:12 +02:00
akallabeth
82dc655979
[core,gateway] improve warning for bad request
...
In case of E_PROXY_ORCHESTRATION_LB_SESSIONHOST_DEALLOCATED print a
warning with the message body or a generic fallback should that not be
provided.
2024-03-26 09:19:45 +01:00
akallabeth
0106d34636
[core,gatewya] fix function argument type
2024-03-20 08:39:15 +01:00
akallabeth
67eb2fce54
[core,gateway] respect abortEvent
...
in RDG read functions check for rdpContext::abortEvent and terminate
blocking functions if set.
2024-03-20 08:39:15 +01:00
akallabeth
70a8b185be
[core,gateway] log http response status & reason
...
only log headers with debug level and body with trace level.
normal operation does not require this information and will flood the
console.
2024-03-12 17:07:37 +01:00
akallabeth
93eb4df524
[core,gateway] implement RDG and TSG policy
...
* use dynamic logger in RDG
* honor [MS-TSGU] 2.2.9.2.1.5.2 TSG_REDIRECTION_FLAGS
* honor [MS-TSGU] 2.2.10.16 HTTP_TUNNEL_AUTH_RESPONSE
HTTP_TUNNEL_AUTH_RESPONSE_FIELD_REDIR_FLAGS flag
* add setting GatewayIgnoreRedirectionPolicy to ignore the gateway
policy if desired
2024-03-07 16:18:41 +01:00
akallabeth
d7ebec5a65
[tidy] move loop variable declaration to loop
2024-02-22 12:31:50 +01:00
akallabeth
b894199f72
[winpr,collections] add generic string clone functions
...
The ArrayList, HashTable, ... New functions require
void* (*fkt)(const void* ptr) type functions. Provide a generic wrapper
for CHAR and WCHAR strdup to eliminate warnings. Also export a
corresponding free function to avoid issues with runtime
differences.
2024-02-15 11:49:16 +01:00
akallabeth
0e44b2c674
[clang-tidy] clang-analyzer-unix.Malloc
2024-02-15 11:49:16 +01:00
akallabeth
0ba995655d
[clang-tidy] cppcoreguidelines-init-variables
2024-02-15 11:49:16 +01:00
akallabeth
207def5c56
[clang-tidy] readability-isolate-declaration
2024-02-15 11:49:16 +01:00
Martin Fleisz
2e5d4fbe06
gateway: Do not fail if unprocessed padding bytes are detected
...
Sometimes the RPC PDUs have unprocessed data (padding bytes) at their
end. In that case do not fail but just log a warning with the correct
amount of remaining bytes.
2024-02-14 16:25:41 +01:00
akallabeth
ba8cf8cf21
[build] fix Wmismatched-deallocator warnings
...
With custom malloc function attributes the fail path in the _New
functions produces warnings due to allocator mismatches. Silence them.
2024-02-05 08:16:55 +01:00
akallabeth
bb42d425ed
[gcc,clang] add support for attribute(malloc)
...
Mark all malloc like functions and add their appropriate free function
to let the compiler complain on mismatches
2024-02-02 15:10:40 +01:00
akallabeth
cefe847683
[core,gateway] use FREERDP_USER_AGENT define
...
Define FREERDP_USER_AGENT in version.h to be used by gateway http user
agent
2024-01-29 08:46:29 +01:00
akallabeth
575d42312a
[code] improve error checks on free
2024-01-19 09:57:41 +01:00
Armin Novak
bb8c08f06e
[build,mingw] rename variable interface
...
interface is a reserved keyword with mingw, breaking compilation.
2023-12-21 07:11:12 +01:00
Armin Novak
d6b7cfc1c2
[warnings] fixed -Wpointer-sign
2023-12-13 13:24:22 +01:00
Armin Novak
a7200699f4
[core,gateway] do not pack RPC_FAULT_CODES
2023-11-30 12:43:03 +01:00
Armin Novak
492cbc8e6f
[opaque_settings] reorder internal includes
...
order is important for internals, as the deprecation warnings are
deactivated for this use case
2023-11-24 21:23:38 +01:00
akallabeth
c78e466be1
[warnings] fixes Wunused-variable
2023-11-24 18:19:03 +01:00
akallabeth
dd2d110870
[warnings] fix -Wcast-qual
2023-11-24 18:19:03 +01:00
akallabeth
cd4d77af86
[settings] add deprecation warnings
...
direct struct access to rdpSettings now produces warnings if not
explicitly deactiaved by defining FREERDP_SETTINGS_INTERNAL_USE
2023-11-24 14:54:56 +01:00
akallabeth
1163cc4d5c
[core] add internal settings.h include
2023-11-24 14:54:56 +01:00
akallabeth
e3a84921de
[core,gateway] fix TSG_PACKET_TYPE_QUARENC_RESPONSE
...
parsing of TSG_PACKET_TYPE_QUARENC_RESPONSE was incomplete, fix that
2023-11-20 18:00:42 +01:00
Armin Novak
e451b4cad1
[core,gateway] rpc use generated session id
2023-11-20 18:00:42 +01:00
Armin Novak
7d02a97a88
[core,gateway] change type of GUID arguments
...
use const GUID* for GUID strings and format the string internally
2023-11-20 18:00:42 +01:00
Armin Novak
e62e1dbbaf
[core,gateway] add RDG-Correlation-Id
...
implement [MS-TSGU] 2.2.3.2.2 RDG-Correlation-Id
2023-11-20 18:00:42 +01:00
Armin Novak
148e61606a
[core,gateway] silence reading of rts signature
...
sometimes we just try to read the signature and do not want errors
logged.
2023-11-20 18:00:42 +01:00
Armin Novak
99f3a9c0e6
[core,gateway] add rts_recv_ping_pdu
2023-11-20 18:00:42 +01:00
Armin Novak
f367465485
[core,gateway] improve rpc logging
2023-11-20 18:00:42 +01:00
Armin Novak
9fcde2db74
[core,gateway] removed duplicate vc_state_str
2023-11-20 18:00:42 +01:00
Armin Novak
8990ffefca
[core,gateway] rpc dynamic logger
2023-11-20 18:00:42 +01:00
Armin Novak
36647567ac
[core,gateway] fix parsing of RTS PDU
...
* [MS-RPCH] 2.2.4.51 FlowControlAckWithDestination RTS PDU
2023-11-20 18:00:42 +01:00
Armin Novak
814ab2a212
[core,gateway] use dynamic logger in tsg
2023-11-20 18:00:42 +01:00
Armin Novak
6e7a35f8bc
[core,gateway] log rts_recv_out_of_sequence_pdu
2023-11-20 18:00:42 +01:00
Armin Novak
a0db106306
[core,gateway] add vc state logging
2023-11-20 18:00:42 +01:00
Armin Novak
fac9fa5f90
[core,gateway] add rpc stringify functions
2023-11-20 18:00:42 +01:00
Armin Novak
60ceff95c5
[fflush] remove of unnecessary fflush
2023-11-20 18:00:42 +01:00
Armin Novak
cf76e70e85
[core,gateway] fix rts_read_auth_verifier_with_stub
...
check offset against fragment size, not remaining size
2023-11-20 18:00:42 +01:00