mirrors/FreeRDP
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[coverity] 1543058 Dereference before null check

Browse Source
This commit is contained in:
akallabeth 2024-04-12 10:25:35 +02:00 committed by akallabeth
parent e88cb403bb
commit d18585b8cc
1 changed files with 11 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
libfreerdp/core/gateway/tsg.c
View File

@ -2082,10 +2082,12 @@ static BOOL TsProxyCreateChannelReadResponse(wLog* log, const RPC_PDU* pdu,
CONTEXT_HANDLE* channelContext, UINT32* channelId)
{
BOOL rc = FALSE;
WLog_Print(log, WLOG_DEBUG, "TsProxyCreateChannelReadResponse");
if (!pdu)
return FALSE;
WINPR_ASSERT(log);
WINPR_ASSERT(pdu);
WINPR_ASSERT(channelId);
WLog_Print(log, WLOG_DEBUG, "TsProxyCreateChannelReadResponse");
if (!Stream_CheckAndLogRequiredLengthWLog(log, pdu->s, 28))
goto fail;
@ -2110,15 +2112,15 @@ fail:
static BOOL TsProxyCloseChannelWriteRequest(rdpTsg* tsg, CONTEXT_HANDLE* context)
{
wStream* s = NULL;
rdpRpc* rpc = NULL;
WINPR_ASSERT(tsg);
WINPR_ASSERT(context);
WLog_Print(tsg->log, WLOG_DEBUG, "TsProxyCloseChannelWriteRequest");
if (!tsg || !tsg->rpc || !context)
return FALSE;
rdpRpc* rpc = tsg->rpc;
WINPR_ASSERT(rpc);
rpc = tsg->rpc;
s = Stream_New(NULL, 20);
wStream* s = Stream_New(NULL, 20);
if (!s)
return FALSE;