mirrors/FreeRDP
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[coverity] 1543240 Dereference before null check

Browse Source
This commit is contained in:
akallabeth 2024-04-12 10:42:10 +02:00 committed by akallabeth
parent 8f9707897c
commit f264cc729c
1 changed files with 9 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
libfreerdp/core/gateway/tsg.c
View File

@ -2033,20 +2033,20 @@ fail:
static BOOL TsProxyCreateChannelWriteRequest(rdpTsg* tsg, CONTEXT_HANDLE* tunnelContext)
{
size_t count = 0;
wStream* s = NULL;
rdpRpc* rpc = NULL;
WINPR_ASSERT(tsg);
WINPR_ASSERT(tunnelContext);
WLog_Print(tsg->log, WLOG_DEBUG, "TsProxyCreateChannelWriteRequest");
if (!tsg || !tsg->rpc || !tunnelContext || !tsg->Hostname)
if (!tsg->rpc || !tsg->Hostname)
return FALSE;
rpc = tsg->rpc;
count = _wcslen(tsg->Hostname) + 1;
rdpRpc* rpc = tsg->rpc;
const size_t count = _wcslen(tsg->Hostname) + 1;
if (count > UINT32_MAX)
return FALSE;
s = Stream_New(NULL, 60 + count * 2);
wStream* s = Stream_New(NULL, 60 + count * 2);
if (!s)
return FALSE;
@ -2388,8 +2388,8 @@ BOOL tsg_recv_pdu(rdpTsg* tsg, const RPC_PDU* pdu)
case TSG_STATE_CONNECTED:
{
CONTEXT_HANDLE* TunnelContext = NULL;
TunnelContext = (tsg->reauthSequence) ? &tsg->NewTunnelContext : &tsg->TunnelContext;
CONTEXT_HANDLE* TunnelContext =
(tsg->reauthSequence) ? &tsg->NewTunnelContext : &tsg->TunnelContext;
if (!TsProxyAuthorizeTunnelReadResponse(tsg, pdu))
{