Commit Graph

11022 Commits

Author SHA1 Message Date
Ilya Shipitsin
a9ab65a935 resolve an issue found by cppcheck:
[libfreerdp/crypto/certificate.c:315] -> [libfreerdp/crypto/certificate.c:316]: (warning) Either the condition 'if(fingerprint&&fprint)' is redundant or there is possible null pointer dereference: fingerprint.
2017-06-01 00:05:51 +05:00
David Fort
3470c4d5f8 Merge pull request #3969 from chipitsine/cppcheck
resolve issue found by cppcheck
2017-05-31 16:48:12 +02:00
David Fort
bbe80451aa Merge pull request #3986 from akallabeth/debug_fix
Fixed missing external declaration (#3982)
2017-05-31 12:02:31 +02:00
Armin Novak
22f1fbe3d2 Fixed missing external declaration (#3982) 2017-05-31 11:44:33 +02:00
akallabeth
2eb0c53428 Merge pull request #3985 from ilammy/x11-cliprdr/fix-html
Do not fixup HTML data length
2017-05-31 11:34:52 +02:00
Ilya Shipitsin
06edf5f7c5 resolve an issue found by cppcheck:
[channels/tsmf/client/tsmf_main.c:89] -> [channels/tsmf/client/tsmf_main.c:95]: (warning) Either the condition '!callback' is redundant or there is possible null pointer dereference: callback.
2017-05-31 14:32:59 +05:00
ilammy
ac2b13fdcc client/X11: do not fixup HTML data length
The data provided by local applications can be actually encoded in
UTF-16 (e.g., Firefox does this to HTML). UTF-16 allows embedded null
bytes so we should not use strlen() to fix up the data. The HTML format
synthesizer can handle trailing null bytes just fine and can detect
whether it deals with UTF-8 or UTF-16.
2017-05-31 05:01:30 +03:00
akallabeth
a1270ec1fb Merge pull request #3980 from uplusplus/patch-5
fixed issue:#3974
2017-05-30 09:20:30 +02:00
joy.you
921f0b7480 fixed issue:#3974
ConvertToUnicode failed
2017-05-27 16:10:41 +08:00
David Fort
48163a27db Merge pull request #3906 from akallabeth/addin_cast_fix
Addin cast fix
2017-05-22 11:12:05 +02:00
David Fort
b92a789dfd Merge pull request #3963 from akallabeth/qoe_ack
Added client RDPGFX_QOE_FRAME_ACKNOWLEDGE_PDU
2017-05-22 11:10:03 +02:00
David Fort
ee8ae987bf Merge pull request #3967 from akallabeth/sec_encrypt_fix
SEC_ENCRYPT check in rdp_client_connect_auto_detect
2017-05-22 11:08:32 +02:00
David Fort
25a3b23013 Merge pull request #3965 from akallabeth/drive_fixes_unicode
Drive fixes unicode
2017-05-22 11:08:10 +02:00
David Fort
7317f0cac6 Merge pull request #3966 from davewheel/ntlm_getHash
Add a callback to provide NTLM hashes on server-side
2017-05-22 11:07:21 +02:00
davewheel
4bfb4dddbf Add a callback to provide NTLM hashes on server-side
Adds a callback that allows servers to compute NTLM hashes by themselves. The typical
use of this callback is to provide a function that gives precomputed hash values.

Sponsored by: Wheel Systems (http://www.wheelsystems.com)
2017-05-18 14:24:24 +02:00
Armin Novak
f414522b7a Added setting for QoeAck. 2017-05-18 14:07:09 +02:00
Armin Novak
b6e5ec5039 Added client RDPGFX_QOE_FRAME_ACKNOWLEDGE_PDU 2017-05-18 14:07:09 +02:00
Martin Fleisz
4cc1ba5b1d Merge pull request #3964 from akallabeth/update_reset_state_fix
Update reset state fix
2017-05-18 09:49:36 +02:00
Armin Novak
ed2c675a83 Fixed path length check. 2017-05-18 09:43:02 +02:00
Armin Novak
6b960a4319 Fix #3962: Remove trailing slashes from path. 2017-05-17 16:43:16 +02:00
Armin Novak
0a309fcbec Use unicode constants for WCHAR 2017-05-17 16:17:16 +02:00
Armin Novak
8904c15cc9 Fixed missing state reset. 2017-05-17 15:58:44 +02:00
Armin Novak
6649eed659 Fixed missing argument checks. 2017-05-17 15:58:32 +02:00
Martin Fleisz
2a23eadada Merge pull request #3957 from akallabeth/gfx_use_logger_instance
Use a preallocated logger instance for GFX
2017-05-16 09:37:49 +02:00
Armin Novak
2a92cc9631 Use a preallocated logger instance for GFX
The static logger functions of WLog have quite a heavy performance
penalty. Use a pointer to an allocated logger to speed things up.
2017-05-15 17:24:47 +02:00
David Fort
2320b3b7e9 Merge pull request #3942 from akallabeth/shift_warn_fix
Fixed right shift on 32bit platforms.
2017-05-15 13:56:07 +02:00
Armin Novak
8c52dcbdc2 SEC_ENCRYPT check in rdp_client_connect_auto_detect
Fix by @wizwizaco for #3951
2017-05-15 13:10:10 +02:00
akallabeth
452eb55a3c Merge pull request #3953 from hardening/kill_warnings
Drop some annoying warning
2017-05-15 11:54:57 +02:00
David Fort
17a4e95a5b Drop some annoying warning
Probably that some unused functions should be removed, but at least it makes
it compile with no warnings.
2017-05-12 13:54:16 +02:00
David Fort
b1df835085 Merge pull request #3952 from akallabeth/set_keyboard_ime
Added support for Set Keyboard IME Status
2017-05-12 10:23:08 +02:00
akallabeth
3944139c20 Merge pull request #3950 from hypherion2/cp_fixes
Fix handle leaks in encomsp and remdesk server
2017-05-12 09:51:17 +02:00
Armin Novak
b1d631f1e5 Added support for Set Keyboard IME Status 2017-05-12 09:43:58 +02:00
Adrian A
5beb181dec Fix handle leaks in encomsp and remdesk server
Ensure proper thread cleanup when these channel servers are stopped.
2017-05-11 13:21:47 -07:00
Martin Fleisz
1e3d4d62a4 Merge pull request #3949 from akallabeth/gdi_surface_crash_fix
Check arguments for Bitmap_SetSurface
2017-05-11 13:59:00 +02:00
David Fort
12dbc06b1a Merge pull request #3948 from hypherion2/master
Remove library prefix override for rdpei-server
2017-05-11 13:49:06 +02:00
Armin Novak
3eb882dd53 Check arguments for Bitmap_SetSurface
The function may be called during connection phase
where there is no valid GDI available.
2017-05-11 13:34:37 +02:00
David Fort
ca1872c60e Merge pull request #3947 from akallabeth/openh264_fixes
Openh264 fixes
2017-05-10 21:22:18 +02:00
Adrian A
fd39002288 Remove library prefix override for rdpei-server
This library was missed in commit
059374457d, so it was the only one that
stilll had a lib prefix
2017-05-10 09:56:37 -07:00
Armin Novak
620b1ea603 Added 64bit file support flag for linux. 2017-05-10 14:58:12 +02:00
Armin Novak
21e20ac9f2 Initialize H264 context size for GFX surfaces. 2017-05-10 12:36:08 +02:00
Armin Novak
ec0992e938 Added pkg-config to cmake OpenH264 detection. 2017-05-10 12:35:20 +02:00
akallabeth
8df8cc6fb5 Merge pull request #3937 from hardening/h264_multimon
Fix h264 in multimon scenario
2017-05-09 11:16:12 +02:00
Bernhard Miklautz
4d8d15ebf4 Merge pull request #3931 from hypherion2/master
Remove unused buffer in Mac shadow subsystem
2017-05-09 09:42:20 +02:00
akallabeth
a7215402ba Merge pull request #3943 from chipitsine/cppcheck
resolve an issue identified by cppcheck:
2017-05-08 16:28:58 +02:00
akallabeth
0679a91236 Merge pull request #3941 from mfleisz/fix_openh264_mt
codec: Fix multi-threading support for OpenH264 1.6 or later
2017-05-08 10:17:27 +02:00
Ilya Shipitsin
07c2345879 resolve an issue identified by cppcheck:
[channels/urbdrc/client/libusb/libusb_udevice.c:1666] -> [channels/urbdrc/client/libusb/libusb_udevice.c:1661]: (warning) Either the condition 'request' is redundant or there is possible null pointer dereference: request.
2017-05-06 00:05:59 +05:00
Martin Fleisz
16111e7e7f codec: Fix multi-threading support for OpenH264 1.6 or later 2017-05-05 12:37:27 +02:00
Martin Fleisz
068f61b4d4 Merge pull request #3924 from akallabeth/gfx_surface_area_update_callback
Added a GFX area update callback.
2017-05-04 10:53:50 +02:00
Armin Novak
4ba7670e43 Fixed right shift on 32bit platforms. 2017-05-04 09:20:10 +02:00
akallabeth
9645123a53 Merge pull request #3930 from realjiangms/fix_shadow_thread_leak
server/shadow: close the thread handle so that it is detached because…
2017-05-03 15:39:40 +02:00