mirrors/FreeRDP
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

resolve an issue found by cppcheck:

Browse Source 
[libfreerdp/crypto/certificate.c:315] -> [libfreerdp/crypto/certificate.c:316]: (warning) Either the condition 'if(fingerprint&&fprint)' is redundant or there is possible null pointer dereference: fingerprint.
This commit is contained in:
Ilya Shipitsin 2017-06-01 00:05:51 +05:00
parent 3470c4d5f8
commit a9ab65a935
1 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
libfreerdp/crypto/certificate.c
View File

@ -312,9 +312,12 @@ static int certificate_data_match_raw(rdpCertificateStore* certificate_store,
if (port == certificate_data->port)
{
found = TRUE;
match = (strcmp(certificate_data->fingerprint, fingerprint) == 0) ? 0 : -1;
if (fingerprint && fprint)
*fprint = _strdup(fingerprint);
if (fingerprint)
{
match = (strcmp(certificate_data->fingerprint, fingerprint) == 0) ? 0 : -1;
if (fprint)
*fprint = _strdup(fingerprint);
}
if (subject && psubject)
crypto_base64_decode(subject, strlen(subject), (BYTE**)psubject, &outLen);
if (issuer && pissuer)