akallabeth
0d5bc92a2b
[warnings] fix apple iOS/macos
2024-09-15 19:47:13 +02:00
akallabeth
869bfd5e86
[client,android] mark includes SYSTEM
2024-09-15 19:47:03 +02:00
akallabeth
1bd6d70057
[warnings] fix some warnings on mac os
2024-09-15 10:06:22 +02:00
akallabeth
ba41d5e532
[warnings] fix unchecked return
2024-09-15 09:08:02 +02:00
akallabeth
a1cef8dd85
[warnings] silence and fix unused results
2024-09-14 21:29:28 +02:00
akallabeth
3460f64f57
[client,common] fix possible NULL dereference
2024-09-14 21:29:21 +02:00
akallabeth
16cec716e0
[strtok] replace function with strtok_s
...
Since strtok is not thread safe replace it with strtok_s (WinPR wrapper
around strtok_r for systems not supporting the ISO function names)
2024-09-13 21:19:17 +02:00
akallabeth
7ef9345743
Merge pull request #10549 from hardening/rcg2
...
core, channels: client-side remote credential guard
2024-09-13 08:24:14 +02:00
akallabeth
7ebefc505f
[warnings] fix some msbuild warnings
2024-09-12 13:32:41 +02:00
akallabeth
b29c141c39
[client,cmdline] fix COMMAND_LINE_ARGUMENT_A arguments
...
* The project expects COMMAND_LINE_ARGUMENT_A arguments, so fix
COMMAND_LINE_ARGUMENT macro usage. (affects windows API)
2024-09-12 13:30:10 +02:00
akallabeth
2638d9d894
[warnings] fix casts
2024-09-12 13:30:00 +02:00
akallabeth
773eed8878
[client,sdl] use auto for variable declaration
2024-09-12 13:29:53 +02:00
akallabeth
e00661d338
[warnings] fix dead store warnings
2024-09-12 13:29:46 +02:00
akallabeth
c9b0c9ecd5
[warnings] remove unused variables
2024-09-12 10:08:10 +02:00
akallabeth
b2d58de1da
[client,X11] fix Wtautological-constant-out-of-range-compare
2024-09-12 09:08:58 +02:00
akallabeth
cc6850bf21
[warnings] fix format nonliteral
...
add pragma to suppress format nonliteral warnings where appropriate
2024-09-12 09:08:53 +02:00
akallabeth
8a990644c0
[warnings] fix missing NULL assert/check
2024-09-12 09:08:51 +02:00
akallabeth
2ae0c456b4
[client,sdl] fix float casts
2024-09-12 09:08:49 +02:00
akallabeth
384cd284d8
[warnings] use WINPR_CAST_CONST_AWAY
...
on locations that require (ugly) const to non const casts usw
WINPR_CAST_CONST_AWAY to do proper compiler specific casts to avoid
warnings
2024-09-11 23:41:50 +02:00
akallabeth
2175428df5
[client,SDL] default webview to off
...
The AAD webview is currently not working as expected, disable until
resolved.
2024-09-11 22:23:33 +02:00
akallabeth
993756e575
[client,sdl] fix SDL3 compilation error
2024-09-11 21:50:30 +02:00
akallabeth
06097575a4
[client,sdl] fix redundant initializer
2024-09-11 20:50:36 +02:00
akallabeth
ae95b66922
[warnings] fix portability [cm]alloc size 0
2024-09-11 20:50:33 +02:00
akallabeth
eec69bde0f
[client,sdl] fix c++ string find, use char overload
2024-09-11 20:50:14 +02:00
akallabeth
9fed64eb0d
[client,SDL] SdlEventUpdateTriggerGuard
...
Delete copy & move assingment operators
2024-09-11 20:48:39 +02:00
David Fort
a4bd5ba886
core, channels: client-side remote credential guard
...
This patch implements the client-side part of the remote credential guard feature
as described in MS-RDPEAR. The 2 main changes are: shipping the TSRemoteGuardaCreds in
NLA, and implement the rdpear channel that allows LSASS to remote all the calls to
our client. For now it's UNIX only as the windows implementation would be implemented
in a completely different way.
To test, you may establish you ccache and then connect with (RCG enabled on the server):
xfreerdp /remoteGuard /u:<user> /d:<domain> /v<server>
That should log you in, and in the session you should not be asked for credentials when
doing mstsc /remoteGuard /v:<other server>.
2024-09-11 17:15:11 +02:00
Armin Novak
17c209c0f9
[client,common] change /dynamic-resizing to BOOL option
...
Allows to use +-/ prefixes to enable/disable the option. Brought up on
matrix channel for uses with RDP files that enable the option. Now it
can be disabled by adding -dynamic-resolution on command line.
2024-09-11 11:06:21 +02:00
akallabeth
edf6ab89f7
[warnings] fix dead store
2024-09-10 14:43:11 +02:00
akallabeth
189abc73f3
[client,sdl] fix missing field initializer warnings
2024-09-10 14:42:42 +02:00
akallabeth
ba7465abf5
Merge pull request #10585 from akallabeth/x11-clip-cache-fix
...
[client,x11] fix clipboard cache
2024-09-10 14:31:25 +02:00
akallabeth
fcdd03a020
[client,x11] fix clipboard cache
...
Use new function format_to_cache_slot to convert a clipboard format to a
valid key value for wHashTable. This avoids issues with our synthesized
CF_RAW format (value 0) which is an invalid key for wHashTable
2024-09-10 13:35:21 +02:00
akallabeth
2a641aa834
[client,sdl3] update to new API
2024-09-10 12:46:27 +02:00
akallabeth
215f798665
[client,x11] add minimize shortcut
2024-09-10 12:29:12 +02:00
akallabeth
d93d9765b3
[client,sdl] add minimize shortcut
2024-09-10 12:28:36 +02:00
akallabeth
306af4070c
[client,common] properly abort on invalid scale-desktop
2024-09-09 12:37:22 +02:00
akallabeth
6a64fe121b
Merge pull request #10569 from akallabeth/fprintf-void
...
Fprintf void
2024-09-06 10:44:32 +02:00
akallabeth
2170cc65e3
[warnings] cast return of fprintf (void)
...
fprintf returns a value. Not using it is mostly fine, but it generates
noise when compiling with all warnings on, so cast to (void)
2024-09-06 09:16:21 +02:00
akallabeth
b26ab2f069
[client,common] extended parser
2024-09-06 08:23:06 +02:00
akallabeth
590fbcf005
Merge pull request #10564 from hardening/sdl3_fix
...
sdl3: fix build with last version of SDL3
2024-09-05 21:51:44 +02:00
akallabeth
749023bacb
Merge pull request #10555 from akallabeth/cast-fix-tls
...
[crypto,tls] simplify function pointer cast
2024-09-05 17:18:27 +02:00
David Fort
3a9a820092
sdl3: fix build with last version of SDL3
2024-09-05 14:57:11 +02:00
akallabeth
8b92e17e60
modernize includes
2024-09-04 22:00:12 +02:00
akallabeth
6a1c3b4545
[function pointer] use macro for GetProcAddress
...
Cast all results of GetProcAddress with WINPR_FUNC_PTR_CAST
2024-09-04 21:31:48 +02:00
akallabeth
889ae65a1f
[warnings] add WINPR_CAST_CONST_PTR_AWAY
...
simple macro casting a const pointer to a non const one.
2024-09-04 20:55:17 +02:00
akallabeth
245afb706c
[function pointers] unify casts with macro
2024-09-04 20:06:45 +02:00
akallabeth
5e123735fa
[warnings] fixed sign-compare
2024-09-04 10:14:05 +02:00
akallabeth
2fc791fe9b
[client,X11] fix shadowed variable
2024-09-04 09:45:00 +02:00
akallabeth
baa70d1ab6
[warnings] fix compare integers of different signs
2024-09-03 15:10:46 +02:00
akallabeth
5a4a1a40ad
fix declaration and implementation parameter names
2024-09-03 12:24:53 +02:00
akallabeth
f7fd817d1c
[warnings] fix redundant casting
2024-09-03 12:24:51 +02:00
akallabeth
cbae4155fb
[client,SDL] delete unused copy & move constructors
2024-09-03 12:17:20 +02:00
Armin Novak
fe4cb6de65
[warnings] fix float/double warnings
2024-09-02 16:20:20 +02:00
akallabeth
5887f8a558
[warnings] suppress warnings
...
Some warnings can not be solved as they depend on external libraries or
limitations of the C standard.
Suppress these warnings selectively
2024-08-30 15:40:16 +02:00
akallabeth
190929c018
[warnings] fix function pointer casts
2024-08-30 15:40:01 +02:00
akallabeth
bd637c6cd1
[warnings] fix various clang-tidy warnings
2024-08-29 17:13:50 +02:00
akallabeth
500495dc00
[warnings] fix SDL3 related issues
2024-08-29 16:03:51 +02:00
akallabeth
ceae258e37
[warnings] fix clang-tidy issues in clients
2024-08-29 15:34:27 +02:00
akallabeth
9c9d74e920
[warnings] fix redundant casts
2024-08-29 12:03:09 +02:00
akallabeth
15456e1ee1
[warnings] fix implicit widening conversion
2024-08-29 10:47:20 +02:00
akallabeth
1d33095500
[warnings] fix cert-err33-c
...
Fix unused return values, cast to void if on purpose
2024-08-29 10:19:27 +02:00
Armin Novak
d71af44bb1
[warnings] disable warnings for generated code
...
* Disable clang-tidy in test build directories
* Disable compiler warnings for test binary directories.
These contain generated code we can not change, so the warnings are just noise
2024-08-28 09:18:30 +02:00
akallabeth
00eb86970d
Merge pull request #10510 from akallabeth/serial-cleanup
...
Serial cleanup
2024-08-26 13:47:10 +02:00
akallabeth
7054b26916
[channels,parallel] compilation checks
...
* Only compile channel related command line if enabled
* Warn on unsupported platforms
2024-08-26 13:30:30 +02:00
akallabeth
050eef537a
[client,common] guard /serial argument
...
only enable if serial redirection support is compiled in
2024-08-26 13:21:13 +02:00
akallabeth
56d660f258
[cmake] mark dependency includes SYSTEM
...
Mark all dependency include paths SYSTEM so warnings from system headers
are excluded from ci warning statistics
2024-08-26 11:10:49 +02:00
akallabeth
2812775c96
Merge pull request #10504 from akallabeth/sdl-monitors
...
[client,sdl] add support for /monitors argument
2024-08-23 15:03:46 +02:00
akallabeth
49dc431045
[client,sdl] add support for /monitors argument
2024-08-23 14:00:47 +02:00
akallabeth
ba7fd06ec4
[coverity] fix some warnings
...
* mostly dead store and identical code branches.
* some possible integer overflows
2024-08-23 12:38:41 +02:00
Armin Novak
17d44e847f
[coverity] fix various warnings
2024-08-21 09:47:34 +02:00
akallabeth
37008506c2
[client,sdl] remove tab from dialog messages
2024-08-20 13:31:41 +02:00
akallabeth
7fe1164d26
Merge pull request #10490 from akallabeth/desktop-resize-deadlock
...
Desktop resize deadlock
2024-08-20 13:28:04 +02:00
akallabeth
37f9d8a930
[client,wayland] improve VerifyCertificate message
...
* Use FreeRDP_CertificateCallbackPreferPEM for callbacks
2024-08-20 12:42:59 +02:00
akallabeth
d5d3d8501e
[client,x11] improve VerifyCertificate message
...
* Use FreeRDP_CertificateCallbackPreferPEM for callbacks
2024-08-20 12:42:57 +02:00
akallabeth
7ea8e63a39
[client,sample] improve VerifyCertificate message
...
* Use FreeRDP_CertificateCallbackPreferPEM for callbacks
2024-08-20 12:42:54 +02:00
akallabeth
39e8c077d4
[client,sdl] improve VerifyCertificate message
...
* Use FreeRDP_CertificateCallbackPreferPEM for callbacks
* Add notBefore and notAfter dates to callback messages
2024-08-20 12:42:51 +02:00
akallabeth
e95a813560
[client,common] unify PEM ceritificate string
...
* Unify PEM data extraction
* Add notBefore and notAfter dates to certificate callback messages
2024-08-20 12:42:49 +02:00
akallabeth
dcbeedb4d4
[client,x11] fix a possible deadlock on desktop resize
2024-08-20 12:41:17 +02:00
Armin Novak
1f95865907
[client,common] ignore empty strings for channels
...
Ignore empty strings when parsing redirection channel arguments
2024-08-14 14:31:58 +02:00
akallabeth
4523c4ec78
Merge pull request #10472 from akallabeth/clip-rdp-2-rdp-fix
...
Clip rdp 2 rdp fix
2024-08-13 08:27:35 +02:00
Armin Novak
14c85bafd3
[client,x11] fix RAW clipboard copy
2024-08-12 15:55:26 +02:00
David Fort
4e6f7fb989
[sdl3] fix build against last SDL3
2024-08-12 11:50:02 +02:00
akallabeth
7dc51e1b71
[client,x11] log variable name for XGetAtomName
...
To better debug issues with calls log the name of the target variable to
allow better tracing which call did fail
2024-08-02 15:12:58 +02:00
akallabeth
2f5570cd67
Merge pull request #10423 from akallabeth/action_script
...
[client,X11] fix ActionScript
2024-07-25 10:00:26 +02:00
Armin Novak
44b07721ec
[client,X11] fix ActionScript
...
* Unify script calls
* Update documentation
* Fix home directory
2024-07-25 09:42:03 +02:00
akallabeth
56b50966a3
[client,x11] log all XInternAtom calls
2024-07-25 07:47:40 +02:00
Armin Novak
9e71b423cd
[warnings] fix various compiler warnings
2024-07-24 11:08:20 +02:00
Ilya Matthew Kuvarzin
761c3a807b
Fix: Prevent RemoteAPP window minimization on desktop switch in Gnome
...
- Modified xf_event_PropertyNotify in xf_event.c to check for Gnome session before minimizing the window
- Added the session check logic in a new function IsGnome placed in xf_utils
- This resolves the issue where RemoteAPP windows were unintentionally minimized when switching desktops in Gnome
- Ensured minimal impact on other window managers
2024-07-23 14:56:10 +02:00
akallabeth
1fe61c9432
Merge pull request #10391 from akallabeth/timezone_impro
...
Timezone improved
2024-07-19 12:45:08 +02:00
akallabeth
6c682c8418
[client,common] add option to set timezone
...
* /timezone now allows setting the timezone used from a windows timezone
key name
* /list:timezones now lists all available windows timezone key names
2024-07-19 11:39:46 +02:00
akallabeth
e72bec8441
[client,SDL] fix thread termination order
...
* Wait in SDL thread until RDP thread has terminated to avoid race
conditions during autoreconnect
* Fix exit code mappings in case the connection was cancelled
2024-07-19 09:10:32 +02:00
akallabeth
b0320d8068
[client,SDL] fix autoreconnect
...
retry on handle check failure, not if WaitForMultipleObjects fails
2024-07-18 15:31:24 +02:00
Armin Novak
51204c1433
[client,X11] fix X11 event mask
...
When reading incremental data for clipboard restore previous event mask
when finished. Fixes #10377
2024-07-17 14:19:58 +02:00
Armin Novak
2ac05d4d4a
[client,X11] X11 locking log with WITH_DEBUG_X11
2024-07-17 11:32:21 +02:00
Armin Novak
71760d6d9a
[client,X11] log XConvertSelection calls
2024-07-17 11:05:57 +02:00
Armin Novak
3f0f1a3bbb
[client,X11] fix duplicate file clipboard clear
2024-07-17 10:41:14 +02:00
Armin Novak
5ebbd39187
[client,X11] prevend duplicate formatID in formatList
...
When announcing client clipboard formats skip any format already in the
list.
2024-07-17 10:31:14 +02:00
Armin Novak
d9d81d347c
[client,X11] fix clipboard locking
2024-07-17 09:49:54 +02:00
Ondrej Holy
17c95924d7
[client,x11] fix typo in help
...
There is a typo in the xfreerdp client help. It says "localtion" instead
of "location". Let's fix it.
2024-07-10 07:16:43 +02:00
Frederick Zhang
c79c28348d
[client,common] update /ipv[4|6] help text
2024-07-09 22:47:11 +10:00
akallabeth
194873b78c
[client,common] fix error logging
...
freerdp_client_command_line_post_filter did log wrong parsing errors.
2024-07-08 14:41:06 +02:00
