3612 Commits

Author	SHA1	Message	Date
Martin Fleisz	e304428a5f	Merge pull request #5857 from akallabeth/scanbuild_fixes ... Scanbuild fixes	2020-02-12 10:16:54 +01:00
David Fort	245fc6014d	Merge pull request #5830 from akallabeth/smartcard_updates ... Smartcard updates	2020-02-07 14:11:00 +01:00
Armin Novak	ddcc5ae768	Fixed copy of opaque data ... do not use strcncpy for opaque data.	2020-01-23 10:12:12 +01:00
Armin Novak	5a51f97ce0	Added NULL checks to silence clang-scanbuild.	2020-01-23 10:12:12 +01:00
Armin Novak	2cb022a922	Fixed NULL dereference.	2020-01-23 10:12:12 +01:00
Martin Fleisz	baca062321	core: Fix and extend populate rdp file from settings ... This PR contains the following changes: - Get rid of unused SettingsModified array (kept in the settings struct for ABI compatibility) - Fix and extend freerdp_client_populate_rdp_file_form_settings (wrote <null> strings to the rdp file, missed a lot of settings) - Set KeyboardHook default value to 2 (hook in fullscreen) just as mstsc does	2020-01-22 14:18:30 +01:00
Kobi Mizrachi	8c5d96784d	cmdline: export CommandLineParseCommaSeparatedValues	2020-01-22 14:18:21 +01:00
Martin Fleisz	263d74ee29	Merge pull request #5783 from akallabeth/gfx_mask_arg ... Added /gfx and /gfx-h264 option mask=<value>	2020-01-16 10:02:15 +01:00
Alexander Volkov	f0321a049d	client/X11: Avoid crash in XGetDeviceButtonMapping() ... XOpenDevice() may fail and return NULL, so try to find the first pointer device that can be opened, and ensure that ptr_dev argument is not NULL before passing it to XGetDeviceButtonMapping().	2020-01-16 08:46:11 +01:00
David Fort	30d6e25def	Merge pull request #5750 from akallabeth/encomsp_auto ... Encomsp automatic input control && cleanups	2020-01-15 13:56:00 +01:00
David Fort	0cc3af2282	Merge pull request #5796 from akallabeth/rdp_10_7_large_pointers ... Added RDP 10.7 large pointer support	2020-01-14 10:17:13 +01:00
Armin Novak	1d9722f8d8	Added /gfx and /gfx-h264 option mask=<value> ... With this new option the gfx capability set can be masked to only announce older versions of the protocol if required. (Fixes #5771)	2020-01-14 07:56:54 +01:00
Martin Fleisz	85984f3bd3	Merge pull request #5752 from akallabeth/manpage_no_err ... Allow to generate docbook with 0 length.	2020-01-13 12:26:31 +01:00
Armin Novak	4f5eaedf7e	Added command line option client-build-number ... The smartcard channel behaviour is influenced by what build number is announced, expose this setting to modify by interested users.	2020-01-13 10:50:14 +01:00
KunMing Xie	7fec130dbc	wf_rail.c: fix crash if CreateWindowEx failed (#5812) ... * wf_rail.c: fix crash if CreateWindowEx failed Co-authored-by: tensorflow123 <kunming.xie@hotmail.com>	2020-01-08 09:02:49 +01:00
David Fort	31a4e2ad8b	Merge pull request #5745 from akallabeth/urbdrc_rewrite ... Urbdrc rewrite	2020-01-06 09:23:45 +01:00
Armin Novak	182d0ce548	Added RDP 10.7 large pointer support ... * Implements [MS-RDPBCGR] version 51 large pointer support. * Logs unknown large pointer capability flags as warning. Signed-off-by: Armin Novak <armin.novak@thincast.com>	2019-12-19 09:53:40 +01:00
Martin Fleisz	71feb974ac	Merge pull request #5739 from akallabeth/improve_function_hiding ... Improve function hiding	2019-12-02 11:31:35 +01:00
Armin Novak	7c243da6e1	Remove symbols exported by accident.	2019-12-02 10:57:31 +01:00
Pål Håland	fc992ee740	SmartSizingWidth and SmartSizingHeight in RDP file: ... Adding this option to use the DesktopHeight and DesktopWidth as parameters for the SmartSizingWidth and SmartSizingHeight, as there are no options for that in standard RDP files. Equivalent of doing /smart-sizing:WxH	2019-11-29 11:14:55 +01:00
Armin Novak	ce5661ce60	Added RDP file option 'desktop size id:i:' support.	2019-11-29 09:09:30 +01:00
Martin Fleisz	683f3f6850	Merge pull request #5753 from akallabeth/win_clipboard_ignore_open_fail ... Fix #5749: Retry to open the clipboard.	2019-11-29 08:18:31 +01:00
Armin Novak	c7337f4b6b	Added data length check for RDP_CODEC_ID_NONE	2019-11-28 08:08:30 +01:00
Armin Novak	b89fd2d8e5	Fix #5749: Retry to open the clipboard. ... On windows the clipboard is shared and other applications or windows might lock the clipboard. For this reason, retry opening if it fails and ignore failure to open during normal operation.	2019-11-26 07:57:32 +01:00
Armin Novak	f40e3ccfd0	Allow to generate docbook with 0 length.	2019-11-25 15:54:05 +01:00
Armin Novak	c5e261e066	Added new command line swith for automatich assistance control.	2019-11-25 10:32:55 +01:00
Armin Novak	2691532061	Fixed const correctness of encomsp functions.	2019-11-25 09:39:21 +01:00
Armin Novak	2d87a84991	Use new URBDRC constants in command line parser.	2019-11-22 10:56:21 +01:00
Armin Novak	a5bebd3c65	Fixed scanbuild warnings.	2019-11-20 09:17:08 +01:00
Armin Novak	92f3100e9d	Fixed #5730: Decoupled floatbar button focus from click events.	2019-11-19 08:12:43 +01:00
Armin Novak	da87247d61	Added KeyboardCodePage option ... Thanks to @byteboon for the hint.	2019-11-07 19:57:07 +01:00
Armin Novak	72ca88f49c	Reformatted to new style	2019-11-07 10:53:54 +01:00
Martin Fleisz	bc39b32d20	Merge pull request #5685 from akallabeth/multi_instance_arg_parse ... COMMAND_LINE_ARGUMENT structs contain parser results, use one per instance	2019-11-06 09:09:22 +01:00
Martin Fleisz	5b6663fe3a	Merge pull request #5689 from akallabeth/cleanups ... Cleanups	2019-11-05 15:28:02 +01:00
Armin Novak	b7a12474dc	Removed invalid use of strnlen	2019-11-05 11:30:26 +01:00
Martin Fleisz	5439c97953	Merge pull request #5553 from akallabeth/win_console_fix ... Reattach to cmd if wfreerdp was started from one.	2019-11-05 09:35:45 +01:00
Armin Novak	a5403448b6	Fixed review remarks.	2019-11-04 11:18:53 +01:00
Armin Novak	27df243a33	Fixed int/size_t use for channel add functions.	2019-10-29 12:58:06 +01:00
Armin Novak	cda3d081e3	Fixed tmpnam warning.	2019-10-29 12:58:05 +01:00
Armin Novak	f01e042211	Code cleanups (strlen, casts, size_t, ...)	2019-10-29 11:58:43 +01:00
Martin Fleisz	a4b3778a4c	Merge pull request #5668 from akallabeth/xfreerdp_mon_check ... Added missing check for monitor indices	2019-10-28 14:13:07 +01:00
Armin Novak	0c87eaee4d	COMMAND_LINE_ARGUMENT structs contain parser results, use one per instance ... Remove the old global structs as the parser modifies them. When using multiple instances in the same process space this could break parsing.	2019-10-28 13:30:05 +01:00
Martin Fleisz	9e32899347	Merge pull request #5676 from akallabeth/hotplug_leak_fix ... Hotplug leak fix	2019-10-28 13:06:36 +01:00
Armin Novak	8af4ddc5f2	Fix #5687: check for file extensions case insensitive.	2019-10-25 14:23:01 +02:00
Armin Novak	1bb63eddf4	Removed experimental warning from gfx	2019-10-24 15:04:48 +02:00
Armin Novak	7d7224abd8	Added missing check for monitor indices	2019-10-23 15:03:39 +02:00
asapelkin	82eadad4a4	Fix some static analizer warnings	2019-10-22 15:39:54 +02:00
kubistika	345cc2a2f5	channels: cliprdr: get rid of duplicated server and client code	2019-10-18 14:20:26 +02:00
kubistika	dff3686642	channels: cliprdr: remove formatDataResp.dwFlags ... According to the channel docs, this field is only used in format data request. Therefore, there's no need to hold it in the response. cliprdr server code was copy-pasted from client code, therefore this must be some leftover.	2019-10-18 14:20:26 +02:00
Armin Novak	f1f0b266ac	Fixed floating point calculations.	2019-10-16 14:53:27 +02:00
Armin Novak	9fee4ae076	Fixed #5645: realloc return handling	2019-10-04 16:19:23 +02:00
Armin Novak	69dbd45d4e	Fixed use after free.	2019-10-03 16:15:52 +02:00
Martin Fleisz	30a92e85b8	common: Fix handling of redirectdrives setting	2019-10-01 15:56:22 +02:00
Martin Fleisz	89841fce03	Merge pull request #5616 from akallabeth/drive_prefer_absolute_path ... Fix #5603: Prefer absolute path for /drive: syntax.	2019-10-01 11:40:38 +02:00
Armin Novak	c904a4c5cd	Trim all RDP file string options except passwords.	2019-09-27 09:09:59 +02:00
Armin Novak	b1d0eaff6d	Fix #5603: Prefer absolute path for /drive: syntax.	2019-09-24 16:42:27 +02:00
Martin Fleisz	6b8b5bbb0e	Merge pull request #5614 from akallabeth/better_gateway_error ... Better gateway error reporting	2019-09-24 16:28:17 +02:00
Martin Fleisz	db2ac11828	Merge pull request #5615 from akallabeth/rdp_relaxed_parse ... Added option to parse RDP files relaxed.	2019-09-24 16:27:54 +02:00
Armin Novak	04a7c068d8	Added option to parse RDP files relaxed.	2019-09-24 16:11:43 +02:00
Armin Novak	41976885c6	Fix #5612: proper return values.	2019-09-24 09:45:35 +02:00
akallabeth	4679bb6b53	Fix ##5593: duplicated typedef.	2019-09-22 16:42:31 +02:00
akallabeth	3edadef768	Fix #5593: Do not use diagnostics pragma inside functions	2019-09-22 16:37:52 +02:00
volth	1edceffa31	avoid blurry filter when scaling factor is 2x, 3x, etc	2019-09-15 05:02:22 +00:00
Armin Novak	73897ebd3b	Tighter error checking for integer options in RDP file.	2019-09-11 14:24:00 +02:00
Armin Novak	7dc47bca4f	Compare rdp file options case insensitive	2019-09-11 10:26:37 +02:00
Armin Novak	18ec98c402	Set default connection type to autodetect for RDP files.	2019-09-05 12:20:40 +02:00
Armin Novak	cebddbd65b	Fix various compiler warnings for wfreerdp.	2019-09-03 15:11:18 +02:00
Armin Novak	d69ad3ee59	Fixed missing NULL check.	2019-09-03 08:56:59 +02:00
Armin Novak	843f18b110	Fix issue reported in #5560: language bar might not be supported by server.	2019-09-03 08:07:45 +02:00
Armin Novak	12b0b9ea28	Do not use named events, they are global!	2019-09-02 15:28:31 +02:00
Armin Novak	c6d9bfce42	Allow /drive:<name>,* syntax.:wq	2019-08-30 13:50:33 +02:00
Martin Fleisz	29f914f178	Merge pull request #5541 from akallabeth/rdp_file_full_drivestoredirect_parsing ... Rdp file full drivestoredirect parsing	2019-08-30 11:29:06 +02:00
Armin Novak	53ee0fbc33	Added GUI/console switch for input callbacks. (disabled until AttachConsole + stdin work)	2019-08-29 19:28:50 +02:00
Armin Novak	1a322bb98b	Added command line or dialog certificate handling.	2019-08-29 19:03:03 +02:00
Armin Novak	09c61dc465	Fix #5554: audin is a dynamic channel	2019-08-29 18:46:49 +02:00
Armin Novak	a93b15fdef	Sanitize drive redirection names.	2019-08-29 17:53:36 +02:00
Armin Novak	81c60631a9	Reattach to cmd if wfreerdp was started from one.	2019-08-29 13:47:53 +02:00
Armin Novak	6c17d138bd	Read and write RDP file 'prompt for credentials'	2019-08-27 12:24:28 +02:00
David Fort	96aeb8512d	keyboard: don't catch Ctrl+Alt-C if encomsp is not activated	2019-08-23 12:57:10 +02:00
Armin Novak	fdf1715213	Unified DriveStoreRedirect parsing.	2019-08-23 12:06:21 +02:00
Armin Novak	d8bf05367b	Added support for drivestoreredirect:s:<path>(<path>) syntax	2019-08-23 11:18:32 +02:00
Armin Novak	0af53bff9b	Allow DynamicDrives as special option for /drive	2019-08-23 10:27:01 +02:00
Armin Novak	35cb729f31	Added drivestoredirect option value parser	2019-08-23 10:27:01 +02:00
Armin Novak	3dec88f5e3	added BandwidthAutoDetect parsing.	2019-08-22 16:13:04 +02:00
Armin Novak	f0ee2cbb97	Automatically activate GFX and RFX codec support on autodetect.	2019-08-22 16:13:04 +02:00
Martin Fleisz	0a4bc1ff94	Merge pull request #5523 from akallabeth/rdp_parser_null_checks ... Rdp parser null checks	2019-08-20 16:50:55 +02:00
Louis Sautier	60152291b3	client: proxy: allow passing SOCKS5 proxies as env. vars	2019-08-20 14:06:38 +02:00
Martin Fleisz	81cb0a7ee5	client/common: Remove incorrect prompt for creds parsing (#5528) ... "prompt for credentials on client" was incorrectly merged together with "prompt for credentials" into a single setting. However the first option determines if the client should prompt for credentials if the remote server does not support server authentication. "prompt for credentials" on the other hand determines if the client should use any previously stored credentials or if it should always prompt for them.	2019-08-20 10:07:10 +02:00
Armin Novak	14dfb99a6f	Fixed NULL buffer access and alignment warnings.	2019-08-14 09:49:02 +02:00
rbarnett	8fee295733	Do not try to free a colormap that FreeRDP did not create.	2019-08-13 09:03:19 +02:00
kubistika	4503684736	client: xf_channels: remove unused settings variable	2019-08-02 20:10:56 +03:00
Martin Fleisz	8e7386a57d	Merge pull request #5506 from akallabeth/scale_desktop_and_device ... With /scale:<value> scale desktop and device.	2019-07-30 12:53:13 +02:00
Armin Novak	b4e1e9a1bd	Fixed loading of microphone channel ... Ensure microphone channel is loaded if settings require it in freerdp_client_load_addins	2019-07-30 12:32:55 +02:00
Armin Novak	70712cd821	With /scale:<value> scale desktop and device.	2019-07-30 12:03:23 +02:00
Armin Novak	fe6a4c5648	Fixed loading of sound channel ... Ensure sound channel is loaded if settings require it in freerdp_client_load_addins	2019-07-30 11:29:17 +02:00
Armin Novak	4128c6741d	Fixed a bunch of conversion warnings.	2019-07-30 11:23:33 +02:00
Kenny Levinsen	d27ad43093	uwac: Do not memcpy when we swap drawing buffers ... The compositor only samples rects that we damage (and have therefore been overwritten). As we are doing damage tracking and reporting, memcpy of our old drawing buffer serves no purpose.	2019-07-30 09:46:57 +02:00
Martin Fleisz	c8d0d50610	common: Fix parsing of devicestoredirect setting in rdp files ... If devicestoredirect was found in an rdp file we incorrectly enabled drive redirection (which has nothing to do with device redirection).	2019-07-30 09:20:58 +02:00
Martin Fleisz	5e672d474e	Merge pull request #5480 from akallabeth/xfreerdp_clip_fix ... Fix broken clipboard after file copy	2019-07-18 12:20:28 +02:00
Martin Fleisz	73c90e6e72	Fix rdp file writer ... The RDP file writer was based on previously parsed lines from an existing rdp file. If you created a new rdpFile, populated it from settings and tried to write it to a file you just got an error. This PR fixes this issue by creating the data from the rdpFile properties rather than the parsed lines.	2019-07-18 11:56:27 +02:00
Martin Fleisz	397db534d2	Reformatting	2019-07-18 11:56:27 +02:00
Armin Novak	2394c987ee	Added alternate full address to rdp file parser.	2019-07-18 10:44:23 +02:00
Armin Novak	cbb9354641	Fix broken clipboard after file copy	2019-07-17 15:13:50 +02:00
Armin Novak	70ba57caee	Fixed freerdp_client_rdp_file_set_integer standard flag set.	2019-07-15 12:01:30 +02:00
Armin Novak	607a3e35f4	Fixed rdp file parser tests.	2019-07-15 12:01:30 +02:00
Armin Novak	1deb78f211	Implemented rdp file parser functions with a callback for custom settings.	2019-07-15 12:01:30 +02:00
Armin Novak	3b38479ec5	Added PromptForCredentials setting.	2019-07-15 12:01:30 +02:00
Martin Fleisz	445764100b	Merge pull request #5396 from widgetii/master ... Artur Zaprzala's rdp2tcp channel driver	2019-07-09 16:17:29 +02:00
Martin Fleisz	c2fa671dda	client: populate settings didn't update NetworkAutoDetect	2019-07-09 15:23:17 +02:00
Armin Novak	fef086359b	Fix #5427: Dispatch updates to main thread. ... thank you @Harrywang55666	2019-06-25 10:49:53 +02:00
Armin Novak	1856093016	Fixed #5406: Ensure mouse wheel rotation step is never zero ... thank you @victorking528	2019-06-25 10:31:17 +02:00
Armin Novak	42ba19dd98	Added rail workdir parameter	2019-05-22 16:37:47 +02:00
Dmitry Ilyin	eee7d4b783	proper code format	2019-05-15 20:12:33 +03:00
Dmitry Ilyin	2cfb2839f4	Artur Zaprzala's rdp2tcp channel driver	2019-05-14 21:04:39 +03:00
Martin Fleisz	b8d931241e	Merge pull request #5314 from akallabeth/setting_getter_setter_generator ... Added python generator for freerdp_[g|s]et_param*	2019-05-09 14:23:31 +02:00
Armin Novak	4d4e7a69d7	Fixed remaining getter/setter return checks.	2019-05-09 14:04:40 +02:00
Martin Fleisz	ff036e0198	Merge pull request #5386 from akallabeth/rails_spec_update ... Rails spec update	2019-05-09 12:49:55 +02:00
Armin Novak	2cc714a57d	Updated RAILS implementation ... * Implement new messages and callbacks * Announce most recent channel features * Added settings to configure flags to announce	2019-05-08 17:25:15 +02:00
akallabeth	9011ef1b75	Merge pull request #5387 from mfleisz/image_from_icon ... core: Move image conversion of icon data into the library	2019-05-08 17:19:27 +02:00
Martin Fleisz	30c3b86655	core: Move image conversion for icon data into the library	2019-05-08 17:06:17 +02:00
Armin Novak	d49adfcf59	Fixed warnings and cleaned up gfx related xfreerdp code.	2019-05-08 17:01:36 +02:00
Martin Fleisz	3e2be308eb	Merge pull request #5266 from akallabeth/file_list_synth ... Added a proper synthesizer for FileGroupDescriptorW to text/uri-list	2019-05-08 15:05:05 +02:00
Armin Novak	93bf375686	Refactored settings getter/setter to stay compatible.	2019-05-08 14:35:25 +02:00
Armin Novak	6ac91924d5	Fixed use of settings getter/setter	2019-05-08 14:17:23 +02:00
Armin Novak	d7ca2db62e	Fixed doulbe semicolon in C files.	2019-05-08 12:58:01 +02:00
Armin Novak	3d1cec894c	Fixed alignment requirements for surface sizes.	2019-05-08 10:36:00 +02:00
Armin Novak	3b7e46fb0e	Updated GFX to 10.6 spec	2019-05-07 12:10:13 +02:00
Armin Novak	6a8755a763	Added image scaling api for software drawing. ... For future GFX channel functions an image scaling function is required. This moves the implementation from wayland client to core library and adds support for the much faster SWScale library.	2019-05-07 08:56:29 +02:00
amratsingh	84e50582b7	android_freerdp.c: fixed wrong registered signature (#5371)	2019-05-02 05:59:52 +02:00
Martin Fleisz	25fc56a625	Merge pull request #5260 from akallabeth/rail_spec_update ... Rail spec update	2019-04-29 11:27:26 +02:00
sgtatham	236c7918cb	xf_cliprdr: detect null terminators more reliably. (#5353) ... Clipboard formats containing plain text are specified to be terminated by a \0 character in MS's documentation on standard clipboard formats: https://docs.microsoft.com/en-us/windows/desktop/dataxchg/standard-clipboard-formats xf_cliprdr_server_format_data_response receives pasted data from the server to transfer to the client, in a sufficiently raw form that the \0 terminator is still present, so it has to remove it. It does so by checking only at the very end of the data. But I've observed that when pasting out of at least one Windows program (namely Outlook 1903 on Windows 10), the intended paste data arrives in this function followed by \0 and then a spurious \n. In that situation the null-terminator removal will fail to notice the \0, and will leave both bogus characters on the end of the paste. Fixed by using memchr to find the _first_ \0 in the paste data, which should not lose any actually intentional data because it's in accordance with the spec above.	2019-04-25 10:54:10 +02:00
Fabrice Fontaine	7dbb64cb62	xf_floatbar.c: fix build without Xfixes ... Remove unneeded include on Xfixes.h as it is not always available and not used in xf_floatbar.c Fixes: - http://autobuild.buildroot.org/results/69245e574787bada718c52c805ec137041dc233d Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>	2019-04-18 23:56:16 +02:00
Armin Novak	05901280fe	Fixed unused argument warnings.	2019-04-05 09:14:35 +02:00
Armin Novak	281dd22061	Fixed unicode key down and up messages.	2019-04-05 09:14:35 +02:00
Armin Novak	c18b30af96	Fixed dead store warnings	2019-04-05 09:14:35 +02:00
Armin Novak	e009a62f06	Fixed sign-compare warnings	2019-04-05 09:14:35 +02:00
Armin Novak	8bb83f2526	Fixed sign-compare warnings	2019-04-05 09:14:35 +02:00
Armin Novak	1762cd1acb	Fixed unchecked return warning.	2019-04-05 09:14:35 +02:00
Armin Novak	54098ab0b5	Fixed unused variable warnings.	2019-04-05 09:14:34 +02:00
Armin Novak	1c24450fe0	Fixed sign-compare warnings, removed internal functions from API	2019-04-05 09:14:34 +02:00
David Fort	058ae0db57	Merge pull request #5273 from akallabeth/mac_compile_warning_fix ... Fixed mac compilation warnings.	2019-04-04 18:03:50 +02:00
David Fort	52bce4745f	Merge pull request #5249 from akallabeth/mac_timer_crash_fix ... Mac timer crash fix	2019-03-28 19:05:48 +01:00
Ilya Shipitsin	7f97574501	client/Windows/wf_event.c: add missing "break" (#5293) ... found by cppcheck [client/Windows/wf_event.c:464] -> [client/Windows/wf_event.c:468]: (warning) Variable 'xNewPos' is reassigned a value before the old one has been used. 'break;' missing?	2019-03-04 09:17:10 +01:00
DraganNSDK	f002c7429b	potential fix for ENTER (modifiers) stuck after CTRL-ALT-ENTER (toggle fullscreen), clearing the buffer in xk_keyboard_update_modifier_keys. (#5280) ... * xk_keyboard_update_modifier_keys fixed to clear the buffer. * removed the xf_keyboard_clear(xfc) fix comments	2019-02-25 12:44:51 +01:00
Armin Novak	9566ae0e90	Fixed mac compilation warnings.	2019-02-21 17:30:12 +01:00
Armin Novak	32ea44c037	Added a proper synthesizer for FileGroupDescriptorW to text/uri-list ... The file clipboard delegate needs a base URI to operate on for systems that are not WIN32. Added that to the context and abort conversion, if that is not set. (currently not fully implemented)	2019-02-21 16:44:40 +01:00
Armin Novak	3680d9f7d2	Fixed cast warnings from freerdp_load_channel_addin_entry	2019-02-21 13:54:25 +01:00
anbukart	b192171434	Embedded window local fix ... Client width and height getting set as 0 when embedded using ParentWindowId setting	2019-02-21 11:03:52 +05:30
Armin Novak	0a95e4aa78	Fixed #5262: Vertical mouse wheel direction and whell step ... * Vertical wheel uses the inverted direction of horizontal wheel. * The wheel step is now calculated from the value provided by wayland.	2019-02-20 08:56:36 +01:00
Armin Novak	aacf5bddc4	Updated rail channel, supporting all new messages.	2019-02-19 15:04:11 +01:00
Armin Novak	2a06366de3	Added autoreconnect for wayland.	2019-02-19 14:12:25 +01:00
David Fort	f0e9c95f44	Merge pull request #5248 from akallabeth/naming_fixes ... Replace hard coded xfreerdp program name	2019-02-13 18:45:17 +01:00
Armin Novak	2d4f53ed41	Fixed #5234: Added timer invalidate on application willresignactive	2019-02-12 11:23:56 +01:00
Armin Novak	e758e848a2	Replaced hardcoded xfreerdp program name	2019-02-12 10:58:37 +01:00
Armin Novak	92dfa34619	Replaced hardcoded xfreerdp program name	2019-02-12 10:58:36 +01:00
Mathew Winters	dc5efab715	Resolve Gfx mode missing surface updates from cache.	2019-02-12 14:27:11 +13:00
Armin Novak	fe6296a25f	Added support for /smart-sizing:<width>x<height> syntax in wayland client.	2019-02-08 12:49:32 +01:00
Armin Novak	f06b31358f	Fixed duplicate log tag definition in wayland client.	2019-02-08 12:11:15 +01:00
Armin Novak	cc050f1413	Fixed conversion range checks and cast for use with cairo	2019-02-08 12:08:30 +01:00
Armin Novak	bb755f1944	Removed unused variables.	2019-02-08 12:08:30 +01:00
Armin Novak	4a3f4ad340	Fixed color format for wayland mouse pointer.	2019-02-08 12:08:30 +01:00
Armin Novak	7413370783	Added mouse pointer scaling.	2019-02-08 12:08:30 +01:00
Armin Novak	8d6a6df48a	Implements #5215: Smart sizing using libcairo	2019-02-08 12:08:30 +01:00
Armin Novak	81d7e62642	Fixed broken checks in X11 event (RAIL mode)	2019-02-08 10:46:26 +01:00
Martin Fleisz	6415cfec48	Merge pull request #5131 from akallabeth/cmd_line_error_logging ... Added extended error logging for assistance, rdp file and command line parser	2019-02-08 09:11:35 +01:00
Armin Novak	753b9c7ce9	Enable server heartbeat PDU by default.	2019-02-07 10:10:57 +01:00
Armin Novak	7610917a48	Disabled offscreen and bitmap cache by default.	2019-02-07 10:10:57 +01:00
Ilya Shipitsin	fb002574c3	client/common/cmdline.c: remove redundant check ... found by cppcheck [client/common/cmdline.c:390] -> [client/common/cmdline.c:399]: (warning) Identical inner 'if' condition is always true.	2019-02-02 10:22:19 +05:00
Ilya Shipitsin	d1939cfc4f	client/Wayland/wlf_cliprdr.c: resolve possible null pointer dereference ... found by cppcheck [client/Wayland/wlf_cliprdr.c:143] -> [client/Wayland/wlf_cliprdr.c:158]: (warning) Either the condition 'clipboard' is redundant or there is possible null pointer dereference: clipboard. [client/Wayland/wlf_cliprdr.c:163] -> [client/Wayland/wlf_cliprdr.c:178]: (warning) Either the condition 'clipboard' is redundant or there is possible null pointer dereference: clipboard.	2019-02-01 03:50:51 +05:00
David Fort	85161c718f	Merge pull request #5223 from akallabeth/scanbuild_null_fixes ... Scanbuild null fixes	2019-01-30 18:22:45 +01:00
Bernhard Miklautz	acebd43acf	Merge pull request #5147 from jphein/master ... Clarified defaults of /floatbar flag	2019-01-30 16:26:41 +01:00
Armin Novak	2dab778101	Fixed NULL dereferences and uninitialized values	2019-01-30 16:11:10 +01:00
Armin Novak	87c7ddeda6	Asserting arg->Value to silence clang analyzer NULL argument checks.	2019-01-29 17:24:29 +01:00
Armin Novak	6a1ff5c485	Fixed compiler warnings #5210	2019-01-29 16:22:46 +01:00
Armin Novak	5c930dc4aa	Fixed compiler warnings #5210	2019-01-29 16:15:33 +01:00
David Fort	72ad4af356	Merge pull request #5221 from akallabeth/wayland_mouse_cursor ... Added wayland mouse cursor	2019-01-29 15:11:38 +01:00
akallabeth	0a8ebcfcac	Merge pull request #5187 from astrand/mingw-part1 ... Mingw build fixes part1	2019-01-29 10:46:21 +01:00
Armin Novak	2418c43cac	Fixed pointer image update.	2019-01-29 09:34:30 +01:00
Armin Novak	23fa6b9182	Added mouse cursor callback stubs.	2019-01-29 09:34:30 +01:00
David Fort	05d9d89796	Merge pull request #5149 from akallabeth/cert_deny ... New option to disable user certificate dialog	2019-01-25 16:59:33 +01:00
akallabeth	7d226ca596	Merge pull request #5218 from ckelsel/master ... May crash if GetCommandLineW failed	2019-01-25 12:19:56 +01:00
David Fort	343bc8c6e4	Merge pull request #5213 from akallabeth/wayland_and_warning_fixes ... Wayland and warning fixes	2019-01-25 11:42:38 +01:00
xie.kunming	b8c64b6bf3	May crash if GetCommandLineW failed	2019-01-25 17:54:25 +08:00
Armin Novak	823411c2f3	Fixed wayland buffer updates ... The wayland buffer size always matches the current window size. That might be different from the actual remote framebuffer size, to when copying always use the correct strides to avoid distorted screen content.	2019-01-25 10:49:03 +01:00
akallabeth	8ed0b92928	Merge pull request #5216 from ckelsel/master ... change SetTimer elapse from 10 to USER_TIMER_MINIMUM	2019-01-25 10:01:30 +01:00
xie.kunming	84493d0039	If uElapse is less than USER_TIMER_MINIMUM (0x0000000A), the timeout is set to USER_TIMER_MINIMUM.	2019-01-25 16:45:52 +08:00
Armin Novak	86e20d7647	Removed buffer damage tracking in client, let UWAC handle that.	2019-01-24 12:44:21 +01:00
Armin Novak	0cf898e722	Fixed warnings found by compiler and static analysis.	2019-01-24 11:53:52 +01:00
Armin Novak	728cdfd689	Fixed warnings found by compiler and static analysis.	2019-01-24 11:53:52 +01:00
Armin Novak	087390b303	Refactored client clipboard function callbacks for const data pointers.	2019-01-23 16:55:13 +01:00
Armin Novak	891d9760dc	Ignore clipboard events if channel not loaded.	2019-01-23 16:01:36 +01:00
Armin Novak	d5b3558402	Added log messages for unusual error events.	2019-01-23 15:56:11 +01:00
Armin Novak	9cdddb7722	Fixed some log messages / missing asserts.	2019-01-23 15:56:11 +01:00
Armin Novak	1cec0e0346	Fixed NULL dereference.	2019-01-23 15:56:11 +01:00
Armin Novak	ca2e8e4bc2	Implemented wayland clipboard.	2019-01-23 15:56:11 +01:00
David Fort	2843f1ad60	Merge pull request #5159 from akallabeth/wayland_display ... Implemented wayland display resize channel.	2019-01-23 15:41:42 +01:00
David Fort	4c465e7f16	Merge pull request #5209 from akallabeth/wayland_protocol_update_and_keyboard_inhibit ... Wayland protocol update and keyboard inhibit support	2019-01-23 10:02:07 +01:00
Armin Novak	97dfa07578	Fixed duplicated check.	2019-01-22 17:27:17 +01:00
Armin Novak	42ad7a8846	Implemented wayland display resize channel.	2019-01-22 17:27:17 +01:00
Armin Novak	81f1fb934c	Implemented keyboard shortcut inhibit support.	2019-01-22 14:27:12 +01:00
Armin Novak	5ef6b71974	Implemented DesktopResize callback for wayland client.	2019-01-22 10:29:08 +01:00
Armin Novak	0b17406eec	Unified buffer update and screen refresh on focus	2019-01-18 14:38:51 +01:00
Armin Novak	4f99c2946f	Unified mouse coordinate scaling.	2019-01-17 13:44:04 +01:00
Armin Novak	864ad5e681	Ignore unknown keywords for windows and posix type detection. ... Eliminates wrong detection in case of an unknown keyword used.	2019-01-16 14:32:19 +01:00
Armin Novak	fc9e88d64f	Added flag to silence command line parser logging during detection.	2019-01-16 14:32:19 +01:00
Armin Novak	89f3f7d837	Added extended error logging for assistance, rdp file and command line parser.	2019-01-16 14:32:19 +01:00
Armin Novak	a3cfef4e07	Implemented full mouse support for mac client.	2019-01-10 11:30:36 +01:00
Peter Åstrand (astrand)	6619de070a	freerdp_client_set_window_size should not be static ... Avoid GCC error, since it is not static according to wf_client.h.	2019-01-09 09:54:31 +01:00
Peter Åstrand (astrand)	fcf59b9c4f	Add msimg32 library through CMake ... MinGW does not support libs through #pragma comments.	2019-01-09 09:52:27 +01:00
Peter Åstrand (astrand)	30cd1ba1ab	Use lowercase for includes and libs ... Makes build possible on case sensitive systems such as MinGW on Linux.	2019-01-09 09:36:28 +01:00
Ilya Shipitsin	4403448a77	client/Windows/wf_cliprdr.c: remove redundant check ... found by cppcheck [client/Windows/wf_cliprdr.c:2556] -> [client/Windows/wf_cliprdr.c:2561]: (warning) Identical condition '!clipboard', second condition is always false	2019-01-07 22:55:08 +05:00
Martin Fleisz	aa442de059	Merge pull request #5174 from chipitsine/master ... resolve several issues found by cppcheck	2019-01-07 15:21:46 +01:00
Armin Novak	b2ef3e69ca	Fixed Wayland horizontal mouse wheel direction.	2019-01-07 10:02:04 +01:00
Armin Novak	2dcc2614d4	Fixed X11 horizontal mouse wheel direction.	2019-01-07 10:01:46 +01:00
Ilya Shipitsin	bdc039e719	resolve several issues found by cppcheck ... [client/X11/xf_floatbar.c:800] -> [client/X11/xf_floatbar.c:796]: (warning) Either the condition '!floatbar' is redundant or there is possible null pointer dereference: floatbar. [client/X11/xf_floatbar.c:800] -> [client/X11/xf_floatbar.c:797]: (warning) Either the condition '!floatbar' is redundant or there is possible null pointer dereference: floatbar. [client/X11/xf_floatbar.c:800] -> [client/X11/xf_floatbar.c:798]: (warning) Either the condition '!floatbar' is redundant or there is possible null pointer dereference: floatbar. [libfreerdp/codec/dsp.c:1156] -> [libfreerdp/codec/dsp.c:1154]: (warning) Either the condition '!srcFormat' is redundant or there is possible null pointer dereference: srcFormat. [channels/drdynvc/client/drdynvc_main.c:1453] -> [channels/drdynvc/client/drdynvc_main.c:1450]: (warning) Either the condition '!drdynvc' is redundant or there is possible null pointer dereference: drdynvc. [channels/audin/client/opensles/audin_opensl_es.c:98] -> [channels/audin/client/opensles/audin_opensl_es.c:94]: (warning) Either the condition '!opensles' is redundant or there is possible null pointer dereference: opensles. [channels/audin/client/opensles/audin_opensl_es.c:159] -> [channels/audin/client/opensles/audin_opensl_es.c:153]: (warning) Either the condition '!opensles' is redundant or there is possible null pointer dereference: opensles.	2019-01-02 20:35:24 +05:00
kunming.xie	3ef6dd2f7c	fix button_set_locked no return statement	2018-12-24 14:52:59 +08:00
Armin Novak	1984f73db8	Implemented horizontal mouse wheel for wayland.	2018-12-18 13:49:13 +01:00
Armin Novak	f647e5cc3f	Implemented mouse buttons 4 and 5 for wayland.	2018-12-18 13:49:08 +01:00
Armin Novak	b60045af27	New option to disable user certificate dialog ... The new option +cert-deny aborts a connection automatically if the certificate can not be validated by OpenSSL or via known hosts.	2018-12-14 10:17:52 +01:00
Jeffrey Hein	d316e7fa1e	Clarified defaults of /floatbar flag	2018-12-13 14:02:38 -08:00
Jeffrey Hein	1e84f00ef8	Added help description for /drive:hotplug,*	2018-12-12 11:29:58 -08:00
Armin Novak	717b0eac9e	Enable smooth fonts by default.	2018-12-11 13:02:26 +01:00
Bernhard Miklautz	6f6c8473a1	Merge pull request #5126 from akallabeth/x11_button_mapping ... X11 extended button remapping support.	2018-12-11 08:53:39 +00:00
Armin Novak	0fa9f06565	Modified flag checks to avoid invalid flag sets.	2018-12-11 09:34:07 +01:00
Martin Fleisz	29e2e2221d	Merge pull request #5083 from akallabeth/mac_client_fixes ... Mac client fixes	2018-12-11 09:19:46 +01:00
Bernhard Miklautz	b3ff75b594	fix [client/Mac]: UI API needs to be called in main thread ... With recent SDKs the view won't update it the UI API is called from a different thread.	2018-12-11 08:33:14 +01:00
Armin Novak	2ce04069cb	Fixed crashes in rail mode after merge of floatbar fixes.	2018-12-10 15:41:20 +01:00
Armin Novak	7102927548	X11 extended button remapping support. ... Up until now X11 mouse button remapping was only possible for the default buttons 1 to 3. With this pull any X11 mouse button can be mapped to any RDP mouse event and all X11 remappings are respected.	2018-12-10 15:03:29 +01:00
Martin Fleisz	b82c4f779a	Merge pull request #5020 from akallabeth/floatbar_fixes ... Floatbar fixes and windows support	2018-12-10 14:45:10 +01:00
Armin Novak	15011b478d	Fixed variable hiding by not redeclaring it in subscope.	2018-12-10 14:31:38 +01:00
Armin Novak	0d3192b9f7	Fixed rail window key hash function to work with UINT32	2018-12-10 11:16:43 +01:00
akallabeth	2927114e7b	Merge pull request #5117 from hardening/rail_hash ... rails: allow a window with id == 0	2018-12-10 10:26:52 +01:00
David Fort	88e361fa00	rails: allow a window with id == 0	2018-12-08 00:32:00 +01:00
Armin Novak	9166df355b	Fixed windows floatbar title.	2018-12-07 15:50:24 +01:00
Armin Novak	4fd8987f5d	Unified windows client window title settings.	2018-12-07 15:22:28 +01:00
Armin Novak	594d10620e	Fixed #5040: Unified xfreerdp window title setting.	2018-12-07 15:22:28 +01:00
Armin Novak	6a9fa3dcbd	Refactored floatbar, extended command line settings.	2018-12-07 15:22:28 +01:00
Don Caton	68c34d5ab0	Windows client: Suppress minimize and restore buttons in float bar when toggle-fullscreen is false, added window title to float bar, improved overall appearance with gradients, shadow and transparent icons. ... # Conflicts: # client/Windows/wf_client.c # client/Windows/wf_event.c # client/Windows/wf_floatbar.c	2018-12-07 15:22:28 +01:00
Armin Novak	5343f6931d	Fixed monitor width and height checks.	2018-12-07 15:22:28 +01:00
Armin Novak	56156d217e	Floatbar self contained.	2018-12-07 15:22:28 +01:00
Bernhard Miklautz	6c88c21736	Merge pull request #5099 from akallabeth/floatbar_close_window ... Fixed #5098: Abort connection and let the application clean up resour…	2018-12-07 13:03:46 +00:00
Martin Fleisz	d0688f058b	Merge pull request #5102 from akallabeth/rail_cleanups ... Cleaned up xf_rail_server_handshake	2018-12-07 11:28:22 +01:00
Armin Novak	ace9bfffdb	Moved to extended certificate verification API	2018-12-06 10:17:05 +01:00
Armin Novak	ec8cc65a1c	Fixed compile issue	2018-12-06 10:17:05 +01:00
Armin Novak	730b6f02c4	Fixed glitches with certificate dialog.	2018-12-06 10:17:05 +01:00
Armin Novak	ec34657ff1	Added certificate dialog.	2018-12-06 10:17:05 +01:00
Armin Novak	4dd6e75779	Added client callbacks.	2018-12-06 10:17:05 +01:00
Armin Novak	c8938c357a	Updated mac build.	2018-12-06 10:17:05 +01:00
Martin Fleisz	8c7f8eb395	Merge pull request #5085 from akallabeth/cert_callbacks_update ... Refactored Certificate callbacks (but keep compatible)	2018-12-06 10:08:17 +01:00
Armin Novak	f5e449a4f8	Cleaned up xf_rail_server_handshake	2018-12-05 09:13:04 +01:00
akallabeth	1b4ee6594e	Merge pull request #5100 from wintersandroid/master ... Add jni interface for get_last_error_string	2018-12-05 08:58:08 +01:00
David Fort	46ffa611cc	Merge pull request #5097 from hualet/master ... Fixed RAIL window can't show again once hidden	2018-12-04 22:42:25 +01:00
Mathew Winters	bd7ff9b10f	Add jni interface for get_last_error_string	2018-12-05 07:56:05 +13:00
Armin Novak	0c13c3199e	Follow up to #4959: Lock gdi_UpdateSurfaces like xf_UpdateSurfaces	2018-12-04 16:56:22 +01:00
Armin Novak	d260d4e29e	Fixed #5098: Abort connection and let the application clean up resources before exit.	2018-12-04 16:42:28 +01:00
David Fort	a1c2033226	Merge pull request #5094 from akallabeth/suppress_output_setting ... Make "suppress output" setting available on command line	2018-12-04 14:38:11 +01:00
Martin Fleisz	5510f9304b	Merge pull request #4959 from akallabeth/gfx_lock_fix ... Implemented GFX mutex locking and enforce return value checks.	2018-12-04 14:29:59 +01:00
Hualet Wang	e33efccf48	Fixed RAIL window can't show again once hidden ... The cause is very simple: we didn't map the xwindow on receiving WINDOW_SHOW. but doing that causes another problem that you can't hide a window anymore, and that is because whlie window hiding, the _NET_WM_STATE and WM_STATE properies of the xwindow may change, in the function `xf_event_PropertyNotify` we just assume that windows not maximized, not minimized, yet not showing normally should be corrected to be shown, we just need to consider the situation that the window is hidden here. fix: #5078	2018-12-04 20:37:37 +08:00
Armin Novak	e04c319d21	Added new default certificate callbacks with extended information. ... The extended information provided by VerifyCertificateEx and VerifyChangedCertificateEx is now exploited by the new functions client_cli_verify_certificate_ex and client_cli_verify_changed_certificate_ex. The old callbacks now print out deprecation warnings to inform the user and developer about this deprecation.	2018-12-04 09:35:24 +01:00
Armin Novak	1398fa5b27	Fixed missing NULL check for thread handle.	2018-12-04 09:34:22 +01:00
Armin Novak	c5512de269	Fix #4999: Increase reference count	2018-12-04 09:34:22 +01:00
Alessandro Muggianu	9b1c9da6a2	Make "suppress output" setting available on command line	2018-12-04 09:31:30 +01:00
Armin Novak	edd6d49f23	Fix #4909: Do not initialize HOME environment variable as it is no longer used. ... GetKnownPath does not require this environment variable to be available for windows builds.	2018-11-29 13:44:21 +01:00
Armin Novak	2e019b2fd1	Implemented GFX locking and enforce return value checks. ... To fix #4825 GFX functions must now aquire a lock before accessing surfaces. This prevents simultaneous update of internal data by client and gfx threads. Also enforce return value checks, where not already done.	2018-11-29 11:55:27 +01:00
Armin Novak	7d89ea22d4	Unified initialization of OrderSupport ... Added a library internal function freerdp_settings_set_default_order_support which initializes the OrderSupport array of settings. Now clients no longer need to set this up on their own, if they do not implement their own hardware accelerated order processing.	2018-11-23 10:11:50 +01:00
Martin Fleisz	394bc62869	Merge pull request #5035 from akallabeth/better_cmdline_format ... Improved formatting of terminal help messages.	2018-11-23 10:03:56 +01:00
Martin Fleisz	9684a06f87	Merge pull request #5053 from akallabeth/sample_client_update ... Fix #5052: Updated client sample	2018-11-23 09:48:08 +01:00
Armin Novak	e6e87eb3b3	Unified strto[u]l in cmdline.c ... To clean up code all integer conversions are now done by a helper function with proper checks in place.	2018-11-22 16:28:30 +01:00
Armin Novak	2f8737d973	Improved formatting of terminal help messages.	2018-11-22 15:56:37 +01:00
David Fort	8d62ced6a4	Merge pull request #5056 from akallabeth/direct_fb_remove ... Removed DirectFB client as it is unmaintained	2018-11-22 15:50:52 +01:00
Armin Novak	fff22f027b	Removed DirectFB client as it is unmaintained ... DirectFB support was in search of a maintainer for ages and no longer compiles. Since nobody stepped up get rid of this unused code once and for all.	2018-11-22 14:40:19 +01:00
Armin Novak	a471fc5939	Spelling fix in log message. ... Integrate spelling fix from debian patch from Mike Gabriel <mike.gabriel@das-netzwerkteam.de>	2018-11-22 12:06:30 +01:00
Armin Novak	f79eeb7446	Fixed NULL access checks.	2018-11-22 11:19:12 +01:00
Armin Novak	c8908c8be6	Updated windows shadow server assistance usage.	2018-11-22 11:11:31 +01:00
Armin Novak	a531930f36	Disable NLA for remote assistance.	2018-11-22 11:11:31 +01:00
Armin Novak	6de2129a90	assistance v2 support	2018-11-22 11:11:31 +01:00
Armin Novak	6ab3d3e8fc	Fix #5052: Updated client sample	2018-11-22 10:38:26 +01:00
Martin Fleisz	947aa80033	Merge pull request #5016 from akallabeth/windows_server_build_fix ... Windows server build fix	2018-11-21 16:02:47 +01:00
akallabeth	1cc739f10e	Merge pull request #5039 from mcsong/master ... Fixed recreate activity issue with bluetooth devices.	2018-11-21 11:49:45 +01:00
mcsong	34e8b92714	Fixed recreate activity issue when a bluetooth device connected or disconnected	2018-11-20 13:11:14 -08:00
mcsong	1d7fd201b1	Fixed recreate activity issue when a bluetooth device connected or disconnected.	2018-11-20 12:57:07 -08:00
akallabeth	3cea4bfb55	Merge pull request #5008 from wintersandroid/master ... Android library build script fixes, and Android thread lock on remote disconnect.	2018-11-20 12:14:28 +01:00
Bernhard Miklautz	58091dc138	new: development cycle dev5	2018-11-20 11:49:34 +01:00
Bernhard Miklautz	ef0c7e81a7	Merge pull request #4953 from akallabeth/region_signed ... signed gdi regions to adjust negative coordinates	2018-11-20 10:07:30 +00:00
Martin Fleisz	38091fc34e	Merge pull request #5030 from akallabeth/pointer_cache_optional ... Fix #4864: Register pointer cache after PostConnect is called	2018-11-20 10:53:40 +01:00
Armin Novak	666ef4ab34	Fix #4864: Register pointer cache after PostConnect is called ... With #4950 client side pointer implementation was made optional. This addresses an issue that each client had to call pointer_cache_register_callbacks on its own.	2018-11-20 09:49:39 +01:00
mcsong	d7ab198a68	added korean translation	2018-11-19 14:38:48 -08:00
akallabeth	b6eca4fc54	signed gdi regions to adjust negative coordinates	2018-11-19 12:52:43 +01:00
Mathew Winters	eceb107ddd	Revert store password variable	2018-11-19 08:27:36 +13:00
ileGITimo	d5dd983bcd	call xf_SetWindowTitle before XMapWindow, so window manager can act on window name	2018-11-17 06:32:52 -08:00
David Fort	e118d14f6a	cmdline: add window-position argument to set initial window position ... This is useful if you want the window to be at a given position. The patch also mutualizes the parsing of <xpos>x<ypos> or <width>x<height> arguments.	2018-11-15 14:40:03 +01:00
Bernhard Miklautz	d915491717	Merge pull request #5012 from akallabeth/rail_app_icons ... Rail app icons	2018-11-15 08:50:56 +00:00
Armin Novak	a2cd934184	Fixed windows build warnings.	2018-11-15 09:01:53 +01:00
Mathew Winters	0e88eb5a91	Fixes as per merge request	2018-11-15 08:29:51 +13:00
akallabeth	268a2c0cf8	Merge pull request #4979 from hardening/CAL ... license: support CAL license	2018-11-14 13:45:31 +01:00
Armin Novak	43e17c9755	Fixed color conversion, log level and buffer types	2018-11-14 11:57:57 +01:00
ilammy	9292b2231f	xfreerdp: set _NET_WM_ICON to RAIL app icon ... Icons on X11 windows are configured using the _NET_WM_ICON property described in Extended Window Manager Hints. Here we implement converison from DIB bitmaps used by RAIL to the format expected by _NET_WM_ICON, and actually set the icon for RAIL app windows. Both DIB format and _NET_WM_ICON (or rather, Xlib) are weird. Let's start with RAIL's format. That's the one used in BMP and ICO formats on Windows. It has some strange properties but thankfully FreeRDP's freerdp_image_copy() can handle most of them for us. (With an exception of monochrome and 16-color formats that it does not support. Sorry, but I'm too lazy to fix them. They are not seem to be used by any real application either.) The one thing that it can't do is to apply the alpha transparency bitmask so we have to do it manually. This instantly reminds us that DIB format has HISTORY: it's vertically flipped and each must be padded to 4 bytes. Both these quirks having reasonable (for a certain definition of 'reason') explanations. Such is life. (Also, 8-bit images require a color palette which we must fill in.) So okay, now comes _NET_WM_ICON. It is more sane (or rather, easier to deal with). The bitmap is represented with a tiny [width, height] header followed by an array of pixels in ARGB format. There is no padding, no weird color formats. But here's a catch: you can't simply take the output of freerdp_image_copy() and cast to (unsigned char*) of colors. We have to allocate an array of C's longs and copy the pixels there, because that's what Xlib expects (and this is mentioned in the spec). Simply casting an array of bytes causes crashes on 64-bit systems. So don't try to cheat or "optimize" and read the docs, kids. Note that XFlush() call after XChangeProperty(). It's there because it seems to helps see the icon quicker with Unity on Ubuntu 14.04. I don't know why. (And Unity does not support _NET_WM_ICON officially. But it sorta kinda works sometimes.) Oh, and while we're here, delete some old, unused, and commented out code that was setting window icons in the past. It's not needed anymore.	2018-11-14 10:53:45 +01:00
ilammy	8163b6d1ce	xfreerdp: add RAIL icon cache ... This commit adds a cache for RAIL application icons. It is (surpisingly) used to cache icons for remote applications. This mechanism is described in MS-RDPERP 3.1.1.2 Icon Cache Support and related items. Note that some (actually, most) of the icons are not cached. These are marked with CacheId == 0xFF. In order to keep the code clean we do not introduce a special case and instead use a 'scratch' icon and simply pretend to return an xfRailIcon from cache. We're going to set icons via _NET_WM_ICON property which explains why we use "long" values to store pixel data. The icon conversion is not implemented in this commit, it's only stubs. However, we do implement processing of window information orders that contain new icons or cached references to previously sent icons. Note that it is important to not fail (i.e., to not return FALSE) if we cannot find a window for the icon by its ID. The server occasionally likes to be slow or something and send icon updates for nonexistent windows. This behavior is mandated by the spec, too: MS-RDPERP 3.2.5.1.6 Processing Window Information Orders Upon receipt of a Window Information Order for an icon or cached icon, as specified in sections 2.2.1.3.1.2.2 and 2.2.1.3.1.2.3, the client SHOULD locate the local RAIL window that corresponds to the WindowId reported in the Hdr field and apply the icon updates to the RAIL window. If no such window can be found, the client SHOULD ignore the order. Indeed, we silently ignore such orders now.	2018-11-14 10:53:45 +01:00
Mathew Winters	f91a4d0b6e	Resolve thread not exiting when remote lost or disconnected.	2018-11-14 15:25:38 +13:00
David Fort	b6e6575bf6	license: support CAL license ... This patch simplifies the licensing code mutualizing encryption / decryption routines. It also adds the support for client_info packet that allows to send a previously saved CAL file.	2018-11-13 09:42:19 +01:00
Armin Novak	738aa56233	Fixed #4995: Don't forget to send the NULL of the clipboard string.	2018-11-12 08:40:54 +01:00
Mathew	2ff19597dc	fix scripts to build with ndk r15c, ... cache dependancies so we are not hitting github often update android dependancies to latest and compile. ./android-build-freerdp.sh --ndk ~/Programming/android-ndk-r15c --relWithDebug --jpeg Still an error compiling openh264	2018-11-09 15:20:52 +13:00
Bernhard Miklautz	8be6ec9720	fix [cmdline]: parameter parsing ... use strtoul instead of strtol	2018-11-08 11:13:57 +01:00
Bernhard Miklautz	1222e7060b	new [crypto/tls]: add support to set tls security level ... The newly introduced option /tls-seclevel can be used to set the tls security level on systems with openssl >= 1.1.0 or libressl. As default level 1 is used as higher levels might prohibit connections to older systems.	2018-11-08 11:13:15 +01:00
Armin Novak	9633e4576d	Fixed signedness of MoniorCount	2018-10-25 14:08:20 +02:00
Armin Novak	02f68c35b9	Fixed -Wextra sign warnings	2018-10-24 13:25:31 +02:00
Bernhard Miklautz	0e9b26c1d2	Merge pull request #4796 from akallabeth/groegera_fixes ... Update X11-modifier key state on focus_in	2018-10-22 12:50:21 +00:00
Bernhard Miklautz	9b353202a5	fix [x11]: compiler warnings in floatbar ... client/X11/xf_floatbar.c:530:27: warning: use of logical '&&' with constant operand [-Wconstant-logical-operand] if (event->xmotion.state && Button1Mask && mode > XF_FLOATBAR_MODE_DRAGGING) ^ ~~~~~~~~~~~ client/X11/xf_floatbar.c:534:32: warning: use of logical '&&' with constant operand [-Wconstant-logical-operand] else if (event->xmotion.state && Button1Mask && mode == XF_FLOATBAR_MODE_DRAGGING) ^ ~~~~~~~~~~~ clang 8.0.0-svn344413-1~exp1+0~20181012203207.819~1.gbpc91f27	2018-10-19 11:33:28 +02:00
akallabeth	3d0ccb3f5d	Merge pull request #4946 from mmattes/fix/floatbar_app_check_missing ... added missing check for remote app where no floatbar exists	2018-10-18 16:40:22 +02:00
Markus Mattes	a235b44f61	added missing check for remote app where no floatbar exists	2018-10-18 15:33:01 +02:00
Armin Novak	88d310ff2c	Fixed compiler warnings (casts, ...)	2018-10-18 09:09:30 +02:00
akallabeth	305f5d1bd5	Merge pull request #4600 from andreesteve/xfullscreen ... X11: Fix fullscreen toggle	2018-10-17 17:27:29 +02:00
Martin Fleisz	e46d1d95ff	Merge pull request #4926 from akallabeth/primary_order_checks ... Order data validation and correction	2018-10-17 16:02:28 +02:00
akallabeth	e54af8efa0	Merge pull request #4927 from akallabeth/cmdline_fixes ... Fixed command line setting of flags, unified string replace	2018-10-17 12:19:03 +02:00
Armin Novak	7b860ce96a	Add command line option /relax-order-checks	2018-10-17 12:16:58 +02:00
akallabeth	5778bf102b	Merge pull request #4891 from akallabeth/rail_fixes ... Rail fixes #4846 and a crash	2018-10-17 11:32:56 +02:00
Armin Novak	10cc319973	Announce glyph orders if glyph cache is activated.	2018-10-17 10:47:23 +02:00
Armin Novak	ca3fb26230	Deactivated unimplemented orders.	2018-10-15 15:22:50 +02:00
Armin Novak	f88ed950d3	Fixed various issues with primary orders.	2018-10-15 14:30:58 +02:00
Armin Novak	9729590870	Fixed command line setting of flags, unified string replace	2018-10-15 12:04:33 +02:00
Armin Novak	a8a6accc15	Fixed compiler warnings.	2018-10-03 15:16:59 +02:00
David Fort	2e1bf90bd9	Merge pull request #4885 from akallabeth/autoreconnect_handle_window_events ... Fixed #3423: Process xevents when in reconnect mode.	2018-10-03 09:42:16 +02:00
akallabeth	4e71af6772	Merge pull request #4906 from FeLvi-zzz/japanese-patch ... Japanese patch #4905	2018-10-02 15:46:17 +02:00
FeLvi_zzz	751cfde864	remove untranslatable strings in Japanese translation	2018-10-02 21:53:55 +09:00
FeLvi_zzz	6d36707ec4	fixed typo in Japanese translation	2018-10-02 21:47:08 +09:00
Armin Novak	00489ae75b	Reworked checks in xf_disp.c	2018-10-02 12:33:52 +02:00
FeLvi_zzz	2564a6a2d2	modified Japanese translation #4905	2018-10-02 18:36:58 +09:00
FeLvi_zzz	7a44e179cf	added Japanese translation	2018-10-02 18:00:29 +09:00
Armin Novak	f332779982	Fixed floatbar X11 leak.	2018-10-01 10:50:47 +02:00
Armin Novak	046d2296a0	Fixed floatbar X11 leak.	2018-10-01 10:49:30 +02:00
Armin Novak	a5b689b35d	Readded override redirect but reset on focus loss.	2018-09-26 12:38:16 +02:00
Armin Novak	316eed1fbf	Menus are no longer popup windows but dropdown menus.	2018-09-26 12:38:16 +02:00
Armin Novak	fa7902c362	Fixed argument check for floatbar events.	2018-09-26 10:14:51 +02:00
David Fort	d0612151f9	Merge pull request #4874 from r-barnett/fix-MonitorLocalShift ... MonitorLocalShiftX,Y should be set when 1st monitor from MonitorIds s…	2018-09-26 10:02:49 +02:00
Martin Fleisz	a90b74b8dc	Merge pull request #4879 from akallabeth/clip_fix ... Fixes for clipboard #4876	2018-09-26 09:37:41 +02:00
akallabeth	0b8a66188c	Merge pull request #4865 from mmattes/feature/floatbar ... Feature/floatbar for X11	2018-09-25 16:34:20 +02:00
Armin Novak	8357f61818	Fixed load/unload for display channel.	2018-09-24 16:44:25 +02:00
Armin Novak	51f97f2d3e	Fixed #3423: Process xevents when in reconnect mode. ... Fixed crashes due to unloaded disp channel in reconnect mode.	2018-09-24 16:24:32 +02:00
Armin Novak	13478c7445	Skip empty server format response.	2018-09-24 12:47:46 +02:00
Armin Novak	228e63d619	Free RDP_KEYBOARD_LAYOUT with freerdp_keyboard_layouts_free	2018-09-24 12:47:32 +02:00
Armin Novak	897c0c72a7	Unified auto_reconnect functions for all clients.	2018-09-24 10:31:43 +02:00
rbarnett	41664572a5	MonitorLocalShiftX,Y should be set when 1st monitor from MonitorIds selected as primary	2018-09-21 13:40:48 -05:00
Martin Fleisz	2096c1108e	Merge pull request #4872 from akallabeth/sw_gdi_default ... Fix #4851: Software GDI is now default	2018-09-21 13:02:39 +02:00
akallabeth	30601608e4	Merge pull request #4855 from r-barnett/fix-logoff-exit-code ... Map a particular disconnect situation triggered by a user logging off…	2018-09-20 12:07:36 +02:00
Armin Novak	dfb1049653	Fix #4851: Software GDI is now default	2018-09-20 10:44:03 +02:00
rbarnett	5d3e76bd80	Replace cryptic names; move the disconnect ultimatum reasons enum into public API and rename; remove setter	2018-09-19 09:36:39 -05:00
rbarnett	8458266183	Store the disconnect provider ulimatum reason in a new field in struct rdp_context and move the test for a logoff reason to xf_client.c	2018-09-18 15:31:10 -05:00
Markus Mattes	36fc5dde21	fix hidden floatbar consumes a lot of cpu	2018-09-18 21:46:02 +02:00
Markus Mattes	21e4804a7f	implemented floatbar for x11	2018-09-18 21:25:51 +02:00
Martin Fleisz	0b7b9c0dc4	Merge pull request #4842 from akallabeth/smartcard_rdp_logon ... Added /smartcard-logon option to set flag. (Stripped version of #4837…	2018-09-17 09:08:47 +02:00
Martin Fleisz	3c158299a3	Merge pull request #4853 from r-barnett/add-nego-fail-exit-code ... Add an exit code for a security protocol negotiation failure	2018-09-14 10:59:31 +02:00
Armin Novak	97c909107f	Fixed const correctness for RAIL callbacks.	2018-09-14 10:07:22 +02:00
rbarnett	1e7be9908b	Add an exit code for a security protocol negotiation failure	2018-09-13 10:29:23 -05:00
akallabeth	56d001ef1b	Merge pull request #4852 from r-barnett/fix-net-disconnect-exit-code ... Set an error exit code for an unsuccessful reconnect	2018-09-13 09:57:16 +02:00
rbarnett	4e97edadec	Set an error exit code for an unsuccessful reconnect	2018-09-12 10:16:27 -05:00
rbarnett	e296a55fad	Reject unknown connection type values for /network command line option.	2018-09-11 10:17:52 -05:00
Martin Fleisz	e00dd1974c	wfreerdp: Increase buffer size for window title (#4731)	2018-09-10 15:26:44 +02:00
Armin Novak	cbb4be4122	Removed manipulation of authentication modes. ... Let +smartcard-logon be a simple flag not changing authentication settings. This can be done with the /sec options already.	2018-09-07 10:54:33 +02:00
Armin Novak	0de43c8b85	Added /smartcard-logon option to set flag. (Stripped version of #4837 by @informatimago)	2018-09-04 15:50:03 +02:00
Armin Novak	54f3a388da	Fixed #4835: BeginPaint callback now optional.	2018-09-04 10:40:17 +02:00
Armin Novak	456b95cbfc	Fixed size of command line value string.	2018-08-27 14:34:42 +02:00
Armin Novak	fad20be6e6	Fixed missing includes.	2018-08-27 14:34:42 +02:00
Armin Novak	62c1696d4c	Removed use of unchecked sprintf	2018-08-27 14:34:42 +02:00
Armin Novak	114abad767	Removed use of strcpy.	2018-08-27 14:34:09 +02:00
Armin Novak	48125164d7	Fixed dead initialization.	2018-08-24 13:40:36 +02:00
Martin Fleisz	0fb19d04be	Merge pull request #4810 from akallabeth/no_proxy_support ... No proxy support	2018-08-24 11:41:58 +02:00
Martin Fleisz	f9e52c1850	Merge pull request #4815 from akallabeth/async_transport_remove ... Removed +async-transport options	2018-08-24 09:48:51 +02:00
Armin Novak	b5df39756d	Added option to ignore proxy env.	2018-08-23 17:02:43 +02:00
Armin Novak	a0facc329f	Added option to deactivate proxy.	2018-08-23 17:02:43 +02:00
Martin Fleisz	ebef5a5e2e	Merge pull request #4811 from akallabeth/dyn_fullscreen_fix ... Fixed single monitor fullscreen resolution update.	2018-08-23 16:58:22 +02:00
Martin Fleisz	3381ca46e6	Merge pull request #4787 from akallabeth/redirect_fqdn_fix ... Redirect fqdn fix	2018-08-23 16:07:48 +02:00
Armin Novak	c3a26b0d6a	Removed +async-transport options ... The async transport option is broken by design. If used the main loop is called from the transport thread and the main thread of the application. Unless the transport layer is refactored to just work on queues (input and output) this option will never work, therefore remove it.	2018-08-22 13:56:37 +02:00
Ondrej Holy	f36054b379	client/cmdline: Fix leak found by covscan ... leaked_storage: Variable "base64" going out of scope leaks the storage it points to.	2018-08-22 13:35:43 +02:00
Ondrej Holy	e9549a3bdc	client/common: Fix leak found by covscan ... leaked_storage: Variable "file" going out of scope leaks the storage it points to.	2018-08-22 13:35:43 +02:00
Ondrej Holy	e7d5aae514	client/x11: Silence false positive warnings from covscan ... Add code annotation to silence false positive warnings from covscan due to omitting termination \0. buffer_size: Calling strncpy with a source string whose length (13 chars) is greater than or equal to the size argument (13) will fail to null-terminate "&tmp[cs]".	2018-08-22 13:35:43 +02:00
Ondrej Holy	baeb29a7e0	client/x11: Fix leak found by covscan ... leaked_storage: Variable "actionScript" going out of scope leaks the storage it points to.	2018-08-22 13:35:43 +02:00
Ondrej Holy	dde4c38382	client/x11: Format code by astyle ... Run ./scripts/format_code.sh before the following changes.	2018-08-22 13:35:43 +02:00
Armin Novak	02dc6ab3f7	Fixed single monitor fullscreen resolution update.	2018-08-21 13:00:39 +02:00
Andreas Gröger	525d089fa8	Update X11-modifier key state on focus_in	2018-08-13 14:45:05 +02:00
Armin Novak	a334aa9657	Fixed #4786: Added fullscreen handling for dynamic resolution.	2018-08-08 13:04:26 +02:00
Armin Novak	13564dbb41	Allow redirect address override with a list of values.	2018-08-08 12:30:47 +02:00
Armin Novak	cc5e402cda	Added command line option /redirect-prefer:<fqdn|ip|netbios> ... Since redirection sometimes happens with internal DNS names that are resolved different by outside DNS it must be possible to override the preferred redirection hint.	2018-08-08 11:24:13 +02:00
Armin Novak	97e7eca30c	Started next development cycle	2018-08-01 15:29:17 +02:00
Armin Novak	eed5a41b6e	Fixed funtion to function pointer argument mismatch	2018-08-01 12:56:18 +02:00
Martin Fleisz	e3eae5db8a	Merge pull request #4240 from akallabeth/wl_client_fixes ... Fixed wayland issues.	2018-07-31 11:03:39 +02:00
akallabeth	88474af925	Merge pull request #4762 from mmattes/issue/4757 ... Fix for #4757	2018-07-30 13:31:32 +02:00
Martin Fleisz	143a2b149a	Merge pull request #4755 from akallabeth/dyn_resize_fix ... Fixed #4679, #4753 dynamic resizing	2018-07-30 12:28:38 +02:00
akallabeth	ffd84916fa	Merge pull request #4765 from mmattes/fix/double-import-xinput2 ... Removed double ifdef WITH_XI, XInput2.h already included	2018-07-30 10:47:34 +02:00
Mandar	093fe83386	macos: Bring RDP window to front ... To bring RDP window on top of all the windows	2018-07-27 15:54:57 +05:30
Markus Mattes	e6209748fa	Removed double ifdef WITH_XI, XInput2.h already included	2018-07-24 14:03:45 +02:00
Markus Mattes	bad8bbadf4	Fix for #4757	2018-07-22 20:00:25 +02:00
Armin Novak	328eba7fe9	Fix #4752: Provide message free function for channel queue.	2018-07-18 15:31:07 +02:00
Armin Novak	4e4ec0b035	Fix #4752: Unsubscirbe all PubSub in dynamic channel.	2018-07-18 14:29:22 +02:00
Armin Novak	ced4d06f74	Fixed #4679, #4753 dynamic resizing ... Simplified resize logic, do not check before setting current resolution.	2018-07-18 09:48:19 +02:00
Martin Fleisz	187cf000bc	Merge pull request #4706 from khvMX/master ... X11: fixed Right-Ctrl ungrab feature (PR #3622)	2018-07-03 12:45:15 +02:00
Martin Fleisz	b34e3bcf73	Merge pull request #4681 from akallabeth/wording_consistent ... Fixed #4636: Consistent wording for boolean options depending on default	2018-06-26 10:19:41 +02:00
Armin Novak	b9b30f92cd	Fixed memory leak in command line value parsing.	2018-06-19 12:55:29 +02:00
Armin Novak	e44d10a3e0	Merge remote-tracking branch 'origin/pr/4701' into reconnect_fixes	2018-06-19 12:46:58 +02:00
Armin Novak	273655a850	Follow up fix for #4631 ... Remember the callback state to avoid calling reerdp_channels_post_connect before the corresponding client callback has benn called. This might happen during redirection and reconnection.	2018-06-18 10:44:35 +02:00
Viktor Mukha	16cde2ee28	X11: fixed Right-Ctrl ungrab feature (PR #3622)	2018-06-08 11:35:02 +02:00
Pascal J. Bourguignon	15f2bafeab	Cleaned up const char** -> char** for argv, since we definitely do modify the argv! ... (we overwrite the password and pin arguments). This implies changes in the argument parsing tests that now must pass a mutable argv (copied from the statically declared test argvs). Some other const inconsistency have been dealt with too.	2018-06-06 16:43:09 +02:00
Armin Novak	8dba31ea0e	Fixed #4636: Consistent wording for boolean options depending on default.	2018-05-17 10:30:13 +02:00
Andre Esteve	ab0bc2a7f5	X11: Fix fullscreen toggle ... 1. Fix fullscreen toggle for window managers that do not have multimonitor fullscreen extension support 2. Fix current monitor detection 3. Fix calculation of vscreen boundaries when single monitor is being used 4. Fix start up position of window when starting (used to always go to the top left corener, now centered) Still a problem: 1. Window decorations do not show when going windowed 2. Smart resizing makes i3 really sad :( 3. Moving window across monitors and going fullscreen always maximizes on startup screen (when not using /multimon)	2018-05-05 18:24:23 -07:00
Martin Fleisz	7eb12bb028	Merge pull request #4610 from akallabeth/cmd_strtol_fix ... Fix #4597: Do string argument checks before a possible strtol	2018-05-04 13:28:18 +02:00
Martin Fleisz	99346d19c6	Merge pull request #4611 from akallabeth/argument_warnings ... Argument warnings	2018-05-04 10:06:42 +02:00
Martin Fleisz	296b19e172	Merge pull request #4596 from p-pautov/rdg_ssl_fixes ... RDG related fixes for better compatibility with mstsc	2018-05-03 10:23:12 +02:00
Kyle Evans	a7c0632bf2	Use SetFreeRDPCMakeInstallDir where CMake modules are installed	2018-05-02 10:36:52 -05:00
Armin Novak	3a54713103	Fixed invalid argument parameter	2018-05-02 13:08:30 +02:00
Armin Novak	1fd5c53a74	Fix #4597: Do string argument checks before a possible strtol ... strtol sets errno, which must be reset if it is no abort condition. Invert the comparisons to avoid that.	2018-05-02 12:57:34 +02:00
David Fort	9381e18cd2	Merge pull request #4570 from akallabeth/toolchain_fix ... android Toolchain fix	2018-05-02 12:09:55 +02:00
Martin Fleisz	31c804c349	Merge pull request #4603 from hardening/socksplus ... SOCKS5 proxy support	2018-05-02 11:26:13 +02:00
David Fort	0f968b782c	proxy: cleanup SOCKS support and add user/password support	2018-05-02 10:51:16 +02:00
Jiri Sasek	1ba31551a6	socks proxy reply fix	2018-05-02 09:43:03 +02:00
Armin Novak	a1c3c1ad64	Added proper return value checks for clipboard data.	2018-05-02 09:21:42 +02:00
Pavel Pautov	32505fda13	Apply "authentication level" RDP property only to non-RDG connections (as mstsc does).	2018-04-25 18:12:23 -07:00
Jiri Sasek	b1c1549ad1	SOCKS proxy support	2018-04-23 21:01:01 +02:00
Armin Novak	927409cf81	Add default values for keystore variables.	2018-04-16 11:39:36 +02:00
Armin Novak	5628ed5e7d	Check for window existence in remote app mode before access ... X11 is asynchronous, so events arriving in xf_event_PropertyNotify may access a window that has already been discarded. Check that before reading properties.	2018-04-12 14:39:37 +02:00
Bernhard Miklautz	d309a1ba33	build: set version to 2.0.0-dev3 ... start 2.0.0-rc3 development cycle	2018-04-11 13:36:33 +02:00
Bernhard Miklautz	c0afb8bd6b	Merge pull request #4322 from akallabeth/rail_fixes ... Rail fixes for GFX mode	2018-04-11 10:49:44 +02:00
Eric Brown	ee87b98850	Fix issues found by build bot	2018-04-10 02:55:15 -05:00
Eric Brown	71c949f61a	Fix Windows 10 cursors drawing as black	2018-04-09 13:59:42 -05:00
Armin Novak	c70bf8329f	Fixed XPixmap checks.	2018-04-04 10:46:14 +02:00
Armin Novak	065a924496	Fixed format string types.	2018-04-04 10:45:57 +02:00
akallabeth	b37a98182d	Merge pull request #4457 from RangeeGmbH/fix_custom_sizes ... Fix /size: /w: /h: with /monitors: (Fix custom sizes)	2018-04-04 10:35:47 +02:00
MartinHaimberger	1a8234c74d	Merge pull request #4472 from akallabeth/win_mouse_button ... [WIN] Added additional mouse mappings.	2018-04-04 10:12:04 +02:00
MartinHaimberger	c73c54a626	Merge pull request #4477 from akallabeth/command_line_fix ... Detect command line flags in case RDP or MSINCIDENT files are used.	2018-04-04 10:06:07 +02:00
Martin Fleisz	edce38613a	Merge pull request #4529 from akallabeth/wlog_cleanup_fix ... Fix #4524: Initialize with cleanup handler	2018-04-04 09:32:46 +02:00
Kai Harms	2dffc3ef96	Fix spelling of network commandline values	2018-04-03 12:12:58 +00:00
Armin Novak	e0d112d548	Removed all calls to WLog_Init and WLog_Uninit ... Since the calls are no longer required remove their usage.	2018-04-03 13:06:41 +02:00
Armin Novak	d249335708	Removed winpr_exit ... As the cleanup functions are called by atexit a dedicated cleanup call is no longer required.	2018-04-03 12:56:33 +02:00
Jakob Kaivo	3a1d70d9ba	add support for the "pcb" block in .rdp files provided by Project Honolulu in the VM interface	2018-03-31 22:15:39 -04:00
Kai Harms	222bf9245e	Fix /size: /w: /h: with /monitor: (Fix custom sizes) ... Fix weird rectangle by removing checks	2018-03-29 07:12:53 +00:00
Ilya Shipitsin	14c15c680d	resolve several possible null pointer dereference ... issue detected by cppcheck [channels/drive/client/drive_main.c:454] -> [channels/drive/client/drive_main.c:443]: (warning) Either the condition '!irp' is redundant or there is possible null pointer dereference: irp. [client/X11/xf_window.c:582] -> [client/X11/xf_window.c:580]: (warning) Either the condition '!xfc' is redundant or there is possible null pointer dereference: xfc. [winpr/libwinpr/path/test/TestPathShell.c:40] -> [winpr/libwinpr/path/test/TestPathShell.c:43]: (warning) Either the condition '!path' is redundant or there is possible null pointer dereference: path. [winpr/libwinpr/path/test/TestPathShell.c:49] -> [winpr/libwinpr/path/test/TestPathShell.c:52]: (warning) Either the condition '!path' is redundant or there is possible null pointer dereference: path.	2018-03-24 17:46:39 +05:00
David Fort	103686eb12	Merge pull request #4497 from akallabeth/kwin_multimon ... Fix #2707: Set fullscreen first	2018-03-19 19:12:02 +01:00
Armin Novak	338e74a6fb	Fix #2707: Set fullscreen first ... Due to kwin bug https://bugs.kde.org/show_bug.cgi?id=391960 multimonitor fullscreen is not applied correctly with the previous approach.	2018-03-19 11:54:06 +01:00
Armin Novak	87ebdf0052	Fixed #4493: duplicate typedef.	2018-03-17 15:25:41 +01:00
Armin Novak	9bd13c25c9	Added WaitableTimer implementation for mac OS.	2018-03-12 13:39:21 +01:00
Armin Novak	f430b55abf	Detect command line flags in case RDP or MSINCIDENT files are used.	2018-03-09 14:25:45 +01:00
Armin Novak	d1fc0e92b5	Added additional mouse mappings.	2018-03-08 13:21:04 +01:00
Armin Novak	44eebbb6e0	Fixed compiler warnings.	2018-03-07 14:47:06 +01:00
Armin Novak	2517755d25	Fixed thread function return and parameters.	2018-03-07 14:36:55 +01:00
akallabeth	ce61ec1d39	Merge pull request #4464 from perkerk/misc-windows-client ... Misc changes for Windows client	2018-03-07 13:47:23 +01:00
Eric Brown	e3adeb1059	Remove NULL check before _aligned_free call	2018-03-07 04:40:18 -06:00
Martin Fleisz	91ee4c2e9c	Merge pull request #4454 from akallabeth/nightly ... Use a custom command to generate helper tool	2018-03-07 10:17:17 +01:00
Eric Brown	930ccb6b7b	Fix memory leak of Decompress buffer in client wf_Bitmap_Free	2018-03-05 13:20:41 -06:00
Eric Brown	d8151c03df	Remove unnecessary WM_SETCURSOR handling from wf_event_proc	2018-03-05 12:32:42 -06:00
Armin Novak	733f58c4f9	Use wrapper functions for input event handling.	2018-03-05 09:59:41 +01:00
Armin Novak	87c44a0471	Removed NULL checks in functions without return	2018-03-05 09:59:26 +01:00
Eric Brown	0c24ade668	Misc fixes for Windows clients	2018-03-02 12:42:04 -06:00
Eric Brown	4c099866e9	Support EmbeddedWindow in wf_resize_window	2018-03-02 12:39:59 -06:00
Armin Novak	47110a723d	Removed duplicate checks, more functions static.	2018-03-01 12:39:29 +01:00
Armin Novak	1f7d33a2f2	Fixed read/write of surface bits command. ... The optional field exBitmapDataHeader of TS_ BITMAP_DATA_EX was ignored. Read and expose the data (currently unused)	2018-03-01 11:38:59 +01:00
Martin Fleisz	8e5d5fa8ea	Merge pull request #4450 from akallabeth/assist_fix ... Assistance and RDP file parser fix	2018-02-21 16:56:55 +01:00
Armin Novak	62f06ed11e	Use a custom command to generate helper tool ... Removing elements from CMAKE_C_FLAGS is not reliable, to use a custom command to compile the helper tool with default CFLAGS for the system.	2018-02-21 13:14:45 +01:00
Martin Fleisz	3cfa837b0c	Merge pull request #4441 from akallabeth/paa ... [cleanup] Support for gatewayaccesstoken / PAA	2018-02-19 17:28:32 +01:00
Armin Novak	68641f109b	Fixed .rdp and .msrcIncident checks. ... The command line detection fails, if only one of the aforementioned files is used as an argument. Detect those first and ignore command line detection if found.	2018-02-19 10:00:54 +01:00
Armin Novak	b2428767b2	manpage helper tool generation fixes ... The generator tool is called by CMake and is incompatible with certain options. Therefore this commit * removes WinPR dependency * removes -fsanitize=* from CFLAGS	2018-02-16 13:57:34 +01:00
Martin Fleisz	5d1ff02d02	Merge pull request #4414 from akallabeth/pthread_cleanup_fix ... Pthread cleanup fix	2018-02-15 11:02:37 +01:00
Jacco Braat	b592684734	Added to rdp file parsing: gatewayaccesstoken:s:<token> ... Added to commandline parsing: /gat:<token> Added GatewayAccessToken to sings	2018-02-15 10:56:57 +01:00
Martin Fleisz	19a00f2099	Merge pull request #4325 from akallabeth/fixes_com ... Fixes serial redirection name check and SAM file parser	2018-02-15 10:39:33 +01:00
Armin Novak	84f2cff5e0	Fixed wayland issues.	2018-02-15 09:44:38 +01:00
Armin Novak	990b8c23a9	Fixed PubSub function pointer casts.	2018-02-14 11:00:52 +01:00
David Fort	441975a4aa	video, geometry: fix prototypes for timer callbacks	2018-02-14 10:16:38 +01:00
David Fort	484abe0567	video: fix invalid geometry and invalid argument passing to time pubsub	2018-02-14 00:08:52 +01:00
Martin Fleisz	bc4b57c08d	Merge pull request #4426 from akallabeth/pointer_null_fix ... Check if xfreerdp window != NULL	2018-02-13 14:37:13 +01:00
Armin Novak	7274ffe6a8	Check if xfreerdp window != NULL ... When xfreerdp aborts a connection it may be before xfc->window was allocated. Don't access it in that case.	2018-02-13 13:38:02 +01:00
Armin Novak	3eb004042e	Fixed code duplication.	2018-02-13 10:52:53 +01:00
Armin Novak	c7d701bdf8	Added software decoding fallback for RDPVOR	2018-02-13 10:52:53 +01:00
Armin Novak	11f11a8763	Fixed scaled drawing of video content.	2018-02-13 10:52:53 +01:00
David Fort	b8e3b232de	video: mutualize things in the common channel code	2018-02-13 10:52:53 +01:00
David Fort	0743559d9c	video: do cleanups in post_connect	2018-02-13 10:51:45 +01:00
David Fort	ca4f75ccd3	video: fixed uninit of channel	2018-02-13 10:51:45 +01:00
David Fort	4b240dad0e	video+geometry: fixed leaks, a segfault and concurrent accesses	2018-02-13 10:51:07 +01:00
David Fort	6e022ae07c	video: fix prototype and cleanup at exit	2018-02-13 10:51:07 +01:00
David Fort	a07efb73ec	video: an implementation of MS-RDPEVOR for X11 ... Implements the decoding of video streams using common H264 decoders. We also implement a trivial feedback algorithm. Sponsored by: Rangee GmbH (http://www.rangee.de)	2018-02-13 10:51:07 +01:00
David Fort	b84839b21c	video: a skeleton for MS-RDPEVOR client ... Basics for implementing the client side of the MS-RDPEVOR channel. Sponsored by: Rangee GmbH (http://www.rangee.de)	2018-02-13 10:51:07 +01:00
Armin Novak	2cf10cc359	bitmap free now always deallocating all resources.	2018-02-13 10:18:43 +01:00
Armin Novak	62607e3b02	Fixed accidental free of XImage data.	2018-02-12 12:44:51 +01:00
Armin Novak	2d58e96dcc	Exit main thread with winpr_exit to trigger resource cleanup. ... When using pthread_once with destructors they are only called, if each thread (including the main thread) is exited with pthread_exit. Introducing winpr_exit as a wrapper for that purpose.	2018-02-12 10:33:02 +01:00
Armin Novak	7c0a33632b	Fixed #4412: XImage must be freed with XDestroyImage	2018-02-12 10:02:35 +01:00
Armin Novak	7e26c54866	Set up and tear down WLog	2018-02-09 12:08:39 +01:00
Armin Novak	1b9da01612	Fixed cleanup of xfc->drawable.	2018-02-09 11:42:18 +01:00
Armin Novak	d181c79463	Fixed rail window cleanup.	2018-02-09 09:35:26 +01:00
Armin Novak	6950d95af0	Fix #4398: Ignore min/max info for non existing window.	2018-02-08 16:55:11 +01:00
Armin Novak	ed9d86b1a3	Fixed GFX output expose.	2018-02-08 13:55:36 +01:00
Armin Novak	c0ec81c3c7	Do not update client if output suppressed.	2018-02-08 11:59:00 +01:00
Armin Novak	253beda330	Fixed formatting.	2018-02-08 11:55:57 +01:00
Armin Novak	17b17d609a	Fixed SuppressOutput update.	2018-02-08 11:55:15 +01:00
MartinHaimberger	71bd654fd2	Merge pull request #4395 from akallabeth/afreerdp_clipboard_fix ... [aFreeRDP] Check length of string returned by ClipboardGetData	2018-02-07 10:33:33 +01:00
Bernhard Miklautz	db2d1ffcce	cmdline refactor: move cmd struct to extra file ... Move the cmd struct to a extra header file. This allows it to only include the header file in generate_argument_docbook.c and therefore remove a linker dependencies.	2018-02-01 17:13:44 +01:00
Armin Novak	7183c5019b	Check length of string returned by ClipboardGetData	2018-02-01 09:34:07 +01:00
Armin Novak	7f75b57fd6	Fixed memory leak.	2018-01-22 16:17:37 +01:00
Armin Novak	91280b3ea5	Updated gradle build version and dependencies.	2018-01-17 12:03:05 +01:00
Armin Novak	51e59e1f2e	Check argument, xfc->window is NULL in RAILS mode	2018-01-08 13:21:03 +01:00
Armin Novak	e23af1d2fc	Fixed missing argument checks.	2018-01-08 13:21:02 +01:00
Armin Novak	ac1d6e8153	Fixed #3676, #4269: Screen update for RAIL with GFX	2018-01-08 13:21:02 +01:00
David Fort	e1cc601963	Merge pull request #4323 from akallabeth/scanbuild_fixes ... Scanbuild and other warnings fixed	2018-01-08 11:16:21 +01:00
David Fort	88c9b1fac1	Merge pull request #4333 from akallabeth/drive_param_check_fix ... Fixed drive redirection argument check	2018-01-08 09:29:25 +01:00
akallabeth	4077d55a6c	Merge pull request #4332 from hardening/xrandr_and_fixes ... Xrandr and fixes	2018-01-08 09:20:56 +01:00
akallabeth	27aac21c03	Fixed drive redirection argument check ... Allow special cases '*' and '%' to pass parameter checks.	2017-12-28 14:05:11 +01:00
David Fort	191b8f950f	Fix for #4330 ... Since ec027bf dynamic resolution is broken when used with egfx. Before that commit we were tracking a server sent resize by setting a DesktopResize callback. This callback is called when the desktop is resized by the server. Anyway the problem was that when this callback is called, the activation sequence is not always completed, which were leading to some freeze with 2012r2 servers (sending packets before the sequence is finished). So with the faulty commit, we are tracking server resizes by subscribing to the Actived event, that is called at the end of a reactivation sequence, so we're sure to not send packets when not fully activated. Anyway the issue that shows on (#4330) is that when you use egfx, no reactivation sequence happens, the server only sends a ResetGraphics message with the new size, and so we miss the resized event. This fix introduces a new GraphicsReset event, makes the display channel subscribe to that event, and react accordingly.	2017-12-23 13:50:54 +01:00
David Fort	58b5573c82	Use more xrandr attributes when available and preserve [desktop|device]ScaleFactor ... Fix a too restrictive detection of XRandr support. Set more monitor's attributes like physical size and orientation when XRandr is available. Set [desktop|device]ScaleFactor when it has been given on the command line, this should fix #4324.	2017-12-23 13:46:42 +01:00
Armin Novak	5144e6e600	Exit client thread if freerdp_connect fails ... freerdp_disconnect must only be called, if the connection was established. Otherwise all resources are cleaned up twice leading to double free and other issues.	2017-12-22 11:09:23 +01:00
Armin Novak	4483751e08	Fixed help for /parallel	2017-12-21 15:19:29 +01:00
David Fort	7c3d75bf1d	Merge pull request #4319 from akallabeth/fullscreen_legacy_fix ... Fullscreen without _NET_WM_FULLSCREEN_MONITORS	2017-12-21 11:25:39 +01:00
Armin Novak	9c93c6cbf3	Fixed unused variable warnings.	2017-12-21 11:04:50 +01:00
Armin Novak	6a21bdae3d	Fixed various scanbuild warnings.	2017-12-21 09:34:35 +01:00
Armin Novak	1628045f67	Fullscreen without _NET_WM_FULLSCREEN_MONITORS ... Some window managers do not support _NET_WM_FULLSCREEN_MONITORS. In that case multimonitor fullscreen does not properly work, so add a path resizing the window over all screens instead. Based on @erbth pull request, adding proper X11 atom checks.	2017-12-20 16:54:44 +01:00
Armin Novak	a202476422	Fixed RDP file parser for unicode. ... There was a memory corruption hidden due to ignoring the buffer size argument.	2017-12-20 13:44:24 +01:00
David Fort	ce89a9096e	disp: improve window resizing ... To workaround a bug with 2012r2 servers, don't send any resize during renegociation and don't resize at a too high rate (every 200ms is good enough).	2017-12-19 20:59:10 +01:00
akallabeth	71fd6f3116	Merge pull request #4313 from hardening/dyn_res_update ... disp: implement dynamic resolution for X11	2017-12-19 13:49:02 +01:00
akallabeth	097f8edd97	Merge pull request #4312 from bmiklautz/smartcard-cleanup ... Smartcard fixes and cleanup	2017-12-14 16:56:29 +01:00
David Fort	80dab90f1a	disp: implement dynamic resolution for X11 ... If the display channel is available we use it to allow the user to resize the xfreerdp window. When the window is resized we announce a new monitor layout and the server reacts by doing a reactivation sequence to the new size. The minimum window size is limited to 300x300 as 2012 servers crash horribly if we send them a smaller layout.	2017-12-14 15:13:11 +01:00
Martin Fleisz	5cec90c781	Merge pull request #4305 from hardening/xrandr_fix ... Fix XRandr for old systems and MacOSX	2017-12-13 17:24:41 +01:00
Bernhard Miklautz	1e6fea7fa7	fix channel/smartcard: simplify channel variables ... Path was not really used and name was duplicated. Use the device->Name directly.	2017-12-13 17:04:06 +01:00
Martin Fleisz	6aa914363a	Merge pull request #4301 from hardening/geometry ... geometry: a skeleton for the MS-RDPEGT channel	2017-12-13 09:09:33 +01:00
David Fort	3b670703fb	Merge pull request #4277 from akallabeth/mac_server ... Mac fixes	2017-12-12 10:40:14 +01:00
David Fort	a6cfd3c49a	geometry: a skeleton for the MS-RDPEGT channel ... The base for implementing the MS-RDPEGT client channel that allows to track window geometry.	2017-12-08 11:26:29 +01:00
David Fort	11ee81be60	Fix XRandr for old systems and MacOSX ... We need a recent enough version of XRandr to correctly detect monitor. Also this patch adds some typo or style fixes.	2017-12-08 10:59:38 +01:00
Martin Fleisz	876a7697be	Merge pull request #4297 from akallabeth/cmd_parser_hardening ... Fix #4296: Hardened command line post filter.	2017-12-05 14:40:03 +01:00
Martin Fleisz	ed9a4b7d45	Merge pull request #4288 from hardening/disp_channel ... Disp channel changes and improvements	2017-12-05 10:56:14 +01:00
Armin Novak	78a0c4c618	Fix #4296: Hardened command line post filter.	2017-12-01 13:13:21 +01:00
akallabeth	0cb5907664	Merge pull request #4275 from ondrejholy/big-endian-fixes ... Big endian fixes	2017-12-01 11:24:50 +01:00
David Fort	e064aa6a99	xfreerdp: when available use xrandr to get display infos	2017-11-29 10:38:48 +01:00
Bernhard Miklautz	1cda26274f	client/android: increase version	2017-11-28 15:33:03 +01:00
David Fort	cf33966f2e	Merge pull request #4282 from akallabeth/force_ipv6 ... Fix #4281: Added option to prefer IPv6 over IPv4	2017-11-28 10:48:53 +01:00
Bernhard Miklautz	baf52f529f	Merge pull request #4261 from akallabeth/doc_ssl_store ... Fix #3890: Point to OpenSSL doc for private CA	2017-11-27 11:46:54 +01:00
Armin Novak	2cc64298f2	Fix #4281: Added option to prefer IPv6 over IPv4	2017-11-27 11:43:54 +01:00
Bernhard Miklautz	cd0b055008	Merge pull request #4270 from akallabeth/mac_clipboard_fix ... Fixed #1536: Clipboard data size.	2017-11-27 10:40:44 +01:00
David Fort	8f8ce70f3d	Merge pull request #4229 from akallabeth/from_stdin_args ... Option to force password prompt before connection	2017-11-24 15:51:46 +01:00
Armin Novak	57958cb178	Fixed #3810: Renamed color functions	2017-11-24 13:21:43 +01:00
Ondrej Holy	90000fd36e	client/common: Fix two memory leaks in RDP file processing ... FALSE is returned immediately in case of parsing error and thus buffer copy is leaked. Let's release the memory properly.	2017-11-24 10:24:47 +01:00
Ondrej Holy	5dcd1ebb06	client/common: Fix RDP file processing on big endian ... TestClientRdpFile fails on big endian machines due to some bug in unicode processing. Let's drop all the unicode functions and convert unicode input into ascii as soon as possible. This significantly simplify RDP file processing and also fixes TestClientRdpFile on big endian machines. https://github.com/FreeRDP/FreeRDP/issues/4231	2017-11-23 20:00:09 +01:00
David Fort	d982cf0e90	Merge pull request #4255 from akallabeth/rfx_fix ... Fix #4253: Rfx decode tile width.	2017-11-23 15:35:52 +01:00
Armin Novak	65a97b13c8	Fixed #1536: Clipboard data size.	2017-11-23 13:16:50 +01:00
akallabeth	71e38a4ce7	Merge pull request #4267 from ondrejholy/autofips ... Enable FIPS mode automatically	2017-11-23 10:49:15 +01:00
Ondrej Holy	6973b14eed	Enable FIPS mode automatically ... FreeRDP aborts if OpenSSL operates in FIPS mode and +fipsmode is not manually specified. Let's prevent the abortion and enable the necessary options in that case automatically.	2017-11-23 10:09:17 +01:00
Martin Fleisz	2f281c06ba	Merge pull request #4244 from akallabeth/drivestoredirect ... Fix parsing of drivestoredirect (#3267)	2017-11-22 12:23:04 +01:00
Armin Novak	7183189328	Fix #4257: Proper error checks for /kbd argument	2017-11-22 11:03:43 +01:00
akallabeth	77a921240b	Testing argument to end with file extension.	2017-11-21 19:10:28 +01:00
Armin Novak	65482ee9bf	Fixed #4249: Corruption due to recursive parser	2017-11-21 13:47:28 +01:00
Armin Novak	12a9b9a0b4	Fix #3890: Point to OpenSSL doc for private CA	2017-11-21 11:47:33 +01:00
Armin Novak	d81e2ec351	Fixed X11 stride on screen update.	2017-11-21 11:09:16 +01:00
Martin Fleisz	785c42f463	Merge pull request #4252 from akallabeth/mac_kbd_sync ... Mac kbd sync	2017-11-21 11:02:25 +01:00
Martin Fleisz	ca4d204c78	Merge pull request #4256 from akallabeth/15bpp_fix ... Fix #4111: 15bpp color handling for brush.	2017-11-21 10:55:18 +01:00
Armin Novak	6504b81b9e	Fix parsing of drivestoredirect (#3267)	2017-11-21 10:46:50 +01:00
Bernhard Miklautz	cbb8650b3d	Merge pull request #4254 from akallabeth/doc_update ... Fix #3509: Added Ctrl+Alt+Enter description	2017-11-20 16:30:54 +01:00
Armin Novak	24233b299c	Fix #4111: 15bpp color handling for brush.	2017-11-20 15:00:09 +01:00
Armin Novak	a3fb3270dc	Fix #3509: Added Ctrl+Alt+Enter description	2017-11-20 13:22:53 +01:00