mirrors/FreeRDP
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

client/cmdline: Fix leak found by covscan

Browse Source 
leaked_storage: Variable "base64" going out of scope leaks the storage it points to.
This commit is contained in:
Ondrej Holy 2018-08-17 14:45:07 +02:00
parent e9549a3bdc
commit f36054b379
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
client/common/cmdline.c
View File

@ -2596,7 +2596,7 @@ int freerdp_client_settings_parse_command_line_arguments(rdpSettings* settings,
}
CommandLineSwitchCase(arg, "reconnect-cookie")
{
BYTE* base64;
BYTE* base64 = NULL;
int length;
crypto_base64_decode((const char*)(arg->Value), (int) strlen(arg->Value),
&base64, &length);
@ -2604,12 +2604,13 @@ int freerdp_client_settings_parse_command_line_arguments(rdpSettings* settings,
if ((base64 != NULL) && (length == sizeof(ARC_SC_PRIVATE_PACKET)))
{
memcpy(settings->ServerAutoReconnectCookie, base64, length);
free(base64);
}
else
{
WLog_ERR(TAG, "reconnect-cookie: invalid base64 '%s'", arg->Value);
}
free(base64);
}
CommandLineSwitchCase(arg, "print-reconnect-cookie")
{