239440e28d
[warnings] remove or comment unused macros
2024-09-20 18:49:38 +02:00
ed942f8c20
[warnings,c++] deactivate -Wexit-time-destructors
...
This warning can be ignored as on all supported platforms memory, file
and network resources are cleared up on program termination.
2024-09-20 17:35:52 +02:00
5bcd737548
Merge pull request #10651 from akallabeth/disable-language-extension-warn
...
[compiler,warnings] disable -Wlanguage-extension-token
2024-09-20 14:07:11 +02:00
d3a7629734
Merge pull request #10629 from akallabeth/rail-modal
...
[client,X11] Fix RAILS modal dialog handling
2024-09-20 13:38:46 +02:00
516cf54c75
[compiler,warnings] disable -Wlanguage-extension-token
...
Expression Statements are not supported by ISO C but we require it for
certain macros. Disable this warning as it just yields false positives.
2024-09-20 13:34:24 +02:00
6660119422
Merge pull request #10650 from akallabeth/winpr-errno
...
[winpr,utils] fix winpr_strerror argument types
2024-09-20 12:57:56 +02:00
69527e117a
[client,X11] update _NET_WM_STATE for WS_EX_TOPMOST
...
* Set _NET_WM_STATE_ABOVE if WS_EX_TOPMOST is set and WS_EX_TOOLWINDOW
clear for a window style
* Clear _NET_WM_STATE_ABOVE in all other cases
2024-09-20 11:33:29 +02:00
d0c1e6055f
[client,X11] add missing _NET_WM_STATE* atoms
2024-09-20 11:33:26 +02:00
0a24f12281
[client,X11] update window style
...
* if WINDOW_ORDER_STATE_NEW is not set also update
2024-09-20 11:31:34 +02:00
fd3c7633d6
[client,X11] fix rails modal windows
...
xf_XSetTransientForHint of windows of type
(WS_EX_CONTROLPARENT | WS_EX_TOOLWINDOW | WS_EX_DLGMODALFRAME)
and parent window set
2024-09-20 11:31:32 +02:00
c8e6b1b71f
[client,x11] log rail WINDOW_STATE_ORDER
2024-09-20 11:31:30 +02:00
2b1abcd550
[client,x11] add helper util x11_error_to_string
...
The helper function x11_error_to_string stringifies a X11 error return
code.
2024-09-20 11:31:27 +02:00
f67e641cce
[client,X11] add helper functions for rail window style
...
* window_styles_to_string
* window_styles_ex_to_string
2024-09-20 11:31:24 +02:00
e79aaf4d82
[ci,abi-checker] suppress winpr_strerror parameter change
...
The change is not 100% clean but does not break ABI (but might create
some unnecessary warnings in 3rd party code)
2024-09-20 11:11:08 +02:00
42e3c6fff8
[winpr,utils] fix winpr_strerror argument types
...
errno is of type int, so use a signed INT32 as argument type to avoid
warings with sign conversions
2024-09-20 10:57:21 +02:00
f86f70a022
Merge pull request #10637 from akallabeth/dealloc-fix
...
[warnings] fix mismatched-dealloc
2024-09-20 10:50:20 +02:00
7a607dbc53
Merge pull request #10630 from akallabeth/disable-ctad-maybe-unuspported
...
[build,c++] add CXXCompilerFlags to (un)set warnings
2024-09-20 10:48:56 +02:00
9e416ed002
Merge pull request #10648 from akallabeth/sdl3-api-update
...
[client,sdl] update to current sdl3-api
2024-09-20 10:45:27 +02:00
699fc70941
[client,sdl] update to current sdl3-api
2024-09-20 10:19:29 +02:00
80623095a0
Merge pull request #10647 from akallabeth/kbd-range-checks
...
[locale,keyboard] fix index range checks
2024-09-20 10:15:05 +02:00
107a8d9f48
[compiler] disable C++ warnings
...
Projects are set to require C++ 17, so disable all warnings complaining
about compatibility with previous versions of the standard.
2024-09-20 09:17:22 +02:00
02b98e9287
[client,sdl] use constexpr instead of defines
2024-09-20 09:17:03 +02:00
c509aabc08
[cmake] disable -Wdisabled-macro-expansion
...
this warning does not yield useful results for FreeRDP, disable by
default.
2024-09-20 09:16:33 +02:00
96052ca2fb
[build,c++] add CXXCompilerFlags to set warnings
...
Just like with the C components and CompilerFlags.cmake add a
configuration for C++ that disables specific warnings only found in C++
code.
2024-09-20 09:16:30 +02:00
ffd40983ac
[locale,keyboard] fix index range checks
2024-09-20 08:28:56 +02:00
e2d1938886
Merge pull request #10644 from FreeRDP/revert-10643-rdg
...
Revert "[core,gateway] read leftover http body in the rdg IN channel."
2024-09-19 13:56:35 +02:00
35ad7e7d0d
Revert "[core,gateway] read leftover http body in the rdg IN channel."
2024-09-19 19:38:29 +08:00
33fcc04263
Merge pull request #10643 from llyzs/rdg
...
[core,gateway] read leftover http body in the rdg IN channel.
2024-09-19 13:21:26 +02:00
56535c9663
[core,gateway] read leftover http body in the rdg IN channel.
2024-09-19 18:29:54 +08:00
8cd12a87fd
Merge pull request #10639 from akallabeth/kbd-layout-fix
...
Kbd layout fix
2024-09-19 11:34:48 +02:00
183be60bac
Merge pull request #10623 from akallabeth/warn-fixes-stream
...
Warn fixes stream
2024-09-19 09:49:19 +02:00
632e2180f7
[winpr,stream] rewrite stream read functions
...
Use a loop to shift in bytes to avoid casts.
2024-09-19 09:06:20 +02:00
46457a5033
[winpr,stream] Add Stream_BufferAs macro
...
* Add Stream_BufferAs, Stream_ConstBufferAs, Stream_GetBufferAs and
Stream_GetPointerAs to get a pointer to the stream pointer or buffer
casted to a specific type.
* Use WINPR_STREAM_CAST in these new macros for proper cast according to
C or C++
2024-09-19 09:06:13 +02:00
c5e8326d07
Merge pull request #10640 from akallabeth/sdl-hicpp
...
[client,sdl] fix class constructors and operators
2024-09-19 08:26:52 +02:00
84719a4d83
[client,sdl] fix class constructors and operators
...
delete unused move/copy constructors and operators
2024-09-18 23:33:50 +02:00
564656166e
[locale,keyboard] add unit tests for functions
2024-09-18 21:31:16 +02:00
8d46de743e
Merge pull request #10638 from akallabeth/tidy-branch-clone
...
[clang-tidy] deactivate bugprone-branch-clone check
2024-09-18 21:22:13 +02:00
7ae1f07aa8
[locale,keyboard] fix missing input validation
2024-09-18 21:17:28 +02:00
afde8e779b
[locale,keyboard] fix loading of keyboard locales
...
if keyboard locales should be loaded from a file also load the layouts
2024-09-18 21:17:21 +02:00
37271d01fa
Merge pull request #10634 from akallabeth/warn-fixes-cov
...
[utils,smartcard] return after free
2024-09-18 21:13:58 +02:00
98f2f69f60
[clang-tidy] deactivate bugprone-branch-clone check
...
The check triggers on switch cases running the same function and, more
importantly, on our macro CommandLineSwitchStart. Not usable for this
project, deactivating the check.
2024-09-18 16:14:55 +02:00
33a7bee4f9
Merge pull request #10617 from akallabeth/sdl-scope-guard
...
Sdl scope guard
2024-09-18 15:41:22 +02:00
c7c84682e1
[warnings] fix mismatched-dealloc
...
Some allocator functions have an error path where the corresponding free
function is called. Since the memory in the allocator function was
allocated using malloc/calloc the free function does not match. Silence
warnings with pragma macros
2024-09-18 15:35:28 +02:00
b4755a58dc
[utils,smartcard] return after free
...
In smartcard_ListReadersA_Call first free up memory and then return in
case of an error
2024-09-18 14:32:45 +02:00
c16e5ffcc2
Merge pull request #10631 from akallabeth/warn-fixes-cov
...
Warn fixes cov
2024-09-18 14:16:10 +02:00
fbbda2259d
[clang-tidy] deactivate cppcoreguidelines-pro-type-reinterpret-cast
...
we do noeed these casts for compatibility with C void* usage. Deactivate
this check to reduce noise.
2024-09-18 13:14:19 +02:00
fdd8a5cedd
[codec,progressive] fix result cast in progressive_rfx_srl_read
2024-09-18 13:14:19 +02:00
3905ef0b01
[client,sdl] split sdl_client_thread_run
...
the function can easily be split into three funcions covering a specific
part of the thread loop. Makes the whole thing less complex and easier
to read.
2024-09-18 13:01:46 +02:00
8ef4b2aefa
[client,SDL] move thread cleanup to own function
...
The cleanup code for the RDP thread of the SDL clients grew quite
complex. Move to a function to reduce complexity and make the main
thread more readable again.
2024-09-18 11:48:35 +02:00
b7601ec755
[client,SDL] remove goto usage, replace with RAII
...
* use std::uniqe_ptr to clean up malloced strings
* use ScopeGuard to run cleanup code whenever the function is exited
2024-09-18 11:48:35 +02:00
akallabeth