akallabeth
1b352bf09a
Merge pull request #10519 from akallabeth/warning-fixes-implicit-int
...
[warnings] fix implicit widening conversion
2024-08-29 11:42:14 +02:00
akallabeth
af813a0929
[cmake,clang-tidy] do not use explicit .clang-tidy
...
if not explicitly added the nearest .clang-tidy file to the compiled
source is used.
2024-08-29 11:18:36 +02:00
akallabeth
6a5d6d0514
[ci,clang-tidy] disable uninitialize va_list warning
2024-08-29 10:47:28 +02:00
akallabeth
15456e1ee1
[warnings] fix implicit widening conversion
2024-08-29 10:47:20 +02:00
akallabeth
4439240fd3
Merge pull request #10525 from akallabeth/warn-fixes-err33-c
...
[warnings] fix cert-err33-c
2024-08-29 10:35:57 +02:00
akallabeth
5443a934a9
Merge pull request #10529 from akallabeth/android-fix
...
Android fix
2024-08-29 10:20:12 +02:00
akallabeth
1d33095500
[warnings] fix cert-err33-c
...
Fix unused return values, cast to void if on purpose
2024-08-29 10:19:27 +02:00
akallabeth
622fcc7025
[warnings] fix types and guards
...
Fix some broken define guards and a wrong return type
2024-08-29 09:53:48 +02:00
akallabeth
1e24fcd9a4
[cmake,android] check compiler flags
...
Check -mfloat-abi=softfp supported before use. This workaround is for
older NDK versions that do not properly set this in the toolchain file.
Newer NDK versions changed compiler no longer supporting that flag.
2024-08-29 09:53:39 +02:00
David Fort
7503efed27
Merge pull request #10528 from akallabeth/winpr-perf
...
Winpr perf
2024-08-29 09:05:16 +02:00
akallabeth
3b8dc5c183
[cmake] move WITH_VERBOSE_WINPR_ASSERT
...
Since the definition is common to FreeRDP and WinPR move it to
CommonConfigOptions
2024-08-29 08:44:39 +02:00
akallabeth
efde29f362
[winpr,utils] Set Queue_Enqueue only once
...
In #10527 performance was measured and SetEvent did take a lot of time
in these measurements. The reset is only required once though, so use a
more fine grained trigger condition.
2024-08-29 08:30:32 +02:00
akallabeth
d0addb52bd
[winpr,utils] Reset CountdownEvent_AddCount only once
...
In #10527 performance was measured and ResetEvent did take a lot of time
in these measurements. The reset is only required once though, so use a
more fine grained trigger condition.
2024-08-29 08:30:21 +02:00
akallabeth
eeba99d73e
Merge pull request #10523 from akallabeth/autoreconnect-fix
...
[core,client] flush pending channel messages
2024-08-28 16:42:05 +02:00
akallabeth
380c5808a0
Merge pull request #10518 from akallabeth/clang-tidy-cleanup
...
Clang tidy cleanup
2024-08-28 16:36:16 +02:00
akallabeth
4ccfbc96ac
[core,client] flush pending channel messages
...
on disconnect flush all pending messages to avoid sending on reconnect.
2024-08-28 14:13:28 +02:00
akallabeth
de5b7c8e42
Merge pull request #10521 from akallabeth/warn-fix-uninit
...
[warnings] fix uninitialized variables
2024-08-28 11:12:11 +02:00
akallabeth
743c923ca7
Merge pull request #10516 from troyrollo/ssh-askpass-support
...
Add support for getting passwords from ssh-askpass
2024-08-28 11:11:35 +02:00
akallabeth
113810e45b
[ci,clang-tidy] use .clang-tidy file
2024-08-28 10:51:48 +02:00
Armin Novak
03449da9e9
[warnings] fix uninitialized variables
2024-08-28 10:46:40 +02:00
akallabeth
3c6f0491bf
Merge pull request #10520 from akallabeth/warn-init-variables
...
[warnings] fix cppcoreguidelines-init-variables
2024-08-28 10:45:14 +02:00
Armin Novak
3b1c1e0af1
[warnings] fix cppcoreguidelines-init-variables
2024-08-28 10:15:36 +02:00
akallabeth
8e4f9ad5ac
[utils,passphrase] do not check for SSH_ASKPASS
2024-08-28 10:14:06 +02:00
akallabeth
396b3b51b4
[utils,passphrase] format & clean code
2024-08-28 10:08:30 +02:00
Armin Novak
4a9018ab14
[clang-tidy] cleanup configuration
...
* Remove unknown AnalyzeTemporaryDtors
* Deactivate some tests contradicting our coding style
2024-08-28 10:01:22 +02:00
Armin Novak
d71af44bb1
[warnings] disable warnings for generated code
...
* Disable clang-tidy in test build directories
* Disable compiler warnings for test binary directories.
These contain generated code we can not change, so the warnings are just noise
2024-08-28 09:18:30 +02:00
akallabeth
6d994feef6
Merge pull request #10517 from akallabeth/uwac-fix
...
[uwac] remove broken function attribute
2024-08-28 09:05:59 +02:00
akallabeth
b0afe43d34
[uwac] remove broken function attribute
2024-08-28 08:50:17 +02:00
Troy Rollo
3f0000df0f
Add support for getting passwords from ssh-askpass
2024-08-28 13:44:21 +10:00
akallabeth
d6b7e90d69
Merge pull request #10514 from akallabeth/double-free
...
[channels,rail] fix use after free
2024-08-27 09:25:04 +02:00
Armin Novak
7aae7896ae
[channels,rail] fix use after free
2024-08-27 09:08:15 +02:00
akallabeth
f928f9465b
Merge pull request #10513 from hardening/freerdp_peer_new_fix
...
core: relax check in freerdp_peer_new
2024-08-27 08:41:49 +02:00
David Fort
f1b299c3e2
core: relax check in freerdp_peer_new
...
Not all socket kinds have the TCP_NODELAY option (especially local UNIX sockets),
so don't make the setsockopt fatal.
2024-08-26 19:53:49 +02:00
akallabeth
598746a26b
Merge pull request #10511 from akallabeth/rails-simplify
...
[channels,rail] simplify sending
2024-08-26 14:31:08 +02:00
akallabeth
7f13d1993d
[channels,rail] simplify sending
...
* Fix #5347 : Do not create useless copy of data to send.
2024-08-26 14:14:47 +02:00
akallabeth
00eb86970d
Merge pull request #10510 from akallabeth/serial-cleanup
...
Serial cleanup
2024-08-26 13:47:10 +02:00
akallabeth
7054b26916
[channels,parallel] compilation checks
...
* Only compile channel related command line if enabled
* Warn on unsupported platforms
2024-08-26 13:30:30 +02:00
akallabeth
387dabc4dd
[channels,serial] add CMake messages
...
Inform user about platforms that do not support serial redirection
2024-08-26 13:26:15 +02:00
akallabeth
1ec18ce827
[channels,serial] default to off on APPLE
2024-08-26 13:23:09 +02:00
akallabeth
050eef537a
[client,common] guard /serial argument
...
only enable if serial redirection support is compiled in
2024-08-26 13:21:13 +02:00
akallabeth
d08e44d883
[channels,serial] only build on linux
...
* Guard by CMake
* Remove code #ifdef to ease porting
2024-08-26 13:18:52 +02:00
akallabeth
f855fdc66a
Merge pull request #10509 from akallabeth/cmake-system-inc
...
[cmake] mark dependency includes SYSTEM
2024-08-26 12:40:10 +02:00
akallabeth
eb7d8fdeb0
[channels,serial] improve command line parsing
...
* Gracefully exit on invalid serial driver
* Gracefully exit on onvalid serial port flags
2024-08-26 12:37:03 +02:00
akallabeth
0b21fddef6
[channels,serial] improve IRP processing logging
2024-08-26 12:37:01 +02:00
akallabeth
df04e4c888
[channels,parallel] unify IRP processing logging
2024-08-26 12:36:58 +02:00
akallabeth
d81dd9d9ff
[winpr,comm] fix stopping of serial threads
...
Since most unhandled threads get cancelled do not rely on
SERIAL_EV_WINPR_WAITING flag.
2024-08-26 12:36:56 +02:00
akallabeth
221dd7ce1d
[winpr,comm] improve error handling
2024-08-26 12:36:51 +02:00
akallabeth
1ca069c771
[channels,serial] fix IrpThread handling
...
* Proper terminated threads cleanup
* Proper remaining threads termination on close
2024-08-26 12:35:54 +02:00
akallabeth
348ddf61c0
[channels,serial] delay IRP thread start
...
wait until irp_thread_func has completed before starting the thread.
This prevents a race condition when accessing the IRP structure which is
freed up once the thread terminates.
2024-08-26 12:35:51 +02:00
akallabeth
9f911bea62
[winpr,comm] cleanup comm_sercx2_sys
...
* WINPR_ASSERT arugments
* remove use of restricted keywords (variables/functions starting with _)
2024-08-26 12:23:14 +02:00
