Commit Graph

302 Commits

Author SHA1 Message Date
Marc-André Moreau
b8d60d5715 Merge branch 'master' of github.com:FreeRDP/FreeRDP 2014-05-10 10:59:56 -04:00
Marc-André Moreau
fb3662c7e2 winpr: fix ranlib missing symbols warnings on OS X 2014-05-09 22:44:19 -04:00
Hardening
50f1f0df6f Add some const modifiers
This allows these functions to be used with const buffers.
2014-05-09 22:36:50 +02:00
Marc-André Moreau
a202fe4057 freerdp: fix several type related warnings 2014-05-08 18:02:02 -04:00
Marc-André Moreau
4460a1a7cf libwinpr-utils: flush file after each write in wlog 2014-05-05 18:04:20 -04:00
Marc-André Moreau
c2a59c23a7 libfreerdp-core: fix potential crash on session redirection failure 2014-04-28 16:44:52 -04:00
Marc-André Moreau
b67288868d Merge branch 'master' of github.com:awakecoding/FreeRDP into fdsapi 2014-04-27 19:18:23 -04:00
Zhang Zhaolong
196f5315ae libwinpr: fix memory leak in case realloc() failed. 2014-04-26 11:32:51 +08:00
Zhang Zhaolong
66dfc4fd5b winpr: fix error malloc size. 2014-04-25 21:14:10 +08:00
Bernhard Miklautz
b817e92e5e cmake: mark required libraries for export 2014-04-23 10:16:02 +02:00
Hardening
ef11358668 Enhance ListDictonnary
This patch enhances ListDictionnary so that you can set callbacks for
keys and for values.
2014-04-18 18:26:04 +02:00
Hardening
6febe88026 Fixes for queue and stack
This patch does misc fixes in queue and stack:
* the *_new() were not handling OOM correctly ;
* the *_Contains() methods were not using the equals cb;
* the lock were not always taken when accessing internal members;
2014-04-18 16:27:51 +02:00
Marc-André Moreau
0059772efa Merge pull request #1789 from MartinHaimberger/mh-memfixes
Fixed misc leaks
2014-04-14 14:17:30 -04:00
Marc-André Moreau
edb3ad383e Merge pull request #1784 from hardening/collections_reallocs
Don't leak memory when realloc fails
2014-04-14 14:17:05 -04:00
Marc-André Moreau
d699128a57 channels/smartcard: add more debug output 2014-04-13 15:50:51 -04:00
Martin Haimberger
dd62e88098 fixed Wlog_Uninit to also free child logger 2014-04-11 02:23:16 -07:00
Hardening
31c77baba0 Don't leak memory when realloc fails 2014-04-09 21:53:42 +02:00
Marc-André Moreau
2c016bf2b0 Merge branch 'master' of github.com:FreeRDP/FreeRDP into smartcard 2014-04-09 10:41:05 -04:00
Hardening
36b4f20ff8 Fixes in case of OOM 2014-04-09 15:26:43 +02:00
Marc-André Moreau
2aa248853a channels/smartcard: cancel outstanding IRPs on re-initialization 2014-04-05 17:15:17 -04:00
Marc-André Moreau
8cdb3576c2 Merge branch 'master' of github.com:awakecoding/FreeRDP into smartcard
Conflicts:
	channels/smartcard/client/smartcard_main.c
2014-04-02 18:27:31 -04:00
Marc-André Moreau
64b550e18f libwinpr-utils: fix .ini parser whitespace trimming 2014-03-25 00:32:05 -04:00
Marc-André Moreau
43031d6b66 libwinpr-utils: improve .ini file parser 2014-03-24 22:41:30 -04:00
Marc-André Moreau
331209f02d libwinpr-utils: start new .ini config file parser 2014-03-24 18:20:34 -04:00
Marc-André Moreau
882f3098b3 libfreerdp-codec: add more NCrush tables, decode literals and CopyOffsets 2014-03-16 15:51:35 -04:00
Marc-André Moreau
c2d8486d8a libwinpr-utils: convert BitStream to macros 2014-03-11 22:17:31 -04:00
Marc-André Moreau
c686d434b7 libfreerdp-codec: initial RDP4/RDP5 MPPC compression test case success 2014-03-09 17:32:49 -04:00
Marc-André Moreau
d9a2fb4ff9 libfreerdp-codec: start MPPC compressor 2014-03-08 17:38:47 -05:00
Marc-André Moreau
dbe7e7aae2 libwinpr-utils: move BitStream functions to macros 2014-03-05 13:08:11 -05:00
Marc-André Moreau
3ba1d1ff4e libwinpr-utils: basic working UINT32-based bitstream implementation 2014-03-05 12:56:26 -05:00
Marc-André Moreau
3973775b69 libwinpr-utils: add MSB/LSB bit printing 2014-03-05 12:03:10 -05:00
Marc-André Moreau
2cd9649f37 libwinpr-utils: start new BitStream util 2014-03-04 18:15:03 -05:00
Marc-André Moreau
922624f5b4 Merge branch 'master' of github.com:awakecoding/FreeRDP into channels 2014-02-27 12:14:18 -05:00
Marc-André Moreau
019877da97 winpr: fix compilation on Windows 2014-02-26 13:35:49 -05:00
Marc-André Moreau
22fbf48109 libwinpr-utils: add synchronized version of HashTable 2014-02-13 22:25:30 -05:00
Marc-André Moreau
9668549fa4 Merge pull request #24 from MartinHaimberger/wlogimprovment
improved WLog
2014-02-12 06:54:20 -05:00
Marc-André Moreau
cdcd290c44 wfreerdp: fix most build warnings 2014-02-10 22:12:13 -05:00
Marc-André Moreau
5ff847a6e6 wfreerdp: fix multiple warnings 2014-02-10 01:06:11 -05:00
Marc-André Moreau
ad86d3c333 libwinpr-utils: add HashTable 2014-02-09 21:55:21 -05:00
Hardening
600047df4f Fix LinkedList_Remove
The previous version was setting to NULL both tail and head when
removing the head or tail item. That was corrupting the list.
2014-02-07 14:30:38 +01:00
Marc-André Moreau
80449cd2c5 libwinpr-memory: start stubbing 2014-01-31 18:27:58 -05:00
Martin Haimberger
65d7e17d4c improved WLog
childlogger use per default now a WLOG_LEVEL_INHERIT level
so the loglevel is taken from the first parent which has another level set.
2014-01-15 05:52:48 -08:00
Marc-André Moreau
f963491ebe libfreerdp-client: cleanup .rdp file parsing 2013-12-05 12:35:31 -05:00
Marc-André Moreau
84137cb76d libwinpr-utils: create wlog output directory 2013-12-04 23:46:58 -05:00
Marc-André Moreau
d9e1c0abaa libfreerdp-codec: add more planar unit tests 2013-11-29 02:16:16 -05:00
Marc-André Moreau
b0b8b6aa9e Merge branch 'master' of github.com:FreeRDP/FreeRDP 2013-11-12 12:59:41 -05:00
Armin Novak
4a1e9d2e4e Using new API for message queue. 2013-11-12 15:18:45 +01:00
Armin Novak
638d26569f Updated MessagePipe to new MessageQueue API. 2013-11-12 15:11:39 +01:00
Armin Novak
09d219b8d6 Added <MessageQueue_Clear> and custom handler argument to
<MessageQueue_New>.
2013-11-12 15:10:41 +01:00
Marc-André Moreau
70aed3fa85 libfreerdp-core: minor style cleanup 2013-11-08 13:57:41 -05:00
Marc-André Moreau
5536033a8a libfreerdp-core: transport refactoring 2013-11-07 17:37:58 -05:00
Marc-André Moreau
61f95fbe16 libfreerdp-core: transport code style cleanup 2013-11-07 15:14:59 -05:00
Marc-André Moreau
3c44ff9c83 channels/rdpsnd: fix bug in rdpsnd and rdpdr deinitialization 2013-11-06 14:31:33 -05:00
Marc-André Moreau
33a9694b45 Merge pull request #15 from MartinHaimberger/WLOGIMPROVEMENT
improved wlog
2013-11-06 10:56:30 -08:00
Marc-André Moreau
1dbf279212 channels/smartcard: refactor usage of lists and get rid of workarounds 2013-11-03 20:46:40 -05:00
Marc-André Moreau
55565e056c freerdp: export targets 2013-10-28 23:06:39 -04:00
Martin Haimberger
ad7be5a4ee improved wlog so new logger inhertit the loglevel
of the root logger
2013-10-25 05:41:01 -07:00
Marc-André Moreau
0417e552cf libwinpr-utils: fix bug in ListDictionary 2013-10-17 17:27:47 -04:00
Marc-André Moreau
490f18a7aa channels/rdpdr: don't use deprecated LIST util, use ListDictionary for faster lookups 2013-10-17 16:30:36 -04:00
Bernhard Miklautz
7c61b16da5 ListDictionary: added Remove_Head function
ListDictionary_Remove_Head removed the first object from the dictionary
and returns it's value.
2013-10-15 16:15:44 +02:00
Bernhard Miklautz
95bed71dbc ListDictionary: support for wObject added 2013-10-15 15:51:53 +02:00
Bernhard Miklautz
86e53aed9a ListDictionary_Remove: return value if removed
Update tests accordingly.
2013-10-15 15:49:57 +02:00
Marc-André Moreau
3d7d4c50db libwinpr-utils: fix IPv4 checksum and TCP sequence numbers with wlog packet messages 2013-10-09 16:37:45 -04:00
Marc-André Moreau
90b90ad496 libwinpr-utils: improve quality of data for reconstructed IP headers 2013-10-09 15:11:56 -04:00
Marc-André Moreau
7bdb63ad89 libwinpr-utils: initial wlog packet header reconstruction 2013-10-09 14:23:38 -04:00
Marc-André Moreau
166e3fbf2d libwinpr-utils: start reconstructing IP headers for wlog packet message 2013-10-09 13:37:53 -04:00
Marc-André Moreau
a3f0f4c8dc libfreerdp-core: started logging packets to pcap file 2013-10-08 23:43:57 -04:00
Marc-André Moreau
684db03578 libwinpr-utils: start implement wlog packet appender 2013-10-08 23:18:59 -04:00
Marc-André Moreau
07afc88878 libwinpr-utils: add some configurability to wlog with environment variables 2013-10-08 22:35:14 -04:00
Marc-André Moreau
a87e7deac4 libwinpr-utils: fix wlog build warnings 2013-10-08 19:39:03 -04:00
Marc-André Moreau
1ee2fa73cf Merge pull request #8 from MartinHaimberger/wlogfix
fixed memory leak in wlog
2013-10-08 15:54:09 -07:00
Marc-André Moreau
353816e050 Merge pull request #6 from MartinHaimberger/loglevel
Loglevel
2013-10-08 15:53:54 -07:00
Marc-André Moreau
e37981e57c libwinpr-utils: improved binary appender 2013-10-04 11:33:49 -04:00
Martin Haimberger
fea6d83367 fixed memory leak in wlog 2013-10-04 03:51:10 -07:00
Martin Haimberger
5e073f5f17 loglevel filtering fix 2013-10-03 06:32:12 -07:00
Marc-André Moreau
aaeb4ea0b2 libwinpr-utils: add wlog support for image and binary data 2013-10-02 15:41:46 -04:00
Marc-André Moreau
0569de167d libwinpr-utils: further split wlog framework into more source files, add some thread safety for write operations 2013-10-02 13:38:21 -04:00
Marc-André Moreau
3fb2724536 libwinpr-utils: fix default WLog behaviour 2013-10-01 20:45:20 -04:00
Marc-André Moreau
2684b829d0 libwinpr-utils: add simple parent/child hierarchy 2013-10-01 18:19:50 -04:00
Marc-André Moreau
0b29f72cc4 libwinpr-utils: added default file output path for wlog 2013-10-01 16:50:47 -04:00
Marc-André Moreau
a374525e6a libwinpr-utils: split wlog framework 2013-10-01 16:08:26 -04:00
Marc-André Moreau
10f1a898ef libfreerdp-client: fix command-line parsing with .rdp file 2013-09-17 17:03:35 -04:00
Marc-André Moreau
c0ba0fb337 libwinpr-utils: fix BufferPool test 2013-09-16 17:59:29 -04:00
Marc-André Moreau
518995a05e freerdp: merge with master 2013-09-16 17:10:27 -04:00
Marc-André Moreau
3b7994a9a6 Merge pull request #1467 from akallabeth/cmdline_enhanced
Cmdline enhanced
2013-09-16 13:33:04 -07:00
Marc-André Moreau
22ce171261 libwinpr-utils: added custom prefix formatter in logger 2013-09-16 16:30:49 -04:00
Marc-André Moreau
5386d5cd60 libwinpr-utils: make use of logMessage structure and macro for logging 2013-09-16 13:24:50 -04:00
Marc-André Moreau
a4c8d97b4c libwinpr-utils: start implementing FileAppender 2013-09-16 12:56:22 -04:00
Marc-André Moreau
af1ea7573c libwinpr-utils: start implementing ConsoleAppender 2013-09-16 12:05:08 -04:00
Marc-André Moreau
968ef14349 libwinpr-utils: introduce trace levels 2013-09-15 16:48:09 -04:00
Marc-André Moreau
6a8b5f2283 libwinpr-utils: start implementing WinPR logger 2013-09-15 15:46:02 -04:00
Armin Novak
21127ec33b Added a new flag to indicate the presence of a single not escaped argument
allowing the legacy command line <server>:<port> syntax.
2013-09-10 10:29:45 +02:00
Armin Novak
a7a7bab619 Fixed optional argument parsing. 2013-09-09 17:21:15 +02:00
Armin Novak
4274b266c0 Fixed command line parser, now printing help, if an invalid option is detected. 2013-09-09 16:07:14 +02:00
Armin Novak
07139276b5 Added newlines at end of file, prevents clang from crashing... 2013-09-05 12:14:35 +02:00
Armin Novak
62356e667c Fixed erroneous patch. 2013-09-05 12:14:34 +02:00
Armin Novak
e5c138a5b9 Fixed various memory leaks, allocation size issues and API misuse
warnings shown by clang as well as some compiler warnings.
2013-09-05 12:14:34 +02:00
Armin Novak
a3b531c036 Fixed issues found with clang-analyzer 2013-09-05 12:14:33 +02:00
Armin Novak
020bae25d7 Fixed coverity issue 1047594 2013-09-05 12:14:32 +02:00
Marc-André Moreau
d7656ada48 libfreerdp-codec: fix NSCodec encoding and buffer pool usage 2013-08-19 18:21:34 -04:00
Marc-André Moreau
317ffb2ca3 libwinpr-utils: backport fixed-size buffer pool inside variable size buffer pool 2013-08-19 17:14:24 -04:00
Marc-André Moreau
87593b4f19 Merge branch 'master' of github.com:FreeRDP/FreeRDP 2013-08-15 13:16:05 -04:00
Marc-André Moreau
efff23acb5 Merge pull request #1395 from richterger/client_redir
Fix memory corruption in client redirection
2013-08-15 10:15:11 -07:00
Marc-André Moreau
9f25c4fc25 libfreerdp-codec: initial working fragmented NSCodec encoder 2013-08-15 13:13:02 -04:00
Marc-André Moreau
c149ede6f2 libwinpr-utils: add support for variable size buffer pool 2013-08-15 00:01:42 -04:00
Marc-André Moreau
b972830841 libfreerdp-codec: make use of ObjectPool for tiles 2013-08-13 09:34:15 -04:00
Marc-André Moreau
f8e870a258 libwinpr-utils: implement asynchronous mode for ListDictionary 2013-08-12 17:48:32 -04:00
Marc-André Moreau
34f9985add freerdp: merge with master 2013-08-07 15:48:57 -04:00
Norbert Federa
3a58934eb2 libwinpr-utils: Use criticalsection with spincount
Use InitializeCriticalSectionAndSpinCount instead of IntializeCriticalSection.
Using spin counts for critical sections of short duration enables the calling
thread to avoid the wait operation in most situations which can dramatically
improve the overall performance on multiprocessor systems.

On Linux this change has no effect because the new winpr critical section
implementation does not use the SpinCount field under Linux because the NPTL
synchronization primitives are implemented using the extremely performant
futex system calls which have this magic already built in.

However, on Mac OS X this change improved the overall performance of the
multithreaded RemoteFX decoder by 25 percent.

I've used a SpinCount of 4000 which avoided 99 percent of the wait calls.
This value is also used by Microsoft's heap manager for its per-heap
critical sections.

Note: This change requires pull request #1397 to be merged.
2013-08-07 18:16:01 +02:00
richterger
505facbb6f Fix off by one problem in StreamPool allocation 2013-08-07 08:01:33 +02:00
Marc-André Moreau
13872f33bf libwinpr-utils: implement doubly-linked list 2013-08-05 17:29:14 -04:00
Norbert Federa
81ef251fc8 winpr: improve and fix locking for data structures
- Improved/completed(almost) winpr's critical section implementation
- Replaced WaitForSingleObject locking with critical sections

Note:
WaitForSingleObject should _never_ be used for granular low-contention
locks as it _always_ enters the kernel.

Just replacing WaitForSingleObject locking in Bufferpool with
EnterCriticalSection boosts the multithreaded rfx decoder
performance by almost 400% on win32.
2013-08-02 12:07:05 +02:00
Marc-André Moreau
b3265b6958 libwinpr-utils: implement ListDictionary 2013-07-05 18:23:26 -04:00
Marc-André Moreau
3fbc4f899f libwinpr-utils: fix deadlock in PubSub 2013-06-27 14:16:50 -04:00
Marc-André Moreau
fbf3208b0a libwinpr-utils: rename certain PubSub functions 2013-06-18 21:23:26 -04:00
Marc-André Moreau
508bae674b libwinpr-utils: improve PubSub with automatic strongly-typed helpers 2013-06-18 00:39:48 -04:00
Marc-André Moreau
e77d4657e4 libwinpr-utils: add PubSub multiplexing and synchronized access 2013-06-15 18:18:02 -04:00
Marc-André Moreau
95a129eb69 libfreerdp-client: start splitting termination and printing logic for CLI parsing 2013-06-15 15:13:38 -04:00
Marc-André Moreau
8ad532a9d4 libwinpr-utils: implement basic Publisher/Subscriber pattern 2013-06-15 13:32:13 -04:00
Marc-André Moreau
174d1bdd71 libwinpr-utils: start implementing Publisher/Subscriber pattern 2013-06-14 16:55:05 -04:00
Marc-André Moreau
2bd6808432 freerdp: merge with master 2013-06-05 10:31:01 -04:00
Daryl Poe
86156ce61f fix memory errors due to too-large memcpy in ArrayList 2013-06-03 09:30:14 -06:00
Marc-André Moreau
e8c5e6c70b libfreerdp-core: send using separate streams, re-enable frame acks 2013-05-15 18:05:40 -04:00
Marc-André Moreau
54281cac13 libwinpr-utils: grow stream by a factor of two 2013-05-15 16:22:58 -04:00
Marc-André Moreau
367ebf32a3 freerdp: make use of stream macros to access members 2013-05-15 12:14:26 -04:00
Marc-André Moreau
fdf3ddcf9e freerdp: purge deprecated stream utils 2013-05-08 17:48:30 -04:00
Marc-André Moreau
b4cac74136 xfreerdp-server: fix RemoteFX encoding 2013-05-01 18:15:55 -04:00
Marc-André Moreau
c49c235c93 libwinpr-utils: fix stream pool 2013-04-30 00:36:16 -04:00
Marc-André Moreau
83af4266bf libfreerdp-core: refactor fastpath fragmentation 2013-04-29 23:55:44 -04:00
Marc-André Moreau
51715636a5 freerdp: remove some deprecated stream utils 2013-04-29 22:35:15 -04:00
Marc-André Moreau
d04b76d005 libfreerdp-core: use stream pool 2013-04-12 13:44:23 -04:00
Marc-André Moreau
0fded8c2d0 winpr-utils: fix StreamPool 2013-04-12 12:20:20 -04:00
Marc-André Moreau
f94f90c08b winpr-utils: initial stream pool implementation 2013-04-11 21:59:02 -04:00
Marc-André Moreau
c65ee0c2f4 wfreerdp: fix build on Windows 2013-03-29 00:33:15 -04:00
Hardening
7701c9d934 Replace printf(...) by fprintf(stderr, ...) 2013-03-28 23:06:34 +01:00
Marc-André Moreau
8b9ea43d78 libfreerdp-core: fix locking with TS Gateway 2013-03-27 20:06:10 -04:00
Marc-André Moreau
690b5147db cmake: simplify android build 2013-03-23 18:13:10 -04:00
Marc-André Moreau
27dc85bed9 libwinpr-utils: add trio portable printf implementation 2013-03-21 21:30:31 -04:00
Marc-André Moreau
a8201b0d1b libwinpr-utils: combine old and new stream utils 2013-03-21 15:19:33 -04:00
Bernhard Miklautz
f6810fb138 Fixed warnings for 32 bit builds 2013-03-15 22:49:25 +01:00
Bernhard Miklautz
103171a98e Fixed compiler warnings (-Wall) 2013-03-15 20:41:10 +01:00
Bernhard Miklautz
e8eb0d0b44 Fixed formating build warnings (-Wformat) 2013-03-15 20:03:48 +01:00
Martin Fleisz
b5ffa2f8ae iOS: Compile fix 2013-03-13 15:12:44 +01:00
Martin Fleisz
96a2717b3c iOS: Compile fixes (Fixed #1069, #1086) 2013-03-13 15:08:45 +01:00
Christian Hofstaedtler
8833c14eac fix ArrayList_Shift for args (al, 0, -1)
As a result, this should fix #1051.
2013-03-12 23:21:42 +01:00
Marc-André Moreau
ea63fdb18e libwinpr-utils: start custom printf replacement 2013-02-28 15:43:57 -05:00
Marc-André Moreau
9873ce28d0 libwinpr-utils: experiment with printf replacement 2013-02-28 08:41:51 -05:00
Marc-André Moreau
fe34a529d5 freerdp: fix build and warnings on Mac OS X 2013-02-21 21:09:42 -05:00
Marc-André Moreau
082e069913 libwinpr-utils: initial MessagePipe implementation 2013-02-20 14:48:32 -05:00
Marc-André Moreau
5e8d35c4ac channels/rdpsnd: use MessageQueue 2013-02-19 22:36:04 -05:00