Commit Graph

554 Commits

Author SHA1 Message Date
akallabeth bb242b9a89
[return checks] fix use of WaitForSingleObject 2024-09-16 08:22:37 +02:00
akallabeth 965d231e49
[return checks] fix use of CloseHandle 2024-09-16 08:22:31 +02:00
akallabeth 94020c183c
[return checks] fix use of ResetEvent 2024-09-16 06:48:09 +02:00
akallabeth 7d67b8e204
[return checks] fix use of SetEvent 2024-09-16 06:47:58 +02:00
akallabeth f7726ed7b6
[server,shadow] improve command line error logging
print an error message indicating where the parsing failed.
2024-09-15 09:21:38 +02:00
akallabeth ba41d5e532
[warnings] fix unchecked return 2024-09-15 09:08:02 +02:00
akallabeth adc4f2abf8
[warnings] fix unused variables 2024-09-12 13:29:58 +02:00
akallabeth 11671bcd5b
[warnings] fix unreachable code return 2024-09-11 20:50:24 +02:00
akallabeth a1be46e5dd
[warning] fix function declarations
use same names in declaration and implementation
2024-09-11 20:50:21 +02:00
akallabeth 749023bacb
Merge pull request #10555 from akallabeth/cast-fix-tls
[crypto,tls] simplify function pointer cast
2024-09-05 17:18:27 +02:00
akallabeth 9ae37b094f fix implicit widening of multiplication result 2024-09-04 22:01:09 +02:00
akallabeth 6a1c3b4545
[function pointer] use macro for GetProcAddress
Cast all results of GetProcAddress with WINPR_FUNC_PTR_CAST
2024-09-04 21:31:48 +02:00
akallabeth 5e123735fa
[warnings] fixed sign-compare 2024-09-04 10:14:05 +02:00
akallabeth 9a027833b9
[warnings] fix misplaced widening cast 2024-09-03 17:40:55 +02:00
akallabeth 5a4a1a40ad
fix declaration and implementation parameter names 2024-09-03 12:24:53 +02:00
akallabeth 24cd7828c9
[warnings] fix clang-tidy issues in server 2024-08-29 15:20:42 +02:00
akallabeth 9c9d74e920
[warnings] fix redundant casts 2024-08-29 12:03:09 +02:00
akallabeth 15456e1ee1
[warnings] fix implicit widening conversion 2024-08-29 10:47:20 +02:00
akallabeth 1d33095500
[warnings] fix cert-err33-c
Fix unused return values, cast to void if on purpose
2024-08-29 10:19:27 +02:00
akallabeth 56d660f258
[cmake] mark dependency includes SYSTEM
Mark all dependency include paths SYSTEM so warnings from system headers
are excluded from ci warning statistics
2024-08-26 11:10:49 +02:00
Armin Novak 1f83198bb1
[server,shadow] send BitmapUpdate with single rectangle
See https://github.com/FreeRDP/FreeRDP/issues/10413

Microsoft ditched support for RFX and multiple rectangles in BitmapUpdate for
windows 11 24H2.

So send all updates only with a single rectangle.
2024-08-08 08:37:51 +02:00
Armin Novak 62eba8dacb
[server,shadow] fix NSCoded and SurfaceBitsCommand 2024-07-24 21:54:46 +02:00
Armin Novak d757dfee24
[server,shadow] Fix RFX SurfaceBitsCommands
* Use RLGR mode from settings (might be overwritten by client)
* Only send RFX SurfaceBits if SURFCMDS_STREAM_SURFACE_BITS was set in
  capabilities
2024-07-24 21:54:36 +02:00
Armin Novak dbfa447f67
[server,shadow] allow RFX and NSC to be disabled 2024-07-24 09:30:52 +02:00
akallabeth 23295dc386
[server,shadow] add option to disable GFX 2024-07-23 16:38:30 +02:00
Armin Novak 68a081f538
[server,shadow] fix XShm library name 2024-07-03 15:52:34 +02:00
akallabeth 00e15e736c
[server,shadow] optimize image comparison
Implement per format comparison functions
2024-07-02 08:06:18 +02:00
Armin Novak 1806daa375
[channel,server] fix unguarded use of functions
If functions of channel_<name>_server are used guard them so the code
compiles if the channel is not compiled in.
2024-06-12 09:58:08 +02:00
akallabeth 7aa72a7507
[core,settings] unify configuration paths
* Add new function freerdp_settings_get_config_path to get current
  user configuration directory
* Add CMake option WITH_FULL_CONFIG_PATH (default OFF): If defined, use
  <appdata>/Vendor/Product as config directory, otherwise use
  <appdata>/vendor (lowercase, only if vendor equal to product)
2024-06-06 11:31:22 +02:00
akallabeth 1b3f3a0408
[codec,color] expose freerdp_image_copy (no)overlap
expose functions for overlapping and non overlapping images to use
directly
2024-05-23 14:48:36 +02:00
Konstantin Kharlamov 4900b15391 shadow: mention in "help" output that auth defaults to "required"
It's marked as "off" currently but it is "on" by default.
2024-04-19 08:36:05 +02:00
Armin Novak f98e459833 [coverity] 1543936 Missing unlock 2024-04-15 12:40:01 +02:00
Armin Novak ffa8029883 [coverity] 1543186 Data race condition 2024-04-15 11:30:31 +02:00
Armin Novak 09060a9a49 [coverity] 1543072 Data race condition 2024-04-15 11:30:31 +02:00
akallabeth c831717cb0 [coverity] 1543129 Uninitialized scalar variable 2024-04-11 12:04:07 +02:00
akallabeth 1473931ecd [coverity] 1543220 Double free 2024-04-11 12:04:07 +02:00
akallabeth 678ff144ab [cmake] unify windows resource file generation
* use a macro to add resource files for executables and shared libraries
* use that macro to declare targets
* use that macro to set library/binary versioning
* use that macro to set target output name
* use a macro to create manpages and names
2024-03-20 11:17:18 +01:00
akallabeth bdd866c3d3 [server,shadow] cast incompatible pointer
the context pointer to WTSOpenServerA is intentional, cast to LPSTR to
match definition
2024-03-18 13:27:32 +01:00
akallabeth 938e1ca2f1 [server,shadow] initialize subsystem->format before use 2024-03-05 10:03:23 +01:00
akallabeth 9268cee35e [server,shadow] shadow_subsystem_pointer_convert_alpha_pointer_data
the function uses implicit color formats. Replace this with the function
shadow_subsystem_pointer_convert_alpha_pointer_data_to_format with
explicit source color format.
Deprecate the old function.
2024-03-05 10:03:23 +01:00
akallabeth fe149f3f57 [server,shadow] deprecate shadow_capture_compare
the function uses implicit color format layout, so move to a version
with explicit format layout.
2024-03-05 10:03:23 +01:00
akallabeth 730d67c7e3 [server,shadow] add WINPR_RESTRICT to comparison
shadow_capture_compare_with_format and shadow_capture_compare always
operate on distinct memory areas. Allow better optimization of
operations with the WINPR_RESTRICT keyword
2024-03-05 10:03:23 +01:00
akallabeth e4a0746cdc [server,shadow] detect changes no alpha
add shadow_capture_compare_with_format no alpha comparison option. If
not both, source and destination have alpha, just ignore it.
2024-03-05 10:03:23 +01:00
nin dc4bd6609b [server,shadow] add image format support for capture
when capturing bitmap data take the source image format into account on
copy and compare.
2024-03-05 10:03:23 +01:00
akallabeth c61fc2a0fa [server,shadow] improve shadow help and startup checks
a SAM file is required for the shadow server to work if NLA is
activated. Better document that and abort startup if no file is
available.
2024-02-26 20:59:39 +01:00
akallabeth d7ebec5a65 [tidy] move loop variable declaration to loop 2024-02-22 12:31:50 +01:00
akallabeth 81d2c1f057 [clang-tidy] clang-analyzer-core.NullDereference 2024-02-15 11:49:16 +01:00
akallabeth 0ba995655d [clang-tidy] cppcoreguidelines-init-variables 2024-02-15 11:49:16 +01:00
akallabeth 207def5c56 [clang-tidy] readability-isolate-declaration 2024-02-15 11:49:16 +01:00
akallabeth ba8cf8cf21 [build] fix Wmismatched-deallocator warnings
With custom malloc function attributes the fail path in the _New
functions produces warnings due to allocator mismatches. Silence them.
2024-02-05 08:16:55 +01:00