mirrors
/
FreeRDP
mirror of https://github.com/FreeRDP/FreeRDP
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

[coverity] 1543186 Data race condition

This commit is contained in:
Armin Novak 2024-04-15 09:55:11 +02:00 committed by akallabeth
parent e4498df607
commit ffa8029883
1 changed files with 13 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

27
server/shadow/shadow_lobby.c
View File

@ -27,9 +27,9 @@
BOOL shadow_client_init_lobby(rdpShadowServer* server)
{
BOOL rc = FALSE;
int width = 0;
int height = 0;
rdtkEngine* engine = NULL;
rdtkSurface* surface = NULL;
RECTANGLE_16 invalidRect;
rdpShadowSurface* lobby = server->lobby;
@ -37,17 +37,14 @@ BOOL shadow_client_init_lobby(rdpShadowServer* server)
if (!lobby)
return FALSE;
if (!(engine = rdtk_engine_new()))
{
return FALSE;
}
rdtkEngine* engine = rdtk_engine_new();
if (!engine)
goto fail;
if (!(surface =
rdtk_surface_new(engine, lobby->data, lobby->width, lobby->height, lobby->scanline)))
{
rdtk_engine_free(engine);
return FALSE;
}
EnterCriticalSection(&lobby->lock);
surface = rdtk_surface_new(engine, lobby->data, lobby->width, lobby->height, lobby->scanline);
if (!surface)
goto fail;
invalidRect.left = 0;
invalidRect.top = 0;
@ -77,9 +74,11 @@ BOOL shadow_client_init_lobby(rdpShadowServer* server)
rdtk_surface_free(surface);
rdtk_engine_free(engine);
region16_union_rect(&(lobby->invalidRegion), &(lobby->invalidRegion), &invalidRect);
LeaveCriticalSection(&lobby->lock);
return TRUE;
rc = TRUE;
fail:
rdtk_engine_free(engine);
return rc;
}