Resolves#6654. To note, AFAICT, this code block should never be executed.
However, I did feel comfortable removing it, in case the location of Trash
is relocated in the future.
* The user of an editor needed knowledge about the editor in order to make
use of it.
* Furthermore, the BPartitionParameterEditor exposed type specific
functionality that it shouldn't know anything about, either.
* We may now define a number of known parameters per editor type; right now
there is only "type" as it's needed by DriveSetup.
* Adapted all disk systems, and DriveSetup to the new API.
* Renamed CreateParamsPanel, and InitializeParamsPanel to *ParametersPanel
in DriveSetup.
* They now share a common base class AbstractParametersPanel.
* The default width will no longer make the parameters and partition type
columns visible.
* Fixed default size of those two columns -- I did not notice that the column
state was being restored before, and thought it would just be another oddity
of BColumnListView :-)
* Since MainWindow maintains its size pretty much itself, the constructor no
longer gets a BRect.
* The window will now also be resized vertically to make space for all the
partitions (only affects first launch without settings file).
* Also made the window a bit higher by default.
This fixes problem with B_MOUSE_DOWN messages produced by Thinkpad
TrackPoint buttons. Those messages have 'clicks' parameter always
equal to zero. Solution was suggested by korli. Thanks!
Fixes#8978
Signed-off-by: Siarzhuk Zharski <zharik@gmx.li>
...instead of the current workspace screen mode that we are switching from.
Fixes#9415
Also don't ignore the returned the status code when updating the screen mode.
* Since <em> is used for parameters we can't use it for emphasis.
* Add \a in a few places it was missing to indicate a parameter.
* Change \a to a \c in one instance, param -> constant.
* Lots of whitespace fixes, most just deleting leading tabs.
* Don't indent code blocks, they should be flush to left since any
indentation is preserved in the output.
key.first is a pointer, so we shouldn't use the & operator here.
CID 610870 and 610871.
Should also fix ticket #9184. At least I cannot reproduce it anymore.
* Original changes by Bill Randle
* Includes a large number of modifications
and cleanups.
* Add a "currentMode" to the gDisplay to
enable easier checking of intended changes.
(we pass the display_mode around quite a
bit, adding a "currentMode" allows code
to know the intended display mode being set
without passing the mode pointer around as
much)
* Instead of guessing whether or not to show the InitParamsPanel, the panel
will now no longer show itself if the disk system does not have an editor,
and silently succeed.
* This also fixed a potential crash if the editor could not be created for
some reason.
* Minor cleanup.
* The AHCI driver was actually ignoring sector size information, and always
set the size to 512.
* Now both, the AHCI driver, and the ATA bus manager, use the same method of
retrieving the sector count, and size.
This removes the solution with no convincing replacement,
and breaks most basic window management tasks such as raising a window when clicking it.
Please come back when you get the issues fixed and a real alternative to the "ugly" border highlighting.
This reverts hrev45197-45202.
* edid1_detailed_timing_raw was missing
a field which threw off the sync bits.
* The result was the monitor will receive
a different sync polarity than it requested.
Most monitors handle this, but it is still
a bug
* The header and table is now correctly written; the backup is still
missing, though.
* The Header class is now responsible for both, the primary, and the
backup header.
* Changed the Header constructors: the block is no longer needed. Also,
under GCC 4 the initialization code accidentally used the read
Header constructor.
* Fixed incorrectly copied GUID - the static_guid cannot be copied
into a guid_t directly.
* Fixed copy&paste bug that would overwrite the offset for the child
partition to be created.
* With all of this in place I successfully created a BFS partition
with a GUID partition table. However, I have not yet tested if other
systems can still read this. Also, creating two partitions doesn't
seem to work yet, either (luckily I only need a single one ;-)).
* Tried to use EFI::Header class, but there doesn't seem to be an easy
way to actually hit the disk -- which we'll have to do to find out
how large the GPT table is.
* Initialization of GPT disks is now working which is why I added the disk
system add-on to the image. However, there is a caveat, as the backup
header and table aren't written yet.
* Partitions can be deleted.
* Creating partitions does not work yet, but I don't know yet why; in
theory it could already work.
* Moved some functionality into their own files so that they can easily
be reused by other code.
* Added crc32() function from FreeBSD. Implemented CRC handling and
validation.
* Implemented missing write functionality.
