- The text was not centered because it was not taking into account the left
offset of the text rendering, which can be gotten from the left value of the
rect returned by GetBoundingBoxesForStrings. I'm pretty sure this was 0 on
BeOS, so there might be problems with our GetBoundingBoxesForStrings. It
doesn't make sense for flat edged glyphs like D and N to be offset. But
nonetheless taking into account that left offset centers the text in this
screensaver. This fixes#4261.
- The text rendering also could look weird because the low color was not set to
blue. Again I'm pretty sure this was not a problem on BeOS, but could be
related to the new subpixel AA rendering. Setting the low color fixes this
and therefore fixes#4252.
- To avoid any weird repaint issues in the ScreenSaver preferences preview
view, the whole background is painted every frame now.
- I also added an escapement_delta member which is used for both the
GetBoundingBoxesForStrings call and the eventual text rendering. This may be
pointless, but it is probably more consistent.
Other changes:
- This now makes use of the new settings view private function.
- I made the coding style compliant with our latest guidelines (I think I got
most of the big ones at least.)
- Removed the references to the old BeOS screen saver kit stuff from the
Jamfile.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@33404 a95241bf-73f2-0310-859d-f6bbb57e9c96
- Make the BuildScreenSaverDefaultSettingsView function be built into
libscreensaver.so and under the BPrivate namespace. This avoids the repetition
of the compiled code in each screen saver that uses it.
- Updated the ScreenSaver preferences to use this.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@33403 a95241bf-73f2-0310-859d-f6bbb57e9c96
- Added use of the new BuildScreenSaverDefaultSettingsView function (this is
basically the same code.)
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@33402 a95241bf-73f2-0310-859d-f6bbb57e9c96
-Added grist to the sourcecode files sent to collectcatkeys to avoid mixups
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@33401 a95241bf-73f2-0310-859d-f6bbb57e9c96
default look for the settings of screen savers without complicated settings
views. This is based on the code originally in the ScreenSaver preferences
window.
Also fixed a type in the ScreenSaverRunner header.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@33400 a95241bf-73f2-0310-859d-f6bbb57e9c96
identify an element. We use the name string of the TypeComponent as index path.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@33395 a95241bf-73f2-0310-859d-f6bbb57e9c96
element in a multi-dimensional array, featuring conversion from and to string.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@33393 a95241bf-73f2-0310-859d-f6bbb57e9c96
Meanwhile, let's replace it with a classical glgears one.
BTW, we need an icon for this preflet, currently it's the Network preflet one!
People more fluent with Icon-O-Matic than me (aka everybody) are welcome.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@33390 a95241bf-73f2-0310-859d-f6bbb57e9c96
code is no longer loaded, e.g. when the module has been unloaded or the tracing
buffer was reattached from a previous session.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@33389 a95241bf-73f2-0310-859d-f6bbb57e9c96
monolithic vmware images as produced by the build system (by registering such
an image via the "diskimage" tool).
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@33388 a95241bf-73f2-0310-859d-f6bbb57e9c96
* Added new header headers/private/system/disk_device_types.h, which defines
the <DiskDeviceTypes.h> constants as macros and which can be used where the
constants cannot be used. The constants are defined using the macros, so now
there's only one place where the string literals should be specified.
* Use the macros in the partitioning systems. I was too lazy to also adjust the
file systems -- most of them seem to hard-code the string literal yet.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@33386 a95241bf-73f2-0310-859d-f6bbb57e9c96
- Fixed vfs_get_vnode_from_fd() return type.
- Added vfs_open_vnode().
- Added a "bool traverseLeafLink" parameter to vfs_get_fs_node_from_path().
It was always resolving symlinks.
* device manager/devfs:
- devfs: get_node_for_path() no longer resolves leaf symlinks. That still
doesn't help with file disk devices, as creating partition wouldn't work
anyway.
- Pulled the module-related implementation part of BaseDevice into new class
AbstractModuleDevice and made all methods of BaseDevice virtual. Small
adjustments to devfs to be happy with the new BaseDevice interface.
- Added BaseDevice subclass FileDevice, which maps the interface to a file's
file descriptor. Still got a few TODOs, but should basically work.
- Use FileDevice for publishing file disk devices in devfs. Now those do
actually work, though there's some BFS trouble with one of the images I
tested.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@33385 a95241bf-73f2-0310-859d-f6bbb57e9c96
as disk devices. It also demonstrates that the respective devfs functionality
is utterly broken.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@33384 a95241bf-73f2-0310-859d-f6bbb57e9c96
-Re enabled the translation of the About alert in bluetooth, as it now works fine. This means you have to update the bluetooth cataogs...
-Updated the french bluetooth catalog accordingly.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@33375 a95241bf-73f2-0310-859d-f6bbb57e9c96
Patch by titer : fix build on PPC host by not messing up the fingerprint endianness
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@33374 a95241bf-73f2-0310-859d-f6bbb57e9c96
also providing Lock() and Unlock(). Applied public header style.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@33367 a95241bf-73f2-0310-859d-f6bbb57e9c96
It is good practive to #undef this before every definition,
due to how the ExtractCatalogEntries jam-rule works.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@33360 a95241bf-73f2-0310-859d-f6bbb57e9c96
