Clemens Zeidler
94892dc091
Make arguments const if appropriated. Style issues and port_id error check. Thanks Stippi.
...
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38214 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-17 22:54:00 +00:00
Oliver Tappe
e0ef64750f
* fix #6373 by switching the BD... macros to take the address of corresponding
...
constants, which had to be defined in several places in order to be available
in the kernel addons, network protocols and the server/kit.
* enable -Werror for all servers
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38213 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-17 21:46:32 +00:00
Clemens Zeidler
7640bbb6cd
Fix coding style.
...
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38212 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-17 21:35:16 +00:00
Clemens Zeidler
488c90defe
Fix style issues, thanks Axel.
...
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38211 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-17 21:15:13 +00:00
Stefano Ceccherini
42f0a4a120
Fixed build after Layout api change (hopefully the fix is correct)
...
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38210 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-17 20:09:25 +00:00
Axel Dörfler
9189743037
* Style cleanup.
...
* Made an enum out of the mailbox type.
* Rearranged some code to get rid of CID 1328 which was not a bug, though.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38209 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-17 19:07:16 +00:00
Alex Wilson
352fb78f1f
Fix Gcc4 build error from my previous commit.
...
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38208 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-17 19:04:45 +00:00
Alex Wilson
1d6c7b6cb6
Big change deriving BLayout from BLayoutItem, and allowing viewless BLayouts.
...
a few highlights:
* BLayout now derives publicly from BLayoutItem
* Added BAbstractLayout class, which our layouts now derive from
* updated layout builders to avoid creating views when they don't need to
* updated layout classes
* updated AboutSystem to fix a little regression
* more details on #6407
* please tell me about any regressions, I've tried to find them all, but some
may have slipped by.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38207 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-17 18:43:41 +00:00
Axel Dörfler
0f274fd5b2
* Calmed down CID 1976; the problematic situation should not be able to occur,
...
but I've changed it anyway to make the code clearer.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38206 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-17 18:22:17 +00:00
Oliver Tappe
77d9a1e9bc
* of course, gcc4 had more issues with the Joystick preflet
...
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38205 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-17 18:08:38 +00:00
Oliver Tappe
f3e4c16e4c
* fix warning to get really all preflets compilable
...
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38204 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-17 18:03:12 +00:00
Oliver Tappe
8f62243f37
* fix warnings in Keymap preflet about hidden virtual by renaming SetFont()
...
to SetBaseFont() (and fFont to fBaseFont)
* enabled -Werror for all preflets
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38203 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-17 17:37:15 +00:00
Alex Wilson
1fd91b7ffd
Small compilation fixes for coming layout changes... (really!!)
...
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38202 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-17 17:11:11 +00:00
Oliver Tappe
e0ae658ae2
* style adjustments - no functional change
...
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38201 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-17 16:53:25 +00:00
Oliver Tappe
1195f511e5
* style adjustments - no functional change
...
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38200 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-17 16:47:14 +00:00
Oliver Tappe
37cebf6883
* fixed all warnings in FileTypes preflet and enabled -Werror
...
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38199 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-17 16:41:28 +00:00
Alex Wilson
1f1606e745
Update DataTranslations to use BGroupLayout and BGridLayout instead of BALMLayout. This works around a regression with some changes I'll be committing soon, although I'd still like to find the source of it... Also do some style cleanup and remove fTranslatorNameView var which was never actually displayed.
...
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38198 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-17 16:39:02 +00:00
Oliver Tappe
54123ac0e8
* style adjustments - no functional change
...
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38197 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-17 16:25:45 +00:00
Axel Dörfler
87de0cb4e1
* Fixed CID 1199-1202: only call the cache listener in case the open succeeded
...
(this might also have derefenced a potentially freed vnode).
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38196 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-17 16:15:45 +00:00
Axel Dörfler
297e601d68
* Fixed CID 1293: a vnode reference, and the cookie could be leaked.
...
* Minor cleanup.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38195 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-17 16:08:50 +00:00
Axel Dörfler
6dcca7f6ab
* Fixed CID 1472: "next" could be NULL and dereferenced.
...
* Simplified code a bit.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38194 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-17 15:39:26 +00:00
Axel Dörfler
ed64d4e0f5
* Fixed CID 1511: protocol could be NULL.
...
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38193 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-17 15:34:24 +00:00
Adrien Destugues
d18fc3994c
Patch by rossi, but I ended u rewriting half of it :
...
* Save terminal windows positions
* Also save their size and workspace, but these aren't used (size is overriden by the menu setting and workspace is annoying)
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38192 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-17 15:29:08 +00:00
Axel Dörfler
579e19f5b9
* Fixed CID 1703: buffer could be leaked. Thanks to Stefano for the note.
...
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38191 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-17 15:21:39 +00:00
Oliver Tappe
9602d07543
CID-1512: ensure that label is never dereferenced while being NULL
...
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38190 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-17 15:02:37 +00:00
Adrien Destugues
26411b5359
* Remove legacy BeOS code
...
* Ensure the argument list passed to execve is NULL-terminated
* Also declare it earlier to make sure gcc4 doesn't erase it from memory when getting out of the if block.
This *should* fix gcc4 Terminal, and *does not* break it under gcc2.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38189 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-17 15:02:10 +00:00
Oliver Tappe
2655efc395
Fixes to Notifications preflet
...
* CID-1501: protect against dynamic_cast potentially returning NULL
* additional style fixes
* fixed all warnings and enabled -Werror
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38188 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-17 14:56:51 +00:00
Oliver Tappe
6137279338
CID-639: Protect against FindItem() potentially returning NULL
...
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38187 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-17 14:42:14 +00:00
Oliver Tappe
529fd9af5d
Fixed all warnings in Shortcuts preflet and enabled -Werror for it
...
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38186 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-17 14:35:28 +00:00
Oliver Tappe
ef9095fbe2
* CID-1742: delete SortArray when we are done using it
...
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38185 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-17 14:07:33 +00:00
Oliver Tappe
6effcf12f2
* CID-1741: remove useless piece of code that did nothing but leak the label
...
* don't check against NULL before deleting fLabel
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38184 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-17 13:56:23 +00:00
Adrien Destugues
f7502de1bb
Look for catkeys files with .catkeys extension instead of .txt, since that's what everyone uses.
...
It makes it easier and less confusing to test catalogs without linking them.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38183 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-17 13:49:52 +00:00
Axel Dörfler
b250dfdf26
* The ActivityMonitor now uses the new network C++ API to retrieve the
...
interface stats. This fixes bug #6457 .
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38182 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-17 11:57:01 +00:00
Axel Dörfler
3f7e748f91
* Made the code a bit more robust against faulty use.
...
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38181 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-17 11:45:56 +00:00
Axel Dörfler
ed18d7cf71
* Initialized the domain_datalink's first_{protocol|info} members. This fixes
...
the crashing bug reported by Atis when trying to add an interface which fails
(the bug causing this has already been fixed with the previous commit).
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38180 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-17 11:45:26 +00:00
Axel Dörfler
75b83073c2
* Getting an address leaked a reference. This fixes that interfaces could not
...
really be deleted (a reference of them was kept in memory).
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38179 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-17 11:43:22 +00:00
Axel Dörfler
7e046eab3b
* UDP really wanted to make sure that the error buffer was freed, and just did
...
it once more. This should be the final nail on bug #6446 .
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38178 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-17 09:51:22 +00:00
Axel Dörfler
a690e25952
* BNetworkInterface must adopt the family from the address, if possible. This
...
should fix "ifconfig" for IPv6.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38177 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-17 09:15:33 +00:00
Adrien Destugues
f230f68b3b
CID 1332 : NULL pointer dereference.
...
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38176 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-17 08:27:20 +00:00
Adrien Destugues
28a4c1b470
CID 1513: NULL pointer dereference.
...
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38175 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-17 08:16:09 +00:00
Adrien Destugues
bd792754f1
CID 1396: NULL pointer dereference.
...
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38174 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-17 08:05:12 +00:00
Adrien Destugues
6709e6bcb8
Refactor default shell handling so it is done in a single place for a new windows and a new tab.
...
Use "/bin/sh -l" as the default command, and always pass -l ('login shell') to the user selected shell.
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38173 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-17 07:53:58 +00:00
Clemens Zeidler
e71b4c11de
Add a simple BWindowStack test app.
...
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38172 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-17 06:50:35 +00:00
Clemens Zeidler
5836cd75c2
Add a BWindowStack interface class. Please review if adding a BWindowStack as a friend of BWindow in Window.h is ok.
...
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38171 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-17 06:47:26 +00:00
Clemens Zeidler
19f43b9f6a
SATDecorator implements event handling and handles the stacking api requests.
...
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38170 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-17 06:41:35 +00:00
Clemens Zeidler
c0494bc592
Add facility to communicate with the desktop listener over an app server link. The ServerWindow dispatch the message to the DesktopObservable which dispatch it to the correct listener.
...
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38169 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-17 06:25:55 +00:00
Clemens Zeidler
b8a44a250e
Add function to find a window in the app server by the client looper port id. Need this for the stacking api e.g. to stack window x on window y.
...
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38168 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-17 06:23:06 +00:00
Clemens Zeidler
38d80987f3
Add PortLinkRef class which use a existing sender and receiver for communication. Suggestion for a better name?
...
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38167 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-17 06:12:30 +00:00
Clemens Zeidler
4667e77fe1
Set a more reasonable Variable range then the default one ([0, inf)).
...
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38166 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-17 05:34:12 +00:00
Oliver Tappe
803a1f70aa
* Refresh() should make sure to try and load both "locale" and "timezone"
...
settings, not give up when one is missing (like on a fresh image)
* try harder to fallback to proper default values when loading the locale
settings file fails
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38165 a95241bf-73f2-0310-859d-f6bbb57e9c96
2010-08-16 22:48:00 +00:00