Introduce a function to generate the string representation of a bitrate
(kbps, mbps, gbps, etc..)
* Factor out the code from MediaPlayer InfoWindow
* Allow different bases (/1000 or /1024)
Based on printf debugging the correct left value is actually -1, not 0, but
instead of hard-coding numbers it makes more sense to use the existing value.
I'm not sure if a -1 left value makes much sense, but overall this seems to
work and does not have the scrolling artifacts.
But overall I think ShowImage needs more layout management. Doing all this
moving and resizing manually is error prone.
Fixes#8648.
* Extract the scrollbar change based on the mouse wheel delta into a protected
method of BView.
* Call that method from BScrollBar's MessageReceived.
With this change it is now a bit easier to scroll horizontally around the
system by putting the mouse cursor over a horizontal scrollbar and using the
wheel.
Fixes#8631.
After coming back from fullscreen mode, horizontally scrolling a zoomed
image would draw vertical lines from the right border. Seems like an
off-by-one issue. This fixes it in my tests... hope it's properly done.
If you've zoomed in fullscreen mode and moved the mouse to the top of the
screen, the toolbar didn't appear. You had to scroll up to the top of zoomed
image first. Using the screen coords instead of the view coords fixes this.
As the downloadable files are now hosted on haiku-files.org and the user is
presented the Intel license at the beginning of the script, the function
OpenIntelFirmwareWebpage is unneeded.
* SizeSlider::MaxPartitionSize() also now returns the size instead of the end
offset.
* Renamed CreateParamsPanel::_UpdateTextControl() to _UpdateSizeTextControl().
* Removed code duplication, and instead just call _UpdateSizeTextControl()
twice.
* Minor other cleanup.
- Automatic whitespace cleanup.
- Remove no longer exposed show/hide time setting. The methodology for
saving it on exit was broken anyways, since it relied on the current
show/hide state of the time view, which would be hidden if the deskbar
was currently in Autohide mode.
* Since ahci devices are emulated as scsi, we use
the SAS style TRIM call (unmap in scsi write same)
* This prevents the need for special, one off trim
calls.
* We don't perform the TRIM just yet, just laying
the goundwork for the request.
Before this the height and width of the tab would jump around as the window was
moved. In addition there was an off-by-one error which caused right-aligned
tabs to not be drawn right (as reported in ticket #4615, which this fixes.)
Before this the active window border color was used, resulting in ugly inactive
window tabs if the active and inactive border colors were quite different.
This was not noticed before because the defaults are two very similar grays.
I copied BStringItem::Draw then modified it. I couldn't find a clean way
of doing it otherwise, since the color box drawing needs to occur between the
selection and text drawing, and the text needs to be offset while the selection
shouldn't be.
