Commit Graph

264 Commits

Author SHA1 Message Date
stippi
84c9928e40 * Added small symbol buttons to tab container view. Currently only "New tab" is
added and works.
* Added "Open location" shortcut Cmd-L as in Firefox.
* Moved "Show downloads" shortcut to Cmd-J, again as in Firefox. It uses Cmd-D
  for "Bookmark this page". Though I have no idea why we simply shouldn't use
  Cmd-D for Downloads and Cmd-B for Bookmark this page.


git-svn-id: http://svn.haiku-os.org/webpositive/webkit/trunk@229 94f232f2-1747-11df-bad5-a5bfde151594
2010-02-26 23:17:51 +00:00
stippi
72664707fa Implemented a completely new tab view framework:
* Tabs are only visible when there are more than one.
* Tabs have close buttons.
* Much more flexible, adding scrolling and left/right buttons when there are
  more tabs than room will be easy. Also drag&drop of tabs.
I've tested this quite a bit, hopefully there are no regressions.


git-svn-id: http://svn.haiku-os.org/webpositive/webkit/trunk@228 94f232f2-1747-11df-bad5-a5bfde151594
2010-02-26 19:02:24 +00:00
stippi
1c3a676322 Fixed comment, the TODO was already resolved.
git-svn-id: http://svn.haiku-os.org/webpositive/webkit/trunk@226 94f232f2-1747-11df-bad5-a5bfde151594
2010-02-26 08:55:29 +00:00
stippi
64f8c06735 Fix crash on program exit. Always good to use defensive programming techniques...
git-svn-id: http://svn.haiku-os.org/webpositive/webkit/trunk@225 94f232f2-1747-11df-bad5-a5bfde151594
2010-02-26 08:53:10 +00:00
stippi
4978460d4c Implement creating new pages properly. This fixes content submission on
haiku-os.org and probably a few other things. Basically, we were creating
the new pages ourselves in dispatchDecidePolicyForNewWindowAction(), but
we were meant to implement dispatchCreatePage() instead. Now, what we do is
similar for the Qt port, only better (found a bug in Arora): When the user
clicked with the tertiary mouse button, we create the window ourselves, as
before, and otherwise always have WebCore create the page instead.


git-svn-id: http://svn.haiku-os.org/webpositive/webkit/trunk@218 94f232f2-1747-11df-bad5-a5bfde151594
2010-02-25 18:50:51 +00:00
anevilyak
5afb1a0f0c Spelling fix.
git-svn-id: http://svn.haiku-os.org/webpositive/webkit/trunk@216 94f232f2-1747-11df-bad5-a5bfde151594
2010-02-25 15:33:01 +00:00
stippi
9397a29aaf Use the document look for the LauncherWindow and adjust the layout accordinly.
git-svn-id: http://svn.haiku-os.org/webpositive/webkit/trunk@214 94f232f2-1747-11df-bad5-a5bfde151594
2010-02-25 14:16:06 +00:00
stippi
f16ed908be What the heck... use the correct weighting for calculating the average grey.
git-svn-id: http://svn.haiku-os.org/webpositive/webkit/trunk@213 94f232f2-1747-11df-bad5-a5bfde151594
2010-02-25 12:49:38 +00:00
stippi
9db22c336b Make it much more obvious when icon buttons are disabled.
git-svn-id: http://svn.haiku-os.org/webpositive/webkit/trunk@212 94f232f2-1747-11df-bad5-a5bfde151594
2010-02-25 12:46:28 +00:00
stippi
1da75c0bed Implemented "Stop Loading" feature, designed icon, added button and necessary
wiring to arrive at BWebFrame::StopLoading().


git-svn-id: http://svn.haiku-os.org/webpositive/webkit/trunk@211 94f232f2-1747-11df-bad5-a5bfde151594
2010-02-25 12:30:39 +00:00
stippi
16ccf622ab Removed forgotten debug output.
git-svn-id: http://svn.haiku-os.org/webpositive/webkit/trunk@207 94f232f2-1747-11df-bad5-a5bfde151594
2010-02-25 09:20:53 +00:00
stippi
ce869c629b Selecting or not selecting the newly opened tab never worked, since the "select"
field was added to the NEW_WINDOW_REQUESTED message, and not passed on to the
internal NEW_TAB message. Fixed this, and also added a check for the tertiary
mouse button for regular navigation actions. This means clicking links with
the middle mouse button opens in a background tab regard less if it would have
opened a new page when clicked with the primary button.


git-svn-id: http://svn.haiku-os.org/webpositive/webkit/trunk@199 94f232f2-1747-11df-bad5-a5bfde151594
2010-02-24 21:00:55 +00:00
stippi
c516096e8e * Refactored WebDownload into BWebDownload and BPrivate::WebDownloadPrivate.
* Fixed a bug where the "Remove Finished" button in the downloads window would
  be wrongly disabled whenever a new download started.
* Implemented cancelling downloads.
* Prepared restarting downloads as far as the GUI goes. Need to research this
  first how a download can be triggered independently from anything else in
  WebCore...


git-svn-id: http://svn.haiku-os.org/webpositive/webkit/trunk@196 94f232f2-1747-11df-bad5-a5bfde151594
2010-02-24 19:48:35 +00:00
stippi
054c42b1b9 Renamed WebViewWindow to BWebWindow and converted the API to Haiku coding guide
lines.


git-svn-id: http://svn.haiku-os.org/webpositive/webkit/trunk@195 94f232f2-1747-11df-bad5-a5bfde151594
2010-02-24 18:33:22 +00:00
stippi
feba54b70c Invalidate the BTabView when new tabs are added. Works around new tabs not
showing immediately after they have been created, some pages don't set the
title either, so then the tab still would't show.


git-svn-id: http://svn.haiku-os.org/webpositive/webkit/trunk@193 94f232f2-1747-11df-bad5-a5bfde151594
2010-02-24 10:39:17 +00:00
stippi
d54c477ad1 Properly set the download listener on new tabs. This fixes the Downloads window
not popping up for subsequent tabs.


git-svn-id: http://svn.haiku-os.org/webpositive/webkit/trunk@192 94f232f2-1747-11df-bad5-a5bfde151594
2010-02-24 10:34:53 +00:00
stippi
57b6a0fc1b * The next round of API cleanup. WebView was renamed to BWebView. Some API needed
be ChromeClientHaiku has been moved to BWebPage. WebView.h is now clean and
  would be ready for the Haiku tree.
* BWebPage no longer invalidates the BWebView when a resize happens, WebCore
  already takes care of that.
* BWebView draws a white area in Draw() when the offscreen view is not clean.
  since no unnecessary invalidation happens, this doesn't result in any flicker
  and basically only speeds up perceived loading speed, since the web page is
  immediately white upon program launch.
* Since WebTabView does not draw a frame, it removes B_FULL_UPDATE_ON_RESIZE
  and thereby completely avoids flickering upon window resize.


git-svn-id: http://svn.haiku-os.org/webpositive/webkit/trunk@190 94f232f2-1747-11df-bad5-a5bfde151594
2010-02-24 10:20:33 +00:00
stippi
58a9dd9dfe * Moved exposed classes from WebCore out of WebFrame.h, reintroduced
WebFramePrivate to hide WebCore internals from the public API.

FrameLoadClientHaiku:
* Don't send load requested in policy decision method
  dispatchDecidePolicyForNavigationAction(). Calling the policy function with
  PolicyUse will already trigger the load correctly. Ignore the request when
  we want to load it into a new window/frame instead.
* Subframes returned false in canHandleRequest(). This was what stopped stuff
  being loaded into sub frames! Finally frames and iframes are working. Praise
  Ingo's Debugger once more!
* Renamed LOAD_TRANSFERING to LOAD_COMMITED, since WebCore means that the loader
  and policy stuff have come to the conclusion to finally load the URL. So that's
  also the event which needs to update the URL text control.


git-svn-id: http://svn.haiku-os.org/webpositive/webkit/trunk@182 94f232f2-1747-11df-bad5-a5bfde151594
2010-02-23 15:52:17 +00:00
stippi
e7bd43d9ca Place the thread priority tweak somewhere where it actually works. This makes
HaikuLauncher totally usable under heavy system load.


git-svn-id: http://svn.haiku-os.org/webpositive/webkit/trunk@174 94f232f2-1747-11df-bad5-a5bfde151594
2010-02-22 13:36:46 +00:00
stippi
0bcb05f98d Forgot to commit this. Polishes no-border BTabView look.
git-svn-id: http://svn.haiku-os.org/webpositive/webkit/trunk@173 94f232f2-1747-11df-bad5-a5bfde151594
2010-02-22 13:30:54 +00:00
stippi
7a9d9c2cf8 Set the "no border" look to avoid the double frame around the WebView.
git-svn-id: http://svn.haiku-os.org/webpositive/webkit/trunk@169 94f232f2-1747-11df-bad5-a5bfde151594
2010-02-22 13:23:55 +00:00
anevilyak
d05b8e1a31 Change window/tab management shortcuts:
- cmd+w now closes the active tab. If the tab is the only one remaining, the window is closed.
- cmd+shift+w closes the window, regardless of tab count.

Whitespace cleanups.



git-svn-id: http://svn.haiku-os.org/webpositive/webkit/trunk@167 94f232f2-1747-11df-bad5-a5bfde151594
2010-02-21 16:16:46 +00:00
stippi
b6ffb2048f Removed stray debug output.
git-svn-id: http://svn.haiku-os.org/webpositive/webkit/trunk@166 94f232f2-1747-11df-bad5-a5bfde151594
2010-02-21 15:31:11 +00:00
stippi
df621688c5 Fix closing tabs.
git-svn-id: http://svn.haiku-os.org/webpositive/webkit/trunk@165 94f232f2-1747-11df-bad5-a5bfde151594
2010-02-21 15:30:49 +00:00
stippi
d3d066c322 BTabView doesn't properly trigger a relayout when adding a new tab.
git-svn-id: http://svn.haiku-os.org/webpositive/webkit/trunk@164 94f232f2-1747-11df-bad5-a5bfde151594
2010-02-21 13:48:07 +00:00
stippi
714edff6e1 Select the new tab when creating it via the menu.
git-svn-id: http://svn.haiku-os.org/webpositive/webkit/trunk@163 94f232f2-1747-11df-bad5-a5bfde151594
2010-02-21 13:43:27 +00:00
stippi
fafcdf7cd1 Introduced BWebPage::ResendNotifications(). This is a simple way for the
window to update itself to the properties of a page when switching pages.
Resolves deadlock problem with BWebPage::CanGoInDirection(), which I've removed.


git-svn-id: http://svn.haiku-os.org/webpositive/webkit/trunk@162 94f232f2-1747-11df-bad5-a5bfde151594
2010-02-21 13:34:54 +00:00
stippi
63d76ab872 Middle clicking links will open new tabs, but will not select them. Matches
Firefox behavior.


git-svn-id: http://svn.haiku-os.org/webpositive/webkit/trunk@161 94f232f2-1747-11df-bad5-a5bfde151594
2010-02-21 13:20:57 +00:00
stippi
56bdbcc74e Fixed deadlocks when adding a new tab. The WebView needs to be created int the
app thread indeed, but the app thread may already be blocking on the window lock,
we we cannot wait for a synchronous reply from the app in the window thread.
Refactored the tab creation and reused it in the LauncherWindow constructor.
Added the ability to load a URL in the new tab right away.


git-svn-id: http://svn.haiku-os.org/webpositive/webkit/trunk@160 94f232f2-1747-11df-bad5-a5bfde151594
2010-02-21 13:13:03 +00:00
stippi
14c76a6546 Use arrow icons for th enavigation buttons. The IconButton class is a slightly
extended version of the LaunchBox version (added TrimIcon() method). Will go
away when/if the browser is moved into the Haiku source tree.


git-svn-id: http://svn.haiku-os.org/webpositive/webkit/trunk@159 94f232f2-1747-11df-bad5-a5bfde151594
2010-02-21 12:49:11 +00:00
stippi
5478dd2992 * Asthetical improvements with the new tab view.
* Actually set the target on the tab view, so that we change urls when switching
  tabs.
* Move all New/Close items to the top-level, since I find it slightly too
  awkward to reach them otherwise.
* Misc coding style fixes.


git-svn-id: http://svn.haiku-os.org/webpositive/webkit/trunk@157 94f232f2-1747-11df-bad5-a5bfde151594
2010-02-20 20:03:11 +00:00
anevilyak
14ad7bdb25 Focus address bar when creating a new tab.
git-svn-id: http://svn.haiku-os.org/webpositive/webkit/trunk@156 94f232f2-1747-11df-bad5-a5bfde151594
2010-02-20 19:59:29 +00:00
anevilyak
75845de732 Add mechanism for asking LauncherApp to create a web view to ensure new view creation always happens in the main thread. Fixes assert failure when creating a new tab with debug builds.
git-svn-id: http://svn.haiku-os.org/webpositive/webkit/trunk@155 94f232f2-1747-11df-bad5-a5bfde151594
2010-02-20 19:52:10 +00:00
anevilyak
d311e279f5 Clean up tabs properly on quit.
git-svn-id: http://svn.haiku-os.org/webpositive/webkit/trunk@154 94f232f2-1747-11df-bad5-a5bfde151594
2010-02-20 18:59:51 +00:00
anevilyak
5eba20dc10 Add close tab support via cmd+shift+w.
git-svn-id: http://svn.haiku-os.org/webpositive/webkit/trunk@153 94f232f2-1747-11df-bad5-a5bfde151594
2010-02-20 18:46:53 +00:00
anevilyak
95b246f2a7 Add basic tabbed browsing support. Does not yet properly handle maintaining/switching the current URL or status bar text per-tab.
git-svn-id: http://svn.haiku-os.org/webpositive/webkit/trunk@152 94f232f2-1747-11df-bad5-a5bfde151594
2010-02-20 16:22:31 +00:00
anevilyak
c14fa62638 Typo/spelling corrections.
git-svn-id: http://svn.haiku-os.org/webpositive/webkit/trunk@151 94f232f2-1747-11df-bad5-a5bfde151594
2010-02-20 15:28:30 +00:00
stippi
82912660d5 * Began renaming some public API with the B* prefix and using the Haiku coding
style. (WebPage -> BWebPage). Documented what needs to go where in WebPage.h.
* Moved misplaced functionality from WebFrame to BWebPage (navigation).
* EditorClientHaiku takes a BWebPage pointer now, which brings a slight cleanup.
* Exposed WebFrame::isEditable() to EditorClientHaiku, so isEditable() can be
  implemented.
* Added some asserts in FrameLoaderClientHaiku according to the Gtk port and
  placed some debug output.


git-svn-id: http://svn.haiku-os.org/webpositive/webkit/trunk@150 94f232f2-1747-11df-bad5-a5bfde151594
2010-02-20 11:13:44 +00:00
stippi
c9219daa51 Fixed left-over bug from refactoring.
git-svn-id: http://svn.haiku-os.org/webpositive/webkit/trunk@148 94f232f2-1747-11df-bad5-a5bfde151594
2010-02-19 18:29:13 +00:00
stippi
a89e2a4b6c Refactoring to support multiple WebViews per WebViewWindow. There is now the
notion of a current WebView. In the notification messages, carry the information
which WebView it is for.


git-svn-id: http://svn.haiku-os.org/webpositive/webkit/trunk@147 94f232f2-1747-11df-bad5-a5bfde151594
2010-02-19 17:23:45 +00:00
stippi
a62545c155 Renamed WebProcess to WebPage.
git-svn-id: http://svn.haiku-os.org/webpositive/webkit/trunk@146 94f232f2-1747-11df-bad5-a5bfde151594
2010-02-19 15:47:21 +00:00
mmlr
defb5e01c4 Fix uninitialized m_windowCount which could cause the app to close on any window
close randomly (or always with libroot_debug).


git-svn-id: http://svn.haiku-os.org/webpositive/webkit/trunk@139 94f232f2-1747-11df-bad5-a5bfde151594
2010-02-19 02:48:44 +00:00
stippi
2bff1b8203 Wired and debugged everything to give us a basic "Go" menu, a.k.a browsing
history... :-)


git-svn-id: http://svn.haiku-os.org/webpositive/webkit/trunk@98 94f232f2-1747-11df-bad5-a5bfde151594
2010-02-15 18:17:17 +00:00
stippi
ce277486d7 Implemented BrowsingHistoryItem class, which uses BDateTime to track when it
was invoked.


git-svn-id: http://svn.haiku-os.org/webpositive/webkit/trunk@95 94f232f2-1747-11df-bad5-a5bfde151594
2010-02-15 16:24:24 +00:00
stippi
d4f4c7f808 Added my copyright, since I've redesigned here quite a bit.
git-svn-id: http://svn.haiku-os.org/webpositive/webkit/trunk@94 94f232f2-1747-11df-bad5-a5bfde151594
2010-02-15 16:23:31 +00:00
stippi
dad9d4a5a4 Added BDateTime stuff from Haiku, and addd archiving features to these classes.
Needs to be put back into Haiku and made public API eventually.


git-svn-id: http://svn.haiku-os.org/webpositive/webkit/trunk@93 94f232f2-1747-11df-bad5-a5bfde151594
2010-02-15 16:22:13 +00:00
stippi
4e703b4b2f Patch by Rene Gollent, which fixes some typos. Thanks!
git-svn-id: http://svn.haiku-os.org/webpositive/webkit/trunk@92 94f232f2-1747-11df-bad5-a5bfde151594
2010-02-15 15:58:35 +00:00
stippi
77d2abe296 First structure of BrowsingHistory. Does nothing, but can in theory save settings.
git-svn-id: http://svn.haiku-os.org/webpositive/webkit/trunk@91 94f232f2-1747-11df-bad5-a5bfde151594
2010-02-15 14:06:28 +00:00
stippi
b2b53e7c19 AuthenticationPanel:
* Improved wording for persistency checkbox.
* Added BTextView for displaying the info text.
* Focus password input on second runs with bad password.
* Enabled drawing updates for blocking windows.


git-svn-id: http://svn.haiku-os.org/webpositive/webkit/trunk@90 94f232f2-1747-11df-bad5-a5bfde151594
2010-02-15 12:25:08 +00:00
stippi
56fc5b5b33 Fix regression about opening URLs from command line args.
git-svn-id: http://svn.haiku-os.org/webpositive/webkit/trunk@89 94f232f2-1747-11df-bad5-a5bfde151594
2010-02-15 12:23:47 +00:00