Commit Graph

62114 Commits

Author SHA1 Message Date
Autocomitter
873f56ec13 Update translations from Pootle 2020-07-25 08:17:15 +00:00
Kyle Ambroff-Kao
e0e5d12ea3 test/haikudepot: Fix build of haikudepottest.so
hrev54429 added some changes to logging in HaikuDepot which broke the
build of the tests.

The build for haikudepottest.so adds some cpp files from the
HaikuDepot source. Now that Logger::NameForLevel and
Logger::IsLevelEnabled are referenced in some of the code being tested
we need to include Logger.cpp as well.

This just adds Logger.cpp to the haikudepottest.so build.

Change-Id: I80a8bb2053c3c78d821ce3cf9902c3a42b0def37
Reviewed-on: https://review.haiku-os.org/c/haiku/+/3056
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>
2020-07-23 07:23:37 +00:00
Michael Lotz
bfb040f065 hda: Use B_32_BIT_CONTIGUOUS when controller is not 64 bit.
This ensures that the allocated physical memory uses 32 bit addresses.

Also avoid writing to the 64 bit address registers when the controller
is not 64 bit.

Change-Id: I58008d68bcd9579903534f824db2660f73e39160
Reviewed-on: https://review.haiku-os.org/c/haiku/+/3065
Reviewed-by: waddlesplash <waddlesplash@gmail.com>
2020-07-22 22:36:31 +00:00
Michael Lotz
71e84ce71a hda: Style cleanup only, no functional change.
Change-Id: Id36bf67a51369099093ae24412fa681f88c4c8d0
Reviewed-on: https://review.haiku-os.org/c/haiku/+/3064
Reviewed-by: waddlesplash <waddlesplash@gmail.com>
2020-07-22 22:36:31 +00:00
Michael Lotz
07edf62c0d hda: Reset streams before (re-)setting DMA memory addresses.
The spec says that changing the DMA memory addresses of a stream should
really only be done after a reset and before the first run. Stopping the
stream is not enough, as the controller is allowed to cache the
addresses even when the stream is paused.

Note that this is applied to both, the initial configuration of buffers
and to the case of dynamically changing stream parameters. In the initial
case this should always be a no-op as the controller was previously
globally reset.

In the dynamic reconfiguration case this fixes random memory corruption
due to the controller still accessing and modifying physical memory that
is released by the driver. With some controllers, such corruption was
easily triggered by changing the input and output sampling rates for the
HDA device in the media preferences.

The return value of the reset call is intentionally not checked to allow
for it to partially or fully fail. At least for HDA under QEMU, the
stream reset fails to start, while the initial stream stop still works
and prevents the memory corruption.

Change-Id: I7c6e6547ee08889a2990de26d5eed5e73b2ca13c
Reviewed-on: https://review.haiku-os.org/c/haiku/+/3063
Reviewed-by: waddlesplash <waddlesplash@gmail.com>
2020-07-22 22:36:31 +00:00
Michael Lotz
f010a08f9a hda: Make interrupt setup more conservative.
Don't unconditionally enable PCI interrupt generation as this only
applies when MSIs are not in use. Delay the evaluation and setting of
the interrupt disable bit until after it is clear whether or not MSIs
are to be used.

Initially force interrupt generation off as early as possible. Depending
on the initial state of the controller, some spurious interrupts might
come up and we really don't want them to occur before everything is set
up in the right way.

Change-Id: Ifb12f5eef1cbf8ecfa3f352564139125d8ad2169
Reviewed-on: https://review.haiku-os.org/c/haiku/+/3062
Reviewed-by: waddlesplash <waddlesplash@gmail.com>
2020-07-22 22:36:31 +00:00
Michael Lotz
8d917e956a hda: Remove doubled and early put of gPCIx86Module.
This is already properly done in uninit_driver.

Putting the module in device instead of driver uninit meant that on a
device reopen the gPCIx86Module would always be gone and therefore MSIs
could not be used anymore even if they previously were.

Change-Id: Ib3bddefbe6bcb02fa1c97f3c843cecaf31c80e3e
Reviewed-on: https://review.haiku-os.org/c/haiku/+/3061
Reviewed-by: waddlesplash <waddlesplash@gmail.com>
2020-07-22 22:36:31 +00:00
Michael Lotz
4ba91f3460 hda: Unconfigure the MSI as well.
Just disabling it will leak the vector reservation and makes it
impossible to configure an MSI on the device again.

Also removes the check for the gPCIx86Module as having an MSI configured
really implies its presence.

Change-Id: I9f0e3e63c988af515d23ad93d86918cde9add97a
Reviewed-on: https://review.haiku-os.org/c/haiku/+/3060
Reviewed-by: waddlesplash <waddlesplash@gmail.com>
2020-07-22 22:36:31 +00:00
Michael Lotz
a95a2065d4 hda: Disable MSIs when installing the interrupt handler fails.
This was previously only done if reset failed.

Change-Id: I30ebe1d302087816bccfe67e3d236c9446425aea
Reviewed-on: https://review.haiku-os.org/c/haiku/+/3059
Reviewed-by: waddlesplash <waddlesplash@gmail.com>
2020-07-22 22:36:31 +00:00
Michael Lotz
3b12162731 hda: Wait for streams to actually start/stop.
In the start case this adds debug output in case a start fails.

For stops this makes sure the stream DMA engine has actually stopped
operating, which is a precondition for some other operations.

Change-Id: I0e2731513febd0e0cd4e1f0ef89cf3d7312a47e1
Reviewed-on: https://review.haiku-os.org/c/haiku/+/3058
Reviewed-by: waddlesplash <waddlesplash@gmail.com>
2020-07-22 22:36:31 +00:00
Michael Lotz
de2e028f80 hda: Factor out waiting for bits to be set/cleared.
It is a recurring pattern to set some bits, then wait for them to be
read as set or the reverse. For resets this is done once in both
directions, so factoring this out removes quite a bit of similar code.

No functional change intended.

Change-Id: I2ae4b6cce490c33e1a027328f01fbffea67c5180
Reviewed-on: https://review.haiku-os.org/c/haiku/+/3057
Reviewed-by: waddlesplash <waddlesplash@gmail.com>
2020-07-22 22:36:31 +00:00
Adrien Destugues
12ef216972 build_haiku_image: no fs indices on CDs
The iso9660 filesystem does not support them
2020-07-22 17:48:32 +02:00
John Scipione
d6a8b3e805 FileTypes: ApplicationTypeWindow text view updates
Remove workaround for BTextView bug from 2006 that no long applies
in FileTypes ApplicationTypeWindow by allowing the text views to
align themselves on FrameResized().

Don't override height on version text views, default height is good.

Change-Id: I41e5a9244c5c79eee3bba133064d016673e008e2
Reviewed-on: https://review.haiku-os.org/c/haiku/+/3053
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>
2020-07-22 13:58:58 +00:00
John Scipione
40f2d4634a DeskCalc: right-align ExpressionTextView
Change-Id: I8bfd34f2a0cf426a2286e9cdd5b96f1b8e122f2b
Reviewed-on: https://review.haiku-os.org/c/haiku/+/3052
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>
2020-07-22 13:58:58 +00:00
John Scipione
2eb1389dc1 Backgrounds: right-align X and Y position boxes
Change-Id: Ice9e51ca30235a6ec28a8a07cf3fea3da43f1414
Reviewed-on: https://review.haiku-os.org/c/haiku/+/3051
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>
2020-07-22 13:58:58 +00:00
Suhel Mehta
788899a8c2 ufs2: All directories are read sucessfully.
Change-Id: I87d3d77d48396ecd0e8fa649169f6e899d161f66
Reviewed-on: https://review.haiku-os.org/c/haiku/+/3028
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>
2020-07-22 07:42:04 +00:00
brjhaiku
f79386adb7 btrfs: partially implemented btrfs_write_stat
Change-Id: Ib17ef1467a320af6edc3739555ebfb3f46bcc98b
Reviewed-on: https://review.haiku-os.org/c/haiku/+/1640
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>
2020-07-22 09:32:36 +02:00
waddlesplash
4316066974 Revert "btrfs: partially implemented btrfs_write_stat"
This reverts commit f16979003a.

Reason for revert: Broke the build.

Change-Id: I60ed4a4c4532810c32c6c5029a21ba8d31f92aa9
Reviewed-on: https://review.haiku-os.org/c/haiku/+/3055
Reviewed-by: waddlesplash <waddlesplash@gmail.com>
2020-07-22 02:26:14 +00:00
Leorize
385d1b54e1 docs/user/net/UrlProtocolListener: document debug message types
Change-Id: If4143acaf2679a74e1a7e358452f9ae306449411
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2985
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>
2020-07-22 01:39:40 +00:00
brjhaiku
f16979003a btrfs: partially implemented btrfs_write_stat
Change-Id: Ib17ef1467a320af6edc3739555ebfb3f46bcc98b
Reviewed-on: https://review.haiku-os.org/c/haiku/+/1640
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>
2020-07-22 01:37:08 +00:00
CodeforEvolution
4c2a60b03d Icons: Add icon for wpa_supplicant
This was the last system daemon/server to not have an icon, so I thought I'd give a go at this!
This icon will still need to be added to Haiku's wpa_supplicant repository however.

Change-Id: Icd4e60ec759daaece30669aa8125fce953bbbf95
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2698
Reviewed-by: waddlesplash <waddlesplash@gmail.com>
2020-07-22 01:36:13 +00:00
Kacper Kasper
2775737e9d TextSearch: add option to set target to parent directory
Two usage scenarios:

* Wrong directory selected when invoking as Tracker add-on.
  I often find myself having TextSearch invoked on selected child,
  when I wanted it to open in parent context.
* Result was not found in target directory, so maybe the search
  should be broader.

Change-Id: I2621f3cec7459572ddae438de4ba42ce74432e28
Reviewed-on: https://review.haiku-os.org/c/haiku/+/3044
Reviewed-by: humdinger <humdingerb@gmail.com>
2020-07-22 01:34:52 +00:00
Adrien Destugues
5b80a2fa0d build_haiku_image: don't recreate indices when updating
mkinex fails when the indices already exist.
2020-07-21 18:38:06 +02:00
Alexander von Gluck IV
a704a197f5 efi/devices: Skip qemu flash device for now due to crash
* An upstream bug exists which results in the tianocore
  bios crashing when attempting to read from qemu's
  (unconfigured, but present) flash device.

Change-Id: Ie9f02a290abc29cce3a5e279382750c0b14164dc
Reviewed-on: https://review.haiku-os.org/c/haiku/+/3049
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>
2020-07-21 12:49:44 +00:00
Alexander von Gluck IV
9f30e61f95 efi/mmu: Add tracing, fix line widths. No functional change
Change-Id: I9fcd6790f7c7e8b9e12a3bc1a2c43cae091a11be
Reviewed-on: https://review.haiku-os.org/c/haiku/+/3048
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>
2020-07-21 12:49:44 +00:00
Kacper Kasper
7d5ea15ee0 TextSearch: change Select all shortcut
Anecdotal: whenever I hit Cmd+A with text field focused I want to
quickly select search phrase, not the results. In fact I never found
myself in a situation where the latter is the desired outcome.
Change-Id: Ib5edcee8e7366485181cb2030ecfa989619cd600
Reviewed-on: https://review.haiku-os.org/c/haiku/+/3043
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>
2020-07-20 14:03:38 +00:00
Augustin Cavalier
913f009e94 XHCI: Add a few comments and remove the documentation file.
The documentation file (which PulkoMandy only merged today) was created
over a year ago from a short conversation I had with him, and by now
a lot of its information is already outdated or has been merged into
comments in the driver already (specifically, the notes at the end about
error messages no longer apply as there are different ones, and the
bugs causing those errors have since been fixed.)

A few of the statements in it were not noted in the driver, though,
so I have added those as comments.
2020-07-19 15:44:58 -04:00
PulkoMandy
4aa9da6843 openboot: fix console to work on both serial and screen
- Use the correct escape sequence for reverse video
- The vertical form feed does not cleanr the screen on normal serial
  terminals, so additionally use the clear screen sequence
2020-07-19 19:30:39 +02:00
Adrien Destugues
5033d6898f SerialConnect: make reverse video work
It's useful to see our openboot boot menu.

I'm not sure what B_NEGATIVE_FACE is meant to do. The be book says
"Characters are drawn in the low color, while the background is drawn in
the high color.", but DrawString does not draw the background, so some
color swapping will still be needed in this case anyway.
2020-07-19 15:02:43 +02:00
Adrien Destugues
d74c554ce2 Time: remove unused sourcefiles. 2020-07-19 13:06:27 +02:00
Adrien Destugues
98e5fab3f4 Locale: move "translate application names" checkbox to formatting tab
Part of #15511
2020-07-19 13:06:26 +02:00
Adrien Destugues
25f1ddecf7 XHCI: add some docs after a chat with waddlesplash.
Better than nothing, but quite likely very incomplete.

Change-Id: I9c0399d9da3851689bdddce98647a43e8d1e4ccf
Reviewed-on: https://review.haiku-os.org/c/haiku/+/1540
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>
2020-07-19 08:07:48 +00:00
Oishika Pradhan
bd514095bb Keymap: better default window size.
Use a larger default window size so the keymap is readable.
However, size it down on low resolution displays.

Fixes #14892

Change-Id: Id35c46fa14bef570f78d8f065d95f6e6d8f0c6d7
Reviewed-on: https://review.haiku-os.org/c/haiku/+/1312
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>
2020-07-18 19:37:17 +00:00
Adrien Destugues
24f8ae4156 DataTranslations: sort by supertype before name
Fixes #9618 (which suggested using a tree view, but I think that's not
useful, just proper sorting of the items seems fine to me)

Change-Id: Ie1298eec048f9cb42528b8420a91e807e8f00eab
Reviewed-on: https://review.haiku-os.org/c/haiku/+/3030
Reviewed-by: waddlesplash <waddlesplash@gmail.com>
2020-07-18 19:35:19 +00:00
Jaroslaw Pelczar
ebcb6f5f4f trans_double_path: Fix member initialization order
Silence GCC -Wreorder warning

Signed-off-by: Jaroslaw Pelczar <jarek@jpelczar.com>
Change-Id: I7dd48fc4427d83ff9f9055c13442ce15e03829e1
Reviewed-on: https://review.haiku-os.org/c/haiku/+/1818
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>
2020-07-18 18:20:43 +00:00
Alexander von Gluck IV
ca7a630e20 kits/package: Break LibsolvSolver add-on out
* BSolver is implemented by solver add-ons
* We may want to (unlikely) leverage another
  package solver in the future.
* We may want to (likely) implement a dummy
  solver when libsolv is unavailable on new
  architectures without bootstrap.
* This also makes solving missing libsolv a little
  more graceful vs the "include "libsolv.h" not
  found.

Change-Id: Iedd9d0f022fb743c4c7606bd33a4b6dbef0576f7
Reviewed-on: https://review.haiku-os.org/c/haiku/+/819
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>
2020-07-18 18:17:48 +00:00
Adrien Destugues
c5aa9dfb4c Create filesystem indices when creating Haiku image
Fixes #4424.

Change-Id: I737ee4f9bb70ce48c0c94f3a862a3073da8c0c4d
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2796
Reviewed-by: Jérôme Duval <jerome.duval@gmail.com>
2020-07-18 14:00:10 +00:00
X512
77912444b8 Tracker: fix ScrollIntoView
Same problem as in BListView::ScrollToSelection.

Change-Id: I1cd26190566b1808f47475c1499298b66549f024
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2312
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>
2020-07-18 13:58:28 +00:00
Adrien Destugues
06b2ce5412 FirstBootPrompt: update welcome text.
Change-Id: Ibc8b051cd183a1184d62af264e0a42815e952f99
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2545
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>
2020-07-18 13:47:29 +00:00
X512
c3a6a6b6ee mime_db: add BPicture type
Change-Id: I69948b04e6c1b19165a51cd0eb999591da4efccb
Reviewed-on: https://review.haiku-os.org/c/haiku/+/2828
Reviewed-by: waddlesplash <waddlesplash@gmail.com>
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>
2020-07-18 13:41:31 +00:00
X512
f27269a67d MediaPlayer: fix reporting wrong format
Now it allows to connect MediaPlayer video producer to differnt node in Cortex.

Change-Id: I7ee598ea64d10e8fa876259e7a4480a650a0e189
Reviewed-on: https://review.haiku-os.org/c/haiku/+/3034
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>
2020-07-18 13:25:09 +00:00
Fredrik Holmqvist
d9f74c873b Graphite options only, replace dupes with floop-nest-optimize
Other loop optimization is enabled in -O3 already
2020-07-18 15:19:44 +02:00
Fredrik Holmqvist
7cea5bf07f Remove graphite building, we have gcc with these deps in build
When we moved ISL, MPFR, GMP and so on inside GCC we no longer
need to do any specific building to support graphite.
2020-07-18 15:19:17 +02:00
Autocomitter
bfa01f5213 Update translations from Pootle 2020-07-18 08:12:49 +00:00
Adrien Destugues
bd3b7c3f90 Make space for AVX-512 registers in x86 arch_thread.
Should fix #16382

Change-Id: Ib1445e3c08036a8c959eae54adcf0f0c27bcf22d
Reviewed-on: https://review.haiku-os.org/c/haiku/+/3031
Reviewed-by: Rene Gollent <rene@gollent.com>
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>
2020-07-17 11:17:20 +00:00
Andrew Lindesay
f96d1f4d92 HaikuDepot: Better Logging
Changes the logging in HD to use a macro for the
various log levels to declutter the code and to
make it easier to more systematically log.

Change-Id: I025970707a0a11e7e3aaa4b52fc91288af0183f5
Reviewed-on: https://review.haiku-os.org/c/haiku/+/3018
Reviewed-by: Adrien Destugues <pulkomandy@gmail.com>
2020-07-15 08:34:22 +00:00
Adrien Destugues
2ad7efd4b5 Build fix. 2020-07-14 19:33:20 +02:00
Adrien Destugues
c916010e87 Add a NULL check in strtol.
The spec says this is undefined behavior, but it will fix one more
problem with #8297

Change-Id: Ibc15f306c92b05019de1050a9eb239ba57b1a91e
Reviewed-on: https://review.haiku-os.org/c/haiku/+/3029
Reviewed-by: Axel Dörfler <axeld@pinc-software.de>
2020-07-13 19:34:09 +00:00
Adrien Destugues
15ba64aaa3 Unify Settings menu shortcut
Use , as the shortcut key for settings in all built-in apps. Some used
S, but that's already the shortcut for saving. , is the recommended
shortcut in the HIG already, but built-in apps were not updated to
match.

Fixes #11733.
2020-07-13 20:53:45 +02:00
Adrien Destugues
d594bd97d3 MIME db: make video/ogg sniffing more specific
Check the codec in the first Ogg page for known video codecs. If none is
found, the file will be identified as audio/ogg instead.

Fixes #8702.
2020-07-13 18:09:12 +02:00