Aren/haiku
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Unify Settings menu shortcut

Browse Source 
Use , as the shortcut key for settings in all built-in apps. Some used
S, but that's already the shortcut for saving. , is the recommended
shortcut in the HIG already, but built-in apps were not updated to
match.

Fixes #11733.
This commit is contained in:
Adrien Destugues 2020-07-13 20:29:31 +02:00
parent d594bd97d3
commit 15ba64aaa3
7 changed files with 8 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/apps/activitymonitor/ActivityWindow.cpp
View File

@ -135,7 +135,7 @@ ActivityWindow::ActivityWindow()
// "Settings" menu
menu = new BMenu(B_TRANSLATE("Settings"));
menu->AddItem(new BMenuItem(B_TRANSLATE("Settings" B_UTF8_ELLIPSIS),
new BMessage(kMsgShowSettings)));
new BMessage(kMsgShowSettings), ','));
menu->AddSeparatorItem();
fAlwaysOnTop = new BMenuItem(B_TRANSLATE("Always on top"), new BMessage(kMsgAlwaysOnTop));

2
src/apps/expander/ExpanderWindow.cpp
View File

@ -634,7 +634,7 @@ ExpanderWindow::_CreateMenuBar()
menu = new BMenu(B_TRANSLATE("Settings"));
menu->AddItem(fPreferencesItem
= new BMenuItem(B_TRANSLATE("Settings" B_UTF8_ELLIPSIS),
new BMessage(MSG_PREFERENCES), 'S'));
new BMessage(MSG_PREFERENCES), ','));
fBar->AddItem(menu);
}

2
src/apps/mediaplayer/MainWin.cpp
View File

@ -1567,7 +1567,7 @@ MainWin::_CreateMenu()
new BMessage(M_TOGGLE_ALWAYS_ON_TOP), 'A'));
item = new BMenuItem(B_TRANSLATE("Settings" B_UTF8_ELLIPSIS),
new BMessage(M_SETTINGS), 'S');
new BMessage(M_SETTINGS), ',');
fFileMenu->AddItem(item);
item->SetTarget(be_app);

3
src/apps/terminal/TermWindow.cpp
View File

@ -537,7 +537,8 @@ TermWindow::_SetupMenu()
.AddItem(fFontSizeMenu)
.AddItem(B_TRANSLATE("Save as default"), MSG_SAVE_AS_DEFAULT)
.AddSeparator()
.AddItem(B_TRANSLATE("Settings" B_UTF8_ELLIPSIS), MENU_PREF_OPEN)
.AddItem(B_TRANSLATE("Settings" B_UTF8_ELLIPSIS), MENU_PREF_OPEN,
',')
.End();
AddChild(fMenuBar);

2
src/apps/tv/MainWin.cpp
View File

@ -211,7 +211,7 @@ MainWin::CreateMenu()
new BMessage(M_TOGGLE_KEEP_ASPECT_RATIO), 'K', B_COMMAND_KEY));
fSettingsMenu->AddSeparatorItem();
fSettingsMenu->AddItem(new BMenuItem(B_TRANSLATE("Settings" B_UTF8_ELLIPSIS)
, new BMessage(M_PREFERENCES), 'P', B_COMMAND_KEY));
, new BMessage(M_PREFERENCES), ',', B_COMMAND_KEY));
const char* pixel_ratio = B_TRANSLATE("pixel aspect ratio");
BString str1 = pixel_ratio;

2
src/apps/webpositive/BrowserWindow.cpp
View File

@ -418,7 +418,7 @@ BrowserWindow::BrowserWindow(BRect frame, SettingsMessage* appSettings,
menu->AddItem(new BMenuItem(B_TRANSLATE("Downloads"),
new BMessage(SHOW_DOWNLOAD_WINDOW), 'D'));
menu->AddItem(new BMenuItem(B_TRANSLATE("Settings"),
new BMessage(SHOW_SETTINGS_WINDOW)));
new BMessage(SHOW_SETTINGS_WINDOW), ','));
menu->AddItem(new BMenuItem(B_TRANSLATE("Cookie manager"),
new BMessage(SHOW_COOKIE_WINDOW)));
menu->AddItem(new BMenuItem(B_TRANSLATE("Script console"),

2
src/kits/tracker/ContainerWindow.cpp
View File

@ -2194,7 +2194,7 @@ BContainerWindow::AddWindowMenu(BMenu* menu)
menu->AddSeparatorItem();
item = new BMenuItem(B_TRANSLATE("Preferences" B_UTF8_ELLIPSIS),
new BMessage(kShowSettingsWindow));
new BMessage(kShowSettingsWindow), ',');
item->SetTarget(be_app);
menu->AddItem(item);
}