This code depends on the inline buffer being used at
the moment. Eventually we should refactor it, but for
now, just use the deprecated method.
Should fix regressions following ICU upgrade.
This avoids things like `cat /dev/power/acpi_{ac,lid}/0`
pegging CPUs to 100%, and the command never finishing.
Followed similar code already present on the acpi_thermal driver.
Change-Id: I5f13137716c36170608ab7e9dcbca628f48a138d
Reviewed-on: https://review.haiku-os.org/c/haiku/+/7397
Haiku-Format: Haiku-format Bot <no-reply+haikuformatbot@haiku-os.org>
Tested-by: Commit checker robot <no-reply+buildbot@haiku-os.org>
Reviewed-by: Jérôme Duval <jerome.duval@gmail.com>
Reviewed-by: Adrien Destugues <pulkomandy@pulkomandy.tk>
* Non-x86 will likely break until they get an updated icu74
build-package
Change-Id: I5762d14f848e1c4e9b837e1dea9c1a54efa8401d
Reviewed-on: https://review.haiku-os.org/c/haiku/+/7346
Reviewed-by: Alex von Gluck IV <kallisti5@unixzen.com>
The `enum` containing `B_USE_DEFAULT_SPACING` and other members are
regularly used in default arguments.
Adding the name to this `enum` makes the header more generator-friendly
(see #6716).
Change-Id: I6676d2329bdb2152ccb37615345b97ba35f70563
Reviewed-on: https://review.haiku-os.org/c/haiku/+/7377
Reviewed-by: Adrien Destugues <pulkomandy@pulkomandy.tk>
Tested-by: Commit checker robot <no-reply+buildbot@haiku-os.org>
Haiku-Format: Haiku-format Bot <no-reply+haikuformatbot@haiku-os.org>
Fixes#5050 and the info staying empty after selecting a just
deselected item.
Change-Id: I519f7b260658e8e5a1671b854b0980d2fcde8352
Reviewed-on: https://review.haiku-os.org/c/haiku/+/7370
Reviewed-by: Máximo Castañeda <antiswen@yahoo.es>
This prints two quite long lists of packages that are mixed up with
other logs, making them annoying to read. It is also not very useful now
that the package server is working quite reliably.
Change-Id: Ibf9d5fc3eadc5cef42a78aea831e0a035e248de3
Reviewed-on: https://review.haiku-os.org/c/haiku/+/7366
Reviewed-by: waddlesplash <waddlesplash@gmail.com>
- When there is no refresh rate info available, disable the menu rather
than showing "nan Hz"
- Rework the screen info tooltip generation, to avoid a confusing %s
that was mistakenly moved to the end of the string in the French
translation.
Change-Id: I4c29863a30c8c761021be57f8a2e2010709b16d5
Reviewed-on: https://review.haiku-os.org/c/haiku/+/7364
Reviewed-by: waddlesplash <waddlesplash@gmail.com>
Tested-by: Commit checker robot <no-reply+buildbot@haiku-os.org>
It caused DPC list corruption when adding already added callback before
this change.
Change-Id: I81928795f91c6cf46fe3be4a8a042e07b9203161
Reviewed-on: https://review.haiku-os.org/c/haiku/+/7363
Tested-by: Commit checker robot <no-reply+buildbot@haiku-os.org>
Reviewed-by: waddlesplash <waddlesplash@gmail.com>
Requires multiple media server restarts to switch
outputs to it, but that's a known media services
problem (#12777 and #12776.)
Input doesn't work quite right with the hardware
I've been testing with, but that's also a known
problem it seems (#9951). Meanwhile, output
seems to work pretty well, once it gets going.
Since transfer status is reported via the packet descriptors, we
can report the endpoint status through the callback status.
Reduces syslog spam when using the USB audio driver.
This error means that the controller failed to read or write data
to/from system memory fast enough. As a result, we should report it
as READ_ERROR/WRITE_ERROR, rather than something that sounds like
an error with the device itself.
Then, make BABBLE reporting consistent: this is a data overrun/underrun
of the device itself, not the buffers passed to the controller.
This then leaves B_DEV_FIFO_OVERRUN/UNDERRUN unused, and thus usable
for reporting ring overrun/underrun on isochronous transfers.
The API documentation already described DATA_OVERRUN/UNDERRUN basically
like they were babble errors, while FIFO_OVERRUN/UNDERRUN are
currently described as "internal errors" at present. No driver actually
checked for these.
When _InternalIO returns with "bytes" smaller than the
original request, this isn't an error (or something we
should retry), but just something we need to pass on.
Fixes part of #18746. However, even after this commit,
file reads don't work quite right: reading past the end
of a file returns errors instead of just no data.
Also fix the broken DeskBar symlink for TV.
Change-Id: I23a9cc5cf3e3d0c6ae1608a3b96a37e9a8c431a2
Reviewed-on: https://review.haiku-os.org/c/haiku/+/7362
Reviewed-by: waddlesplash <waddlesplash@gmail.com>
Otherwise the calling program will think that
no part of the write succeeded, when in fact
it did.
tty_read() already did this correctly. Not sure
how this wasn't uncovered previously.
Fixes#18447.
Some non-layout applications start out with negative
view dimensions. Making them positive too early on can
break the view's appearance, it seems.
Fixes#18690.
* Break segment setup out into its own method.
* Break the actual sending logic out into its own method.
- While at it, remove some old/obsolete comments and
rearrange some of the logic to match.
* Separate the send-pure-ACK and send-data methods.
- This way, the "force" parameters will act differently,
specifying "force" to SendAcknowledge() may generate
a duplicate ACK, while to SendQueued() it will either
send data smaller than a segment size, or do nothing.
Functional changes should be minor, and the code
meanwhile should be much easier to read.
Change-Id: I1e14b9a1e3b7c8b2d3bf8ae30f1369d8c9f662a4
Reviewed-on: https://review.haiku-os.org/c/haiku/+/7361
Reviewed-by: waddlesplash <waddlesplash@gmail.com>
* Each packet needs to be its own TD.
* All transfers are scheduled in frames, not microframes.
Combined with a few fixes to the USB audio driver, this seems
to get things working much better than before.
