Commit Graph

59306 Commits

Author SHA1 Message Date
Augustin Cavalier
5f5cc39c2c STXTTranslator: Fix truncated "be:encoding" attribute write.
Same issue as the mail_util fix.

Also while I'm here, alter behavior so that the Be-style attribute
gets overwritten with the Haiku-style one, instead of getting left
as is.

Should potentially help with #14674.
2018-11-11 15:58:45 -05:00
Peter Kosyh
398bb93961 mail: fixes of default notifier (reset)
This fixes POP3 notification messages.

Change-Id: Ic7d9c0bb23c4dc9814f6c4bade0aba367fa28db1
Reviewed-on: https://review.haiku-os.org/685
Reviewed-by: waddlesplash <waddlesplash@gmail.com>
2018-11-11 20:36:28 +00:00
Peter Kosyh
fea29e79c7 write_read_attr: fix truncated B_MAIL_ATTR_STATUS
This fix garbage attributes on e-mail messages on status changes.

Change-Id: I5293a0e71a1b84c04889fa3375488b0075aad12e
Reviewed-on: https://review.haiku-os.org/682
Reviewed-by: Adrien Destugues <pulkomandy@pulkomandy.tk>
2018-11-11 14:26:55 +00:00
Augustin Cavalier
23623eee9a registrar: Remove now-unused non-Haiku code. 2018-11-10 15:16:25 -05:00
Augustin Cavalier
387609c3be shortcuts: Remove #if __INTEL__.
This isn't true on x86_64 (so we were displaying the wrong key names there).
The actual names of the keys should probably be fetched from the selected
keyboard.
2018-11-10 15:02:04 -05:00
Augustin Cavalier
3bf15c7f86 shortcut_catcher: Remove non-Haiku code. 2018-11-10 15:01:45 -05:00
Augustin Cavalier
231ee3b8ad mail: Remove regex match limitation from the BeOS days.
It was still enabled on 32-bit x86...
2018-11-10 15:00:49 -05:00
Augustin Cavalier
1801b9565c BuildSetup: Don't define __x86_64__, GCC/Clang do this automatically. 2018-11-10 14:52:07 -05:00
Augustin Cavalier
d8b0a13568 build_cross_tools: export ACLOCAL to stop GCC from trying to use it.
This should fix the build of the crosstools on Haiku, CentOS, and
other platforms with versions of autofools too old or too new for
GCC 7.
2018-11-10 14:41:55 -05:00
Augustin Cavalier
68d50ca8a3 mail_daemon: Replace own_image with the one from PowerStatus.
We probably should make this a common function...

Fixes the mail status icon not appearing on x86_64, as __INTEL__ is
not defined there.
2018-11-10 14:28:26 -05:00
Augustin Cavalier
494a6e4e8e kernel/vm: Remove hacky stack dumper from vm_page_fault.
As the TODO said, we now have good userland debugging facilities, so
this isn't needed (and has been if 0'd out for almost a decade now.)
The dprintf on page faults may still be useful under rare circumstances,
but we already have a "TRACE_FAULTS" configuration for this file,
so guard it behind that.

Fixes part of #14360.
2018-11-10 14:12:18 -05:00
Adrien Destugues
e4425315dd Proofread and update the HIG
- Use neutral they to make the user (and in one instance, the
  'stereotypical lazy developer') gender neutral. Thanks to hacker news
  commenters for raising the issue.
- Various updates and clarifications on cursors (not restricted to black
  and white anymore), toolbars & about boxes (we now have a standard
  implementation for them), zooming (exemple more strongly showing that
  it should be "fit to contents" especially on modern high resolution
  displays)
- Reword english in some places

Change-Id: Ic8a392665c08e5186a1fb8aa95e4b741862a8dd7
Reviewed-on: https://review.haiku-os.org/681
Reviewed-by: waddlesplash <waddlesplash@gmail.com>
2018-11-09 21:43:21 +00:00
Adrien Destugues
d02879c185 HIG: rewrap
This will ease managing the doc and reviewing upcoming changes.
2018-11-09 20:48:44 +01:00
Adrien Destugues
c4bb4fbb7e Devices: remove "not implemented" driver line
This just confuses users. Let's re-add it when we have implemented it.
2018-11-09 20:30:39 +01:00
Adrien Destugues
0ca6ba69fa screenmode: remove leftover debug print. 2018-11-09 20:29:35 +01:00
Autocomitter
adba659760 Update translations from Pootle 2018-11-08 21:45:32 +00:00
Adrien Destugues
4c8208af52 ffmpeg: fix crash at end of video stream
Mixing new and old style decoding APIs won't work. And we were still
using the old API for managing the end of videos.

Change-Id: Ic194ab98721455658ecefde4f951c3f1e43ae1be
Reviewed-on: https://review.haiku-os.org/679
Reviewed-by: waddlesplash <waddlesplash@gmail.com>
2018-11-08 20:09:08 +00:00
Peter Kosyh
2e8be594e7 mail_daemon: IMAPConnectionWorker missing ::WorkerQuit() on errors
This fixes some crashes.

In _Worker thread on connect or process errors fOwner.WorkerQuit(this) was not called, leaving destroyed thread object in fWorkerMap and fWorkers.

Moreover, on connection problem the imap mailboxes was never checked on next planned sync because of non empty fWorkers.

Change-Id: I55ce6474b655fad5ddd8024225fc8f633bc35c48
Reviewed-on: https://review.haiku-os.org/678
Reviewed-by: Adrien Destugues <pulkomandy@pulkomandy.tk>
Reviewed-by: waddlesplash <waddlesplash@gmail.com>
2018-11-08 14:26:03 +00:00
waddlesplash
2cf9765df8 Revert "add-ons/mail_daemon: IMAP: limit UIDs in UID FETCH"
This reverts commit ed08b22dec.

See discussion on the commits mailing list (and on IRC.)
2018-11-07 19:03:30 -05:00
Peter Kosyh
3a469b95be mail_daemon: IMAP remove trailing space in flags list
This fixes STORE FLAGS request and gmail

Change-Id: I28c507244788e2e56e46bef428a465bd8d798d51
Reviewed-on: https://review.haiku-os.org/673
Reviewed-by: waddlesplash <waddlesplash@gmail.com>
2018-11-06 00:06:38 +00:00
Andrew Lindesay
4b30bf30b8 HaikuDepot : Handling for NULL Identity URLs on Repository Sources
Change-Id: I0f0094cf2ed38750dca4783b41f061977d833cea
Reviewed-on: https://review.haiku-os.org/677
Reviewed-by: waddlesplash <waddlesplash@gmail.com>
2018-11-06 00:06:10 +00:00
Axel Dörfler
419bc0a2ca Deskbar: Made the leaf scale with the font size
* It's now a vector icon as well.
* Vertical mode doesn't look that good anymore with higher font sizes,
  but I didn't understand how to do it properly.

Change-Id: I0eed0e2873b270c349dfd3af117cfcb751e590a1
Reviewed-on: https://review.haiku-os.org/671
Reviewed-by: Stephan Aßmus <superstippi@gmx.de>
2018-11-06 00:05:42 +00:00
Axel Dörfler
b791e997bf Tracker: Improved NavIcon spacing
* The spacing between icon and text now scales with the font size, too.
2018-11-05 22:41:32 +00:00
Axel Dörfler
a55e9f5235 Tracker: NavMenu icons scale with font size
* Moved icon size computation into separate utility function.
2018-11-05 22:20:55 +00:00
Axel Dörfler
fa584266d5 Tracker: Simplified test; fColumnList cannot be NULL 2018-11-05 22:20:55 +00:00
Peter Kosyh
f2d9de4577 mail_daemon: IMAP Settings.h DeleteRemoteWhenLocal forgotten prototype
this fixes broken build, sorry

Change-Id: I2d6dd152739ae1d7aefdf0c98732b9f302b90025
Reviewed-on: https://review.haiku-os.org/676
Reviewed-by: waddlesplash <waddlesplash@gmail.com>
2018-11-05 19:57:22 +00:00
Kacper Kasper
35a074e071 BStringView: fix #14680 2018-11-05 19:41:38 +01:00
Peter Kosyh
eef12cec97 mail_daemon: IMAP delete messages on the server only when delete_remote_when_local setting is set
Change-Id: I88fcc7a185cede080af7c3b85f9466a02f895809
Reviewed-on: https://review.haiku-os.org/674
Reviewed-by: Stephan Aßmus <superstippi@gmx.de>
2018-11-05 17:30:09 +00:00
Olivier Coursière
7c96721b51 Usability improvements in StartTeamWindow
- Enlarge the window's width so a larger part of the path will fit in the TextBox.

- Apply the existing path to the BFilePanel before browsing. It improve
usability when you paste a path or type a new one in the TextBox
then click on the browse button to choose the application
or fine tune the directory.

Please not that it is a best effort feature : if the file or the directory does
not exist, the BFilePanel will fallback to the old behavior :
showing the previously selected file/directory in the session
(or home directory).

Change-Id: I504a1ec72f9f7a236e2e37039961fddc58218eae
Reviewed-on: https://review.haiku-os.org/672
Reviewed-by: Rene Gollent <rene@gollent.com>
2018-11-05 00:01:36 +00:00
Augustin Cavalier
6ccc2b9f89 Tracker: Add some missing NULL checks.
Fixes #14685.
2018-11-04 15:38:21 -05:00
Augustin Cavalier
85f8e70013 Revert "jam: Fix bootstrap via absolutes in LD_LIBRARY_PATH"
This reverts commit 030d0eb58f.

It is absolutely not correct to assume PWD is the generated dir;
it may also be the repository root.

Fixes jam putting some build artifacts in the source tree.
2018-11-04 15:37:31 -05:00
Alexander von Gluck IV
5bd0fbd13a build: Add riscv architecture
* I mean, qemu 3.0 supports it.
* Nobody get excited, we need all the triplets added to
  our gcc buildtools. clang 7.0 seems to be cool with riscv though.

Change-Id: I17728163e4f28a3c16cee482a253364724b06f3a
2018-11-04 13:47:50 -06:00
Axel Dörfler
efafab643c Deskbar: Resizable tray
* Adds max width and height arguments to
  instantiate_deskbar_(item|entry).
* Old applications just stay with a 16x16 scaled icon, though.
* All used apps within the repository are converted to the new call
  besides the input_server input method icon (that will need further
  API changes in the input_server).

Change-Id: I29cc439396917be2c24135888459d31364997dff
Reviewed-on: https://review.haiku-os.org/656
Reviewed-by: waddlesplash <waddlesplash@gmail.com>
2018-11-04 19:00:49 +00:00
Peter Kosyh
1ad1c1c87b mail_daemon: ESMTP auth fix (250 AUTH reply)
See RFC 5231 (https://tools.ietf.org/html/rfc5321): "Following the normal
syntax for multiline replies, these keywords follow the code (250) and a
hyphen for all but the last line..."

Change-Id: I1ee533a332d1e18ffddd4ad1520d14f4013b739e
Reviewed-on: https://review.haiku-os.org/670
Reviewed-by: waddlesplash <waddlesplash@gmail.com>
2018-11-04 18:57:28 +00:00
Axel Dörfler
b5ecd7c203 DirectWindowStars: Fixed 64-bit build 2018-11-04 18:37:55 +00:00
Axel Dörfler
0f03d737b9 Tracker: List view icons now grow with font size
* This also removes the mini/large icon mode for list views; it's now
  simply always matching your font size.

Change-Id: Ieedd86cc3a50dd0f950d97bbd9839384d44f8bd3
Reviewed-on: https://review.haiku-os.org/662
Reviewed-by: waddlesplash <waddlesplash@gmail.com>
2018-11-04 17:36:50 +00:00
Peter Kosyh
65d8c2f34f mail_daemon: ErrorLogWindow fix forever ResizeTo
Change-Id: Ibd5721ff7c9bfd7fcee30438b61a63720f1a6206
Reviewed-on: https://review.haiku-os.org/668
Reviewed-by: waddlesplash <waddlesplash@gmail.com>
2018-11-04 17:05:53 +00:00
Adrien Destugues
5e14319a11 ffmpeg: use new producer/consumer API for video decoding
This API allows us to send whole packets no matter how the video is
formatted, and get frames out as they are ready (sometimes multiple
frames per packets, which did not work well with the previous API).

Change-Id: I0bd7d4706e330bb11d87cb41e93cfc6995b4b3a5
Reviewed-on: https://review.haiku-os.org/665
Reviewed-by: waddlesplash <waddlesplash@gmail.com>
2018-11-04 17:04:06 +00:00
Adrien Destugues
ce402e82f2 ffmpeg: remove deprecated comment.
This field is deprecated.

Change-Id: I18c3b89ef7438c61b464aaf8bebc1484bf479d6b
Reviewed-on: https://review.haiku-os.org/664
Reviewed-by: waddlesplash <waddlesplash@gmail.com>
2018-11-04 17:03:13 +00:00
Adrien Destugues
9e2c056c27 ffmpeg: fix timestamp tracing
Use ffmpeg functions to format the timestamps.

Change-Id: Idd51feb22fc6c5a70e177604eb995ae2d8601cd4
Reviewed-on: https://review.haiku-os.org/663
Reviewed-by: waddlesplash <waddlesplash@gmail.com>
2018-11-04 17:03:13 +00:00
Alexander von Gluck IV
8850049390 docker/bootstrap: Add missing pkg-config for ICU
* ARM now gets up to the ICU build failures. (yay?)

Change-Id: Iaad978fe86f8cbb57e553bc3584bd8351559c7dc
2018-11-04 09:13:24 -06:00
Alexander von Gluck IV
3a92284113 docker/bootstrap: Make README.md a bit more detailed
Change-Id: If095b584cd99521770280533359da5024ff745bf
2018-11-04 09:05:15 -06:00
Alexander von Gluck IV
1b7e0197c1 docker/bootstrap: zlib needs cmake
Change-Id: I460f811bd2ea144ea8121772024e19686e2fa9bb
2018-11-04 09:04:48 -06:00
Alexander von Gluck IV
030d0eb58f jam: Fix bootstrap via absolutes in LD_LIBRARY_PATH
* The PWD's are live based on jam run location which means
  they shouldn't bind the generated directory to a fixed path
  as before.
* We also need an absolute LD_LIBRARY PATH since haikuporter
  loses the context invoking host tools.
* I don't think we can run jam from outside of the generated
  directory anymore... but I don't think that was a thing.

Change-Id: I020f902ce5235bf268c9075d6e2ae85296a4ad20
2018-11-04 08:39:01 -06:00
Alexander von Gluck IV
9f35df2324 docker/bootstrap: Add --debug to get better haikuporter debug output
Change-Id: I8e9a093a28c96b334f3747d1624b9ee6d5fe9844
2018-11-04 08:37:54 -06:00
Augustin Cavalier
c87601b89a ps2: Fix Werrors. 2018-11-03 15:22:53 -04:00
Augustin Cavalier
4e1ffc1266 freebsd11_network: Add "return 0" to placate warning. 2018-11-03 15:22:30 -04:00
Axel Dörfler
1fab551726 Deskbar: Center window icons in WindowMenuItem
* They had a fixed top offset which looked bad with larger font sizes.
* The icons should be replaced with vector icons, though, and properly
  resized.
2018-11-03 20:03:16 +00:00
Axel Dörfler
5fd3bc6d2c BDeskbar: Moved constants to shared header
* Instead of duplicating them in different files.
2018-11-03 20:03:15 +00:00
Kuroneko
ed08b22dec add-ons/mail_daemon: IMAP: limit UIDs in UID FETCH
Some IMAP servers (such as dovecot) have hard line length limits for
commands.

The way UID FETCH was being scheduled was creating FETCHes longer than
the maximum length.

Limit these to a reasonable number of UIDs per fetch, such that we have
a hope of success when facing monsterous mailboxes.

Change-Id: I8a2184eec1b8fcab6f7914a9b14ad008700b96d1
Signed-off-by: Augustin Cavalier <waddlesplash@gmail.com>
Reviewed-on: https://review.haiku-os.org/c/haiku/+/626

Style fixes by me, and also replaced emplace_back with push_back
for GCC2 compatibility.
2018-11-03 14:45:50 -04:00