Commit Graph

86 Commits

Author SHA1 Message Date
dholland
9cdcb5fdab Use bool (not int) for a boolean return type. 2014-03-30 05:53:12 +00:00
dholland
c560d1b163 Remove SHORTLEN and LONGLEN defines; use sizeof() properly instead.
Fix two semi-compensating size bugs in wire transmission affecting
64-bit machines.
2014-03-30 05:30:28 +00:00
dholland
9e2af583dd Remove all the conditional compilation for INTERNET. Now you can run
this on either a local or internet socket (including via inetd on
either) and it will, or is supposed to, DTRT.

Does not really support ipv6 yet, but in a number of places will no
longer vomit or exhibit UB if it encounters an ipv6 address.
2014-03-30 01:44:37 +00:00
dholland
8c7631b6e4 Clean up the names of the various pieces of socket apparatus.
Systematic naming is easier to follow...
2014-03-30 00:26:58 +00:00
dholland
f0ab07d690 fix non-INTERNET build 2014-03-29 23:44:38 +00:00
dholland
ec434f4b81 Er oops, fix previous. 2014-03-29 22:30:27 +00:00
dholland
865e0d6472 Reduce ifdefs by making a common function to talk to either syslogd or
stderr.
2014-03-29 22:29:55 +00:00
dholland
98db4e3267 handle compiled-in pathnames the customary way 2014-03-29 22:11:19 +00:00
dholland
ecca92983f Additional minor cleanup and remove a straggler data declaration
from hunt_common.h.
2014-03-29 21:55:59 +00:00
dholland
506bf125f4 Group function declarations by which source file they come from, and
delete several that don't actually exist.
2014-03-29 21:43:46 +00:00
dholland
e195993756 be consistent about whether functions are static 2014-03-29 21:38:54 +00:00
dholland
b19465b277 sprinkle static 2014-03-29 21:33:41 +00:00
dholland
f1eb9b5b9c Flush unwanted file. 2014-03-29 21:27:40 +00:00
dholland
39032702fc Move definitions to the file they're used in. 2014-03-29 21:27:08 +00:00
dholland
15b06d8071 move a comment that should have gone with its symbol 2014-03-29 21:25:35 +00:00
dholland
b833a6b3f7 Remove tautological #if DEBUG. 2014-03-29 21:24:56 +00:00
dholland
ff658bd09f Split hunt and huntd's includes, instead of incestuously sharing a pile
of external data and function declarations between the two programs.

Common constants and defines now go in hunt_common.h. Stuff that belongs
only to hunt is in hunt/hunt_private.h. Stuff that belongs only to huntd
is in huntd/hunt.h.

Copy some declarations that are used in both programs under the same
names (but are not actually the same objects) from huntd/hunt.h to
hunt/hunt_private.h. Move others that are only used in hunt. Remove
some entirely unused material, and tidy up standard includes.
2014-03-29 21:24:26 +00:00
dholland
8f371b472c tsort contents of file 2014-03-29 20:44:20 +00:00
dholland
1b82cc9fb5 const in unused code 2014-03-29 20:41:57 +00:00
dholland
54eb2b3816 remove stubbed-out function 2014-03-29 20:35:30 +00:00
dholland
263e041ca2 Rip out the code that broadcasts talk requests to the local
hunt-players mailing list.

In this day and age it doesn't even begin to work: even if you were to
have such a mailing list locally, sendmail wouldn't expand it for you,
the addresses you got back wouldn't be talk-requestable addresses,
talk requests don't cross NAT or firewalls safely, talk doesn't
support ipv6, and nobody runs talkd anyway.

It doesn't make sense to try to replace it with some other kind of
notify scheme either; there might still be a multiuser machine
somewhere with enough simultaneous users that broadcasting something
akin to talk requests locally might make sense, and where a nontrivial
number of the users actually play hunt, but probably not, and if so
those users are likely to be better off using wall(1) anyway. Nowadays
games will be set up by looking for people in chat or by emailing or
texting friends.

Theoretically someone could set up an internet hunt metaserver for
finding hunt games, but that would be something entirely different
anyway and I doubt there's demand.
2014-03-29 20:32:04 +00:00
dholland
d39951fe62 Remove empty header file. 2014-03-29 20:16:09 +00:00
dholland
7004aab3ca Use setproctitle() instead of handrolled version. 2014-03-29 20:12:12 +00:00
dholland
7b718e7cd8 Make the code for issuing talk requests to find players actually build. 2014-03-29 20:10:10 +00:00
dholland
37a43147ab don't declare own boolean type 2014-03-29 19:41:10 +00:00
dholland
208bf48e82 use random(), not a handrolled 16-bit generator 2014-03-29 19:33:03 +00:00
dholland
329b34a67e Use getaddrinfo() instead of gethostbyname(). 2014-03-29 19:26:28 +00:00
dholland
d509fb9f42 typo in error message 2014-03-29 19:03:21 +00:00
dholland
267ec317ae const 2014-03-29 19:02:12 +00:00
dholland
8a64b7f83c simplify silly logic 2014-03-29 19:01:00 +00:00
apb
27e71a78a5 If you are going to use memcpy instead of struct assignment, then at
least use sizeof(the correct variable).  The use of memcmp to test
two pointers for equality, one line earlier, is also weird but may be
correct.
2014-03-28 17:49:11 +00:00
christos
193b880fad fix unused variable warnings 2013-10-19 17:19:30 +00:00
njoly
84e9c4d0dc Fix sendmail section (8 -> 1) in xrefs. 2013-07-09 09:41:30 +00:00
plunky
9f61b80465 NULL does not need a cast 2011-08-31 16:24:54 +00:00
joerg
1a5e0fc9be #if 0 some unused code. 2011-05-23 22:58:44 +00:00
dholland
9ac5061b87 u_int32_t -> uint32_t 2009-08-27 00:36:32 +00:00
dholland
75b3905d60 sprinkle static and prune some dead code 2009-08-12 07:42:11 +00:00
dholland
81eafd7899 Remove config options for 4.2BSD and 4.3BSD, and associated code. Highly
obsolete, and I doubt most of it still worked anyway.
2009-07-04 07:51:34 +00:00
dholland
57ba7791b7 Remove the non-curses screen handling, since it relies on knowing
about various internals of SVR4 curses, old BSD curses, and/or other
unclean things. (Yes, the non-curses handling still used bits of
curses. Fie.)
2009-07-04 07:10:22 +00:00
dholland
cda8e486de Remove config for the return type of signal handlers, which is also a
long-dead issue.
2009-07-04 06:38:34 +00:00
dholland
765594d234 Remove references to config #defines for the thoroughly obsolete
4.2BSD syslog API.
2009-07-04 06:31:31 +00:00
dholland
c41c818a00 more whitespace 2009-07-04 06:19:05 +00:00
dholland
b2f99339f0 Whitespace. 2009-07-04 04:29:54 +00:00
dholland
db04762fba Sigh, more of the same (missed two) 2009-07-04 03:29:20 +00:00
dholland
b00a6a7437 __attribute__((__noreturn__)) -> __dead 2009-07-04 03:27:57 +00:00
dholland
fbca3d8cfa ANSIfy function declarations. 2009-07-04 01:58:57 +00:00
dholland
6ffae66268 Remove a pile of bogus casts. One object file diff, crosschecked and
found harmless.
2009-07-04 01:01:18 +00:00
dholland
0ed1b742e0 sprintf -> snprintf 2009-06-28 21:12:10 +00:00
dholland
4c08f5f97e Fix possible remote DoS of a running hunt game, and prevent a possible
theoretical attack involving >= 1 billion ammo.
2009-06-28 18:59:37 +00:00
joerg
25e7748736 Fix preamble 2009-03-11 13:01:49 +00:00