If you are going to use memcpy instead of struct assignment, then at

least use sizeof(the correct variable).  The use of memcmp to test
two pointers for equality, one line earlier, is also weird but may be
correct.
This commit is contained in:
apb 2014-03-28 17:49:11 +00:00
parent 59200c73fc
commit 27e71a78a5
1 changed files with 3 additions and 3 deletions

View File

@ -1,4 +1,4 @@
/* $NetBSD: get_names.c,v 1.10 2009/07/04 04:29:55 dholland Exp $ */
/* $NetBSD: get_names.c,v 1.11 2014/03/28 17:49:11 apb Exp $ */
/*
* Copyright (c) 1983-2003, Regents of the University of California.
* All rights reserved.
@ -32,7 +32,7 @@
#include <sys/cdefs.h>
#ifndef lint
__RCSID("$NetBSD: get_names.c,v 1.10 2009/07/04 04:29:55 dholland Exp $");
__RCSID("$NetBSD: get_names.c,v 1.11 2014/03/28 17:49:11 apb Exp $");
#endif /* not lint */
#include "bsd.h"
@ -146,7 +146,7 @@ get_remote_name(char *his_address)
if (memcmp(&his_machine_name, &my_machine_name,
sizeof(his_machine_name)) == 0)
memcpy(&his_machine_addr, &my_machine_addr,
sizeof(his_machine_name));
sizeof(his_machine_addr));
else {
/* look up the address of the recipient's machine */
hp = gethostbyname(his_machine_name);