Commit Graph

151 Commits

Author SHA1 Message Date
mrg
b609b30b6c adjust a fallthru comment and add a missing break. 2019-10-13 07:42:57 +00:00
mrg
de11d87641 introduce some common variables for use in GCC warning disables:
GCC_NO_FORMAT_TRUNCATION    -Wno-format-truncation (GCC 7/8)
GCC_NO_STRINGOP_TRUNCATION  -Wno-stringop-truncation (GCC 8)
GCC_NO_STRINGOP_OVERFLOW    -Wno-stringop-overflow (GCC 8)
GCC_NO_CAST_FUNCTION_TYPE   -Wno-cast-function-type (GCC 8)

use these to turn off warnings for most GCC-8 complaints.  many
of these are false positives, most of the real bugs are already
commited, or are yet to come.


we plan to introduce versions of (some?) of these that use the
"-Wno-error=" form, which still displays the warnings but does
not make it an error, and all of the above will be re-considered
as either being "fix me" (warning still displayed) or "warning
is wrong."
2019-10-13 07:28:04 +00:00
mrg
21303c93e9 convert HAVE_GCC == 7 to HAVE_GCC >= 7. 2019-09-29 23:44:58 +00:00
mrg
a5ca97c6e5 apply -Wno-error=implicit-fallthrough on files that have fallthru
comments but are missed by the current checker.
2019-02-04 09:51:47 +00:00
skrll
eec6f7013a Remove unused. 2014-03-30 09:11:50 +00:00
dholland
9cdcb5fdab Use bool (not int) for a boolean return type. 2014-03-30 05:53:12 +00:00
dholland
f2f2077532 Use the curses beep function instead of writing a beep to stdout. 2014-03-30 05:48:35 +00:00
dholland
3d0af5d09f curses has printw, use it. 2014-03-30 05:46:54 +00:00
dholland
7a606e3ec4 don't use the preprocessor to rename curses functions, just call them 2014-03-30 05:44:55 +00:00
dholland
290fd62765 fix off-by-one 2014-03-30 05:41:50 +00:00
dholland
ea57ad9ea1 Instead of #define STDIN 0, use STDIN_FILENO. 2014-03-30 05:38:13 +00:00
dholland
c560d1b163 Remove SHORTLEN and LONGLEN defines; use sizeof() properly instead.
Fix two semi-compensating size bugs in wire transmission affecting
64-bit machines.
2014-03-30 05:30:28 +00:00
dholland
b57df0f022 Naming reform for socket pieces, akin to what I did in huntd earlier.
(but not as comprehensive)
2014-03-30 05:14:47 +00:00
dholland
5c657efd0e I wish the socket API didn't require casts. Easy to mess them up. 2014-03-30 04:57:37 +00:00
dholland
e25cca1c03 fix obvious mistake (seems to have been there since 4.4) 2014-03-30 04:40:50 +00:00
dholland
90606027c5 Tidy up list of broadcast addresses. 2014-03-30 04:39:40 +00:00
dholland
319c22dff7 Clean up the handling of the list of hunt daemons. 2014-03-30 04:31:21 +00:00
dholland
2509088ed2 use fewer globals 2014-03-30 03:35:26 +00:00
dholland
78a2d83843 more cleanup 2014-03-30 03:26:19 +00:00
dholland
15043e8a8f unexpose some globals that server.c previously required 2014-03-30 02:58:25 +00:00
dholland
3d3dd0d453 name reform, fewer file statics 2014-03-30 02:53:11 +00:00
dholland
61623de9c7 goto considered harmful 2014-03-30 02:46:57 +00:00
dholland
082c40f53a split off a bunch of the nastier network code into its own file 2014-03-30 02:26:09 +00:00
dholland
38f4986ae9 When indexing an array with a char, cast it to unsigned char, not int,
to not only silence the compiler warning but also get the correct
behavior.
2014-03-30 02:11:25 +00:00
dholland
9e2af583dd Remove all the conditional compilation for INTERNET. Now you can run
this on either a local or internet socket (including via inetd on
either) and it will, or is supposed to, DTRT.

Does not really support ipv6 yet, but in a number of places will no
longer vomit or exhibit UB if it encounters an ipv6 address.
2014-03-30 01:44:37 +00:00
dholland
8c7631b6e4 Clean up the names of the various pieces of socket apparatus.
Systematic naming is easier to follow...
2014-03-30 00:26:58 +00:00
dholland
f0ab07d690 fix non-INTERNET build 2014-03-29 23:44:38 +00:00
dholland
ec434f4b81 Er oops, fix previous. 2014-03-29 22:30:27 +00:00
dholland
865e0d6472 Reduce ifdefs by making a common function to talk to either syslogd or
stderr.
2014-03-29 22:29:55 +00:00
dholland
375031264b group external functions by where they come from 2014-03-29 22:15:26 +00:00
dholland
80f7486c03 be consistent about whether functions are static 2014-03-29 22:15:13 +00:00
dholland
98db4e3267 handle compiled-in pathnames the customary way 2014-03-29 22:11:19 +00:00
dholland
af8c06ff02 make some globals static 2014-03-29 22:05:44 +00:00
dholland
ecca92983f Additional minor cleanup and remove a straggler data declaration
from hunt_common.h.
2014-03-29 21:55:59 +00:00
dholland
506bf125f4 Group function declarations by which source file they come from, and
delete several that don't actually exist.
2014-03-29 21:43:46 +00:00
dholland
e195993756 be consistent about whether functions are static 2014-03-29 21:38:54 +00:00
dholland
b19465b277 sprinkle static 2014-03-29 21:33:41 +00:00
dholland
f1eb9b5b9c Flush unwanted file. 2014-03-29 21:27:40 +00:00
dholland
39032702fc Move definitions to the file they're used in. 2014-03-29 21:27:08 +00:00
dholland
15b06d8071 move a comment that should have gone with its symbol 2014-03-29 21:25:35 +00:00
dholland
b833a6b3f7 Remove tautological #if DEBUG. 2014-03-29 21:24:56 +00:00
dholland
ff658bd09f Split hunt and huntd's includes, instead of incestuously sharing a pile
of external data and function declarations between the two programs.

Common constants and defines now go in hunt_common.h. Stuff that belongs
only to hunt is in hunt/hunt_private.h. Stuff that belongs only to huntd
is in huntd/hunt.h.

Copy some declarations that are used in both programs under the same
names (but are not actually the same objects) from huntd/hunt.h to
hunt/hunt_private.h. Move others that are only used in hunt. Remove
some entirely unused material, and tidy up standard includes.
2014-03-29 21:24:26 +00:00
dholland
d07915f9b3 Remove unsafe and unnecessary pointer casts. 2014-03-29 20:53:55 +00:00
dholland
c6e948ac19 catch up to huntd changes.
XXX: this needs to stop promiscuously sharing .h files.
2014-03-29 20:52:13 +00:00
dholland
8f371b472c tsort contents of file 2014-03-29 20:44:20 +00:00
dholland
1b82cc9fb5 const in unused code 2014-03-29 20:41:57 +00:00
dholland
54eb2b3816 remove stubbed-out function 2014-03-29 20:35:30 +00:00
dholland
263e041ca2 Rip out the code that broadcasts talk requests to the local
hunt-players mailing list.

In this day and age it doesn't even begin to work: even if you were to
have such a mailing list locally, sendmail wouldn't expand it for you,
the addresses you got back wouldn't be talk-requestable addresses,
talk requests don't cross NAT or firewalls safely, talk doesn't
support ipv6, and nobody runs talkd anyway.

It doesn't make sense to try to replace it with some other kind of
notify scheme either; there might still be a multiuser machine
somewhere with enough simultaneous users that broadcasting something
akin to talk requests locally might make sense, and where a nontrivial
number of the users actually play hunt, but probably not, and if so
those users are likely to be better off using wall(1) anyway. Nowadays
games will be set up by looking for people in chat or by emailing or
texting friends.

Theoretically someone could set up an internet hunt metaserver for
finding hunt games, but that would be something entirely different
anyway and I doubt there's demand.
2014-03-29 20:32:04 +00:00
dholland
d39951fe62 Remove empty header file. 2014-03-29 20:16:09 +00:00
dholland
7004aab3ca Use setproctitle() instead of handrolled version. 2014-03-29 20:12:12 +00:00