Commit Graph

2611 Commits

Author SHA1 Message Date
Pavel Roskin
e17a56efb6 Call auth_end() exactly once in scp_v0_process()
As discovered by Valgrind, it wasn't called at all in case of a
successful session creation, which leaked memory.
2016-10-21 20:15:50 +00:00
Pavel Roskin
65ac8e758b Fix memory leak: free session data
Call scp_session_destroy() in the functions that call
scp_session_create() and nowhere else.

As found by Valgrind, the session data is not freed if the session is
created successfully.
2016-10-21 20:15:50 +00:00
Itamar Reis Peixoto
8bf28e45c4 Merge pull request #445 from proski/noextra
Avoid using non-standard Automake variables starting with "EXTRA"
2016-10-21 16:55:55 -02:00
Pavel Roskin
a370306f75 Get rid of EXTRA_LIBS, use variables with more specific names 2016-10-20 10:43:02 -07:00
Pavel Roskin
5c69f3cd57 Eliminate EXTRA_FLAGS, it's a poor name, use AM_LDFLAGS 2016-10-20 10:43:02 -07:00
Pavel Roskin
0422734fc7 Merge EXTRA_DEFINES and EXTRA_INCLUDES into AM_CPPFLAGS
AM_CPPFLAGS is a documented Automake variable for C preprocessor flags
that should not be overridden when compiling the package.

There is no need to have two additional variables that are ultimately
merged into AM_CPPFLAGS.

Their names are also confusing. EXTDA_DIST is a documented Automake
variable. Everything else that starts with "EXTRA" is not.
2016-10-20 10:43:02 -07:00
Koichiro IWAO
85e98d211a Update file-loc.txt 2016-10-20 16:05:43 +09:00
metalefty
0c4c52878a Merge pull request #444 from proski/trivial
Simple changes, mostly log messages and documentation
2016-10-20 15:52:25 +09:00
Pavel Roskin
6fef1e4eb5 Use const pointers in function arguments when possible 2016-10-17 08:54:07 -07:00
Pavel Roskin
bc868b96b1 Remove text2bool() from log.h, there is no such function 2016-10-17 08:54:07 -07:00
Pavel Roskin
09746fcebc Leave only one "autorun" in xrdp.ini, improve comment 2016-10-17 08:54:07 -07:00
Pavel Roskin
c3b99de739 Fix wrong comments in sesman config printing code 2016-10-17 08:54:07 -07:00
Pavel Roskin
bf08892622 Fix incorrect description of auth_userpass() return value 2016-10-17 08:54:07 -07:00
Pavel Roskin
a618d4f757 Don't use final newline in log calls, it's already appended 2016-10-17 08:54:07 -07:00
Pavel Roskin
424cef464b Log malloc errors with LOG_LEVEL_ERROR 2016-10-17 08:38:22 -07:00
Pavel Roskin
9ac592b218 Don't use term "missing" when using default files, it's too alarming
Also improve messages when non-absolute path is rejected.
2016-10-17 08:38:22 -07:00
Pavel Roskin
acdfc94511 Merge prog_std.txt into coding_style.md 2016-10-17 08:38:22 -07:00
metalefty
c9108242cd Merge pull request #434 from proski/buildx
Fixes for x11rdp build
2016-10-17 17:21:32 +09:00
Koichiro IWAO
ee3a38f93d xrdp: librfxcodc link fix
as same fix as done in 4a815d5 for libpainter
2016-10-13 14:07:53 +09:00
jsorg71
1a69dbe119 Merge pull request #435 from metalefty/update-submodules
Update xorgxrdp and librfxcodec
2016-10-12 00:58:19 -07:00
Pavel Roskin
bc5e166f13 Move libXdmcp above libxcb, libxcb can use it 2016-10-09 21:35:30 -07:00
Pavel Roskin
293d8b4b79 Add *.a to top .gitignore, add xorg/X11R7.6/.gitignore 2016-10-09 21:35:27 -07:00
Pavel Roskin
3cf67c684b buildx.sh: force forward patch, don't ask whether to revert 2016-10-09 21:35:23 -07:00
Koichiro IWAO
3bdce59160 librfxcodec=845ee8c 2016-10-09 00:07:55 +09:00
Koichiro IWAO
1f587945cf xorgxrdp=822e3b8 2016-10-09 00:06:26 +09:00
Pavel Roskin
6247a3afac buildx.sh: remove special case for python, it's not built anymore 2016-10-08 02:02:07 +00:00
Pavel Roskin
d602e71465 Change compilation order to resolve dependencies
With this change, buildx.sh succeeds on a system without pre-existing
X11 installation.
2016-10-08 02:02:07 +00:00
Pavel Roskin
b2bbaef640 buildx.sh: utilize all available CPUs when compiling 2016-10-08 02:02:07 +00:00
Pavel Roskin
8e7d12ff50 buildx.sh: "clean" is a constant string, not a semantic variable 2016-10-08 02:02:07 +00:00
Pavel Roskin
22c370a6a1 buildx.sh: use "mkdir -p" to create $PREFIX_DIR, don't retry
Improve messages about $PREFIX_DIR
2016-10-08 02:02:07 +00:00
metalefty
132cc10f75 Merge pull request #431 from metalefty/remove-python-from-x11rdp
X11rdp: remove python as it isn't really needed these days
2016-10-06 18:57:19 +09:00
Koichiro IWAO
1612730140 X11rdp: remove python as it isn't really needed these days
Closes #399.
2016-10-05 09:52:29 +09:00
Jay Sorg
b24f8d8fef remove a debug message 2016-10-03 20:34:12 -07:00
Jay Sorg
409878666f xrdp: handle 3 byte PDU 2016-10-03 20:05:14 -07:00
metalefty
f0c0976d1d Merge pull request #411 from proski/socket_close
Cleaning up bogus messages about closing "established" connections to NULL:NULL
2016-09-20 17:56:38 +09:00
metalefty
ba78399122 Merge pull request #417 from metalefty/apply-keyboard-options
Apply xkb options for x11rdp
2016-09-09 16:04:43 +09:00
Pavel Roskin
7d03d1a3e9 Fix outgoing connections on Mac OSX
connect() on an already established connection returns error with errno
set to EISCONN. Treat it as success.
2016-09-08 22:28:38 -07:00
Pavel Roskin
5465b8c85e Add socklen_t check with substitution, use socklen_t as needed 2016-09-08 20:26:19 -07:00
Pavel Roskin
49ae93130a Improve message about listening socket is a wrong state 2016-09-08 20:26:19 -07:00
Pavel Roskin
945833a94f Don't close socket in scp_process_start(), the caller closes it 2016-09-08 20:26:19 -07:00
Pavel Roskin
f7c27f05cf g_term_event is a wait object, not TCP socket, delete it correctly 2016-09-08 20:26:19 -07:00
Pavel Roskin
931fb90832 sesrun: remove unused g_sck and write-only g_pid 2016-09-08 20:26:19 -07:00
Pavel Roskin
d605310bdc sesman: don't close listening socket in signal handler
It is closed when the main loop terminates.
2016-09-08 20:26:19 -07:00
Pavel Roskin
6f4ffa769c Improve debug information when closing a socket
Don't assume AF_INET family. Don't assume the socket is connected. Report
local address and port. Don't try to close non-sockets and invalid file
descriptors. Report errors getting socket information and closing the
socket. Use more appropriate log levels.
2016-09-08 20:26:19 -07:00
metalefty
c02f18993a Merge pull request #420 from proski/uk-keyboard
Add UK English keyboard and code to generate it
2016-09-09 00:11:29 +09:00
Koichiro IWAO
e2d4b65787 libxrdp: cleanup log log in xrdp_load_keyboard_layout 2016-09-06 15:55:11 +09:00
Pavel Roskin
7e8863b0f2 Add UK English keyboard and code to generate it 2016-09-05 22:12:17 -07:00
Koichiro IWAO
2488159645 libxrdp: log keyboard type/subtype 2016-09-02 13:44:11 +09:00
Koichiro IWAO
644242fc53 libxrdp: log keyboard options 2016-09-02 13:44:11 +09:00
Koichiro IWAO
bc37e5aaac x11rdp: apply keyboard options 2016-09-02 13:44:11 +09:00