Commit Graph

4282 Commits

Author SHA1 Message Date
Nexarian
ba0e75f8be Utility functions for xrdp regions and tests
- xrdp_region_get_bounds
- xrdp_region_not_empty
- Incorporate example usage of cmocka
- Cmocka doesn't work with C++
2023-02-13 23:46:39 -05:00
matt335672
11a8823a3a
Merge pull request #2550 from matt335672/fix_libipm_doxygen_errors
Fix doxygen warnings for libipm
2023-02-13 21:26:00 +00:00
matt335672
b9a12257fc Fix doxygen warnings for libipm 2023-02-13 20:44:52 +00:00
matt335672
54db636e76
Merge pull request #2497 from matt335672/use_poll
Use poll() instead of select()
2023-02-13 14:37:00 +00:00
matt335672
86d0d0e9fd Addressed review comments 2023-02-13 14:28:29 +00:00
matt335672
acdfd12cb6 Fix typo in chansrv_fuse.c
The code as it stands is checking two file descriptors for possible
input, but only one needs to be checked.
2023-02-13 14:28:29 +00:00
matt335672
78fa1c15b2 Replace select() system call with poll()
poll() is specified in POSIX.1-2001 as a simpler interface for
multiplexed file descriptors than select(). It also provides more
functionality.

This PR replaces the select() calls used in xrdp with poll()
equivalents.
2023-02-13 14:28:29 +00:00
matt335672
b414cfcd5e
Merge pull request #2536 from matt335672/list_improvements
Add memory allocation checking to the list module
2023-02-13 14:23:23 +00:00
matt335672
994418cd90 Add simple list test cases 2023-02-13 10:37:46 +00:00
matt335672
5aa5624551 Add memory allocation checking to the list module
The list module lacks memory allocation checking, and
consequently can coredump on list_create() or
list_add_item().
2023-02-13 10:37:46 +00:00
matt335672
a27440c237
Merge pull request #2492 from derekschrock/randr-wait
Add xrdp-waitforx to wait for X to start with RandR outputs
2023-02-13 10:29:22 +00:00
metalefty
f3dc94448c
Merge pull request #2537 from metalefty/sound-log
sound: logging improvements
2023-02-13 10:38:31 +09:00
Derek Schrock
cb39b84de5 Use g_set_alarm and g_sleep 2023-02-11 18:01:12 -05:00
Derek Schrock
1e5b42893c Add g_set_alarm to set an alarm calling func after secs seconds 2023-02-11 18:01:12 -05:00
Derek Schrock
829378bba8 Add xrdp-waitforx to wait for X to start with RandR outputs
For some window managers (fvwm2 and fvwm3) if the X server isn't
running and has output it's possible for the window manager to fail or
reconfigure randr incorrectly.

With xrdp-waitfox:
 - Install xrdp-waitfox to the BIN dir.
 - sesman will run xrdp-waitfox as the logged in user.
 - Set an alarm to exit after 30 seconds.
 - Try to open env DISPLAY value's display (10 seconds).
 - Test for RandR extension.
 - Wait for outputs to appear (10 seconds).
2023-02-11 18:01:10 -05:00
Nexarian
9bab8e0da5
Merge pull request #2545 from Nexarian/add-free-to-egfx-unit-test
Add free to egfx unit tests
2023-02-11 12:16:02 -05:00
Nexarian
b1edd4ff05
Merge pull request #2544 from Nexarian/add-unit-test-parameter
Add unit test parameter for more coverage.
2023-02-11 12:15:23 -05:00
Nexarian
259be09334 Add free to egfx unit tests 2023-02-11 00:39:03 -05:00
Nexarian
d3be110ffc Add unit test parameter for more coverage. 2023-02-11 00:28:30 -05:00
Koichiro IWAO
9d7a817e87 chansrv/audin: return UNKNOWN when undefined value
is passed to audin_wave_format_tag_to_str.
2023-02-11 11:51:08 +09:00
metalefty
c463a0e865
Merge pull request #2541 from metalefty/log_time
log: fix syslog glitch after #2386
2023-02-10 09:06:12 +09:00
Koichiro IWAO
ec2f165af4 log: fix syslog glitch after #2386
The tail of new datetime format was sticking out.
2023-02-09 17:09:28 +09:00
Hiero32
1ffe7890d8
sound: fix noise between two playbacks for mp3/aac (#2519)
* sound: fix noise between two playbacks for mp3/aac
* fix sound stuttered on skip operation of vlc
2023-02-09 10:09:04 +09:00
Koichiro IWAO
73a8865561 chansrv/audin,sound: record index of formats array
It helps to know which audio format is in use.
2023-02-09 01:21:45 +09:00
Koichiro IWAO
a355b7bf98 chansrv/audin: record audin (microphone redirection) audio formats 2023-02-09 01:06:44 +09:00
Koichiro IWAO
264ee4a761 chansrv/sound: adjust log level and record wFormatTag as string
These log levels are unintendedly decreased during logging reworking.

Recording audio formats are useful to know which format is used in
current RDP session.
2023-02-09 01:06:44 +09:00
Koichiro IWAO
5f07c648e4 chansrv: add a utility function to convert wFormatTag into string 2023-02-09 01:06:44 +09:00
Nexarian
4b4989b6a7
Merge pull request #2534 from Nexarian/Nexarian/add-core-cmocka-framework
Add core cmocka framework
2023-02-07 08:49:40 -05:00
Nexarian
ddba7a317a Add core cmocka framework
Initial integration with cmocka.

The intent is to first apply this to the xrdp unit tests, but until
something uses it directly we'll hold off on updating the Makefile.
2023-02-06 22:47:04 -05:00
Nexarian
dd03a1ad10
Merge pull request #2531 from Nexarian/Nexarian/update-github-ci-unit-testing
Improvements for unit testing
2023-02-06 09:56:49 -05:00
Nexarian
e92ee19d97
Merge pull request #2532 from Nexarian/Nexarian/fix-xrdp-types-include-list16
xrdp_types.h uses list16
2023-02-06 09:56:27 -05:00
Nexarian
7542dfc4f2
Merge pull request #2533 from Nexarian/Nexarian/update-pixman-region-header
Add functions and reformat pixman-region.h
2023-02-05 19:16:53 -05:00
Nexarian
7520c69049 Add functions and reformat pixman-region.h
- Update pixman-region.h header
-- Reformat so all lines fit within 80 characters.
-- Update define guard to use convention for the rest of XRDP.

Add pixman_region_not_empty and pixman_region_extents in anticipation of
using it for EGFX in the future.
2023-02-04 15:07:13 -05:00
Nexarian
61c11891be xrdp_types.h uses list16
- Declare list16 explicitly as a type that's used so the header will
  compile standalone.
2023-02-04 15:01:58 -05:00
Nexarian
ee4b57b4c9 Improvements for unit testing
- Set max features to enable tests
- Add names to each step
- Enable test-suite.log artifact upload for distcheck.
2023-02-04 14:56:51 -05:00
matt335672
04a9c76087
Merge pull request #2522 from akarl10/startwm-xsession-desktop-files
Debian: use startup command from /usr/share/xsession if DISPLAY_SESSION is set
2023-02-02 14:21:51 +00:00
akarl10
093baad9b0 try using startup command in /usr/share/xsessions
gnome shell has a way to start different desktop profiles, but all
use the same gnome-session binary.

currently implemented only for debian based distributions
2023-02-02 14:54:56 +01:00
matt335672
9e53b72c80
Merge pull request #2528 from akarl10/chansrv-fuse-display-variable
Add %d and %D to fuse mount path for local mounts.
2023-02-02 10:36:49 +00:00
akarl10
46398fcda5 [chansrv-fuse] refactoring to make compiler happier 2023-02-01 16:03:32 +01:00
matt335672
3156ed32ed
Merge pull request #2526 from matt335672/add_include_guards
Add missing include guards
2023-02-01 11:04:32 +00:00
Michael Saxl
367a045f00 [chansrv-fuse] update documentation 2023-01-31 20:13:34 +01:00
Michael Saxl
2052664d69 [chansrv-fuse] do also % substitutions when relative paths are used 2023-01-31 20:11:26 +01:00
akarl10
5bcac32bf1 [chansrv-fuse] update documentation 2023-01-31 19:41:17 +01:00
akarl10
3458210c1c [chansrv-fuse] Add %d and %D as path replacement variables
%d is the numeric display number
%D is the DISPLAY environment variable

this enables the concurrent use of fuse in multiple sessions of the same
user
2023-01-31 19:41:02 +01:00
matt335672
5ed9b96530 Add missing include guards 2023-01-31 09:30:36 +00:00
matt335672
b75a5ce763
Merge pull request #2494 from matt335672/fd_support_for_libipm
Add file descriptor passing support for libipm
2023-01-31 08:54:28 +00:00
Nexarian
e119e0f257
Merge pull request #2523 from Nexarian/cpitstick/xrdp_h_fix
Adding define guards to xrdp.h
2023-01-30 19:54:22 -05:00
Nexarian
f21f412c23 Adding define guards to xrdp.h 2023-01-30 11:48:34 -05:00
matt335672
7a190bf709 Add tests for libipm file descriptor calls 2023-01-30 14:31:16 +00:00
matt335672
c9adb3a2a6 libipm: Add support for receiving file descriptors 2023-01-30 14:31:16 +00:00