Commit Graph

2519 Commits

Author SHA1 Message Date
Pavel Roskin
aaa89ad4e6 Use const unsigned for hex arrays
Some constants are too big for the signed type.
2016-07-08 04:29:43 +00:00
Pavel Roskin
aeeb3d2c2e Fix warnings detected by -Wwrite-strings 2016-07-08 04:29:42 +00:00
Pavel Roskin
a680d46edf Use -Wwrite-strings compiler flag if supported, add required macros
String literals are const in C++. Using this warnings moves us closer to
the stated goal of C++ compatibility, makes the code cleaner and lets
compilers optimize the code better.

Add m4/ax_append_compile_flags.m4 from Autoconf Archives for the
AX_APPEND_COMPILE_FLAGS macro and m4/ax_check_compile_flag.m4 as its
dependency.
2016-07-08 04:29:40 +00:00
Pavel Roskin
951e632757 Make program_name constant, don't duplicate or free it 2016-07-08 04:27:07 +00:00
Pavel Roskin
b00ca6e03d Remove commented out config_read_logging(), the code is long dead 2016-07-08 04:26:59 +00:00
Pavel Roskin
1ded8ec437 Remove unused string support in scp_session_set_addr()
Using the same argument for binary and text data is not a good idea. If
string support is ever needed, it should be a separate function.

Remove SCP_ADDRESS_TYPE_IPV4_BIN and SCP_ADDRESS_TYPE_IPV6_BIN, use
SCP_ADDRESS_TYPE_IPV4 and SCP_ADDRESS_TYPE_IPV6, which simplifies the
code.
2016-07-08 04:15:41 +00:00
Pavel Roskin
f908528a00 Downgrade "libscp initialized" to LOG_LEVEL_DEBUG, remove line number
It's a bad style to start the log with a cryptic warning.
2016-07-08 04:15:39 +00:00
Pavel Roskin
f7ef9bb938 Fix scp_init() invocation, it takes no arguments 2016-07-08 04:15:38 +00:00
Pavel Roskin
6f5feb61e0 Shorten and clarify log window messages
Specify display in the "login failed" message. Print the section name
that wasn't found. Remove stdout message about missing section,
xrdp_wm_log_msg() already writes to stdout.
2016-07-08 04:15:34 +00:00
Pavel Roskin
a1b7de5679 Make xrdp_wm_log_msg() log its output
Accept variable arguments and the log level in xrdp_wm_log_msg(). Remove
logging that is done automatically now.
2016-07-08 04:15:33 +00:00
Pavel Roskin
27ba5b4e86 Rewrite add_string_to_logwindow()
Make static, fix formatting, shorten some variable names, use += to add
to variable, accept immutable strings.
2016-07-08 04:15:30 +00:00
Pavel Roskin
77b380c0b5 Fix format warnings in log_message() calls 2016-06-21 16:30:16 -07:00
Pavel Roskin
b1527b7947 Check string format in log_message
Move "printflike" definition to arch.h, it's used both by log.h and
os_calls.h.
2016-06-21 16:30:16 -07:00
Pavel Roskin
be1d034f91 Report pid and listening address/port for xrdp and xrdp-sesman
For xrdp-sesman, don't report that the daemon is listening to a port if
it fails to attach to that port. Don't use LOG_LEVEL_ALWAYS for startup
message, it's not a critical error.
2016-06-21 16:30:15 -07:00
Pavel Roskin
a77ae440a7 Rename SESMAN_CFG_X11DISPLAYOFFSET to SESMAN_CFG_SESS_X11DISPLAYOFFSET
Move it to other session options in config.h. X11DisplayOffset is part of
the [Sessions] section.
2016-06-21 16:30:15 -07:00
Pavel Roskin
7aa35f1f57 Fix typos in manual pages 2016-06-21 16:30:15 -07:00
Pavel Roskin
0d7f2d2802 Improve manual page for sesman
Add new sections and parameters, improve wording, wrap lines.
2016-06-21 16:30:15 -07:00
Pavel Roskin
ae5bb5bf9c Fix incorrect use of "it's" and "its", adjust wording 2016-06-21 16:30:15 -07:00
Idan Freiberg
703fedded7 Merge pull request #379 from SvenDowideit/mention-channel-code
Mention the channel code in man page.
2016-05-31 08:02:58 +03:00
Sven Dowideit
332a6d4444 Mention the channel code
Signed-off-by: Sven Dowideit <SvenDowideit@home.org.au>
2016-05-31 01:02:23 +00:00
speidy
f5ec7f4102 libxrdp: oops, fix virtual desktop size check 2016-05-18 00:24:16 -04:00
speidy
881756a82c libxrdp: oops, fix virtual desktop size check 2016-05-18 00:23:07 -04:00
speidy
36c17767b7 libxrdp: in CS_MONITOR, validate virtual desktop size we got from client 2016-05-18 00:20:41 -04:00
speidy
b38dcf1bb0 xrdp_wm: fix for multimon, draw login window and log window on primary
monitor
2016-05-17 20:11:49 -04:00
Jay Sorg
dd906c3fc8 remove tabs 2016-05-16 16:03:13 -07:00
Jay Sorg
d27270ab1f remove tabs 2016-05-16 15:59:25 -07:00
speidy
80b91c0a7b neutrinordp: indentation fixes 2016-05-12 19:02:05 -04:00
speidy
a42cb4842c neutrinordp:
o support for passing domain name to module, using
xrdp.ini module specific parameter
o reduce rail trace logging
2016-05-12 17:22:18 -04:00
speidy
551d7dd58f neutrinordp: support for 32 to 16 bitmap conversion 2016-05-12 17:22:07 -04:00
speidy
f20e06ff42 neutrinordp: added 16bpp to 32bpp pixel color conversion 2016-05-12 17:21:15 -04:00
speidy
eb2bbcfc9f neutrinordp: set nla, program parameters from preamble 2016-05-12 17:20:50 -04:00
speidy
62799b8b10 xrdp_wm: in multimon scenario, draw log window and login window on
primary monitor
2016-05-12 17:20:32 -04:00
jsorg71
f31b5a178b Merge pull request #372 from proski/gcc5-warnings
Fix warnings reported by gcc 5.3.0 on Mac OS
2016-05-11 20:15:29 -07:00
Pavel Roskin
9057ad0bba Remove unused variables in get_display_num_from_display() 2016-05-06 18:58:16 -07:00
Pavel Roskin
1403652c72 Remove unused variable in devredir_cvt_from_unicode_len() 2016-05-06 18:58:16 -07:00
Pavel Roskin
f2d326cbed Remove unused variables from dev_redir_proc_query_dir_response() 2016-05-06 18:58:16 -07:00
Pavel Roskin
0dd0426e6f Check XGetWindowProperty() return code in clipboard_event_property_notify() 2016-05-06 18:31:03 -07:00
Pavel Roskin
e7e4d61265 Return correct error code from process_server_paint_rect_shmem_ex() 2016-05-06 18:17:56 -07:00
Itamar Reis Peixoto
0a6a55b547 Merge pull request #370 from proski/typos
Typo fixes and more
2016-05-06 09:05:38 -04:00
jsorg71
8249091183 Merge pull request #332 from metalefty/freebsd/ipv6
common: add log for g_tcp_connect
2016-05-05 22:00:51 -07:00
Pavel Roskin
b95dc9e12f Remove extraneous color initialization 2016-05-05 00:11:36 -07:00
Pavel Roskin
72019d3611 Use better symbols to protect include files 2016-05-05 00:06:26 -07:00
Pavel Roskin
c3f6e1f58a Use uniform comments for GUIDs 2016-05-05 00:06:26 -07:00
Pavel Roskin
d33bc07005 Capitalize language and country names 2016-05-05 00:05:23 -07:00
Pavel Roskin
ca9cbcafc8 Typo fixes 2016-05-04 23:33:30 -07:00
jsorg71
fdb146740f Merge pull request #360 from proski/format-warnings
Warning fixes
2016-05-03 00:52:58 -07:00
Jay Sorg
fac0907a3c trans: set non blocking socket after accept 2016-04-27 18:16:45 -07:00
jsorg71
b0e1e21305 Merge pull request #366 from proski/macos-sem
Add unnamed semaphore support on Mac OS
2016-04-26 23:31:59 -07:00
Pavel Roskin
f93074a430 Add unnamed semaphore support on Mac OS
sem_init() is not functional on Mac OS. Use the Grand Central Dispatch
implementation.

Make libscp_lock.c use semaphores through the thread_calls wrapper.
2016-04-23 00:26:46 -07:00
Pavel Roskin
70f3d4c5e2 Fix warnings for unused variables read from byte streams 2016-04-23 00:18:38 -07:00