Commit Graph

4670 Commits

Author SHA1 Message Date
Ilia Shipitsin
a00374d1a4 CI: scheduled coverity scan 2024-08-29 10:28:08 +02:00
matt335672
67ace5c59d
Merge pull request #3054 from matt335672/update_readme
Update README.md
2024-05-03 11:05:29 +01:00
matt335672
dbbb172f92 Update README.md
Clarified wording around Fedora. Also, removed references to yum
as RHEL/CentOS 7 is EOL on 30th June 2024
2024-05-01 09:26:58 +01:00
matt335672
15b46f8ccf
Merge pull request #2829 from firewave/missing-prototypes
fixed `-Wmissing-prototypes` (and subsequent) compiler warnings
2024-04-24 15:49:52 +01:00
firewave
c7070b95af xrdp/neutrinordp: fixed -Wmissing-prototypes compiler warning
Co-authored-by: matt335672 <30179339+matt335672@users.noreply.github.com>
2024-04-23 18:46:37 +02:00
firewave
5eed76f32b fixed -Wunused-function compiler warnings 2024-04-23 18:38:20 +02:00
firewave
5db94568ec vnc/vnc.c: fixed -Wmaybe-uninitialized warnings
vnc.c: In function ‘lib_framebuffer_update’:
vnc.c:816:37: error: ‘b’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
  816 |         return (r << 16) | (g << 8) | b;
      |                ~~~~~~~~~~~~~~~~~~~~~^~~
vnc.c:1301:9: note: ‘b’ was declared here
 1301 |     int b;
      |         ^
vnc.c:816:31: error: ‘g’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
  816 |         return (r << 16) | (g << 8) | b;
      |                            ~~~^~~~~
vnc.c:1300:9: note: ‘g’ was declared here
 1300 |     int g;
      |         ^
vnc.c:816:19: error: ‘r’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
  816 |         return (r << 16) | (g << 8) | b;
      |                ~~~^~~~~~
vnc.c:1299:9: note: ‘r’ was declared here
 1299 |     int r;
      |         ^
2024-04-23 18:38:20 +02:00
firewave
fb9c175b11 enabled and fixed -Wmissing-prototypes compiler warnings
Co-authored-by: matt335672 <30179339+matt335672@users.noreply.github.com>
2024-04-23 18:38:20 +02:00
matt335672
f92076a2e7
Merge pull request #3042 from matt335672/update_libpainter
Update libpainter submodule
2024-04-23 12:35:00 +01:00
matt335672
d6a256cca2 Update libpainter submodule
Needed for -Wmissing-prototypes support
2024-04-23 12:08:06 +01:00
metalefty
cc7d5ef921
Merge pull request #3035 from metalefty/issue-template
Mention how to copy & paste in fenced code blocks more clearly
2024-04-19 12:13:50 +09:00
Koichiro Iwao
d31e3f6174 Mention how to copy & paste in fenced code blocks more clearly 2024-04-19 12:08:00 +09:00
matt335672
f781962a55
Merge pull request #3031 from matt335672/update_rfxcodec
Merge updates from librfxcodec
2024-04-18 16:35:45 +01:00
matt335672
82d0e50348 Merge updates from librfxcodec
1) add SSE2 simd for dwt_shift_rem and diff_count

   make dwt_shift_rem easier to read
   move common rlgr defines to common file
   move common dwt defines to common file

2) Fix 'make distcheck'

3) Fix compiler warnings on 'make check'
2024-04-18 15:48:56 +01:00
matt335672
0a0a39380e
Merge pull request #3012 from matt335672/update_syscall_filter
Simplify allowed system calls for xrdp
2024-04-12 10:59:30 +01:00
matt335672
fe0ee0f9df
Merge pull request #3027 from matt335672/reclassify_info_msg
Reclassify debugging message as informational
2024-04-08 10:52:59 +01:00
matt335672
4b571b8499 Reclassify debugging message as informational 2024-04-08 10:13:34 +01:00
matt335672
e73f26c7c1
Merge pull request #3013 from jsorg71/too_big_for_max
gfx send multiple wire to surface messages when compressed data is la…
2024-03-25 11:36:39 +00:00
Jay Sorg
898e1ca135 format change 2024-03-22 14:53:38 -07:00
Jay Sorg
95bfb349a8 gfx send multiple wire to surface messages when compressed data is larger than max_compressed_bytes 2024-03-22 14:20:54 -07:00
matt335672
2277a111dc
Merge pull request #3009 from jsorg71/per_frame_log
remove per frame log entry when client frame acks is off
2024-03-22 12:12:53 +00:00
matt335672
8a2f427162
Merge pull request #3011 from matt335672/unpriv_user_fix
Fix permissions on user socket directory
2024-03-22 12:08:39 +00:00
matt335672
7fabef86f0
Merge pull request #2943 from matt335672/update_astyle_ver
Remove hard-coded version from scripts/run_astyle.sh
2024-03-22 12:08:31 +00:00
matt335672
f5d8fe5f3d
Merge pull request #2959 from matt335672/remove_librt_from_link
Remove unnecessary '-lrt' from common lib link
2024-03-22 12:08:11 +00:00
matt335672
fb34d742bb
Merge pull request #2910 from matt335672/fix_lfn_performance
Improve performance on long fat networks (LFNs)
2024-03-22 12:07:58 +00:00
matt335672
e0e9177f5e Simplify allowed system calls for xrdp
- The command 'systemd-analyze syscall-filter' shows that the group
  @system-service added to the xrdp-service SystemCallFilter
  actually includes all of the other listed groups and individual
  services.  Consequently this line can be simplified to just specify
  @system-service.

- (reversion) The SystemCallErrorNumber setting in xrdp.service has been
  removed so that unauthorized system calls cause an immediate process exit.
2024-03-22 11:40:44 +00:00
matt335672
200e4d84f4 Fix permissions on user socket directory
The user socket directory needs to be SGID so that they inherit
the group ownnership. Then xrdp can write to them.
2024-03-22 10:44:19 +00:00
Jay Sorg
651fcf85b7 remove per frame log entry when client frame acks is off 2024-03-20 23:07:22 -07:00
matt335672
45df24076f
Merge pull request #2990 from matt335672/detect_missing_drdynvc
Detect missing drdynvc
2024-03-15 10:30:22 +00:00
matt335672
661a441745
Merge pull request #2999 from matt335672/devel_fix_freebsd_core
[devel] Don't generate a corefile when generating SIGSEGV
2024-03-14 11:50:02 +00:00
matt335672
4f03b02302 Don't generate a corefile when generating SIGSEGV
One of the tests uses a child process which generates SIGSEGV.
On FreeBSD this generates a corefile by default which breaks
the 'make distcheck' process.
2024-03-14 11:14:49 +00:00
matt335672
6ff99cc4b5 Load channel config in xrdp_wm_create()
This commit moves the '[Channels]' parsing code for xrdp.ini
from xrdp_wm_init() to an earlier location in xrdp_wm_create().

libxrdp can now check that drdynvc is not disabled before starting it,
and xrdp_wm can disable GFX if virtual channels are not available.
2024-03-11 14:13:44 +00:00
matt335672
697dcbb24d Start the drdynvc channel within xrdp_wm
The responsibility for starting the drdynvc channel is moved out of
libxrdp into the application. This will make it easier to allow the
application to check the channel is enabled before starting it.
2024-03-11 11:00:53 +00:00
metalefty
0187daeb59
Merge pull request #2976 from rowlap/patch-2
Remove duplicate DEBUG output
2024-03-06 17:18:52 +09:00
rowlap
bf81557cdc
Remove duplicate DEBUG output
allow_multimon and new_cursors are printed twice
2024-03-05 11:59:20 +00:00
metalefty
b6d4e9df4f
Merge pull request #2969 from matt335672/increase_gfx_buffer
Increase GFX output buffer size
2024-03-03 09:36:43 +09:00
metalefty
5ccabaf706
Merge pull request #2972 from metalefty/logs
Suppress some logs when no errors
2024-03-01 00:01:32 +09:00
Koichiro Iwao
0b4150ff48 Suppress some logs when no errors
This outputs per-frame logs when using VNC backend and on login screen.
2024-02-29 15:03:48 +09:00
metalefty
a2c0d39c1e
Merge pull request #2970 from rowlap/patch-1
Remove tcutils channel from xrdp.ini
2024-02-27 22:30:08 +09:00
matt335672
90e4aca26a Increase GFX output buffer size
Size the GFX output buffer pessimistically based on the largest monitor
in the configuration.
2024-02-27 10:03:33 +00:00
matt335672
5845ce7c16
Merge pull request #2967 from derekschrock/ipv6
Fall back to IPv4 if IPv6 capable but don't have an IPv6 address set
2024-02-26 09:28:57 +00:00
Derek Schrock
5afbca4954 Fall back to IPv4 if IPv6 capable but don't have an IPv6 address set
When xrdp is built with IPv6 support it will only fall back to IPv4 if
IPv6 is not supported (EAFNOSUPPORT).  However, if the system is IPv6
capable but doesn't have an IPv6 address set (at least inside a FreeBSD
jail) EPROTONOSUPPORT is returned from socket().
2024-02-25 17:53:44 -05:00
matt335672
b79a7690fa
Merge pull request #2962 from matt335672/fix_egfx_disconnect
GFX: Fix disconnect on resize of busy windows
2024-02-23 15:34:01 +00:00
matt335672
3430b8898c GFX: Fix disconnect on resize of busy windows
When a resize is underway on a busy X server, it is possible for a
queued EGFX cmd (order #62) to be processed after the decoder has been
deleted. This causes a client disconnect with no useful error message.
2024-02-22 14:30:53 +00:00
rowlap
2a0c2a612f
Remove tcutils channel from xrdp.ini
According to #1943 tcutils was removed, so update the channel section to match.
2024-02-21 18:32:18 +00:00
matt335672
b2c0c506e8
Merge pull request #2745 from matt335672/wtmp
Add utmp/wtmp support
2024-02-21 14:22:16 +00:00
matt335672
e821eddb62 Remove unnecessary '-lrt' from common lib link
The '-lrt' added to the Makefile for the common library appears
to be unnecessary.

- On modern Linuxes, this library has been merged with libc, and the
  supplied library is empty.
- On older ones (e.g. Devuan 4), the library contains routines we
  do not use in xrdp (although we use 'shm_open()' in xorgxrdp).
- On FreeBSD 14 the library contains only mq_*  and timer_* routines
  which, again, are not required.
2024-02-21 12:43:53 +00:00
metalefty
b6b9283df1
Merge pull request #2956 from metalefty/copyright
Bump copyright year and make easier to bump
2024-02-21 21:29:31 +09:00
matt335672
9bc706f412
Merge pull request #2955 from matt335672/github_ci_update_actions
Migrate github actions to Node 20
2024-02-21 12:28:06 +00:00
metalefty
82bbf7ef03
Merge pull request #2954 from metalefty/gfx_log
GFX: Relegate some logs to LOG_LEVEL_DEBUG
2024-02-21 19:11:52 +09:00