Commit Graph

2467 Commits

Author SHA1 Message Date
Pavel Roskin 70f3d4c5e2 Fix warnings for unused variables read from byte streams 2016-04-23 00:18:38 -07:00
Pavel Roskin 95e1603f9d Fix recently introduced warnings in session.c
Use of tabs is fixed as well.
2016-04-21 23:03:40 -07:00
Pavel Roskin 0629b25d5f Fix warnings about unused variables and functions 2016-04-21 22:27:27 -07:00
Pavel Roskin e65bd6b7d7 Fix more format warnings 2016-04-21 21:21:17 -07:00
Pavel Roskin bd0b1acf79 Fix format warnings caused by g_writeln("") 2016-04-21 21:21:15 -07:00
Pavel Roskin 55e12a09d8 Include config_ac.h from common/os_calls.h to enable all format warnings 2016-04-21 21:20:12 -07:00
Jay Sorg b3273a3bfc X11rdp: Mesa link fix 2016-04-21 11:11:28 -07:00
Jay Sorg 5e398e0c91 multimon fix 2016-04-20 18:11:47 -07:00
Jay Sorg 473f3dcd0c X11rdp: merge multimon from Xorg driver 2016-04-19 15:34:45 -07:00
jsorg71 00a11f77ce Merge pull request #359 from metalefty/sesman/configurable-xserver-path
sesman: do not hardcode Xorg/X11rdp/Xvnc executables
2016-04-18 13:29:15 -07:00
jsorg71 6c21aca50b Merge pull request #361 from metalefty/do-not-attempt-to-trap-sigkill
Do not attempt to trap SIGKILL part 2
2016-04-17 17:40:43 -07:00
Koichiro IWAO f7858e964d Remove trailing whitespace, no logic change 2016-04-11 16:46:49 +09:00
Koichiro IWAO cfdce461c3 Do not attempt to trap SIGKILL part 2
it doesn't work on any OS.
2016-04-11 16:43:12 +09:00
Jay Sorg 87208db090 fix warnings 2016-04-09 22:10:12 -07:00
Jay Sorg dbf6bcc8be remove some warnings 2016-04-09 19:26:27 -07:00
Jay Sorg 6a692c96cf remove some warnings 2016-04-09 19:17:05 -07:00
Koichiro IWAO cf2b629462 sesman: do not hardcode Xorg/X11rdp/Xvnc executables
In RHEL and its clones, /usr/bin/Xorg is set suid-root. To execute
Xorg with user privileges, /etc/pam.d/xserver needs be edited [1],
or suid bit of Xorg binary needs to be dropped.

In order to keep Xorg and /etc/pam.d/xserver untouched, preparing
non-suid version of Xorg as /usr/bin/Xorg.non-suid for example is
the simplest solution. However, Xorg.non-suid cannot be executed
since it is hardcoded to execute Xorg in sesman.

This change makes more flexible to execute Xorg with non-standard
name or not in PATH environment variable.

[1] https://www.centos.org/forums/viewtopic.php?t=21185
2016-04-07 18:34:43 +09:00
Koichiro IWAO fb08623b66 sesman: brief xorg_params, no logic change 2016-04-07 16:27:23 +09:00
Jay Sorg 0655272b9c common: call recv/send before can_recv/can_send 2016-04-06 16:37:34 -07:00
Jay Sorg bd6c38af4d common: fix warnings 2016-04-02 16:49:23 -07:00
jsorg71 75d79e0e3c Merge pull request #353 from nerdknight/devel
Fix compile error "format not a string literal and no format arguments [-Werror=format-security]"
2016-04-02 16:11:59 -07:00
NerdKnight 99ebe1340f Fix compile error "format not a string literal and no format arguments [-Werror=format-security]" 2016-03-28 14:55:20 -03:00
jsorg71 034ee36f9c Merge pull request #341 from proski/sanity-checks
Sanity checks
2016-03-16 20:51:58 -07:00
Itamar Reis Peixoto 6b3fc5a373 Merge pull request #347 from metalefty/typo
fix typo xrdp-sessman -> xrdp-sessvc
2016-03-16 23:40:44 -04:00
Jay Sorg a6cba63a89 fix a warning 2016-03-16 14:40:24 -07:00
Jay Sorg 689ffe79d9 fix warnings, move some calls to os_calls 2016-03-16 14:32:14 -07:00
Koichiro IWAO ff4ec98412 fix typo xrdp-sessman -> xrdp-sessvc 2016-03-15 18:25:52 +09:00
Jay Sorg 38241f2a0b Fix all format warnings and some unused variable warnings 2016-03-14 17:04:08 -07:00
Jay Sorg 7393579205 Don't attempt to intercept SIGKILL, it doesn't work on any OS 2016-03-14 16:33:49 -07:00
Pavel Roskin 9091c3eef2 Annotate printf-like functions if supported by the compiler
Both GCC and Clang support it. Add a macro from Autoconf archive to check
for format attribute support.
2016-03-03 22:56:09 -08:00
Pavel Roskin 4da6f8a538 Enable -Wall flag for compilers that support it
Add Autoconf archive macros to check for -Wall and its dependencies.
Adjust m4/.gitignore to only ignore libtool macros.

Require Autoconf 2.65 for compatibility with Autoconf archive macros.
2016-03-03 22:56:09 -08:00
Pavel Roskin e0a9c769e0 Be more specific in error messages about PID file location 2016-03-03 22:56:09 -08:00
Pavel Roskin 3eb495f425 Check if rsakeys.ini exists on startup, exit if it's missing 2016-03-03 22:56:08 -08:00
Pavel Roskin 86ec50789c Move all sanity checks to a separate function xrdp_sanity_check() 2016-03-03 22:56:08 -08:00
Jay Sorg cdb967c0f3 xorgxrdp=a0add6c 2016-03-02 01:21:39 -08:00
Jay Sorg 5af0d06d1e keygen: default 2048 bit RSA key 2016-02-24 14:10:46 -08:00
Itamar Reis Peixoto cfbb00c6cb Merge pull request #333 from proski/key-install
Key install (generate rsakeys.ini during make install)
2016-02-24 06:38:02 -05:00
jsorg71 f53b3bb737 Merge pull request #326 from metalefty/pulseaudio-6.0
pulse: fix build pulseaudio 6.0 or higher
2016-02-23 23:19:59 -08:00
Pavel Roskin b63575cebc Create and install rsakeys.ini
Use install-data-hook to ensure restrictive permissions on rsakeys.ini.

Don't create rsakeys.ini in init scripts. This makes xrdp functional upon
"make install" without relying on the init scripts.

Packagers should not package rsakeys.ini, it should be created when the
package is installed.
2016-02-23 22:33:28 -08:00
Pavel Roskin 22e6f3e2f7 Use SCRIPTS for executable scripts, don't use "chmod 755" 2016-02-22 23:13:16 -08:00
Pavel Roskin 7642675ddf Use "dist_" prefix to minimize use of EXTRA_DIST
"dist" is ignored in presense of "noinst", so keep noinst_man_MANS.
2016-02-22 22:11:57 -08:00
Jay Sorg f100036cd9 common: minor fix for older openssl keygen 2016-02-22 11:48:54 -08:00
Jay Sorg 3bc9f1e275 Merge branch 'devel' of git:neutrinolabs/xrdp into devel 2016-02-22 11:40:28 -08:00
Jay Sorg 0d192aee62 common: fix for key generated smaller than asked for 2016-02-22 11:38:03 -08:00
Itamar Reis Peixoto f1dd912218 Merge pull request #330 from proski/automake
More makefile cleanup
2016-02-22 07:45:12 -05:00
Pavel Roskin 59a5fb0ddb Move headers from EXTRA_DIST to sources, sort alphabetically
There should be no functional difference.
2016-02-21 23:06:48 -08:00
Pavel Roskin 3ad28e1130 Add m4 directory to EXTRA_DIST, not all Automake versions package it 2016-02-21 21:31:02 -08:00
Koichiro IWAO 93f7bcb71b pulse: fix build pulseaudio 6.0 or higher
Discovered in #321.  The number of argument for pa_rtpoll_run have
been changed since 6.0.

>=6.0 : int pa_rtpoll_run(pa_rtpoll *f);
<6.0  : int pa_rtpoll_run(pa_rtpoll *f, bool wait);

Check pulseaudio version by PA_CHECK_VERSION macro introduced since
pulseaudio 0.9.16.  In case PA_CHECK_VERSION is not defined,
pa_rtpoll_run takes 2 arguments.
2016-02-18 00:45:33 +09:00
Itamar Reis Peixoto 3934be9320 Merge pull request #320 from proski/sesadmin
Make sesadmin useful, another round of typo hunting
2016-02-15 06:59:39 -02:00
Pavel Roskin 50cbf01044 xrdp-sesadmin: show help and exit if mandatory arguments are not given
Don't mark password as mandatory, it's asked if not provided on the
command line.
2016-02-14 10:27:17 -08:00