Commit Graph

4310 Commits

Author SHA1 Message Date
Nexarian 5273624089 Fixing some comments 2023-03-14 02:02:09 -04:00
matt335672 545663494c
Merge pull request #2591 from matt335672/freebsd_waitforx_flags
Add AM_CPPFLAGS to makefile.am for waitforx
2023-03-13 21:03:05 +00:00
matt335672 56d99d8535 Add AM_CPPFLAGS to makefile.am for waitforx
Without this, the compilation of waitforx can fail on FreeBSD
with this error:-

waitforx.c:1:10: fatal error: 'X11/extensions/Xrandr.h' file not found

This PR makes the use of AM_CPPFLAGS and AM_CFLAGS the same as
that for (e.g.) chansrv which also depends on X includes
2023-03-13 20:52:00 +00:00
matt335672 45983b6c5e
Merge pull request #2568 from matt335672/poll_regression
Poll regression
2023-03-13 20:07:06 +00:00
matt335672 3bd1820407 Fix regression caused by move to poll() 2023-03-13 20:02:05 +00:00
matt335672 653a7a9bff
Merge pull request #2576 from matt335672/list_string_support
List string support
2023-03-10 11:07:59 +00:00
matt335672 c9940f6b0d
Merge pull request #2581 from metalefty/help-alignment
sesman: fix help message alignment
2023-03-08 10:42:13 +00:00
Koichiro IWAO 75f534b69f sesman: fix help message alignment 2023-03-08 10:24:08 +09:00
matt335672 621b3fc6dc Add g_execvp_list() to os_calls 2023-03-06 16:03:55 +00:00
matt335672 c3d697de16 Add list_add_strdup() etc 2023-03-06 15:58:13 +00:00
matt335672 a6995f5e58
Merge pull request #2575 from matt335672/fix_list_insert_bug
Fix regression in list module
2023-03-06 15:57:25 +00:00
matt335672 a317c3de5d Fix regression in list module 2023-03-06 15:47:49 +00:00
matt335672 1ae819668a
Merge pull request #2573 from ZhipengXue97/devel
chansrv: Fix potential null dereference
2023-03-06 10:28:19 +00:00
Nexarian 4f9b3055ab
Merge pull request #2553 from Nexarian/add-string-split-function
Add function to split string into list.
2023-03-05 10:11:53 -05:00
Zhipeng Xue fbb3b9cef9 Fix potential null dereference 2023-03-05 13:38:43 +08:00
Nexarian 89e178e7c9 Add function to split string into list.
- With working unit tests.
2023-03-03 18:33:33 -05:00
Nexarian 39abe6fbfe
Merge pull request #2567 from matt335672/ci_fail_workaround
Fix CI build break
2023-03-03 18:33:06 -05:00
matt335672 eb3d159612 Fix CI build break 2023-02-27 11:30:07 +00:00
matt335672 420a7a429f
Merge pull request #2557 from Hiero32/improve_#2522
improve "#2522 use startup command from /usr/share/xsession ..."
2023-02-22 12:45:23 +00:00
Hiero32 cdc65db487
change comment a bit 2023-02-22 20:59:37 +09:00
Hiero32 a2a8a0ba89
fix comment 2023-02-21 21:30:33 +09:00
Hiero32 fda1ed0042
remove "source /etc/xrdp/export_desktop_session" 2023-02-21 21:15:21 +09:00
matt335672 c886415893
Merge pull request #2552 from yifanjiang/devel
Make pam.d directory configurable
2023-02-21 11:44:14 +00:00
Yifan J 8be6bc137e Make pam.d directory configurable 2023-02-21 09:50:46 +08:00
matt335672 e80e02220e
Merge pull request #2559 from matt335672/waitforx_ignore
Add waitforx/xrdp-waitforx to .gitignore
2023-02-20 21:12:28 +00:00
matt335672 726099f870 Add waitforx/xrdp-waitforx to .gitignore 2023-02-20 20:55:09 +00:00
Hiero32 5364ee6aaf
improve "#2522 use startup command from /usr/share/xsession ..." 2023-02-18 10:04:27 +09:00
Nexarian 3a2a64dee0
Merge pull request #2524 from Nexarian/add-rect-utility-functions
Adding utility functions for xrdp regions.
2023-02-15 11:27:53 -05:00
Nexarian ba0e75f8be Utility functions for xrdp regions and tests
- xrdp_region_get_bounds
- xrdp_region_not_empty
- Incorporate example usage of cmocka
- Cmocka doesn't work with C++
2023-02-13 23:46:39 -05:00
matt335672 11a8823a3a
Merge pull request #2550 from matt335672/fix_libipm_doxygen_errors
Fix doxygen warnings for libipm
2023-02-13 21:26:00 +00:00
matt335672 b9a12257fc Fix doxygen warnings for libipm 2023-02-13 20:44:52 +00:00
matt335672 54db636e76
Merge pull request #2497 from matt335672/use_poll
Use poll() instead of select()
2023-02-13 14:37:00 +00:00
matt335672 86d0d0e9fd Addressed review comments 2023-02-13 14:28:29 +00:00
matt335672 acdfd12cb6 Fix typo in chansrv_fuse.c
The code as it stands is checking two file descriptors for possible
input, but only one needs to be checked.
2023-02-13 14:28:29 +00:00
matt335672 78fa1c15b2 Replace select() system call with poll()
poll() is specified in POSIX.1-2001 as a simpler interface for
multiplexed file descriptors than select(). It also provides more
functionality.

This PR replaces the select() calls used in xrdp with poll()
equivalents.
2023-02-13 14:28:29 +00:00
matt335672 b414cfcd5e
Merge pull request #2536 from matt335672/list_improvements
Add memory allocation checking to the list module
2023-02-13 14:23:23 +00:00
matt335672 994418cd90 Add simple list test cases 2023-02-13 10:37:46 +00:00
matt335672 5aa5624551 Add memory allocation checking to the list module
The list module lacks memory allocation checking, and
consequently can coredump on list_create() or
list_add_item().
2023-02-13 10:37:46 +00:00
matt335672 a27440c237
Merge pull request #2492 from derekschrock/randr-wait
Add xrdp-waitforx to wait for X to start with RandR outputs
2023-02-13 10:29:22 +00:00
metalefty f3dc94448c
Merge pull request #2537 from metalefty/sound-log
sound: logging improvements
2023-02-13 10:38:31 +09:00
Derek Schrock cb39b84de5 Use g_set_alarm and g_sleep 2023-02-11 18:01:12 -05:00
Derek Schrock 1e5b42893c Add g_set_alarm to set an alarm calling func after secs seconds 2023-02-11 18:01:12 -05:00
Derek Schrock 829378bba8 Add xrdp-waitforx to wait for X to start with RandR outputs
For some window managers (fvwm2 and fvwm3) if the X server isn't
running and has output it's possible for the window manager to fail or
reconfigure randr incorrectly.

With xrdp-waitfox:
 - Install xrdp-waitfox to the BIN dir.
 - sesman will run xrdp-waitfox as the logged in user.
 - Set an alarm to exit after 30 seconds.
 - Try to open env DISPLAY value's display (10 seconds).
 - Test for RandR extension.
 - Wait for outputs to appear (10 seconds).
2023-02-11 18:01:10 -05:00
Nexarian 9bab8e0da5
Merge pull request #2545 from Nexarian/add-free-to-egfx-unit-test
Add free to egfx unit tests
2023-02-11 12:16:02 -05:00
Nexarian b1edd4ff05
Merge pull request #2544 from Nexarian/add-unit-test-parameter
Add unit test parameter for more coverage.
2023-02-11 12:15:23 -05:00
Nexarian 259be09334 Add free to egfx unit tests 2023-02-11 00:39:03 -05:00
Nexarian d3be110ffc Add unit test parameter for more coverage. 2023-02-11 00:28:30 -05:00
Koichiro IWAO 9d7a817e87 chansrv/audin: return UNKNOWN when undefined value
is passed to audin_wave_format_tag_to_str.
2023-02-11 11:51:08 +09:00
metalefty c463a0e865
Merge pull request #2541 from metalefty/log_time
log: fix syslog glitch after #2386
2023-02-10 09:06:12 +09:00
Koichiro IWAO ec2f165af4 log: fix syslog glitch after #2386
The tail of new datetime format was sticking out.
2023-02-09 17:09:28 +09:00