Go to file
Niklas Cassel ccac65fbd1 hw/ide/ahci: fix broken SError handling
When encountering an NCQ error, you should not write the NCQ tag to the
SError register. This is completely wrong.

The SError register has a clear definition, where each bit represents a
different error, see PxSERR definition in AHCI 1.3.1.

If we write a random value (like the NCQ tag) in SError, e.g. Linux will
read SError, and will trigger arbitrary error handling depending on the
NCQ tag that happened to be executing.

In case of success, ncq_cb() will call ncq_finish().
In case of error, ncq_cb() will call ncq_err() (which will clear
ncq_tfs->used), and then call ncq_finish(), thus using ncq_tfs->used is
sufficient to tell if finished should get set or not.

Signed-off-by: Niklas Cassel <niklas.cassel@wdc.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Message-id: 20230609140844.202795-9-nks@flawful.org
Signed-off-by: John Snow <jsnow@redhat.com>
(cherry picked from commit 9f89423537)
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
2023-09-11 10:53:51 +03:00
.github/workflows github: fix config mistake preventing repo lockdown commenting 2022-04-26 16:12:26 +01:00
.gitlab/issue_templates GitLab: Add "Feature Request" issue template. 2021-06-25 10:08:37 +01:00
.gitlab-ci.d python: drop pipenv 2023-09-11 10:53:50 +03:00
accel kvm: Introduce kvm_arch_get_default_type hook 2023-09-11 10:53:50 +03:00
audio module: add Error arguments to module_load and module_load_qom 2022-11-06 09:48:50 +01:00
authz configure, meson: convert pam detection to meson 2021-06-25 10:54:10 +02:00
backends vhost: enable vrings in vhost_dev_start() for vhost-user devices 2022-12-01 02:30:04 -05:00
block block/monitor: Fix crash when executing HMP commit 2023-05-18 21:09:59 +03:00
bsd-user bsd-user: Catch up with sys/param.h requirement for machine/pmap.h 2022-10-26 14:09:17 -06:00
chardev chardev/char-socket: set s->listener = NULL in char_socket_finalize 2023-03-29 10:20:04 +03:00
common-user common-user: Only compile the common user code if have_user is set 2022-06-28 11:12:05 +02:00
configs hw/isa/Kconfig: Fix dependencies of piix4 southbridge 2022-10-31 11:32:07 +01:00
contrib contrib/plugins: protect execlog's last_exec expansion 2022-10-31 20:37:59 +00:00
crypto crypto: Support export akcipher to pkcs8 2022-11-02 06:56:32 -04:00
disas disas/nanomips: Tidy read for 48-bit opcodes 2022-11-08 01:04:25 +01:00
docs docs/about/license: Update LICENSE URL 2023-09-11 10:53:50 +03:00
dtc@b6910bec11 dtc: Update to version 1.6.1 2021-10-14 08:08:11 +02:00
dump dump: kdump-zlib data pages not dumped with pvtime/aarch64 2023-09-11 10:53:50 +03:00
ebpf ebpf: replace deprecated bpf_program__set_socket_filter 2022-07-06 11:39:09 +08:00
fpu softfloat: Fix the incorrect computation in float32_exp2 2023-05-18 21:09:59 +03:00
fsdev 9pfs: prevent opening special files (CVE-2023-2861) 2023-06-08 23:52:29 +03:00
gdb-xml gdb-xml: Fix size of EFER register on i386 architecture when debugged by GDB 2022-11-06 09:48:26 +01:00
gdbstub gdbstub: move guest debug support check to ops 2022-10-06 11:53:41 +01:00
hw hw/ide/ahci: fix broken SError handling 2023-09-11 10:53:51 +03:00
include kvm: Introduce kvm_arch_get_default_type hook 2023-09-11 10:53:50 +03:00
io io: remove io watch if TLS channel is closed during handshake 2023-08-02 17:22:20 +03:00
libdecnumber libdecnumber/dpd/decimal64: Fix compiler warning from Clang 15 2022-11-11 09:13:52 +01:00
linux-headers Update linux headers to v6.0-rc4 2022-09-26 17:23:47 +02:00
linux-user linux-user/elfload: Set V in ELF_HWCAP for RISC-V 2023-09-11 10:53:50 +03:00
meson@3a9b285a55 meson: require 0.61.3 2022-10-01 21:16:36 +02:00
migration block-migration: Ensure we don't crash during migration cleanup 2023-09-11 10:53:50 +03:00
monitor qemu-sockets: move and rename SocketAddress_to_str() 2022-10-28 13:28:52 +08:00
nbd block: Change blk_{pread,pwrite}() param order 2022-07-12 12:14:56 +02:00
net vdpa: Return -EIO if device ack is VIRTIO_NET_ERR in _load_mq() 2023-08-05 20:49:23 +03:00
pc-bios target/hppa: Update to SeaBIOS-hppa version 8 2023-06-26 19:35:39 +03:00
plugins plugins: add [pre|post]fork helpers to linux-user 2022-10-06 11:53:41 +01:00
po po: add ukrainian translation 2022-07-05 10:15:49 +02:00
python python: drop pipenv 2023-09-11 10:53:50 +03:00
qapi Block layer patches 2022-11-14 16:59:10 -05:00
qga qga/win32: Use rundll for VSS installation 2023-08-02 16:07:32 +03:00
qobject include/qapi: add g_autoptr support for qobject types 2022-04-06 10:50:38 +02:00
qom module: add Error arguments to module_load and module_load_qom 2022-11-06 09:48:50 +01:00
replay replay: Fix declaration of replay_read_next_clock 2022-11-29 11:09:11 -05:00
roms target/hppa: Update to SeaBIOS-hppa version 8 2023-06-26 19:35:39 +03:00
scripts checkpatch: add qemu_bh_new/aio_bh_new checks 2023-09-11 10:53:50 +03:00
scsi QIOChannel: Add flags on io_writev and introduce io_flush callback 2022-05-16 13:56:24 +01:00
semihosting semihosting/arm-compat-semi: Avoid using hardcoded /tmp 2022-10-31 20:37:58 +00:00
softmmu memory: prevent dma-reentracy issues 2023-09-11 10:53:50 +03:00
storage-daemon qsd: Unlink absolute PID file path 2022-07-12 14:30:38 +02:00
stubs qga: Allow building of the guest agent without system emulators or tools 2022-11-11 09:17:45 +01:00
subprojects libvhost-user: check for NULL when allocating a virtqueue element 2023-03-29 10:20:04 +03:00
target target/ppc: Flush inputs to zero with NJ in ppc_store_vscr 2023-09-11 10:53:50 +03:00
tcg tcg: Move TCG_TARGET_HAS_direct_jump init to tb_gen_code 2022-11-09 12:29:03 +11:00
tests hw/ide/ahci: PxCI should not get cleared when ERR_STAT is set 2023-09-11 10:53:51 +03:00
tools virtiofsd: Add sigreturn to the seccomp whitelist 2022-11-25 13:56:05 -05:00
trace include/hw/core: Create struct CPUJumpCache 2022-10-04 12:13:12 -07:00
ui ui/vnc-clipboard: fix infinite loop in inflate_buffer (CVE-2023-3255) 2023-07-18 09:50:19 +03:00
util async: avoid use-after-free on re-entrancy guard 2023-09-11 10:53:50 +03:00
.cirrus.yml ci: Upgrade msys2 release to 20220603 2022-07-29 10:33:29 -07:00
.dir-locals.el Add .dir-locals.el file to configure emacs coding style 2015-10-08 19:46:01 +03:00
.editorconfig .editorconfig: update the automatic mode setting for Emacs 2021-03-10 15:34:11 +00:00
.exrc qemu: add .exrc 2012-09-07 09:02:44 +03:00
.gdbinit .gdbinit: load QEMU sub-commands when gdb starts 2017-06-07 14:38:45 +01:00
.gitattributes gitattributes: Cover Objective-C source files 2022-03-29 00:15:14 +02:00
.gitignore .gitignore: add multiple items to .gitignore 2022-10-22 22:48:17 +02:00
.gitlab-ci.yml docs: Document GitLab custom CI/CD variables 2021-07-29 07:56:01 +02:00
.gitmodules Remove the slirp submodule (i.e. compile only with an external libslirp) 2022-09-26 17:23:47 +02:00
.gitpublish Add a git-publish configuration file 2018-03-05 09:03:17 +00:00
.mailmap MAINTAINERS: Replace my amsat.org email address 2022-10-17 17:21:22 -04:00
.patchew.yml scripts/checkpatch: roll diff tweaking into checkpatch itself 2021-06-25 10:08:33 +01:00
.readthedocs.yml readthedocs: build with Python 3.6 2020-10-05 16:30:45 +01:00
.travis.yml Revert "gitlab: disable accelerated zlib for s390x" 2022-07-20 12:15:09 +01:00
block.c block: Make bdrv_child_get_parent_aio_context I/O 2022-11-10 14:58:34 +01:00
blockdev-nbd.c nbd/server: Allow MULTI_CONN for shared writable exports 2022-05-12 13:10:52 +02:00
blockdev.c block: Fix use after free in blockdev_mark_auto_del() 2023-05-18 21:09:59 +03:00
blockjob.c block: Make bdrv_child_get_parent_aio_context I/O 2022-11-10 14:58:34 +01:00
configure configure: fix GLIB_VERSION for cross-compilation 2023-03-29 10:20:04 +03:00
COPYING
COPYING.LIB COPYING.LIB: Synchronize the LGPL 2.1 with the version from gnu.org 2019-01-30 11:01:22 +01:00
cpu.c accel/tcg: Complete cpu initialization before registration 2022-11-01 08:31:41 +11:00
cpus-common.c cpus: Introduce cpu_list_generation_id 2022-07-20 12:15:08 +01:00
disas.c disas: use result of ->read_memory_func 2022-10-06 11:53:40 +01:00
event-loop-base.c util/event-loop-base: Introduce options to set the thread pool size 2022-05-09 10:43:23 +01:00
gitdm.config contrib/gitdm: add a new interns group-map for GSoC/Outreachy work 2021-07-23 17:22:16 +01:00
hmp-commands-info.hx hmp: add virtio commands 2022-10-09 16:38:45 -04:00
hmp-commands.hx qapi: net: add stream and dgram netdevs 2022-10-28 13:28:52 +08:00
iothread.c util/event-loop-base: Introduce options to set the thread pool size 2022-05-09 10:43:23 +01:00
job-qmp.c job.c: enable job lock/unlock and remove Aiocontext locks 2022-10-07 12:11:41 +02:00
job.c block: remove bdrv_try_set_aio_context and replace it with bdrv_try_change_aio_context 2022-10-27 20:14:11 +02:00
Kconfig meson: Introduce target-specific Kconfig 2021-07-09 18:21:34 +02:00
Kconfig.host vfio-user: build library 2022-06-15 16:42:33 +01:00
LICENSE tcg/LICENSE: Remove out of date claim about TCG subdirectory licensing 2019-11-11 15:11:21 +01:00
MAINTAINERS MAINTAINERS: Add subprojects/libvhost-user to section "vhost" 2022-11-27 13:34:21 -05:00
Makefile configure: cleanup creation of tests/tcg target config 2022-10-06 11:53:40 +01:00
memory_ldst.c.inc exec/memory_ldst: Use correct type sizes 2021-05-26 08:35:51 -07:00
meson_options.txt gtk: disable GTK Clipboard with a new meson option 2022-11-23 12:15:06 +01:00
meson.build meson: leave unnecessary modules out of the build 2023-05-18 21:09:59 +03:00
module-common.c all: Clean up includes 2016-02-04 17:41:30 +00:00
os-posix.c os-posix: asynchronous teardown for shutdown on Linux 2022-10-31 09:46:34 +01:00
os-win32.c Remove qemu-common.h include from most units 2022-04-06 14:31:55 +02:00
page-vary-common.c Remove qemu-common.h include from most units 2022-04-06 14:31:55 +02:00
page-vary.c include: move target page bits declaration to page-vary.h 2022-04-06 14:31:43 +02:00
qemu-bridge-helper.c qemu-bridge-helper: relocate path to default ACL 2020-09-30 19:11:36 +02:00
qemu-edid.c qemu-edid: Restrict input parameter -d to avoid division by zero 2022-10-12 13:38:15 +02:00
qemu-img-cmds.hx qemu-img: Unify [-b [-F]] documentation 2022-02-01 13:49:15 +01:00
qemu-img.c qemu-img: remove unused variable 2022-11-11 09:12:10 +01:00
qemu-io-cmds.c block: Change blk_pwrite_compressed() param order 2022-07-12 12:14:56 +02:00
qemu-io.c include: move qemu_*_exec_dir() to cutils 2022-05-28 11:42:56 +02:00
qemu-keymap.c qemu-keymap: Add license in generated files 2021-12-17 10:41:50 +01:00
qemu-nbd.c qemu-nbd: regression with arguments passing into nbd_client_thread() 2023-07-31 09:11:17 +03:00
qemu-options.hx qemu-options: finesse the recommendations around -blockdev 2023-05-18 21:09:59 +03:00
qemu.nsi nsis installer: Fix mouse-over descriptions for emulators 2022-03-18 10:55:15 +00:00
qemu.sasl sasl: remove comment about obsolete kerberos versions 2021-06-14 13:28:50 +01:00
README.rst README.rst: fix link formatting 2022-08-04 13:44:21 +02:00
replication.c replication: move include out of root directory 2021-05-26 14:49:46 +02:00
trace-events gdbstub: move into its own sub directory 2022-10-06 11:53:41 +01:00
VERSION Update version for 7.2.5 release 2023-08-07 15:05:37 +03:00
version.rc configure: remove CONFIG_FILEVERSION and CONFIG_PRODUCTVERSION 2021-01-02 21:03:37 +01:00

===========
QEMU README
===========

QEMU is a generic and open source machine & userspace emulator and
virtualizer.

QEMU is capable of emulating a complete machine in software without any
need for hardware virtualization support. By using dynamic translation,
it achieves very good performance. QEMU can also integrate with the Xen
and KVM hypervisors to provide emulated hardware while allowing the
hypervisor to manage the CPU. With hypervisor support, QEMU can achieve
near native performance for CPUs. When QEMU emulates CPUs directly it is
capable of running operating systems made for one machine (e.g. an ARMv7
board) on a different machine (e.g. an x86_64 PC board).

QEMU is also capable of providing userspace API virtualization for Linux
and BSD kernel interfaces. This allows binaries compiled against one
architecture ABI (e.g. the Linux PPC64 ABI) to be run on a host using a
different architecture ABI (e.g. the Linux x86_64 ABI). This does not
involve any hardware emulation, simply CPU and syscall emulation.

QEMU aims to fit into a variety of use cases. It can be invoked directly
by users wishing to have full control over its behaviour and settings.
It also aims to facilitate integration into higher level management
layers, by providing a stable command line interface and monitor API.
It is commonly invoked indirectly via the libvirt library when using
open source applications such as oVirt, OpenStack and virt-manager.

QEMU as a whole is released under the GNU General Public License,
version 2. For full licensing details, consult the LICENSE file.


Documentation
=============

Documentation can be found hosted online at
`<https://www.qemu.org/documentation/>`_. The documentation for the
current development version that is available at
`<https://www.qemu.org/docs/master/>`_ is generated from the ``docs/``
folder in the source tree, and is built by `Sphinx
<https://www.sphinx-doc.org/en/master/>`_.


Building
========

QEMU is multi-platform software intended to be buildable on all modern
Linux platforms, OS-X, Win32 (via the Mingw64 toolchain) and a variety
of other UNIX targets. The simple steps to build QEMU are:


.. code-block:: shell

  mkdir build
  cd build
  ../configure
  make

Additional information can also be found online via the QEMU website:

* `<https://wiki.qemu.org/Hosts/Linux>`_
* `<https://wiki.qemu.org/Hosts/Mac>`_
* `<https://wiki.qemu.org/Hosts/W32>`_


Submitting patches
==================

The QEMU source code is maintained under the GIT version control system.

.. code-block:: shell

   git clone https://gitlab.com/qemu-project/qemu.git

When submitting patches, one common approach is to use 'git
format-patch' and/or 'git send-email' to format & send the mail to the
qemu-devel@nongnu.org mailing list. All patches submitted must contain
a 'Signed-off-by' line from the author. Patches should follow the
guidelines set out in the `style section
<https://www.qemu.org/docs/master/devel/style.html>`_ of
the Developers Guide.

Additional information on submitting patches can be found online via
the QEMU website

* `<https://wiki.qemu.org/Contribute/SubmitAPatch>`_
* `<https://wiki.qemu.org/Contribute/TrivialPatches>`_

The QEMU website is also maintained under source control.

.. code-block:: shell

  git clone https://gitlab.com/qemu-project/qemu-web.git

* `<https://www.qemu.org/2017/02/04/the-new-qemu-website-is-up/>`_

A 'git-publish' utility was created to make above process less
cumbersome, and is highly recommended for making regular contributions,
or even just for sending consecutive patch series revisions. It also
requires a working 'git send-email' setup, and by default doesn't
automate everything, so you may want to go through the above steps
manually for once.

For installation instructions, please go to

*  `<https://github.com/stefanha/git-publish>`_

The workflow with 'git-publish' is:

.. code-block:: shell

  $ git checkout master -b my-feature
  $ # work on new commits, add your 'Signed-off-by' lines to each
  $ git publish

Your patch series will be sent and tagged as my-feature-v1 if you need to refer
back to it in the future.

Sending v2:

.. code-block:: shell

  $ git checkout my-feature # same topic branch
  $ # making changes to the commits (using 'git rebase', for example)
  $ git publish

Your patch series will be sent with 'v2' tag in the subject and the git tip
will be tagged as my-feature-v2.

Bug reporting
=============

The QEMU project uses GitLab issues to track bugs. Bugs
found when running code built from QEMU git or upstream released sources
should be reported via:

* `<https://gitlab.com/qemu-project/qemu/-/issues>`_

If using QEMU via an operating system vendor pre-built binary package, it
is preferable to report bugs to the vendor's own bug tracker first. If
the bug is also known to affect latest upstream code, it can also be
reported via GitLab.

For additional information on bug reporting consult:

* `<https://wiki.qemu.org/Contribute/ReportABug>`_


ChangeLog
=========

For version history and release notes, please visit
`<https://wiki.qemu.org/ChangeLog/>`_ or look at the git history for
more detailed information.


Contact
=======

The QEMU community can be contacted in a number of ways, with the two
main methods being email and IRC

* `<mailto:qemu-devel@nongnu.org>`_
* `<https://lists.nongnu.org/mailman/listinfo/qemu-devel>`_
* #qemu on irc.oftc.net

Information on additional methods of contacting the community can be
found online via the QEMU website:

* `<https://wiki.qemu.org/Contribute/StartHere>`_