Go to file
Markus Armbruster a58c439a2d chardev/parallel: Don't close stdin on inappropriate device
The __linux__ version of qemu_chr_open_pp_fd() tries to claim the
parport device with a PPCLAIM ioctl().  On success, it stores the file
descriptor in the chardev object, and returns success.  On failure, it
closes the file descriptor, and returns failure.

chardev_new() then passes the Chardev to object_unref().  This duly
calls char_parallel_finalize(), which closes the file descriptor
stored in the chardev object.  Since qemu_chr_open_pp_fd() didn't
store it, it's still zero, so this closes standard input.  Ooopsie.

To demonstate, add a unit test.  With the bug above unfixed, running
this test closes standard input.  char_hotswap_test() happens to run
next.  It opens a socket, duly gets file descriptor 0, and since it
tests for success with > 0 instead of >= 0, it fails.

The new unit test needs to be conditional exactly like the chardev it
tests.  Since the condition is rather complicated, steal the solution
from the serial chardev: define HAVE_CHARDEV_PARALLEL in qemu/osdep.h.
This also permits simplifying chardev/meson.build a bit.

The bug fix is easy enough: store the file descriptor, and leave
closing it to char_parallel_finalize().

The next commit will fix char_hotswap_test()'s test for success.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-ID: <20240203080228.2766159-2-armbru@redhat.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
[Test fixed up for BSDs, indentation fixed up, commit message improved]
2024-02-14 07:44:38 +01:00
.github/workflows
.gitlab/issue_templates
.gitlab-ci.d ci: Update comment for migration-compat-aarch64 2024-02-07 10:51:27 +08:00
accel migration: prevent migration when VM has poisoned memory 2024-02-05 14:41:58 +08:00
audio misc: Clean up includes 2024-01-30 21:20:20 +03:00
authz
backends oslib-posix: initialize backend memory objects in parallel 2024-02-06 08:15:22 +01:00
block blkio: Respect memory-alignment for bounce buffer allocations 2024-02-07 15:26:04 +01:00
bsd-user include/qemu: Add TCGCPUOps typedef to typedefs.h 2024-01-29 21:04:10 +10:00
chardev chardev/parallel: Don't close stdin on inappropriate device 2024-02-14 07:44:38 +01:00
common-user
configs
contrib
crypto
disas disas/riscv: Clean up includes 2024-01-30 21:20:20 +03:00
docs tcg: Introduce TCG_COND_TST{EQ,NE} 2024-02-08 16:08:42 +00:00
dump dump: Fix HMP dump-guest-memory -z without -R 2024-01-30 21:20:20 +03:00
ebpf
fpu
fsdev
gdb-xml
gdbstub
host/include
hw Block layer patches 2024-02-08 20:08:44 +00:00
include chardev/parallel: Don't close stdin on inappropriate device 2024-02-14 07:44:38 +01:00
io
libdecnumber
linux-headers target/loongarch/kvm: Enable LSX/LASX extension 2024-01-25 15:25:31 +08:00
linux-user linux-user/aarch64: Add padding before __kernel_rt_sigreturn 2024-02-03 16:46:10 +10:00
migration migration/multifd: Add a synchronization point for channel creation 2024-02-07 09:53:18 +08:00
monitor monitor: only run coroutine commands in qemu_aio_context 2024-01-26 11:16:58 +01:00
nbd
net net: make nb_nics and nd_table[] static in net/net.c 2024-02-02 16:23:48 +00:00
pc-bios target/hppa qemu v8.2 regression fixes 2024-01-16 14:24:42 +00:00
plugins misc: Clean up includes 2024-01-30 21:20:20 +03:00
po
python
qapi monitor: use aio_co_reschedule_self() 2024-02-07 14:44:21 +01:00
qga qga/qapi-schema: Move command description right after command name 2024-02-03 09:20:33 +01:00
qobject
qom target/ppc/cpu-models: Rename power5+ and power7+ for new QOM naming rules 2024-02-05 14:21:21 +01:00
replay
roms target/hppa qemu v8.2 regression fixes 2024-01-16 14:24:42 +00:00
scripts scripts/clean-includes: Update exclude list 2024-01-30 21:20:20 +03:00
scsi
semihosting include/exec: Change cpu_mmu_index argument to CPUState 2024-02-03 16:46:10 +10:00
stats
storage-daemon
stubs system/replay: Restrict icount to system emulation 2024-01-19 12:28:59 +01:00
subprojects userfaultfd: use 1ULL to build ioctl masks 2024-01-29 11:02:12 +08:00
system oslib-posix: initialize backend memory objects in parallel 2024-02-06 08:15:22 +01:00
target tcg: Introduce TCG_COND_TST{EQ,NE} 2024-02-08 16:08:42 +00:00
tcg tcg/tci: Support TCG_COND_TST{EQ,NE} 2024-02-05 22:45:41 +00:00
tests chardev/parallel: Don't close stdin on inappropriate device 2024-02-14 07:44:38 +01:00
tools
trace
ui
util * Emulate CVB, CVBY, CVBG and CVDG s390x instructions 2024-02-08 11:59:28 +00:00
.dir-locals.el
.editorconfig
.exrc
.gdbinit
.git-blame-ignore-revs
.gitattributes
.gitignore
.gitlab-ci.yml
.gitmodules
.gitpublish
.mailmap mailmap: Fix Stefan Weil email 2024-01-30 21:20:20 +03:00
.patchew.yml
.readthedocs.yml readthodocs: fully specify a build environment 2024-01-12 13:23:48 +00:00
.travis.yml
block.c commit: Allow users to request only format driver names in backing file format 2024-01-26 11:16:58 +01:00
blockdev-nbd.c
blockdev.c stream: Allow users to request only format driver names in backing file format 2024-01-26 11:16:58 +01:00
blockjob.c
configure configure: Add linux header compile support for LoongArch 2024-01-19 12:28:59 +01:00
COPYING
COPYING.LIB
cpu-common.c
cpu-target.c linux-user: Allow gdbstub to ignore page protection 2024-01-29 20:48:49 +10:00
event-loop-base.c
gitdm.config
hmp-commands-info.hx docs/devel/docs: Document .hx file syntax 2024-01-15 17:12:22 +00:00
hmp-commands.hx hmp: Remove deprecated 'singlestep' command 2024-01-19 11:38:32 +01:00
iothread.c
job-qmp.c
job.c
Kconfig
Kconfig.host
LICENSE
MAINTAINERS hw/fsi: Update MAINTAINER list 2024-02-01 08:33:18 +01:00
Makefile
memory_ldst.c.inc
meson_options.txt
meson.build meson: Link with libinotify on FreeBSD 2024-02-06 10:27:50 +01:00
module-common.c
os-posix.c
os-win32.c
page-vary-common.c
page-vary-target.c
pythondeps.toml
qemu-bridge-helper.c
qemu-edid.c
qemu-img-cmds.hx docs/devel/docs: Document .hx file syntax 2024-01-15 17:12:22 +00:00
qemu-img.c
qemu-io-cmds.c
qemu-io.c
qemu-keymap.c
qemu-nbd.c
qemu-options.hx doc/sphinx/hxtool.py: add optional label argument to SRST directive 2024-02-02 13:51:58 +00:00
qemu.nsi
qemu.sasl
README.rst
replication.c
trace-events
VERSION
version.rc

===========
QEMU README
===========

QEMU is a generic and open source machine & userspace emulator and
virtualizer.

QEMU is capable of emulating a complete machine in software without any
need for hardware virtualization support. By using dynamic translation,
it achieves very good performance. QEMU can also integrate with the Xen
and KVM hypervisors to provide emulated hardware while allowing the
hypervisor to manage the CPU. With hypervisor support, QEMU can achieve
near native performance for CPUs. When QEMU emulates CPUs directly it is
capable of running operating systems made for one machine (e.g. an ARMv7
board) on a different machine (e.g. an x86_64 PC board).

QEMU is also capable of providing userspace API virtualization for Linux
and BSD kernel interfaces. This allows binaries compiled against one
architecture ABI (e.g. the Linux PPC64 ABI) to be run on a host using a
different architecture ABI (e.g. the Linux x86_64 ABI). This does not
involve any hardware emulation, simply CPU and syscall emulation.

QEMU aims to fit into a variety of use cases. It can be invoked directly
by users wishing to have full control over its behaviour and settings.
It also aims to facilitate integration into higher level management
layers, by providing a stable command line interface and monitor API.
It is commonly invoked indirectly via the libvirt library when using
open source applications such as oVirt, OpenStack and virt-manager.

QEMU as a whole is released under the GNU General Public License,
version 2. For full licensing details, consult the LICENSE file.


Documentation
=============

Documentation can be found hosted online at
`<https://www.qemu.org/documentation/>`_. The documentation for the
current development version that is available at
`<https://www.qemu.org/docs/master/>`_ is generated from the ``docs/``
folder in the source tree, and is built by `Sphinx
<https://www.sphinx-doc.org/en/master/>`_.


Building
========

QEMU is multi-platform software intended to be buildable on all modern
Linux platforms, OS-X, Win32 (via the Mingw64 toolchain) and a variety
of other UNIX targets. The simple steps to build QEMU are:


.. code-block:: shell

  mkdir build
  cd build
  ../configure
  make

Additional information can also be found online via the QEMU website:

* `<https://wiki.qemu.org/Hosts/Linux>`_
* `<https://wiki.qemu.org/Hosts/Mac>`_
* `<https://wiki.qemu.org/Hosts/W32>`_


Submitting patches
==================

The QEMU source code is maintained under the GIT version control system.

.. code-block:: shell

   git clone https://gitlab.com/qemu-project/qemu.git

When submitting patches, one common approach is to use 'git
format-patch' and/or 'git send-email' to format & send the mail to the
qemu-devel@nongnu.org mailing list. All patches submitted must contain
a 'Signed-off-by' line from the author. Patches should follow the
guidelines set out in the `style section
<https://www.qemu.org/docs/master/devel/style.html>`_ of
the Developers Guide.

Additional information on submitting patches can be found online via
the QEMU website

* `<https://wiki.qemu.org/Contribute/SubmitAPatch>`_
* `<https://wiki.qemu.org/Contribute/TrivialPatches>`_

The QEMU website is also maintained under source control.

.. code-block:: shell

  git clone https://gitlab.com/qemu-project/qemu-web.git

* `<https://www.qemu.org/2017/02/04/the-new-qemu-website-is-up/>`_

A 'git-publish' utility was created to make above process less
cumbersome, and is highly recommended for making regular contributions,
or even just for sending consecutive patch series revisions. It also
requires a working 'git send-email' setup, and by default doesn't
automate everything, so you may want to go through the above steps
manually for once.

For installation instructions, please go to

*  `<https://github.com/stefanha/git-publish>`_

The workflow with 'git-publish' is:

.. code-block:: shell

  $ git checkout master -b my-feature
  $ # work on new commits, add your 'Signed-off-by' lines to each
  $ git publish

Your patch series will be sent and tagged as my-feature-v1 if you need to refer
back to it in the future.

Sending v2:

.. code-block:: shell

  $ git checkout my-feature # same topic branch
  $ # making changes to the commits (using 'git rebase', for example)
  $ git publish

Your patch series will be sent with 'v2' tag in the subject and the git tip
will be tagged as my-feature-v2.

Bug reporting
=============

The QEMU project uses GitLab issues to track bugs. Bugs
found when running code built from QEMU git or upstream released sources
should be reported via:

* `<https://gitlab.com/qemu-project/qemu/-/issues>`_

If using QEMU via an operating system vendor pre-built binary package, it
is preferable to report bugs to the vendor's own bug tracker first. If
the bug is also known to affect latest upstream code, it can also be
reported via GitLab.

For additional information on bug reporting consult:

* `<https://wiki.qemu.org/Contribute/ReportABug>`_


ChangeLog
=========

For version history and release notes, please visit
`<https://wiki.qemu.org/ChangeLog/>`_ or look at the git history for
more detailed information.


Contact
=======

The QEMU community can be contacted in a number of ways, with the two
main methods being email and IRC

* `<mailto:qemu-devel@nongnu.org>`_
* `<https://lists.nongnu.org/mailman/listinfo/qemu-devel>`_
* #qemu on irc.oftc.net

Information on additional methods of contacting the community can be
found online via the QEMU website:

* `<https://wiki.qemu.org/Contribute/StartHere>`_