qemu/target/ppc
Richard Purdie 044897ef4a target/ppc: Fix system lockups caused by interrupt_request state corruption
Occasionally in Linux guests on x86_64 we're seeing logs like:

ppc_set_irq: 0x55b4e0d562f0 n_IRQ 8 level 1 => pending 00000100req 00000004

when they should read:

ppc_set_irq: 0x55b4e0d562f0 n_IRQ 8 level 1 => pending 00000100req 00000002

The "00000004" is CPU_INTERRUPT_EXITTB yet the code calls
cpu_interrupt(cs, CPU_INTERRUPT_HARD) ("00000002") in this function
just before the log message. Something is causing the HARD bit setting
to get lost.

The knock on effect of losing that bit is the decrementer timer interrupts
don't get delivered which causes the guest to sit idle in its idle handler
and 'hang'.

The issue occurs due to races from code which sets CPU_INTERRUPT_EXITTB.

Rather than poking directly into cs->interrupt_request, that code needs to:

a) hold BQL
b) use the cpu_interrupt() helper

This patch fixes the call sites to do this, fixing the hang. The calls
are made from a variety of contexts so a helper function is added to handle
the necessary locking. This can likely be improved and optimised in the future
but it ensures the code is correct and doesn't lockup as it stands today.

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
2017-12-05 12:28:42 +11:00
..
translate target/ppc: optimize various functions using extract op 2017-07-19 14:45:16 -07:00
Makefile.objs build: remove CONFIG_LIBDECNUMBER 2017-10-16 18:03:52 +02:00
arch_dump.c exec,dump,i386,ppc,s390x: don't include exec/cpu-all.h explicitly 2017-09-19 18:21:33 +02:00
compat.c ppc: fix setting of compat mode 2017-11-08 13:21:37 +11:00
cpu-models.c target/ppc: Add POWER9 DD2.0 model information 2017-10-17 10:34:00 +11:00
cpu-models.h target/ppc: Add POWER9 DD2.0 model information 2017-10-17 10:34:00 +11:00
cpu-qom.h ppc: move '-cpu foo,compat=xxx' parsing into ppc_cpu_parse_featurestr() 2017-10-17 10:34:00 +11:00
cpu.c target/ppc: support for 32-bit carry and overflow 2017-03-01 11:23:39 +11:00
cpu.h ppc: spapr: use generic cpu_model parsing 2017-10-17 10:34:01 +11:00
dfp_helper.c
excp_helper.c target/ppc: Fix system lockups caused by interrupt_request state corruption 2017-12-05 12:28:42 +11:00
fpu_helper.c target/ppc: use helper for excp handling 2017-03-06 13:17:28 +11:00
gdbstub.c
helper.h target/ppc: Flush TLB on write to PIDR 2017-04-26 12:41:56 +10:00
helper_regs.h target/ppc: Fix system lockups caused by interrupt_request state corruption 2017-12-05 12:28:42 +11:00
int_helper.c target/ppc: Fix carry flag setting for shift algebraic instructions 2017-10-17 10:34:00 +11:00
internal.h target-ppc: implement load atomic instruction 2017-02-22 11:28:27 +11:00
kvm-stub.c
kvm.c ppc: spapr: use generic cpu_model parsing 2017-10-17 10:34:01 +11:00
kvm_ppc.h spapr: fix the value of SDR1 in kvmppc_put_books_sregs() 2017-09-27 13:05:41 +10:00
machine.c target-ppc: Don't invalidate non-supported msr bits 2017-11-30 14:56:42 +11:00
mem_helper.c ppc: use DIV_ROUND_UP 2017-08-31 12:29:07 +02:00
mfrom_table.c
mfrom_table_gen.c
misc_helper.c target/ppc: Flush TLB on write to PIDR 2017-04-26 12:41:56 +10:00
mmu-book3s-v3.c target/ppc: Implement ISA V3.00 radix page fault handler 2017-05-11 09:45:15 +10:00
mmu-book3s-v3.h target/ppc: Implement ISA V3.00 radix page fault handler 2017-05-11 09:45:15 +10:00
mmu-hash32.c target/ppc: Eliminate htab_base and htab_mask variables 2017-03-01 11:23:39 +11:00
mmu-hash32.h target/ppc: Manage external HPT via virtual hypervisor 2017-03-01 11:23:39 +11:00
mmu-hash64.c spapr: Small cleanup of PPC MMU enums 2017-03-03 11:30:59 +11:00
mmu-hash64.h pseries: Implement HPT resizing 2017-07-17 15:07:05 +10:00
mmu-radix64.c target/ppc: Add debug function for radix mmu translation 2017-07-11 11:04:02 +10:00
mmu-radix64.h target/ppc: Add debug function for radix mmu translation 2017-07-11 11:04:02 +10:00
mmu_helper.c booke206: fix tlbnps for fixed size TLB 2017-09-08 09:30:55 +10:00
monitor.c Use qemu_tolower() and qemu_toupper(), not tolower() and toupper() 2017-07-21 10:32:41 +01:00
timebase_helper.c
trace-events docs: fix broken paths to docs/devel/tracing.txt 2017-07-31 13:12:53 +03:00
translate.c Capstone disassembler 2017-10-27 08:04:51 +01:00
translate_init.c ppc: fix VTB migration 2017-11-22 15:28:37 +11:00
user_only_helper.c