Peter Maydell c5ffd16ba4 Revert "cputlb: Restrict SavedIOTLB to system emulation" ... This reverts commit d7ee93e243. That commit tries to make a field in the CPUState struct not be present when CONFIG_USER_ONLY is set. Unfortunately, you can't conditionally omit fields in structs like this based on ifdefs that are set per-target. If you try it, then code in files compiled per-target (where CONFIG_USER_ONLY is or can be set) will disagree about the struct layout with files that are compiled once-only (where this kind of ifdef is never set). This manifests specifically in 'make check-tcg' failing, because code in cpus-common.c that sets up the CPUState::cpu_index field puts it at a different offset from the code in plugins/core.c in qemu_plugin_vcpu_init_hook() which reads the cpu_index field. The latter then hits an assert because from its point of view every thread has a 0 cpu_index. There might be other weird behaviour too. Mostly we catch this kind of bug because the CONFIG_whatever is listed in include/exec/poison.h and so the reference to it in build-once source files will then cause a compiler error. Unfortunately CONFIG_USER_ONLY is an exception to that: we have some places where we use it in "safe" ways in headers that will be seen by once-only source files (e.g. ifdeffing out function prototypes) and it would be a lot of refactoring to be able to get to a position where we could poison it. This leaves us in a "you have to be careful to walk around the bear trap" situation... Fixes: d7ee93e243 ("cputlb: Restrict SavedIOTLB to system emulation") Signed-off-by: Peter Maydell <peter.maydell@linaro.org> Message-Id: <20230620175712.1331625-1-peter.maydell@linaro.org> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>		2023-06-21 07:19:46 +02:00
..
accel-cpu.h	accel-cpu: make cpu_realizefn return a bool	2021-05-10 15:41:50 -04:00
cpu.h	Revert "cputlb: Restrict SavedIOTLB to system emulation"	2023-06-21 07:19:46 +02:00
generic-loader.h	Use OBJECT_DECLARE_SIMPLE_TYPE when possible	2020-09-18 14:12:32 -04:00
split-irq.h	Use OBJECT_DECLARE_SIMPLE_TYPE when possible	2020-09-18 14:12:32 -04:00
sysbus-fdt.h	hw/core: Move the ARM sysbus-fdt to core	2022-04-29 10:48:26 +10:00
sysemu-cpu-ops.h	dump: Replace opaque DumpState pointer with a typed one	2022-10-06 19:30:43 +04:00
tcg-cpu-ops.h	hw/core/cpu: Check for USER_ONLY definition instead of SOFTMMU one	2023-06-20 10:01:30 +02:00