2012-11-15 00:54:06 +04:00
|
|
|
/*
|
|
|
|
* Q35 chipset based pc system emulator
|
|
|
|
*
|
|
|
|
* Copyright (c) 2003-2004 Fabrice Bellard
|
|
|
|
* Copyright (c) 2009, 2010
|
|
|
|
* Isaku Yamahata <yamahata at valinux co jp>
|
|
|
|
* VA Linux Systems Japan K.K.
|
|
|
|
* Copyright (C) 2012 Jason Baron <jbaron@redhat.com>
|
|
|
|
*
|
|
|
|
* This is based on pc.c, but heavily modified.
|
|
|
|
*
|
|
|
|
* Permission is hereby granted, free of charge, to any person obtaining a copy
|
|
|
|
* of this software and associated documentation files (the "Software"), to deal
|
|
|
|
* in the Software without restriction, including without limitation the rights
|
|
|
|
* to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
|
|
|
|
* copies of the Software, and to permit persons to whom the Software is
|
|
|
|
* furnished to do so, subject to the following conditions:
|
|
|
|
*
|
|
|
|
* The above copyright notice and this permission notice shall be included in
|
|
|
|
* all copies or substantial portions of the Software.
|
|
|
|
*
|
|
|
|
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
|
|
|
|
* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
|
|
|
|
* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
|
|
|
|
* THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
|
|
|
|
* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
|
|
|
|
* OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
|
|
|
|
* THE SOFTWARE.
|
|
|
|
*/
|
2016-01-26 21:17:03 +03:00
|
|
|
#include "qemu/osdep.h"
|
2013-02-04 18:40:22 +04:00
|
|
|
#include "hw/hw.h"
|
2013-08-19 18:26:55 +04:00
|
|
|
#include "hw/loader.h"
|
2012-12-17 21:20:04 +04:00
|
|
|
#include "sysemu/arch_init.h"
|
2013-02-05 20:06:20 +04:00
|
|
|
#include "hw/i2c/smbus.h"
|
2013-02-04 18:40:22 +04:00
|
|
|
#include "hw/boards.h"
|
2013-02-05 20:06:20 +04:00
|
|
|
#include "hw/timer/mc146818rtc.h"
|
|
|
|
#include "hw/xen/xen.h"
|
2012-12-17 21:20:04 +04:00
|
|
|
#include "sysemu/kvm.h"
|
2013-02-04 18:40:22 +04:00
|
|
|
#include "hw/kvm/clock.h"
|
2013-02-05 20:06:20 +04:00
|
|
|
#include "hw/pci-host/q35.h"
|
2012-12-17 21:19:49 +04:00
|
|
|
#include "exec/address-spaces.h"
|
2013-02-05 20:06:20 +04:00
|
|
|
#include "hw/i386/ich9.h"
|
2015-08-12 05:08:20 +03:00
|
|
|
#include "hw/smbios/smbios.h"
|
2012-11-15 00:54:06 +04:00
|
|
|
#include "hw/ide/pci.h"
|
|
|
|
#include "hw/ide/ahci.h"
|
|
|
|
#include "hw/usb.h"
|
2014-06-20 05:40:25 +04:00
|
|
|
#include "qemu/error-report.h"
|
2015-05-19 14:29:51 +03:00
|
|
|
#include "migration/migration.h"
|
2012-11-15 00:54:06 +04:00
|
|
|
|
|
|
|
/* ICH9 AHCI has 6 ports */
|
|
|
|
#define MAX_SATA_PORTS 6
|
|
|
|
|
|
|
|
/* PC hardware initialisation */
|
2014-05-07 18:42:57 +04:00
|
|
|
static void pc_q35_init(MachineState *machine)
|
2012-11-15 00:54:06 +04:00
|
|
|
{
|
2015-08-07 22:55:45 +03:00
|
|
|
PCMachineState *pcms = PC_MACHINE(machine);
|
2015-12-02 01:58:03 +03:00
|
|
|
PCMachineClass *pcmc = PC_MACHINE_GET_CLASS(pcms);
|
2012-11-15 00:54:06 +04:00
|
|
|
Q35PCIHost *q35_host;
|
2013-07-01 14:18:22 +04:00
|
|
|
PCIHostState *phb;
|
2012-11-15 00:54:06 +04:00
|
|
|
PCIBus *host_bus;
|
|
|
|
PCIDevice *lpc;
|
|
|
|
BusState *idebus[MAX_SATA_PORTS];
|
|
|
|
ISADevice *rtc_state;
|
|
|
|
MemoryRegion *pci_memory;
|
|
|
|
MemoryRegion *rom_memory;
|
|
|
|
MemoryRegion *ram_memory;
|
|
|
|
GSIState *gsi_state;
|
|
|
|
ISABus *isa_bus;
|
|
|
|
qemu_irq *gsi;
|
|
|
|
qemu_irq *i8259;
|
|
|
|
int i;
|
|
|
|
ICH9LPCState *ich9_lpc;
|
|
|
|
PCIDevice *ahci;
|
2014-06-20 05:40:25 +04:00
|
|
|
ram_addr_t lowmem;
|
2014-10-01 22:19:29 +04:00
|
|
|
DriveInfo *hd[MAX_SATA_PORTS];
|
2015-05-28 23:04:10 +03:00
|
|
|
MachineClass *mc = MACHINE_GET_CLASS(machine);
|
2013-04-29 19:02:50 +04:00
|
|
|
|
2013-12-16 15:55:06 +04:00
|
|
|
/* Check whether RAM fits below 4G (leaving 1/2 GByte for IO memory
|
|
|
|
* and 256 Mbytes for PCI Express Enhanced Configuration Access Mapping
|
|
|
|
* also known as MMCFG).
|
|
|
|
* If it doesn't, we need to split it in chunks below and above 4G.
|
|
|
|
* In any case, try to make sure that guest addresses aligned at
|
|
|
|
* 1G boundaries get mapped to host addresses aligned at 1G boundaries.
|
|
|
|
* For old machine types, use whatever split we used historically to avoid
|
|
|
|
* breaking migration.
|
|
|
|
*/
|
2014-05-07 18:42:57 +04:00
|
|
|
if (machine->ram_size >= 0xb0000000) {
|
2015-12-02 01:58:03 +03:00
|
|
|
lowmem = pcmc->gigabyte_align ? 0x80000000 : 0xb0000000;
|
2014-06-20 05:40:25 +04:00
|
|
|
} else {
|
|
|
|
lowmem = 0xb0000000;
|
|
|
|
}
|
|
|
|
|
2014-07-07 23:00:41 +04:00
|
|
|
/* Handle the machine opt max-ram-below-4g. It is basically doing
|
2014-06-20 05:40:25 +04:00
|
|
|
* min(qemu limit, user limit).
|
|
|
|
*/
|
2015-08-07 22:55:45 +03:00
|
|
|
if (lowmem > pcms->max_ram_below_4g) {
|
|
|
|
lowmem = pcms->max_ram_below_4g;
|
2014-06-20 05:40:25 +04:00
|
|
|
if (machine->ram_size - lowmem > lowmem &&
|
|
|
|
lowmem & ((1ULL << 30) - 1)) {
|
|
|
|
error_report("Warning: Large machine and max_ram_below_4g(%"PRIu64
|
|
|
|
") not a multiple of 1G; possible bad performance.",
|
2015-08-07 22:55:45 +03:00
|
|
|
pcms->max_ram_below_4g);
|
2014-06-20 05:40:25 +04:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
if (machine->ram_size >= lowmem) {
|
2015-08-07 22:55:51 +03:00
|
|
|
pcms->above_4g_mem_size = machine->ram_size - lowmem;
|
|
|
|
pcms->below_4g_mem_size = lowmem;
|
2012-11-15 00:54:06 +04:00
|
|
|
} else {
|
2015-08-07 22:55:51 +03:00
|
|
|
pcms->above_4g_mem_size = 0;
|
|
|
|
pcms->below_4g_mem_size = machine->ram_size;
|
2012-11-15 00:54:06 +04:00
|
|
|
}
|
|
|
|
|
2016-01-14 18:09:38 +03:00
|
|
|
if (xen_enabled()) {
|
|
|
|
xen_hvm_init(pcms, &ram_memory);
|
2014-06-20 05:40:24 +04:00
|
|
|
}
|
|
|
|
|
2015-10-15 06:12:12 +03:00
|
|
|
pc_cpus_init(pcms);
|
2015-12-17 13:40:49 +03:00
|
|
|
if (!pcmc->has_acpi_build) {
|
|
|
|
/* only machine types 1.7 & older need this */
|
|
|
|
pc_acpi_init("q35-acpi-dsdt.aml");
|
|
|
|
}
|
2014-06-20 05:40:24 +04:00
|
|
|
|
|
|
|
kvmclock_create();
|
|
|
|
|
2012-11-15 00:54:06 +04:00
|
|
|
/* pci enabled */
|
2015-12-02 01:58:03 +03:00
|
|
|
if (pcmc->pci_enabled) {
|
2012-11-15 00:54:06 +04:00
|
|
|
pci_memory = g_new(MemoryRegion, 1);
|
2013-11-06 22:18:08 +04:00
|
|
|
memory_region_init(pci_memory, NULL, "pci", UINT64_MAX);
|
2012-11-15 00:54:06 +04:00
|
|
|
rom_memory = pci_memory;
|
|
|
|
} else {
|
|
|
|
pci_memory = NULL;
|
|
|
|
rom_memory = get_system_memory();
|
|
|
|
}
|
|
|
|
|
2015-12-11 21:42:30 +03:00
|
|
|
pc_guest_info_init(pcms);
|
pc: hack for migration compatibility from QEMU 2.0
Changing the ACPI table size causes migration to break, and the memory
hotplug work opened our eyes on how horribly we were breaking things in
2.0 already.
The ACPI table size is rounded to the next 4k, which one would think
gives some headroom. In practice this is not the case, because the user
can control the ACPI table size (each CPU adds 97 bytes to the SSDT and
8 to the MADT) and so some "-smp" values will break the 4k boundary and
fail to migrate. Similarly, PCI bridges add ~1870 bytes to the SSDT.
This patch concerns itself with fixing migration from QEMU 2.0. It
computes the payload size of QEMU 2.0 and always uses that one.
The previous patch shrunk the ACPI tables enough that the QEMU 2.0 size
should always be enough; non-AML tables can change depending on the
configuration (especially MADT, SRAT, HPET) but they remain the same
between QEMU 2.0 and 2.1, so we only compute our padding based on the
sizes of the SSDT and DSDT.
Migration from QEMU 1.7 should work for guests that have a number of CPUs
other than 12, 13, 14, 54, 55, 56, 97, 98, 139, 140. It was already
broken from QEMU 1.7 to QEMU 2.0 in the same way, though.
Even with this patch, QEMU 1.7 and 2.0 have two different ideas of
"-M pc-i440fx-2.0" when there are PCI bridges. Igor sent a patch to
adopt the QEMU 1.7 definition. I think distributions should apply
it if they move directly from QEMU 1.7 to 2.1+ without ever packaging
version 2.0.
Reviewed-by: Laszlo Ersek <lersek@redhat.com>
Tested-by: Igor Mammedov <imammedo@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
2014-07-28 19:34:15 +04:00
|
|
|
|
2015-12-02 01:58:03 +03:00
|
|
|
if (pcmc->smbios_defaults) {
|
2013-10-30 16:56:40 +04:00
|
|
|
/* These values are guest ABI, do not change */
|
2014-04-23 17:42:38 +04:00
|
|
|
smbios_set_defaults("QEMU", "Standard PC (Q35 + ICH9, 2009)",
|
2015-12-02 01:58:03 +03:00
|
|
|
mc->name, pcmc->smbios_legacy_mode,
|
|
|
|
pcmc->smbios_uuid_encoded,
|
2015-09-07 12:39:28 +03:00
|
|
|
SMBIOS_ENTRY_POINT_21);
|
2013-10-30 16:56:40 +04:00
|
|
|
}
|
|
|
|
|
2012-11-15 00:54:06 +04:00
|
|
|
/* allocate ram and load rom/bios */
|
|
|
|
if (!xen_enabled()) {
|
2015-08-07 22:55:50 +03:00
|
|
|
pc_memory_init(pcms, get_system_memory(),
|
2015-12-11 21:42:24 +03:00
|
|
|
rom_memory, &ram_memory);
|
2012-11-15 00:54:06 +04:00
|
|
|
}
|
|
|
|
|
|
|
|
/* irq lines */
|
|
|
|
gsi_state = g_malloc0(sizeof(*gsi_state));
|
|
|
|
if (kvm_irqchip_in_kernel()) {
|
2015-12-02 01:58:03 +03:00
|
|
|
kvm_pc_setup_irq_routing(pcmc->pci_enabled);
|
2012-11-15 00:54:06 +04:00
|
|
|
gsi = qemu_allocate_irqs(kvm_pc_gsi_handler, gsi_state,
|
|
|
|
GSI_NUM_PINS);
|
|
|
|
} else {
|
|
|
|
gsi = qemu_allocate_irqs(gsi_handler, gsi_state, GSI_NUM_PINS);
|
|
|
|
}
|
|
|
|
|
|
|
|
/* create pci host bus */
|
|
|
|
q35_host = Q35_HOST_DEVICE(qdev_create(NULL, TYPE_Q35_HOST_DEVICE));
|
|
|
|
|
2013-07-29 18:47:54 +04:00
|
|
|
object_property_add_child(qdev_get_machine(), "q35", OBJECT(q35_host), NULL);
|
2012-11-15 00:54:06 +04:00
|
|
|
q35_host->mch.ram_memory = ram_memory;
|
|
|
|
q35_host->mch.pci_address_space = pci_memory;
|
|
|
|
q35_host->mch.system_memory = get_system_memory();
|
2013-05-09 11:53:50 +04:00
|
|
|
q35_host->mch.address_space_io = get_system_io();
|
2015-08-07 22:55:51 +03:00
|
|
|
q35_host->mch.below_4g_mem_size = pcms->below_4g_mem_size;
|
|
|
|
q35_host->mch.above_4g_mem_size = pcms->above_4g_mem_size;
|
2012-11-15 00:54:06 +04:00
|
|
|
/* pci */
|
|
|
|
qdev_init_nofail(DEVICE(q35_host));
|
2013-07-01 14:18:22 +04:00
|
|
|
phb = PCI_HOST_BRIDGE(q35_host);
|
|
|
|
host_bus = phb->bus;
|
2015-11-26 19:00:28 +03:00
|
|
|
pcms->bus = phb->bus;
|
2012-11-15 00:54:06 +04:00
|
|
|
/* create ISA bus */
|
|
|
|
lpc = pci_create_simple_multifunction(host_bus, PCI_DEVFN(ICH9_LPC_DEV,
|
|
|
|
ICH9_LPC_FUNC), true,
|
|
|
|
TYPE_ICH9_LPC_DEVICE);
|
2014-06-02 17:25:24 +04:00
|
|
|
|
|
|
|
object_property_add_link(OBJECT(machine), PC_MACHINE_ACPI_DEVICE_PROP,
|
|
|
|
TYPE_HOTPLUG_HANDLER,
|
2015-08-07 22:55:45 +03:00
|
|
|
(Object **)&pcms->acpi_dev,
|
2014-06-02 17:25:24 +04:00
|
|
|
object_property_allow_set_link,
|
|
|
|
OBJ_PROP_LINK_UNREF_ON_RELEASE, &error_abort);
|
|
|
|
object_property_set_link(OBJECT(machine), OBJECT(lpc),
|
|
|
|
PC_MACHINE_ACPI_DEVICE_PROP, &error_abort);
|
|
|
|
|
2012-11-15 00:54:06 +04:00
|
|
|
ich9_lpc = ICH9_LPC_DEVICE(lpc);
|
|
|
|
ich9_lpc->pic = gsi;
|
|
|
|
ich9_lpc->ioapic = gsi_state->ioapic_irq;
|
|
|
|
pci_bus_irqs(host_bus, ich9_lpc_set_irq, ich9_lpc_map_irq, ich9_lpc,
|
|
|
|
ICH9_LPC_NB_PIRQS);
|
2013-01-23 06:11:37 +04:00
|
|
|
pci_bus_set_route_irq_fn(host_bus, ich9_route_intx_pin_to_irq);
|
2012-11-15 00:54:06 +04:00
|
|
|
isa_bus = ich9_lpc->isa_bus;
|
|
|
|
|
|
|
|
/*end early*/
|
|
|
|
isa_bus_irqs(isa_bus, gsi);
|
|
|
|
|
|
|
|
if (kvm_irqchip_in_kernel()) {
|
|
|
|
i8259 = kvm_i8259_init(isa_bus);
|
|
|
|
} else if (xen_enabled()) {
|
|
|
|
i8259 = xen_interrupt_controller_init();
|
|
|
|
} else {
|
2015-05-29 08:26:59 +03:00
|
|
|
i8259 = i8259_init(isa_bus, pc_allocate_cpu_irq());
|
2012-11-15 00:54:06 +04:00
|
|
|
}
|
|
|
|
|
|
|
|
for (i = 0; i < ISA_NUM_IRQS; i++) {
|
|
|
|
gsi_state->i8259_irq[i] = i8259[i];
|
|
|
|
}
|
2015-12-02 01:58:03 +03:00
|
|
|
if (pcmc->pci_enabled) {
|
2014-08-05 01:11:19 +04:00
|
|
|
ioapic_init_gsi(gsi_state, "q35");
|
2012-11-15 00:54:06 +04:00
|
|
|
}
|
|
|
|
|
|
|
|
pc_register_ferr_irq(gsi[13]);
|
|
|
|
|
qapi: Don't let implicit enum MAX member collide
Now that we guarantee the user doesn't have any enum values
beginning with a single underscore, we can use that for our
own purposes. Renaming ENUM_MAX to ENUM__MAX makes it obvious
that the sentinel is generated.
This patch was mostly generated by applying a temporary patch:
|diff --git a/scripts/qapi.py b/scripts/qapi.py
|index e6d014b..b862ec9 100644
|--- a/scripts/qapi.py
|+++ b/scripts/qapi.py
|@@ -1570,6 +1570,7 @@ const char *const %(c_name)s_lookup[] = {
| max_index = c_enum_const(name, 'MAX', prefix)
| ret += mcgen('''
| [%(max_index)s] = NULL,
|+// %(max_index)s
| };
| ''',
| max_index=max_index)
then running:
$ cat qapi-{types,event}.c tests/test-qapi-types.c |
sed -n 's,^// \(.*\)MAX,s|\1MAX|\1_MAX|g,p' > list
$ git grep -l _MAX | xargs sed -i -f list
The only things not generated are the changes in scripts/qapi.py.
Rejecting enum members named 'MAX' is now useless, and will be dropped
in the next patch.
Signed-off-by: Eric Blake <eblake@redhat.com>
Message-Id: <1447836791-369-23-git-send-email-eblake@redhat.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
[Rebased to current master, commit message tweaked]
Signed-off-by: Markus Armbruster <armbru@redhat.com>
2015-11-18 11:52:57 +03:00
|
|
|
assert(pcms->vmport != ON_OFF_AUTO__MAX);
|
2015-08-07 22:55:45 +03:00
|
|
|
if (pcms->vmport == ON_OFF_AUTO_AUTO) {
|
|
|
|
pcms->vmport = xen_enabled() ? ON_OFF_AUTO_OFF : ON_OFF_AUTO_ON;
|
2014-11-21 19:18:52 +03:00
|
|
|
}
|
|
|
|
|
2012-11-15 00:54:06 +04:00
|
|
|
/* init basic PC hardware */
|
2015-06-25 16:35:07 +03:00
|
|
|
pc_basic_device_init(isa_bus, gsi, &rtc_state, !mc->no_floppy,
|
2015-08-07 22:55:45 +03:00
|
|
|
(pcms->vmport != ON_OFF_AUTO_ON), 0xff0104);
|
2012-11-15 00:54:06 +04:00
|
|
|
|
|
|
|
/* connect pm stuff to lpc */
|
2015-08-07 22:55:45 +03:00
|
|
|
ich9_lpc_pm_init(lpc, pc_machine_is_smm_enabled(pcms), !mc->no_tco);
|
2012-11-15 00:54:06 +04:00
|
|
|
|
|
|
|
/* ahci and SATA device, for q35 1 ahci controller is built-in */
|
|
|
|
ahci = pci_create_simple_multifunction(host_bus,
|
|
|
|
PCI_DEVFN(ICH9_SATA1_DEV,
|
|
|
|
ICH9_SATA1_FUNC),
|
|
|
|
true, "ich9-ahci");
|
|
|
|
idebus[0] = qdev_get_child_bus(&ahci->qdev, "ide.0");
|
|
|
|
idebus[1] = qdev_get_child_bus(&ahci->qdev, "ide.1");
|
2014-10-17 22:04:35 +04:00
|
|
|
g_assert(MAX_SATA_PORTS == ICH_AHCI(ahci)->ahci.ports);
|
2014-10-01 22:19:29 +04:00
|
|
|
ide_drive_get(hd, ICH_AHCI(ahci)->ahci.ports);
|
|
|
|
ahci_ide_create_devs(ahci, hd);
|
2012-11-15 00:54:06 +04:00
|
|
|
|
2015-01-06 16:29:14 +03:00
|
|
|
if (usb_enabled()) {
|
2012-11-15 00:54:06 +04:00
|
|
|
/* Should we create 6 UHCI according to ich9 spec? */
|
|
|
|
ehci_create_ich9_with_companions(host_bus, 0x1d);
|
|
|
|
}
|
|
|
|
|
|
|
|
/* TODO: Populate SPD eeprom data. */
|
|
|
|
smbus_eeprom_init(ich9_smb_init(host_bus,
|
|
|
|
PCI_DEVFN(ICH9_SMB_DEV, ICH9_SMB_FUNC),
|
|
|
|
0xb100),
|
|
|
|
8, NULL, 0);
|
|
|
|
|
2015-08-07 22:55:54 +03:00
|
|
|
pc_cmos_init(pcms, idebus[0], idebus[1], rtc_state);
|
2012-11-15 00:54:06 +04:00
|
|
|
|
|
|
|
/* the rest devices to which pci devfn is automatically assigned */
|
|
|
|
pc_vga_init(isa_bus, host_bus);
|
|
|
|
pc_nic_init(isa_bus, host_bus);
|
2015-12-02 01:58:03 +03:00
|
|
|
if (pcmc->pci_enabled) {
|
2012-11-15 00:54:06 +04:00
|
|
|
pc_pci_device_init(host_bus);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2015-09-28 21:07:21 +03:00
|
|
|
/* Looking for a pc_compat_2_4() function? It doesn't exist.
|
|
|
|
* pc_compat_*() functions that run on machine-init time and
|
|
|
|
* change global QEMU state are deprecated. Please don't create
|
|
|
|
* one, and implement any pc-*-2.4 (and newer) compat code in
|
|
|
|
* HW_COMPAT_*, PC_COMPAT_*, or * pc_*_machine_options().
|
|
|
|
*/
|
|
|
|
|
2015-04-23 09:21:35 +03:00
|
|
|
static void pc_compat_2_3(MachineState *machine)
|
|
|
|
{
|
2015-06-18 19:30:52 +03:00
|
|
|
PCMachineState *pcms = PC_MACHINE(machine);
|
2015-05-19 14:29:51 +03:00
|
|
|
savevm_skip_section_footers();
|
2015-06-18 19:30:52 +03:00
|
|
|
if (kvm_enabled()) {
|
|
|
|
pcms->smm = ON_OFF_AUTO_OFF;
|
|
|
|
}
|
2014-10-08 15:58:24 +04:00
|
|
|
global_state_set_optional();
|
2015-05-13 19:17:43 +03:00
|
|
|
savevm_skip_configuration();
|
2015-04-23 09:21:35 +03:00
|
|
|
}
|
|
|
|
|
2014-12-05 12:51:42 +03:00
|
|
|
static void pc_compat_2_2(MachineState *machine)
|
|
|
|
{
|
2015-04-23 09:21:35 +03:00
|
|
|
pc_compat_2_3(machine);
|
2015-02-23 15:56:43 +03:00
|
|
|
machine->suppress_vmdesc = true;
|
2014-12-05 12:51:42 +03:00
|
|
|
}
|
|
|
|
|
2014-10-29 16:26:07 +03:00
|
|
|
static void pc_compat_2_1(MachineState *machine)
|
|
|
|
{
|
2014-12-05 12:51:42 +03:00
|
|
|
pc_compat_2_2(machine);
|
2015-09-11 18:40:27 +03:00
|
|
|
x86_cpu_change_kvm_default("svm", NULL);
|
2014-10-29 16:26:07 +03:00
|
|
|
}
|
|
|
|
|
2014-05-07 18:42:57 +04:00
|
|
|
static void pc_compat_2_0(MachineState *machine)
|
2014-04-24 14:14:53 +04:00
|
|
|
{
|
2014-10-29 16:26:07 +03:00
|
|
|
pc_compat_2_1(machine);
|
2014-04-24 14:14:53 +04:00
|
|
|
}
|
|
|
|
|
2014-05-07 18:42:57 +04:00
|
|
|
static void pc_compat_1_7(MachineState *machine)
|
2013-10-30 16:56:40 +04:00
|
|
|
{
|
2014-05-07 18:42:57 +04:00
|
|
|
pc_compat_2_0(machine);
|
2015-09-11 18:40:27 +03:00
|
|
|
x86_cpu_change_kvm_default("x2apic", NULL);
|
2013-10-30 16:56:40 +04:00
|
|
|
}
|
|
|
|
|
2014-05-07 18:42:57 +04:00
|
|
|
static void pc_compat_1_6(MachineState *machine)
|
2013-05-13 21:00:23 +04:00
|
|
|
{
|
2014-05-07 18:42:57 +04:00
|
|
|
pc_compat_1_7(machine);
|
2013-05-13 21:00:23 +04:00
|
|
|
}
|
|
|
|
|
2014-05-07 18:42:57 +04:00
|
|
|
static void pc_compat_1_5(MachineState *machine)
|
2013-08-01 16:39:11 +04:00
|
|
|
{
|
2014-05-07 18:42:57 +04:00
|
|
|
pc_compat_1_6(machine);
|
2013-08-01 16:39:11 +04:00
|
|
|
}
|
|
|
|
|
2014-05-07 18:42:57 +04:00
|
|
|
static void pc_compat_1_4(MachineState *machine)
|
pc: Kill the "use flash device for BIOS unless KVM" misfeature
Use of a flash memory device for the BIOS was added in series "[PATCH
v10 0/8] PC system flash support", commit 4732dca..1b89faf, v1.1.
Flash vs. ROM is a guest-visible difference. Thus, flash use had to
be suppressed for machine types pc-1.0 and older. This was
accomplished by adding a dummy device "pc-sysfw" with property
"rom_only":
* Non-zero rom_only means "use ROM". Default for pc-1.0 and older.
* Zero rom_only means "maybe use flash". Default for newer machines.
Not only is the dummy device ugly, it was also retroactively added to
the older machine types! Fortunately, it's not guest-visible (thus no
immediate guest ABI breakage), and has no vmstate (thus no immediate
migration breakage). Breakage occurs only if the user unwisely
enables flash by setting rom_only to zero. Patch review FAIL #1.
Why "maybe use flash"? Flash didn't (and still doesn't) work with
KVM. Therefore, rom_only=0 really means "use flash, except when KVM
is enabled, use ROM". This is a Bad Idea, because it makes enabling/
disabling KVM guest-visible. Patch review FAIL #2.
Aside: it also precludes migrating between KVM on and off, but that's
not possible for other reasons anyway.
Fix as follows:
1. Change the meaning of rom_only=0 to mean "use flash, no ifs, buts,
or maybes" for pc-i440fx-1.5 and pc-q35-1.5. Don't change anything
for older machines (to remain bug-compatible).
2. Change the default value from 0 to 1 for these machines.
Necessary, because 0 doesn't work with KVM. Once it does, we can flip
the default back to 0.
3. Don't revert the retroactive addition of device "pc-sysfw" to older
machine types. Seems not worth the trouble.
4. Add a TODO comment asking for device "pc-sysfw" to be dropped once
flash works with KVM.
Net effect is that you get a BIOS ROM again even when KVM is disabled,
just like for machines predating the introduction of flash.
To get flash instead, use "--global pc-sysfw.rom_only=0".
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-id: 1365780303-26398-4-git-send-email-armbru@redhat.com
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
2013-04-12 19:25:03 +04:00
|
|
|
{
|
2014-05-07 18:42:57 +04:00
|
|
|
pc_compat_1_5(machine);
|
2013-08-21 22:14:43 +04:00
|
|
|
}
|
|
|
|
|
2015-05-15 20:19:01 +03:00
|
|
|
#define DEFINE_Q35_MACHINE(suffix, name, compatfn, optionfn) \
|
|
|
|
static void pc_init_##suffix(MachineState *machine) \
|
|
|
|
{ \
|
|
|
|
void (*compat)(MachineState *m) = (compatfn); \
|
|
|
|
if (compat) { \
|
|
|
|
compat(machine); \
|
|
|
|
} \
|
|
|
|
pc_q35_init(machine); \
|
|
|
|
} \
|
|
|
|
DEFINE_PC_MACHINE(suffix, name, pc_init_##suffix, optionfn)
|
2014-04-24 14:14:53 +04:00
|
|
|
|
pc: Kill the "use flash device for BIOS unless KVM" misfeature
Use of a flash memory device for the BIOS was added in series "[PATCH
v10 0/8] PC system flash support", commit 4732dca..1b89faf, v1.1.
Flash vs. ROM is a guest-visible difference. Thus, flash use had to
be suppressed for machine types pc-1.0 and older. This was
accomplished by adding a dummy device "pc-sysfw" with property
"rom_only":
* Non-zero rom_only means "use ROM". Default for pc-1.0 and older.
* Zero rom_only means "maybe use flash". Default for newer machines.
Not only is the dummy device ugly, it was also retroactively added to
the older machine types! Fortunately, it's not guest-visible (thus no
immediate guest ABI breakage), and has no vmstate (thus no immediate
migration breakage). Breakage occurs only if the user unwisely
enables flash by setting rom_only to zero. Patch review FAIL #1.
Why "maybe use flash"? Flash didn't (and still doesn't) work with
KVM. Therefore, rom_only=0 really means "use flash, except when KVM
is enabled, use ROM". This is a Bad Idea, because it makes enabling/
disabling KVM guest-visible. Patch review FAIL #2.
Aside: it also precludes migrating between KVM on and off, but that's
not possible for other reasons anyway.
Fix as follows:
1. Change the meaning of rom_only=0 to mean "use flash, no ifs, buts,
or maybes" for pc-i440fx-1.5 and pc-q35-1.5. Don't change anything
for older machines (to remain bug-compatible).
2. Change the default value from 0 to 1 for these machines.
Necessary, because 0 doesn't work with KVM. Once it does, we can flip
the default back to 0.
3. Don't revert the retroactive addition of device "pc-sysfw" to older
machine types. Seems not worth the trouble.
4. Add a TODO comment asking for device "pc-sysfw" to be dropped once
flash works with KVM.
Net effect is that you get a BIOS ROM again even when KVM is disabled,
just like for machines predating the introduction of flash.
To get flash instead, use "--global pc-sysfw.rom_only=0".
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-id: 1365780303-26398-4-git-send-email-armbru@redhat.com
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
2013-04-12 19:25:03 +04:00
|
|
|
|
2015-05-15 20:18:56 +03:00
|
|
|
static void pc_q35_machine_options(MachineClass *m)
|
2015-05-15 20:18:54 +03:00
|
|
|
{
|
|
|
|
m->family = "pc_q35";
|
|
|
|
m->desc = "Standard PC (Q35 + ICH9, 2009)";
|
|
|
|
m->hot_add_cpu = pc_hot_add_cpu;
|
|
|
|
m->units_per_default_bus = 1;
|
2015-09-11 23:14:23 +03:00
|
|
|
m->default_machine_opts = "firmware=bios-256k.bin";
|
|
|
|
m->default_display = "std";
|
|
|
|
m->no_floppy = 1;
|
|
|
|
m->no_tco = 0;
|
2015-05-15 20:18:54 +03:00
|
|
|
}
|
|
|
|
|
2015-11-30 17:56:36 +03:00
|
|
|
static void pc_q35_2_6_machine_options(MachineClass *m)
|
2015-09-11 23:14:25 +03:00
|
|
|
{
|
|
|
|
pc_q35_machine_options(m);
|
|
|
|
m->alias = "q35";
|
|
|
|
}
|
|
|
|
|
2015-11-30 17:56:36 +03:00
|
|
|
DEFINE_Q35_MACHINE(v2_6, "pc-q35-2.6", NULL,
|
|
|
|
pc_q35_2_6_machine_options);
|
|
|
|
|
|
|
|
static void pc_q35_2_5_machine_options(MachineClass *m)
|
|
|
|
{
|
2015-11-24 06:33:57 +03:00
|
|
|
PCMachineClass *pcmc = PC_MACHINE_CLASS(m);
|
2015-11-30 17:56:36 +03:00
|
|
|
pc_q35_2_6_machine_options(m);
|
|
|
|
m->alias = NULL;
|
2015-11-24 06:33:57 +03:00
|
|
|
pcmc->save_tsc_khz = false;
|
2015-11-30 17:56:36 +03:00
|
|
|
SET_MACHINE_COMPAT(m, PC_COMPAT_2_5);
|
|
|
|
}
|
|
|
|
|
2015-09-11 23:14:25 +03:00
|
|
|
DEFINE_Q35_MACHINE(v2_5, "pc-q35-2.5", NULL,
|
|
|
|
pc_q35_2_5_machine_options);
|
|
|
|
|
2015-05-15 20:18:56 +03:00
|
|
|
static void pc_q35_2_4_machine_options(MachineClass *m)
|
2015-05-15 20:18:54 +03:00
|
|
|
{
|
2015-09-07 14:55:32 +03:00
|
|
|
PCMachineClass *pcmc = PC_MACHINE_CLASS(m);
|
2015-09-11 23:14:25 +03:00
|
|
|
pc_q35_2_5_machine_options(m);
|
2015-10-30 22:36:07 +03:00
|
|
|
m->hw_version = "2.4.0";
|
2015-09-07 14:55:32 +03:00
|
|
|
pcmc->broken_reserved_end = true;
|
2015-09-11 23:14:25 +03:00
|
|
|
SET_MACHINE_COMPAT(m, PC_COMPAT_2_4);
|
2015-05-15 20:18:54 +03:00
|
|
|
}
|
2013-12-02 15:47:29 +04:00
|
|
|
|
2015-05-15 20:19:01 +03:00
|
|
|
DEFINE_Q35_MACHINE(v2_4, "pc-q35-2.4", NULL,
|
|
|
|
pc_q35_2_4_machine_options);
|
2015-05-15 20:18:53 +03:00
|
|
|
|
2015-04-23 09:21:35 +03:00
|
|
|
|
2015-05-15 20:18:56 +03:00
|
|
|
static void pc_q35_2_3_machine_options(MachineClass *m)
|
2015-05-15 20:18:54 +03:00
|
|
|
{
|
|
|
|
pc_q35_2_4_machine_options(m);
|
2015-10-30 22:36:07 +03:00
|
|
|
m->hw_version = "2.3.0";
|
2015-06-18 19:49:28 +03:00
|
|
|
m->no_floppy = 0;
|
2015-06-28 20:58:56 +03:00
|
|
|
m->no_tco = 1;
|
2015-05-15 20:18:55 +03:00
|
|
|
SET_MACHINE_COMPAT(m, PC_COMPAT_2_3);
|
2015-05-15 20:18:54 +03:00
|
|
|
}
|
2015-04-23 09:21:35 +03:00
|
|
|
|
2015-05-15 20:19:01 +03:00
|
|
|
DEFINE_Q35_MACHINE(v2_3, "pc-q35-2.3", pc_compat_2_3,
|
|
|
|
pc_q35_2_3_machine_options);
|
2015-05-15 20:18:53 +03:00
|
|
|
|
2014-12-05 12:51:42 +03:00
|
|
|
|
2015-05-15 20:18:56 +03:00
|
|
|
static void pc_q35_2_2_machine_options(MachineClass *m)
|
2015-05-15 20:18:54 +03:00
|
|
|
{
|
2015-12-02 01:58:03 +03:00
|
|
|
PCMachineClass *pcmc = PC_MACHINE_CLASS(m);
|
2015-05-15 20:18:54 +03:00
|
|
|
pc_q35_2_3_machine_options(m);
|
2015-10-30 22:36:07 +03:00
|
|
|
m->hw_version = "2.2.0";
|
2015-05-15 20:18:55 +03:00
|
|
|
SET_MACHINE_COMPAT(m, PC_COMPAT_2_2);
|
2015-12-02 01:58:03 +03:00
|
|
|
pcmc->rsdp_in_ram = false;
|
2015-05-15 20:18:54 +03:00
|
|
|
}
|
2014-12-05 12:51:42 +03:00
|
|
|
|
2015-05-15 20:19:01 +03:00
|
|
|
DEFINE_Q35_MACHINE(v2_2, "pc-q35-2.2", pc_compat_2_2,
|
|
|
|
pc_q35_2_2_machine_options);
|
2015-05-15 20:18:53 +03:00
|
|
|
|
2014-07-30 11:02:00 +04:00
|
|
|
|
2015-05-15 20:18:56 +03:00
|
|
|
static void pc_q35_2_1_machine_options(MachineClass *m)
|
2015-05-15 20:18:54 +03:00
|
|
|
{
|
2015-12-02 01:58:03 +03:00
|
|
|
PCMachineClass *pcmc = PC_MACHINE_CLASS(m);
|
2015-05-15 20:18:54 +03:00
|
|
|
pc_q35_2_2_machine_options(m);
|
2015-10-30 22:36:07 +03:00
|
|
|
m->hw_version = "2.1.0";
|
2015-05-15 20:18:54 +03:00
|
|
|
m->default_display = NULL;
|
2015-05-15 20:18:55 +03:00
|
|
|
SET_MACHINE_COMPAT(m, PC_COMPAT_2_1);
|
2015-12-02 01:58:03 +03:00
|
|
|
pcmc->smbios_uuid_encoded = false;
|
2015-12-02 01:58:06 +03:00
|
|
|
pcmc->enforce_aligned_dimm = false;
|
2015-05-15 20:18:54 +03:00
|
|
|
}
|
2014-07-30 11:02:00 +04:00
|
|
|
|
2015-05-15 20:19:01 +03:00
|
|
|
DEFINE_Q35_MACHINE(v2_1, "pc-q35-2.1", pc_compat_2_1,
|
|
|
|
pc_q35_2_1_machine_options);
|
2015-05-15 20:18:53 +03:00
|
|
|
|
2014-04-24 14:14:53 +04:00
|
|
|
|
2015-05-15 20:18:56 +03:00
|
|
|
static void pc_q35_2_0_machine_options(MachineClass *m)
|
2015-05-15 20:18:54 +03:00
|
|
|
{
|
2015-12-02 01:58:03 +03:00
|
|
|
PCMachineClass *pcmc = PC_MACHINE_CLASS(m);
|
2015-05-15 20:18:54 +03:00
|
|
|
pc_q35_2_1_machine_options(m);
|
2015-10-30 22:36:07 +03:00
|
|
|
m->hw_version = "2.0.0";
|
2015-05-15 20:18:55 +03:00
|
|
|
SET_MACHINE_COMPAT(m, PC_COMPAT_2_0);
|
2015-12-02 01:58:03 +03:00
|
|
|
pcmc->has_reserved_memory = false;
|
|
|
|
pcmc->smbios_legacy_mode = true;
|
2015-12-02 01:58:05 +03:00
|
|
|
pcmc->acpi_data_size = 0x10000;
|
2015-05-15 20:18:54 +03:00
|
|
|
}
|
2014-04-24 14:14:53 +04:00
|
|
|
|
2015-05-15 20:19:01 +03:00
|
|
|
DEFINE_Q35_MACHINE(v2_0, "pc-q35-2.0", pc_compat_2_0,
|
|
|
|
pc_q35_2_0_machine_options);
|
2015-05-15 20:18:53 +03:00
|
|
|
|
2013-12-02 15:47:29 +04:00
|
|
|
|
2015-05-15 20:18:56 +03:00
|
|
|
static void pc_q35_1_7_machine_options(MachineClass *m)
|
2015-05-15 20:18:54 +03:00
|
|
|
{
|
2015-12-02 01:58:03 +03:00
|
|
|
PCMachineClass *pcmc = PC_MACHINE_CLASS(m);
|
2015-05-15 20:18:54 +03:00
|
|
|
pc_q35_2_0_machine_options(m);
|
2015-10-30 22:36:07 +03:00
|
|
|
m->hw_version = "1.7.0";
|
2015-05-15 20:18:54 +03:00
|
|
|
m->default_machine_opts = NULL;
|
2015-12-02 01:58:08 +03:00
|
|
|
m->option_rom_has_mr = true;
|
2015-05-15 20:18:55 +03:00
|
|
|
SET_MACHINE_COMPAT(m, PC_COMPAT_1_7);
|
2015-12-02 01:58:03 +03:00
|
|
|
pcmc->smbios_defaults = false;
|
|
|
|
pcmc->gigabyte_align = false;
|
2015-05-15 20:18:54 +03:00
|
|
|
}
|
e1000: add interrupt mitigation support
This patch partially implements the e1000 interrupt mitigation mechanisms.
Using a single QEMUTimer, it emulates the ITR register (which is the newer
mitigation register, recommended by Intel) and approximately emulates
RADV and TADV registers. TIDV and RDTR register functionalities are not
emulated (RDTR is only used to validate RADV, according to the e1000 specs).
RADV, TADV, TIDV and RDTR registers make up the older e1000 mitigation
mechanism and would need a timer each to be completely emulated. However,
a single timer has been used in order to reach a good compromise between
emulation accuracy and simplicity/efficiency.
The implemented mechanism can be enabled/disabled specifying the command
line e1000-specific boolean parameter "mitigation", e.g.
qemu-system-x86_64 -device e1000,mitigation=on,... ...
For more information, see the Software developer's manual at
http://download.intel.com/design/network/manuals/8254x_GBe_SDM.pdf.
Interrupt mitigation boosts performance when the guest suffers from
an high interrupt rate (i.e. receiving short UDP packets at high packet
rate). For some numerical results see the following link
http://info.iet.unipi.it/~luigi/papers/20130520-rizzo-vm.pdf
Signed-off-by: Vincenzo Maffione <v.maffione@gmail.com>
Reviewed-by: Andreas Färber <afaerber@suse.de> (for pc-* machines)
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
2013-08-02 20:30:52 +04:00
|
|
|
|
2015-05-15 20:19:01 +03:00
|
|
|
DEFINE_Q35_MACHINE(v1_7, "pc-q35-1.7", pc_compat_1_7,
|
|
|
|
pc_q35_1_7_machine_options);
|
2015-05-15 20:18:53 +03:00
|
|
|
|
e1000: add interrupt mitigation support
This patch partially implements the e1000 interrupt mitigation mechanisms.
Using a single QEMUTimer, it emulates the ITR register (which is the newer
mitigation register, recommended by Intel) and approximately emulates
RADV and TADV registers. TIDV and RDTR register functionalities are not
emulated (RDTR is only used to validate RADV, according to the e1000 specs).
RADV, TADV, TIDV and RDTR registers make up the older e1000 mitigation
mechanism and would need a timer each to be completely emulated. However,
a single timer has been used in order to reach a good compromise between
emulation accuracy and simplicity/efficiency.
The implemented mechanism can be enabled/disabled specifying the command
line e1000-specific boolean parameter "mitigation", e.g.
qemu-system-x86_64 -device e1000,mitigation=on,... ...
For more information, see the Software developer's manual at
http://download.intel.com/design/network/manuals/8254x_GBe_SDM.pdf.
Interrupt mitigation boosts performance when the guest suffers from
an high interrupt rate (i.e. receiving short UDP packets at high packet
rate). For some numerical results see the following link
http://info.iet.unipi.it/~luigi/papers/20130520-rizzo-vm.pdf
Signed-off-by: Vincenzo Maffione <v.maffione@gmail.com>
Reviewed-by: Andreas Färber <afaerber@suse.de> (for pc-* machines)
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
2013-08-02 20:30:52 +04:00
|
|
|
|
2015-05-15 20:18:56 +03:00
|
|
|
static void pc_q35_1_6_machine_options(MachineClass *m)
|
2015-05-15 20:18:54 +03:00
|
|
|
{
|
2015-12-02 01:58:03 +03:00
|
|
|
PCMachineClass *pcmc = PC_MACHINE_CLASS(m);
|
2015-05-15 20:18:54 +03:00
|
|
|
pc_q35_machine_options(m);
|
2015-10-30 22:36:07 +03:00
|
|
|
m->hw_version = "1.6.0";
|
2015-12-02 01:58:08 +03:00
|
|
|
m->rom_file_has_mr = false;
|
2015-05-15 20:18:55 +03:00
|
|
|
SET_MACHINE_COMPAT(m, PC_COMPAT_1_6);
|
2015-12-02 01:58:03 +03:00
|
|
|
pcmc->has_acpi_build = false;
|
2015-05-15 20:18:54 +03:00
|
|
|
}
|
2013-08-27 10:48:06 +04:00
|
|
|
|
2015-05-15 20:19:01 +03:00
|
|
|
DEFINE_Q35_MACHINE(v1_6, "pc-q35-1.6", pc_compat_1_6,
|
|
|
|
pc_q35_1_6_machine_options);
|
2015-05-15 20:18:53 +03:00
|
|
|
|
2013-05-28 00:23:53 +04:00
|
|
|
|
2015-05-15 20:18:56 +03:00
|
|
|
static void pc_q35_1_5_machine_options(MachineClass *m)
|
2015-05-15 20:18:54 +03:00
|
|
|
{
|
|
|
|
pc_q35_1_6_machine_options(m);
|
2015-10-30 22:36:07 +03:00
|
|
|
m->hw_version = "1.5.0";
|
2015-05-15 20:18:55 +03:00
|
|
|
SET_MACHINE_COMPAT(m, PC_COMPAT_1_5);
|
2015-05-15 20:18:54 +03:00
|
|
|
}
|
pc: Define MACHINE_OPTIONS macros consistently for all machines
Define a MACHINE_OPTIONS macro for each PC machine, and move every field
inside the QEMUMachine structs to the macros, except for name, init, and
compat_props.
This also ensures that all MACHINE_OPTIONS inherit the fields from the
next version, so their definitions carry only the changes that exist
between one version and the next one.
Comments about specific cases:
pc-*-2.1:
Existing PC_*_2_1_MACHINE_OPTIONS macros were defined as:
PC_*_MACHINE_OPTIONS,
.default_machine_opts = "firmware=bios-256k.bin"
PC_*_2_2_MACHINE_OPTIONS is:
PC_*_2_3_MACHINE_OPTIONS
which is expanded to:
PC_*_MACHINE_OPTIONS,
.default_machine_opts = "firmware=bios-256k.bin",
.default_display = "std"
The only difference between 2_1 and 2_2 is .default_display, that's why
we didn't reuse PC_*_2_2_MACHINE_OPTIONS. The good news is that having
multiple initializers for a field is allowed by C99, and the last
initializer overrides the previous ones.
So we can reuse the 2_2 macro in 2_1 and define PC_*_2_1_MACHINE_OPTIONS
as:
PC_*_2_2_MACHINE_OPTIONS,
.default_display = NULL
pc-*-1.7:
PC_*_1_7_MACHINE_OPTIONS was defined as:
PC_*_MACHINE_OPTIONS
PC_*_2_0_MACHINE_OPTIONS is defined as:
PC_*_2_1_MACHINE_OPTIONS
which is expanded to:
PC_*_2_2_MACHINE_OPTIONS,
.default_display = NULL
which is expanded to:
PC_*_2_3_MACHINE_OPTIONS,
.default_display = NULL
which is expanded to:
PC_*_MACHINE_OPTIONS,
.default_machine_opts = "firmware=bios-256k.bin",
.default_display = "std",
.default_display = NULL /* overrides the previous line */
So, the only difference between PC_*_1_7_MACHINE_OPTIONS and
PC_*_2_0_MACHINE_OPTIONS is .default_machine_opts (as .default_display
is not explicitly set by PC_*_MACHINE_OPTIONS so it is NULL).
So we can keep the macro reuse pattern and define
PC_*_2_0_MACHINE_OPTIONS as:
PC_*_2_0_MACHINE_OPTIONS,
.default_machine_opts = NULL
pc-*-2.4 (alias and is_default fields):
Set alias and is_default fields inside the 2.4 MACHINE_OPTIONS macro,
and clear it in the 2.3 macro (that reuses the 2.4 macro).
hw_machine:
As all the machines older than v1.0 set hw_version explicitly, we can
safely move the field to the MACHINE_OPTIONS macros without affecting
the other versions that reuse them.
init function:
Some machines had the init function set inside the MACHINE_OPTIONS
macro. Move it to the QEMUMachine declaration, to keep it consistent
with the other machines.
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
2015-05-15 20:18:52 +03:00
|
|
|
|
2015-05-15 20:19:01 +03:00
|
|
|
DEFINE_Q35_MACHINE(v1_5, "pc-q35-1.5", pc_compat_1_5,
|
|
|
|
pc_q35_1_5_machine_options);
|
2015-05-15 20:18:53 +03:00
|
|
|
|
2012-11-15 00:54:06 +04:00
|
|
|
|
2015-05-15 20:18:56 +03:00
|
|
|
static void pc_q35_1_4_machine_options(MachineClass *m)
|
2015-05-15 20:18:54 +03:00
|
|
|
{
|
|
|
|
pc_q35_1_5_machine_options(m);
|
2015-10-30 22:36:07 +03:00
|
|
|
m->hw_version = "1.4.0";
|
2015-05-15 20:18:54 +03:00
|
|
|
m->hot_add_cpu = NULL;
|
2015-05-15 20:18:55 +03:00
|
|
|
SET_MACHINE_COMPAT(m, PC_COMPAT_1_4);
|
2015-05-15 20:18:54 +03:00
|
|
|
}
|
2013-08-27 10:48:06 +04:00
|
|
|
|
2015-05-15 20:19:01 +03:00
|
|
|
DEFINE_Q35_MACHINE(v1_4, "pc-q35-1.4", pc_compat_1_4,
|
|
|
|
pc_q35_1_4_machine_options);
|