2009-05-15 01:35:06 +04:00
|
|
|
/*
|
|
|
|
* Dynamic device configuration and creation.
|
|
|
|
*
|
|
|
|
* Copyright (c) 2009 CodeSourcery
|
|
|
|
*
|
|
|
|
* This library is free software; you can redistribute it and/or
|
|
|
|
* modify it under the terms of the GNU Lesser General Public
|
|
|
|
* License as published by the Free Software Foundation; either
|
|
|
|
* version 2 of the License, or (at your option) any later version.
|
|
|
|
*
|
|
|
|
* This library is distributed in the hope that it will be useful,
|
|
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
|
|
* Lesser General Public License for more details.
|
|
|
|
*
|
|
|
|
* You should have received a copy of the GNU Lesser General Public
|
2009-07-17 00:47:01 +04:00
|
|
|
* License along with this library; if not, see <http://www.gnu.org/licenses/>.
|
2009-05-15 01:35:06 +04:00
|
|
|
*/
|
|
|
|
|
|
|
|
/* The theory here is that it should be possible to create a machine without
|
|
|
|
knowledge of specific devices. Historically board init routines have
|
|
|
|
passed a bunch of arguments to each device, requiring the board know
|
|
|
|
exactly which device it is dealing with. This file provides an abstract
|
|
|
|
API for device configuration and initialization. Devices will generally
|
|
|
|
inherit from a particular bus (e.g. PCI or I2C) rather than
|
|
|
|
this API directly. */
|
|
|
|
|
2013-02-04 18:40:22 +04:00
|
|
|
#include "hw/qdev.h"
|
2014-03-17 06:40:23 +04:00
|
|
|
#include "hw/fw-path-provider.h"
|
2012-12-17 21:20:04 +04:00
|
|
|
#include "sysemu/sysemu.h"
|
2012-12-17 21:19:43 +04:00
|
|
|
#include "qapi/error.h"
|
2013-02-04 14:37:52 +04:00
|
|
|
#include "qapi/qmp/qerror.h"
|
2012-12-17 21:19:43 +04:00
|
|
|
#include "qapi/visitor.h"
|
2013-03-06 16:58:59 +04:00
|
|
|
#include "qapi/qmp/qjson.h"
|
2014-02-05 19:36:45 +04:00
|
|
|
#include "hw/hotplug.h"
|
2014-06-02 17:25:03 +04:00
|
|
|
#include "hw/boards.h"
|
2014-06-18 10:43:43 +04:00
|
|
|
#include "qapi-event.h"
|
2009-05-15 01:35:06 +04:00
|
|
|
|
2011-12-23 01:24:20 +04:00
|
|
|
int qdev_hotplug = 0;
|
2011-01-04 22:37:50 +03:00
|
|
|
static bool qdev_hot_added = false;
|
|
|
|
static bool qdev_hot_removed = false;
|
2009-09-25 23:42:41 +04:00
|
|
|
|
2011-12-09 20:51:49 +04:00
|
|
|
const VMStateDescription *qdev_get_vmsd(DeviceState *dev)
|
|
|
|
{
|
2011-12-09 21:06:57 +04:00
|
|
|
DeviceClass *dc = DEVICE_GET_CLASS(dev);
|
|
|
|
return dc->vmsd;
|
2011-12-09 20:51:49 +04:00
|
|
|
}
|
|
|
|
|
|
|
|
const char *qdev_fw_name(DeviceState *dev)
|
|
|
|
{
|
2011-12-09 21:06:57 +04:00
|
|
|
DeviceClass *dc = DEVICE_GET_CLASS(dev);
|
2011-12-09 20:51:49 +04:00
|
|
|
|
2011-12-09 21:06:57 +04:00
|
|
|
if (dc->fw_name) {
|
|
|
|
return dc->fw_name;
|
2011-12-09 20:51:49 +04:00
|
|
|
}
|
|
|
|
|
|
|
|
return object_get_typename(OBJECT(dev));
|
|
|
|
}
|
|
|
|
|
2011-12-18 20:05:11 +04:00
|
|
|
static void qdev_property_add_legacy(DeviceState *dev, Property *prop,
|
|
|
|
Error **errp);
|
|
|
|
|
2011-12-24 01:34:39 +04:00
|
|
|
static void bus_remove_child(BusState *bus, DeviceState *child)
|
2010-02-19 21:12:18 +03:00
|
|
|
{
|
2011-12-24 01:34:39 +04:00
|
|
|
BusChild *kid;
|
|
|
|
|
|
|
|
QTAILQ_FOREACH(kid, &bus->children, sibling) {
|
|
|
|
if (kid->child == child) {
|
|
|
|
char name[32];
|
|
|
|
|
|
|
|
snprintf(name, sizeof(name), "child[%d]", kid->index);
|
|
|
|
QTAILQ_REMOVE(&bus->children, kid, sibling);
|
2013-01-25 17:12:32 +04:00
|
|
|
|
|
|
|
/* This gives back ownership of kid->child back to us. */
|
2011-12-24 01:34:39 +04:00
|
|
|
object_property_del(OBJECT(bus), name, NULL);
|
2013-01-25 17:12:32 +04:00
|
|
|
object_unref(OBJECT(kid->child));
|
2011-12-24 01:34:39 +04:00
|
|
|
g_free(kid);
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
static void bus_add_child(BusState *bus, DeviceState *child)
|
|
|
|
{
|
|
|
|
char name[32];
|
|
|
|
BusChild *kid = g_malloc0(sizeof(*kid));
|
2010-02-19 21:12:18 +03:00
|
|
|
|
|
|
|
if (qdev_hotplug) {
|
|
|
|
assert(bus->allow_hotplug);
|
|
|
|
}
|
2011-12-13 00:29:27 +04:00
|
|
|
|
2011-12-24 01:34:39 +04:00
|
|
|
kid->index = bus->max_index++;
|
|
|
|
kid->child = child;
|
2013-01-25 17:12:32 +04:00
|
|
|
object_ref(OBJECT(kid->child));
|
2011-12-13 00:29:27 +04:00
|
|
|
|
2011-12-24 01:34:39 +04:00
|
|
|
QTAILQ_INSERT_HEAD(&bus->children, kid, sibling);
|
|
|
|
|
2013-01-25 17:12:32 +04:00
|
|
|
/* This transfers ownership of kid->child to the property. */
|
2011-12-24 01:34:39 +04:00
|
|
|
snprintf(name, sizeof(name), "child[%d]", kid->index);
|
|
|
|
object_property_add_link(OBJECT(bus), name,
|
|
|
|
object_get_typename(OBJECT(child)),
|
2014-03-19 11:58:56 +04:00
|
|
|
(Object **)&kid->child,
|
|
|
|
NULL, /* read-only property */
|
|
|
|
0, /* return ownership on prop deletion */
|
|
|
|
NULL);
|
2011-12-24 01:34:39 +04:00
|
|
|
}
|
|
|
|
|
|
|
|
void qdev_set_parent_bus(DeviceState *dev, BusState *bus)
|
|
|
|
{
|
2011-12-23 01:14:27 +04:00
|
|
|
dev->parent_bus = bus;
|
2013-01-25 17:12:35 +04:00
|
|
|
object_ref(OBJECT(bus));
|
2011-12-24 01:34:39 +04:00
|
|
|
bus_add_child(bus, dev);
|
2010-02-19 21:12:18 +03:00
|
|
|
}
|
|
|
|
|
2009-05-15 01:35:06 +04:00
|
|
|
/* Create a new device. This only initializes the device state structure
|
|
|
|
and allows properties to be set. qdev_init should be called to
|
|
|
|
initialize the actual device emulation. */
|
2009-05-23 03:05:19 +04:00
|
|
|
DeviceState *qdev_create(BusState *bus, const char *name)
|
2011-02-05 17:34:25 +03:00
|
|
|
{
|
|
|
|
DeviceState *dev;
|
|
|
|
|
|
|
|
dev = qdev_try_create(bus, name);
|
|
|
|
if (!dev) {
|
2011-08-04 02:49:04 +04:00
|
|
|
if (bus) {
|
error: Strip trailing '\n' from error string arguments (again)
Commit 6daf194d and be62a2eb got rid of a bunch, but they keep coming
back. Tracked down with this Coccinelle semantic patch:
@r@
expression err, eno, cls, fmt;
position p;
@@
(
error_report(fmt, ...)@p
|
error_set(err, cls, fmt, ...)@p
|
error_set_errno(err, eno, cls, fmt, ...)@p
|
error_setg(err, fmt, ...)@p
|
error_setg_errno(err, eno, fmt, ...)@p
)
@script:python@
fmt << r.fmt;
p << r.p;
@@
if "\\n" in str(fmt):
print "%s:%s:%s:%s" % (p[0].file, p[0].line, p[0].column, fmt)
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-id: 1360354939-10994-4-git-send-email-armbru@redhat.com
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
2013-02-09 00:22:16 +04:00
|
|
|
error_report("Unknown device '%s' for bus '%s'", name,
|
2012-12-04 17:19:34 +04:00
|
|
|
object_get_typename(OBJECT(bus)));
|
2011-08-04 02:49:04 +04:00
|
|
|
} else {
|
error: Strip trailing '\n' from error string arguments (again)
Commit 6daf194d and be62a2eb got rid of a bunch, but they keep coming
back. Tracked down with this Coccinelle semantic patch:
@r@
expression err, eno, cls, fmt;
position p;
@@
(
error_report(fmt, ...)@p
|
error_set(err, cls, fmt, ...)@p
|
error_set_errno(err, eno, cls, fmt, ...)@p
|
error_setg(err, fmt, ...)@p
|
error_setg_errno(err, eno, fmt, ...)@p
)
@script:python@
fmt << r.fmt;
p << r.p;
@@
if "\\n" in str(fmt):
print "%s:%s:%s:%s" % (p[0].file, p[0].line, p[0].column, fmt)
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-id: 1360354939-10994-4-git-send-email-armbru@redhat.com
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
2013-02-09 00:22:16 +04:00
|
|
|
error_report("Unknown device '%s' for default sysbus", name);
|
2011-08-04 02:49:04 +04:00
|
|
|
}
|
2013-03-22 12:44:14 +04:00
|
|
|
abort();
|
2011-02-05 17:34:25 +03:00
|
|
|
}
|
|
|
|
|
|
|
|
return dev;
|
|
|
|
}
|
|
|
|
|
2012-03-27 20:38:47 +04:00
|
|
|
DeviceState *qdev_try_create(BusState *bus, const char *type)
|
2009-05-15 01:35:06 +04:00
|
|
|
{
|
2011-12-23 01:14:27 +04:00
|
|
|
DeviceState *dev;
|
|
|
|
|
2012-03-27 20:38:47 +04:00
|
|
|
if (object_class_by_name(type) == NULL) {
|
2012-02-17 05:47:44 +04:00
|
|
|
return NULL;
|
|
|
|
}
|
2012-03-27 20:38:47 +04:00
|
|
|
dev = DEVICE(object_new(type));
|
2011-12-23 01:14:27 +04:00
|
|
|
if (!dev) {
|
|
|
|
return NULL;
|
|
|
|
}
|
|
|
|
|
2009-06-30 16:12:08 +04:00
|
|
|
if (!bus) {
|
2010-12-16 21:33:22 +03:00
|
|
|
bus = sysbus_get_default();
|
2009-06-30 16:12:08 +04:00
|
|
|
}
|
|
|
|
|
2011-12-23 01:14:27 +04:00
|
|
|
qdev_set_parent_bus(dev, bus);
|
2013-01-25 17:12:37 +04:00
|
|
|
object_unref(OBJECT(dev));
|
2011-12-23 01:14:27 +04:00
|
|
|
return dev;
|
2009-05-15 01:35:06 +04:00
|
|
|
}
|
|
|
|
|
|
|
|
/* Initialize a device. Device properties should be set before calling
|
|
|
|
this function. IRQs and MMIO regions should be connected/mapped after
|
2009-10-07 03:15:56 +04:00
|
|
|
calling this function.
|
|
|
|
On failure, destroy the device and return negative value.
|
|
|
|
Return 0 on success. */
|
2009-08-14 12:36:05 +04:00
|
|
|
int qdev_init(DeviceState *dev)
|
2009-05-15 01:35:06 +04:00
|
|
|
{
|
2013-01-09 06:58:11 +04:00
|
|
|
Error *local_err = NULL;
|
2009-09-01 11:56:12 +04:00
|
|
|
|
2013-01-09 06:58:10 +04:00
|
|
|
assert(!dev->realized);
|
2011-12-09 21:06:57 +04:00
|
|
|
|
2013-01-09 06:58:11 +04:00
|
|
|
object_property_set_bool(OBJECT(dev), true, "realized", &local_err);
|
|
|
|
if (local_err != NULL) {
|
2013-04-29 16:35:08 +04:00
|
|
|
qerror_report_err(local_err);
|
2013-01-09 06:58:11 +04:00
|
|
|
error_free(local_err);
|
2013-09-11 16:54:09 +04:00
|
|
|
object_unparent(OBJECT(dev));
|
2013-01-09 06:58:11 +04:00
|
|
|
return -1;
|
2009-10-07 03:15:56 +04:00
|
|
|
}
|
2013-01-09 06:58:11 +04:00
|
|
|
return 0;
|
|
|
|
}
|
2012-03-27 20:38:47 +04:00
|
|
|
|
2014-04-25 14:44:21 +04:00
|
|
|
static void device_realize(DeviceState *dev, Error **errp)
|
2013-01-09 06:58:11 +04:00
|
|
|
{
|
|
|
|
DeviceClass *dc = DEVICE_GET_CLASS(dev);
|
2012-03-27 20:38:47 +04:00
|
|
|
|
2013-01-09 06:58:11 +04:00
|
|
|
if (dc->init) {
|
|
|
|
int rc = dc->init(dev);
|
|
|
|
if (rc < 0) {
|
2014-04-25 14:44:21 +04:00
|
|
|
error_setg(errp, "Device initialization failed.");
|
2013-01-09 06:58:11 +04:00
|
|
|
return;
|
|
|
|
}
|
2011-07-24 21:38:36 +04:00
|
|
|
}
|
2009-05-23 03:05:19 +04:00
|
|
|
}
|
|
|
|
|
2013-04-15 20:34:10 +04:00
|
|
|
static void device_unrealize(DeviceState *dev, Error **errp)
|
|
|
|
{
|
|
|
|
DeviceClass *dc = DEVICE_GET_CLASS(dev);
|
|
|
|
|
|
|
|
if (dc->exit) {
|
|
|
|
int rc = dc->exit(dev);
|
|
|
|
if (rc < 0) {
|
|
|
|
error_setg(errp, "Device exit failed.");
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2010-05-15 15:32:40 +04:00
|
|
|
void qdev_set_legacy_instance_id(DeviceState *dev, int alias_id,
|
|
|
|
int required_for_version)
|
|
|
|
{
|
2013-01-09 06:58:10 +04:00
|
|
|
assert(!dev->realized);
|
2010-05-15 15:32:40 +04:00
|
|
|
dev->instance_id_alias = alias_id;
|
|
|
|
dev->alias_required_for_version = required_for_version;
|
|
|
|
}
|
|
|
|
|
2012-03-15 00:37:38 +04:00
|
|
|
void qdev_unplug(DeviceState *dev, Error **errp)
|
2009-09-25 23:42:41 +04:00
|
|
|
{
|
2011-12-09 21:06:57 +04:00
|
|
|
DeviceClass *dc = DEVICE_GET_CLASS(dev);
|
|
|
|
|
2013-05-03 17:25:36 +04:00
|
|
|
if (dev->parent_bus && !dev->parent_bus->allow_hotplug) {
|
2012-03-15 00:37:38 +04:00
|
|
|
error_set(errp, QERR_BUS_NO_HOTPLUG, dev->parent_bus->name);
|
|
|
|
return;
|
2009-09-25 23:42:41 +04:00
|
|
|
}
|
2009-11-02 12:26:41 +03:00
|
|
|
|
2014-02-05 19:36:46 +04:00
|
|
|
if (!dc->hotpluggable) {
|
|
|
|
error_set(errp, QERR_DEVICE_NO_HOTPLUG,
|
|
|
|
object_get_typename(OBJECT(dev)));
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
2011-01-04 22:37:50 +03:00
|
|
|
qdev_hot_removed = true;
|
|
|
|
|
2014-02-05 19:36:52 +04:00
|
|
|
if (dev->parent_bus && dev->parent_bus->hotplug_handler) {
|
|
|
|
hotplug_handler_unplug(dev->parent_bus->hotplug_handler, dev, errp);
|
|
|
|
} else {
|
|
|
|
assert(dc->unplug != NULL);
|
|
|
|
if (dc->unplug(dev) < 0) { /* legacy handler */
|
|
|
|
error_set(errp, QERR_UNDEFINED_ERROR);
|
|
|
|
}
|
2012-03-15 00:37:38 +04:00
|
|
|
}
|
2009-09-25 23:42:41 +04:00
|
|
|
}
|
|
|
|
|
2010-11-19 12:55:59 +03:00
|
|
|
static int qdev_reset_one(DeviceState *dev, void *opaque)
|
|
|
|
{
|
2011-12-04 21:36:01 +04:00
|
|
|
device_reset(dev);
|
2010-11-19 12:55:59 +03:00
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2010-11-19 12:56:00 +03:00
|
|
|
static int qbus_reset_one(BusState *bus, void *opaque)
|
|
|
|
{
|
2012-05-02 11:00:20 +04:00
|
|
|
BusClass *bc = BUS_GET_CLASS(bus);
|
|
|
|
if (bc->reset) {
|
2013-12-06 20:54:27 +04:00
|
|
|
bc->reset(bus);
|
2010-11-19 12:56:00 +03:00
|
|
|
}
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2010-11-19 12:56:01 +03:00
|
|
|
void qdev_reset_all(DeviceState *dev)
|
|
|
|
{
|
2013-12-06 20:54:27 +04:00
|
|
|
qdev_walk_children(dev, NULL, NULL, qdev_reset_one, qbus_reset_one, NULL);
|
2010-11-19 12:56:01 +03:00
|
|
|
}
|
|
|
|
|
2013-01-10 18:49:07 +04:00
|
|
|
void qbus_reset_all(BusState *bus)
|
|
|
|
{
|
2013-12-06 20:54:27 +04:00
|
|
|
qbus_walk_children(bus, NULL, NULL, qdev_reset_one, qbus_reset_one, NULL);
|
2013-01-10 18:49:07 +04:00
|
|
|
}
|
|
|
|
|
2010-12-20 08:33:35 +03:00
|
|
|
void qbus_reset_all_fn(void *opaque)
|
|
|
|
{
|
|
|
|
BusState *bus = opaque;
|
2013-01-10 18:49:07 +04:00
|
|
|
qbus_reset_all(bus);
|
2010-12-20 08:33:35 +03:00
|
|
|
}
|
|
|
|
|
2009-09-25 23:42:41 +04:00
|
|
|
/* can be used as ->unplug() callback for the simple cases */
|
|
|
|
int qdev_simple_unplug_cb(DeviceState *dev)
|
|
|
|
{
|
|
|
|
/* just zap it */
|
2013-09-11 16:54:09 +04:00
|
|
|
object_unparent(OBJECT(dev));
|
2009-09-25 23:42:41 +04:00
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2011-04-06 17:51:59 +04:00
|
|
|
|
|
|
|
/* Like qdev_init(), but terminate program via error_report() instead of
|
2009-10-07 03:15:58 +04:00
|
|
|
returning an error value. This is okay during machine creation.
|
|
|
|
Don't use for hotplug, because there callers need to recover from
|
|
|
|
failure. Exception: if you know the device's init() callback can't
|
|
|
|
fail, then qdev_init_nofail() can't fail either, and is therefore
|
|
|
|
usable even then. But relying on the device implementation that
|
|
|
|
way is somewhat unclean, and best avoided. */
|
|
|
|
void qdev_init_nofail(DeviceState *dev)
|
|
|
|
{
|
2012-06-27 16:37:54 +04:00
|
|
|
const char *typename = object_get_typename(OBJECT(dev));
|
|
|
|
|
2010-05-27 23:23:08 +04:00
|
|
|
if (qdev_init(dev) < 0) {
|
2012-06-27 16:37:54 +04:00
|
|
|
error_report("Initialization of device %s failed", typename);
|
2010-05-27 23:23:08 +04:00
|
|
|
exit(1);
|
|
|
|
}
|
2009-10-07 03:15:58 +04:00
|
|
|
}
|
|
|
|
|
2009-09-25 23:42:41 +04:00
|
|
|
void qdev_machine_creation_done(void)
|
|
|
|
{
|
|
|
|
/*
|
|
|
|
* ok, initial machine setup is done, starting from now we can
|
|
|
|
* only create hotpluggable devices
|
|
|
|
*/
|
|
|
|
qdev_hotplug = 1;
|
|
|
|
}
|
|
|
|
|
2011-01-04 22:37:50 +03:00
|
|
|
bool qdev_machine_modified(void)
|
|
|
|
{
|
|
|
|
return qdev_hot_added || qdev_hot_removed;
|
|
|
|
}
|
|
|
|
|
2009-05-23 03:05:19 +04:00
|
|
|
BusState *qdev_get_parent_bus(DeviceState *dev)
|
2009-05-15 01:35:06 +04:00
|
|
|
{
|
2009-05-23 03:05:19 +04:00
|
|
|
return dev->parent_bus;
|
2009-05-15 01:35:06 +04:00
|
|
|
}
|
|
|
|
|
2014-05-20 10:30:58 +04:00
|
|
|
static NamedGPIOList *qdev_get_named_gpio_list(DeviceState *dev,
|
|
|
|
const char *name)
|
|
|
|
{
|
|
|
|
NamedGPIOList *ngl;
|
|
|
|
|
|
|
|
QLIST_FOREACH(ngl, &dev->gpios, node) {
|
|
|
|
/* NULL is a valid and matchable name, otherwise do a normal
|
|
|
|
* strcmp match.
|
|
|
|
*/
|
|
|
|
if ((!ngl->name && !name) ||
|
|
|
|
(name && ngl->name && strcmp(name, ngl->name) == 0)) {
|
|
|
|
return ngl;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
ngl = g_malloc0(sizeof(*ngl));
|
|
|
|
ngl->name = g_strdup(name);
|
|
|
|
QLIST_INSERT_HEAD(&dev->gpios, ngl, node);
|
|
|
|
return ngl;
|
|
|
|
}
|
|
|
|
|
|
|
|
void qdev_init_gpio_in_named(DeviceState *dev, qemu_irq_handler handler,
|
|
|
|
const char *name, int n)
|
|
|
|
{
|
|
|
|
NamedGPIOList *gpio_list = qdev_get_named_gpio_list(dev, name);
|
|
|
|
|
|
|
|
gpio_list->in = qemu_extend_irqs(gpio_list->in, gpio_list->num_in, handler,
|
|
|
|
dev, n);
|
|
|
|
gpio_list->num_in += n;
|
|
|
|
}
|
|
|
|
|
2009-05-15 01:35:06 +04:00
|
|
|
void qdev_init_gpio_in(DeviceState *dev, qemu_irq_handler handler, int n)
|
|
|
|
{
|
2014-05-20 10:30:58 +04:00
|
|
|
qdev_init_gpio_in_named(dev, handler, NULL, n);
|
|
|
|
}
|
|
|
|
|
|
|
|
void qdev_init_gpio_out_named(DeviceState *dev, qemu_irq *pins,
|
|
|
|
const char *name, int n)
|
|
|
|
{
|
|
|
|
NamedGPIOList *gpio_list = qdev_get_named_gpio_list(dev, name);
|
|
|
|
|
|
|
|
assert(gpio_list->num_out == 0);
|
|
|
|
gpio_list->num_out = n;
|
|
|
|
gpio_list->out = pins;
|
2009-05-15 01:35:06 +04:00
|
|
|
}
|
|
|
|
|
|
|
|
void qdev_init_gpio_out(DeviceState *dev, qemu_irq *pins, int n)
|
|
|
|
{
|
2014-05-20 10:30:58 +04:00
|
|
|
qdev_init_gpio_out_named(dev, pins, NULL, n);
|
|
|
|
}
|
|
|
|
|
|
|
|
qemu_irq qdev_get_gpio_in_named(DeviceState *dev, const char *name, int n)
|
|
|
|
{
|
|
|
|
NamedGPIOList *gpio_list = qdev_get_named_gpio_list(dev, name);
|
|
|
|
|
|
|
|
assert(n >= 0 && n < gpio_list->num_in);
|
|
|
|
return gpio_list->in[n];
|
2009-05-15 01:35:06 +04:00
|
|
|
}
|
|
|
|
|
|
|
|
qemu_irq qdev_get_gpio_in(DeviceState *dev, int n)
|
|
|
|
{
|
2014-05-20 10:30:58 +04:00
|
|
|
return qdev_get_gpio_in_named(dev, NULL, n);
|
|
|
|
}
|
|
|
|
|
|
|
|
void qdev_connect_gpio_out_named(DeviceState *dev, const char *name, int n,
|
|
|
|
qemu_irq pin)
|
|
|
|
{
|
|
|
|
NamedGPIOList *gpio_list = qdev_get_named_gpio_list(dev, name);
|
|
|
|
|
|
|
|
assert(n >= 0 && n < gpio_list->num_out);
|
|
|
|
gpio_list->out[n] = pin;
|
2009-05-15 01:35:06 +04:00
|
|
|
}
|
|
|
|
|
|
|
|
void qdev_connect_gpio_out(DeviceState * dev, int n, qemu_irq pin)
|
|
|
|
{
|
2014-05-20 10:30:58 +04:00
|
|
|
qdev_connect_gpio_out_named(dev, NULL, n, pin);
|
2009-05-15 01:35:06 +04:00
|
|
|
}
|
|
|
|
|
2009-05-23 03:05:19 +04:00
|
|
|
BusState *qdev_get_child_bus(DeviceState *dev, const char *name)
|
2009-05-15 01:35:06 +04:00
|
|
|
{
|
2009-05-23 03:05:19 +04:00
|
|
|
BusState *bus;
|
2009-05-15 01:35:06 +04:00
|
|
|
|
2009-09-12 11:36:22 +04:00
|
|
|
QLIST_FOREACH(bus, &dev->child_bus, sibling) {
|
2009-05-15 01:35:06 +04:00
|
|
|
if (strcmp(name, bus->name) == 0) {
|
2009-05-23 03:05:19 +04:00
|
|
|
return bus;
|
2009-05-15 01:35:06 +04:00
|
|
|
}
|
|
|
|
}
|
|
|
|
return NULL;
|
|
|
|
}
|
|
|
|
|
2013-12-06 20:54:26 +04:00
|
|
|
int qbus_walk_children(BusState *bus,
|
|
|
|
qdev_walkerfn *pre_devfn, qbus_walkerfn *pre_busfn,
|
|
|
|
qdev_walkerfn *post_devfn, qbus_walkerfn *post_busfn,
|
|
|
|
void *opaque)
|
2010-11-19 12:55:58 +03:00
|
|
|
{
|
2011-12-24 01:34:39 +04:00
|
|
|
BusChild *kid;
|
2010-11-19 12:55:58 +03:00
|
|
|
int err;
|
|
|
|
|
2013-12-06 20:54:26 +04:00
|
|
|
if (pre_busfn) {
|
|
|
|
err = pre_busfn(bus, opaque);
|
2010-11-19 12:55:58 +03:00
|
|
|
if (err) {
|
|
|
|
return err;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2011-12-24 01:34:39 +04:00
|
|
|
QTAILQ_FOREACH(kid, &bus->children, sibling) {
|
2013-12-06 20:54:26 +04:00
|
|
|
err = qdev_walk_children(kid->child,
|
|
|
|
pre_devfn, pre_busfn,
|
|
|
|
post_devfn, post_busfn, opaque);
|
2010-11-19 12:55:58 +03:00
|
|
|
if (err < 0) {
|
|
|
|
return err;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2013-12-06 20:54:26 +04:00
|
|
|
if (post_busfn) {
|
|
|
|
err = post_busfn(bus, opaque);
|
|
|
|
if (err) {
|
|
|
|
return err;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2010-11-19 12:55:58 +03:00
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2013-12-06 20:54:26 +04:00
|
|
|
int qdev_walk_children(DeviceState *dev,
|
|
|
|
qdev_walkerfn *pre_devfn, qbus_walkerfn *pre_busfn,
|
|
|
|
qdev_walkerfn *post_devfn, qbus_walkerfn *post_busfn,
|
|
|
|
void *opaque)
|
2010-11-19 12:55:58 +03:00
|
|
|
{
|
|
|
|
BusState *bus;
|
|
|
|
int err;
|
|
|
|
|
2013-12-06 20:54:26 +04:00
|
|
|
if (pre_devfn) {
|
|
|
|
err = pre_devfn(dev, opaque);
|
2010-11-19 12:55:58 +03:00
|
|
|
if (err) {
|
|
|
|
return err;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
QLIST_FOREACH(bus, &dev->child_bus, sibling) {
|
2013-12-06 20:54:26 +04:00
|
|
|
err = qbus_walk_children(bus, pre_devfn, pre_busfn,
|
|
|
|
post_devfn, post_busfn, opaque);
|
2010-11-19 12:55:58 +03:00
|
|
|
if (err < 0) {
|
|
|
|
return err;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2013-12-06 20:54:26 +04:00
|
|
|
if (post_devfn) {
|
|
|
|
err = post_devfn(dev, opaque);
|
|
|
|
if (err) {
|
|
|
|
return err;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2010-11-19 12:55:58 +03:00
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2010-12-24 06:14:12 +03:00
|
|
|
DeviceState *qdev_find_recursive(BusState *bus, const char *id)
|
2009-09-25 23:42:41 +04:00
|
|
|
{
|
2011-12-24 01:34:39 +04:00
|
|
|
BusChild *kid;
|
|
|
|
DeviceState *ret;
|
2009-09-25 23:42:41 +04:00
|
|
|
BusState *child;
|
|
|
|
|
2011-12-24 01:34:39 +04:00
|
|
|
QTAILQ_FOREACH(kid, &bus->children, sibling) {
|
|
|
|
DeviceState *dev = kid->child;
|
|
|
|
|
|
|
|
if (dev->id && strcmp(dev->id, id) == 0) {
|
2009-09-25 23:42:41 +04:00
|
|
|
return dev;
|
2011-12-24 01:34:39 +04:00
|
|
|
}
|
|
|
|
|
2009-09-25 23:42:41 +04:00
|
|
|
QLIST_FOREACH(child, &dev->child_bus, sibling) {
|
|
|
|
ret = qdev_find_recursive(child, id);
|
|
|
|
if (ret) {
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
return NULL;
|
|
|
|
}
|
|
|
|
|
2013-01-25 17:12:27 +04:00
|
|
|
static void qbus_realize(BusState *bus, DeviceState *parent, const char *name)
|
2009-05-23 03:05:19 +04:00
|
|
|
{
|
2012-02-03 23:32:19 +04:00
|
|
|
const char *typename = object_get_typename(OBJECT(bus));
|
qdev: Keep global allocation counter per bus
When we have 2 separate qdev devices that both create a qbus of the
same type without specifying a bus name or device name, we end up
with two buses of the same name, such as ide.0 on the Mac machines:
dev: macio-ide, id ""
bus: ide.0
type IDE
dev: macio-ide, id ""
bus: ide.0
type IDE
If we now spawn a device that connects to a ide.0 the last created
bus gets the device, with the first created bus inaccessible to the
command line.
After some discussion on IRC we concluded that the best quick fix way
forward for this is to make automated bus-class type based allocation
count a global counter. That's what this patch implements. With this
we instead get
dev: macio-ide, id ""
bus: ide.1
type IDE
dev: macio-ide, id ""
bus: ide.0
type IDE
on the example mentioned above.
This also means that if you did -device ...,bus=ide.0 you got a device
on the first bus (the last created one) before this patch and get that
device on the second one (the first created one) now. Breaks
migration unless you change bus=ide.0 to bus=ide.1 on the destination.
This is intended and makes the bus enumeration work as expected.
As per review request follows a list of otherwise affected boards and
the reasoning for the conclusion that they are ok:
target machine bus id times
------ ------- ------ -----
aarch64 n800 i2c-bus.0 2
aarch64 n810 i2c-bus.0 2
arm n800 i2c-bus.0 2
arm n810 i2c-bus.0 2
-> Devices are only created explicitly on one of the two buses, using
s->mpu->i2c[0], so no change to the guest.
aarch64 vexpress-a15 virtio-mmio-bus.0 4
aarch64 vexpress-a9 virtio-mmio-bus.0 4
aarch64 virt virtio-mmio-bus.0 32
arm vexpress-a15 virtio-mmio-bus.0 4
arm vexpress-a9 virtio-mmio-bus.0 4
arm virt virtio-mmio-bus.0 32
-> Makes -device bus= work for all virtio-mmio buses. Breaks
migration. Workaround for migration from old to new: specify
virtio-mmio-bus.4 or .32 respectively rather than .0 on the
destination.
aarch64 xilinx-zynq-a9 usb-bus.0 2
arm xilinx-zynq-a9 usb-bus.0 2
mips64el fulong2e usb-bus.0 2
-> Normal USB operation not affected. Migration driver needs command
line to use the other bus.
i386 isapc ide.0 2
x86_64 isapc ide.0 2
mips mips ide.0 2
mips64 mips ide.0 2
mips64el mips ide.0 2
mipsel mips ide.0 2
ppc g3beige ide.0 2
ppc mac99 ide.0 2
ppc prep ide.0 2
ppc64 g3beige ide.0 2
ppc64 mac99 ide.0 2
ppc64 prep ide.0 2
-> Makes -device bus= work for all IDE buses. Breaks migration.
Workaround for migration from old to new: specify ide.1 rather than
ide.0 on the destination.
Signed-off-by: Alexander Graf <agraf@suse.de>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Andreas Faerber <afaerber@suse.de>
Signed-off-by: Alexander Graf <agraf@suse.de>
2014-02-06 19:08:15 +04:00
|
|
|
BusClass *bc;
|
2009-07-15 15:59:24 +04:00
|
|
|
char *buf;
|
qdev: Keep global allocation counter per bus
When we have 2 separate qdev devices that both create a qbus of the
same type without specifying a bus name or device name, we end up
with two buses of the same name, such as ide.0 on the Mac machines:
dev: macio-ide, id ""
bus: ide.0
type IDE
dev: macio-ide, id ""
bus: ide.0
type IDE
If we now spawn a device that connects to a ide.0 the last created
bus gets the device, with the first created bus inaccessible to the
command line.
After some discussion on IRC we concluded that the best quick fix way
forward for this is to make automated bus-class type based allocation
count a global counter. That's what this patch implements. With this
we instead get
dev: macio-ide, id ""
bus: ide.1
type IDE
dev: macio-ide, id ""
bus: ide.0
type IDE
on the example mentioned above.
This also means that if you did -device ...,bus=ide.0 you got a device
on the first bus (the last created one) before this patch and get that
device on the second one (the first created one) now. Breaks
migration unless you change bus=ide.0 to bus=ide.1 on the destination.
This is intended and makes the bus enumeration work as expected.
As per review request follows a list of otherwise affected boards and
the reasoning for the conclusion that they are ok:
target machine bus id times
------ ------- ------ -----
aarch64 n800 i2c-bus.0 2
aarch64 n810 i2c-bus.0 2
arm n800 i2c-bus.0 2
arm n810 i2c-bus.0 2
-> Devices are only created explicitly on one of the two buses, using
s->mpu->i2c[0], so no change to the guest.
aarch64 vexpress-a15 virtio-mmio-bus.0 4
aarch64 vexpress-a9 virtio-mmio-bus.0 4
aarch64 virt virtio-mmio-bus.0 32
arm vexpress-a15 virtio-mmio-bus.0 4
arm vexpress-a9 virtio-mmio-bus.0 4
arm virt virtio-mmio-bus.0 32
-> Makes -device bus= work for all virtio-mmio buses. Breaks
migration. Workaround for migration from old to new: specify
virtio-mmio-bus.4 or .32 respectively rather than .0 on the
destination.
aarch64 xilinx-zynq-a9 usb-bus.0 2
arm xilinx-zynq-a9 usb-bus.0 2
mips64el fulong2e usb-bus.0 2
-> Normal USB operation not affected. Migration driver needs command
line to use the other bus.
i386 isapc ide.0 2
x86_64 isapc ide.0 2
mips mips ide.0 2
mips64 mips ide.0 2
mips64el mips ide.0 2
mipsel mips ide.0 2
ppc g3beige ide.0 2
ppc mac99 ide.0 2
ppc prep ide.0 2
ppc64 g3beige ide.0 2
ppc64 mac99 ide.0 2
ppc64 prep ide.0 2
-> Makes -device bus= work for all IDE buses. Breaks migration.
Workaround for migration from old to new: specify ide.1 rather than
ide.0 on the destination.
Signed-off-by: Alexander Graf <agraf@suse.de>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Andreas Faerber <afaerber@suse.de>
Signed-off-by: Alexander Graf <agraf@suse.de>
2014-02-06 19:08:15 +04:00
|
|
|
int i, len, bus_id;
|
2009-05-23 03:05:19 +04:00
|
|
|
|
2013-01-25 17:12:27 +04:00
|
|
|
bus->parent = parent;
|
|
|
|
|
|
|
|
if (name) {
|
|
|
|
bus->name = g_strdup(name);
|
2012-02-03 23:32:19 +04:00
|
|
|
} else if (bus->parent && bus->parent->id) {
|
qdev: Keep global allocation counter per bus
When we have 2 separate qdev devices that both create a qbus of the
same type without specifying a bus name or device name, we end up
with two buses of the same name, such as ide.0 on the Mac machines:
dev: macio-ide, id ""
bus: ide.0
type IDE
dev: macio-ide, id ""
bus: ide.0
type IDE
If we now spawn a device that connects to a ide.0 the last created
bus gets the device, with the first created bus inaccessible to the
command line.
After some discussion on IRC we concluded that the best quick fix way
forward for this is to make automated bus-class type based allocation
count a global counter. That's what this patch implements. With this
we instead get
dev: macio-ide, id ""
bus: ide.1
type IDE
dev: macio-ide, id ""
bus: ide.0
type IDE
on the example mentioned above.
This also means that if you did -device ...,bus=ide.0 you got a device
on the first bus (the last created one) before this patch and get that
device on the second one (the first created one) now. Breaks
migration unless you change bus=ide.0 to bus=ide.1 on the destination.
This is intended and makes the bus enumeration work as expected.
As per review request follows a list of otherwise affected boards and
the reasoning for the conclusion that they are ok:
target machine bus id times
------ ------- ------ -----
aarch64 n800 i2c-bus.0 2
aarch64 n810 i2c-bus.0 2
arm n800 i2c-bus.0 2
arm n810 i2c-bus.0 2
-> Devices are only created explicitly on one of the two buses, using
s->mpu->i2c[0], so no change to the guest.
aarch64 vexpress-a15 virtio-mmio-bus.0 4
aarch64 vexpress-a9 virtio-mmio-bus.0 4
aarch64 virt virtio-mmio-bus.0 32
arm vexpress-a15 virtio-mmio-bus.0 4
arm vexpress-a9 virtio-mmio-bus.0 4
arm virt virtio-mmio-bus.0 32
-> Makes -device bus= work for all virtio-mmio buses. Breaks
migration. Workaround for migration from old to new: specify
virtio-mmio-bus.4 or .32 respectively rather than .0 on the
destination.
aarch64 xilinx-zynq-a9 usb-bus.0 2
arm xilinx-zynq-a9 usb-bus.0 2
mips64el fulong2e usb-bus.0 2
-> Normal USB operation not affected. Migration driver needs command
line to use the other bus.
i386 isapc ide.0 2
x86_64 isapc ide.0 2
mips mips ide.0 2
mips64 mips ide.0 2
mips64el mips ide.0 2
mipsel mips ide.0 2
ppc g3beige ide.0 2
ppc mac99 ide.0 2
ppc prep ide.0 2
ppc64 g3beige ide.0 2
ppc64 mac99 ide.0 2
ppc64 prep ide.0 2
-> Makes -device bus= work for all IDE buses. Breaks migration.
Workaround for migration from old to new: specify ide.1 rather than
ide.0 on the destination.
Signed-off-by: Alexander Graf <agraf@suse.de>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Andreas Faerber <afaerber@suse.de>
Signed-off-by: Alexander Graf <agraf@suse.de>
2014-02-06 19:08:15 +04:00
|
|
|
/* parent device has id -> use it plus parent-bus-id for bus name */
|
|
|
|
bus_id = bus->parent->num_child_bus;
|
|
|
|
|
2012-02-03 23:32:19 +04:00
|
|
|
len = strlen(bus->parent->id) + 16;
|
2011-08-21 07:09:37 +04:00
|
|
|
buf = g_malloc(len);
|
qdev: Keep global allocation counter per bus
When we have 2 separate qdev devices that both create a qbus of the
same type without specifying a bus name or device name, we end up
with two buses of the same name, such as ide.0 on the Mac machines:
dev: macio-ide, id ""
bus: ide.0
type IDE
dev: macio-ide, id ""
bus: ide.0
type IDE
If we now spawn a device that connects to a ide.0 the last created
bus gets the device, with the first created bus inaccessible to the
command line.
After some discussion on IRC we concluded that the best quick fix way
forward for this is to make automated bus-class type based allocation
count a global counter. That's what this patch implements. With this
we instead get
dev: macio-ide, id ""
bus: ide.1
type IDE
dev: macio-ide, id ""
bus: ide.0
type IDE
on the example mentioned above.
This also means that if you did -device ...,bus=ide.0 you got a device
on the first bus (the last created one) before this patch and get that
device on the second one (the first created one) now. Breaks
migration unless you change bus=ide.0 to bus=ide.1 on the destination.
This is intended and makes the bus enumeration work as expected.
As per review request follows a list of otherwise affected boards and
the reasoning for the conclusion that they are ok:
target machine bus id times
------ ------- ------ -----
aarch64 n800 i2c-bus.0 2
aarch64 n810 i2c-bus.0 2
arm n800 i2c-bus.0 2
arm n810 i2c-bus.0 2
-> Devices are only created explicitly on one of the two buses, using
s->mpu->i2c[0], so no change to the guest.
aarch64 vexpress-a15 virtio-mmio-bus.0 4
aarch64 vexpress-a9 virtio-mmio-bus.0 4
aarch64 virt virtio-mmio-bus.0 32
arm vexpress-a15 virtio-mmio-bus.0 4
arm vexpress-a9 virtio-mmio-bus.0 4
arm virt virtio-mmio-bus.0 32
-> Makes -device bus= work for all virtio-mmio buses. Breaks
migration. Workaround for migration from old to new: specify
virtio-mmio-bus.4 or .32 respectively rather than .0 on the
destination.
aarch64 xilinx-zynq-a9 usb-bus.0 2
arm xilinx-zynq-a9 usb-bus.0 2
mips64el fulong2e usb-bus.0 2
-> Normal USB operation not affected. Migration driver needs command
line to use the other bus.
i386 isapc ide.0 2
x86_64 isapc ide.0 2
mips mips ide.0 2
mips64 mips ide.0 2
mips64el mips ide.0 2
mipsel mips ide.0 2
ppc g3beige ide.0 2
ppc mac99 ide.0 2
ppc prep ide.0 2
ppc64 g3beige ide.0 2
ppc64 mac99 ide.0 2
ppc64 prep ide.0 2
-> Makes -device bus= work for all IDE buses. Breaks migration.
Workaround for migration from old to new: specify ide.1 rather than
ide.0 on the destination.
Signed-off-by: Alexander Graf <agraf@suse.de>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Andreas Faerber <afaerber@suse.de>
Signed-off-by: Alexander Graf <agraf@suse.de>
2014-02-06 19:08:15 +04:00
|
|
|
snprintf(buf, len, "%s.%d", bus->parent->id, bus_id);
|
2009-07-15 15:59:24 +04:00
|
|
|
bus->name = buf;
|
|
|
|
} else {
|
qdev: Keep global allocation counter per bus
When we have 2 separate qdev devices that both create a qbus of the
same type without specifying a bus name or device name, we end up
with two buses of the same name, such as ide.0 on the Mac machines:
dev: macio-ide, id ""
bus: ide.0
type IDE
dev: macio-ide, id ""
bus: ide.0
type IDE
If we now spawn a device that connects to a ide.0 the last created
bus gets the device, with the first created bus inaccessible to the
command line.
After some discussion on IRC we concluded that the best quick fix way
forward for this is to make automated bus-class type based allocation
count a global counter. That's what this patch implements. With this
we instead get
dev: macio-ide, id ""
bus: ide.1
type IDE
dev: macio-ide, id ""
bus: ide.0
type IDE
on the example mentioned above.
This also means that if you did -device ...,bus=ide.0 you got a device
on the first bus (the last created one) before this patch and get that
device on the second one (the first created one) now. Breaks
migration unless you change bus=ide.0 to bus=ide.1 on the destination.
This is intended and makes the bus enumeration work as expected.
As per review request follows a list of otherwise affected boards and
the reasoning for the conclusion that they are ok:
target machine bus id times
------ ------- ------ -----
aarch64 n800 i2c-bus.0 2
aarch64 n810 i2c-bus.0 2
arm n800 i2c-bus.0 2
arm n810 i2c-bus.0 2
-> Devices are only created explicitly on one of the two buses, using
s->mpu->i2c[0], so no change to the guest.
aarch64 vexpress-a15 virtio-mmio-bus.0 4
aarch64 vexpress-a9 virtio-mmio-bus.0 4
aarch64 virt virtio-mmio-bus.0 32
arm vexpress-a15 virtio-mmio-bus.0 4
arm vexpress-a9 virtio-mmio-bus.0 4
arm virt virtio-mmio-bus.0 32
-> Makes -device bus= work for all virtio-mmio buses. Breaks
migration. Workaround for migration from old to new: specify
virtio-mmio-bus.4 or .32 respectively rather than .0 on the
destination.
aarch64 xilinx-zynq-a9 usb-bus.0 2
arm xilinx-zynq-a9 usb-bus.0 2
mips64el fulong2e usb-bus.0 2
-> Normal USB operation not affected. Migration driver needs command
line to use the other bus.
i386 isapc ide.0 2
x86_64 isapc ide.0 2
mips mips ide.0 2
mips64 mips ide.0 2
mips64el mips ide.0 2
mipsel mips ide.0 2
ppc g3beige ide.0 2
ppc mac99 ide.0 2
ppc prep ide.0 2
ppc64 g3beige ide.0 2
ppc64 mac99 ide.0 2
ppc64 prep ide.0 2
-> Makes -device bus= work for all IDE buses. Breaks migration.
Workaround for migration from old to new: specify ide.1 rather than
ide.0 on the destination.
Signed-off-by: Alexander Graf <agraf@suse.de>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Andreas Faerber <afaerber@suse.de>
Signed-off-by: Alexander Graf <agraf@suse.de>
2014-02-06 19:08:15 +04:00
|
|
|
/* no id -> use lowercase bus type plus global bus-id for bus name */
|
|
|
|
bc = BUS_GET_CLASS(bus);
|
|
|
|
bus_id = bc->automatic_ids++;
|
|
|
|
|
2012-05-02 11:00:20 +04:00
|
|
|
len = strlen(typename) + 16;
|
2011-08-21 07:09:37 +04:00
|
|
|
buf = g_malloc(len);
|
qdev: Keep global allocation counter per bus
When we have 2 separate qdev devices that both create a qbus of the
same type without specifying a bus name or device name, we end up
with two buses of the same name, such as ide.0 on the Mac machines:
dev: macio-ide, id ""
bus: ide.0
type IDE
dev: macio-ide, id ""
bus: ide.0
type IDE
If we now spawn a device that connects to a ide.0 the last created
bus gets the device, with the first created bus inaccessible to the
command line.
After some discussion on IRC we concluded that the best quick fix way
forward for this is to make automated bus-class type based allocation
count a global counter. That's what this patch implements. With this
we instead get
dev: macio-ide, id ""
bus: ide.1
type IDE
dev: macio-ide, id ""
bus: ide.0
type IDE
on the example mentioned above.
This also means that if you did -device ...,bus=ide.0 you got a device
on the first bus (the last created one) before this patch and get that
device on the second one (the first created one) now. Breaks
migration unless you change bus=ide.0 to bus=ide.1 on the destination.
This is intended and makes the bus enumeration work as expected.
As per review request follows a list of otherwise affected boards and
the reasoning for the conclusion that they are ok:
target machine bus id times
------ ------- ------ -----
aarch64 n800 i2c-bus.0 2
aarch64 n810 i2c-bus.0 2
arm n800 i2c-bus.0 2
arm n810 i2c-bus.0 2
-> Devices are only created explicitly on one of the two buses, using
s->mpu->i2c[0], so no change to the guest.
aarch64 vexpress-a15 virtio-mmio-bus.0 4
aarch64 vexpress-a9 virtio-mmio-bus.0 4
aarch64 virt virtio-mmio-bus.0 32
arm vexpress-a15 virtio-mmio-bus.0 4
arm vexpress-a9 virtio-mmio-bus.0 4
arm virt virtio-mmio-bus.0 32
-> Makes -device bus= work for all virtio-mmio buses. Breaks
migration. Workaround for migration from old to new: specify
virtio-mmio-bus.4 or .32 respectively rather than .0 on the
destination.
aarch64 xilinx-zynq-a9 usb-bus.0 2
arm xilinx-zynq-a9 usb-bus.0 2
mips64el fulong2e usb-bus.0 2
-> Normal USB operation not affected. Migration driver needs command
line to use the other bus.
i386 isapc ide.0 2
x86_64 isapc ide.0 2
mips mips ide.0 2
mips64 mips ide.0 2
mips64el mips ide.0 2
mipsel mips ide.0 2
ppc g3beige ide.0 2
ppc mac99 ide.0 2
ppc prep ide.0 2
ppc64 g3beige ide.0 2
ppc64 mac99 ide.0 2
ppc64 prep ide.0 2
-> Makes -device bus= work for all IDE buses. Breaks migration.
Workaround for migration from old to new: specify ide.1 rather than
ide.0 on the destination.
Signed-off-by: Alexander Graf <agraf@suse.de>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Andreas Faerber <afaerber@suse.de>
Signed-off-by: Alexander Graf <agraf@suse.de>
2014-02-06 19:08:15 +04:00
|
|
|
len = snprintf(buf, len, "%s.%d", typename, bus_id);
|
|
|
|
for (i = 0; i < len; i++) {
|
2009-07-30 17:28:45 +04:00
|
|
|
buf[i] = qemu_tolower(buf[i]);
|
qdev: Keep global allocation counter per bus
When we have 2 separate qdev devices that both create a qbus of the
same type without specifying a bus name or device name, we end up
with two buses of the same name, such as ide.0 on the Mac machines:
dev: macio-ide, id ""
bus: ide.0
type IDE
dev: macio-ide, id ""
bus: ide.0
type IDE
If we now spawn a device that connects to a ide.0 the last created
bus gets the device, with the first created bus inaccessible to the
command line.
After some discussion on IRC we concluded that the best quick fix way
forward for this is to make automated bus-class type based allocation
count a global counter. That's what this patch implements. With this
we instead get
dev: macio-ide, id ""
bus: ide.1
type IDE
dev: macio-ide, id ""
bus: ide.0
type IDE
on the example mentioned above.
This also means that if you did -device ...,bus=ide.0 you got a device
on the first bus (the last created one) before this patch and get that
device on the second one (the first created one) now. Breaks
migration unless you change bus=ide.0 to bus=ide.1 on the destination.
This is intended and makes the bus enumeration work as expected.
As per review request follows a list of otherwise affected boards and
the reasoning for the conclusion that they are ok:
target machine bus id times
------ ------- ------ -----
aarch64 n800 i2c-bus.0 2
aarch64 n810 i2c-bus.0 2
arm n800 i2c-bus.0 2
arm n810 i2c-bus.0 2
-> Devices are only created explicitly on one of the two buses, using
s->mpu->i2c[0], so no change to the guest.
aarch64 vexpress-a15 virtio-mmio-bus.0 4
aarch64 vexpress-a9 virtio-mmio-bus.0 4
aarch64 virt virtio-mmio-bus.0 32
arm vexpress-a15 virtio-mmio-bus.0 4
arm vexpress-a9 virtio-mmio-bus.0 4
arm virt virtio-mmio-bus.0 32
-> Makes -device bus= work for all virtio-mmio buses. Breaks
migration. Workaround for migration from old to new: specify
virtio-mmio-bus.4 or .32 respectively rather than .0 on the
destination.
aarch64 xilinx-zynq-a9 usb-bus.0 2
arm xilinx-zynq-a9 usb-bus.0 2
mips64el fulong2e usb-bus.0 2
-> Normal USB operation not affected. Migration driver needs command
line to use the other bus.
i386 isapc ide.0 2
x86_64 isapc ide.0 2
mips mips ide.0 2
mips64 mips ide.0 2
mips64el mips ide.0 2
mipsel mips ide.0 2
ppc g3beige ide.0 2
ppc mac99 ide.0 2
ppc prep ide.0 2
ppc64 g3beige ide.0 2
ppc64 mac99 ide.0 2
ppc64 prep ide.0 2
-> Makes -device bus= work for all IDE buses. Breaks migration.
Workaround for migration from old to new: specify ide.1 rather than
ide.0 on the destination.
Signed-off-by: Alexander Graf <agraf@suse.de>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Andreas Faerber <afaerber@suse.de>
Signed-off-by: Alexander Graf <agraf@suse.de>
2014-02-06 19:08:15 +04:00
|
|
|
}
|
2009-07-15 15:59:24 +04:00
|
|
|
bus->name = buf;
|
|
|
|
}
|
|
|
|
|
2012-02-03 23:32:19 +04:00
|
|
|
if (bus->parent) {
|
|
|
|
QLIST_INSERT_HEAD(&bus->parent->child_bus, bus, sibling);
|
|
|
|
bus->parent->num_child_bus++;
|
|
|
|
object_property_add_child(OBJECT(bus->parent), bus->name, OBJECT(bus), NULL);
|
2013-01-25 17:12:37 +04:00
|
|
|
object_unref(OBJECT(bus));
|
2012-05-02 14:06:55 +04:00
|
|
|
} else if (bus != sysbus_get_default()) {
|
2010-12-20 08:33:35 +03:00
|
|
|
/* TODO: once all bus devices are qdevified,
|
|
|
|
only reset handler for main_system_bus should be registered here. */
|
|
|
|
qemu_register_reset(qbus_reset_all_fn, bus);
|
2009-05-23 03:05:19 +04:00
|
|
|
}
|
2009-09-17 00:25:27 +04:00
|
|
|
}
|
|
|
|
|
2013-01-25 17:12:33 +04:00
|
|
|
static void bus_unparent(Object *obj)
|
|
|
|
{
|
|
|
|
BusState *bus = BUS(obj);
|
|
|
|
BusChild *kid;
|
|
|
|
|
|
|
|
while ((kid = QTAILQ_FIRST(&bus->children)) != NULL) {
|
|
|
|
DeviceState *dev = kid->child;
|
2013-09-11 16:54:09 +04:00
|
|
|
object_unparent(OBJECT(dev));
|
2013-01-25 17:12:33 +04:00
|
|
|
}
|
|
|
|
if (bus->parent) {
|
|
|
|
QLIST_REMOVE(bus, sibling);
|
|
|
|
bus->parent->num_child_bus--;
|
|
|
|
bus->parent = NULL;
|
|
|
|
} else {
|
|
|
|
assert(bus != sysbus_get_default()); /* main_system_bus is never freed */
|
|
|
|
qemu_unregister_reset(qbus_reset_all_fn, bus);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2014-04-25 14:44:21 +04:00
|
|
|
static bool bus_get_realized(Object *obj, Error **errp)
|
2013-11-26 02:48:40 +04:00
|
|
|
{
|
|
|
|
BusState *bus = BUS(obj);
|
|
|
|
|
|
|
|
return bus->realized;
|
|
|
|
}
|
|
|
|
|
2014-04-25 14:44:21 +04:00
|
|
|
static void bus_set_realized(Object *obj, bool value, Error **errp)
|
2013-11-26 02:48:40 +04:00
|
|
|
{
|
|
|
|
BusState *bus = BUS(obj);
|
|
|
|
BusClass *bc = BUS_GET_CLASS(bus);
|
2014-06-11 16:52:09 +04:00
|
|
|
BusChild *kid;
|
2013-11-26 02:48:40 +04:00
|
|
|
Error *local_err = NULL;
|
|
|
|
|
|
|
|
if (value && !bus->realized) {
|
|
|
|
if (bc->realize) {
|
|
|
|
bc->realize(bus, &local_err);
|
|
|
|
}
|
2014-06-11 16:52:09 +04:00
|
|
|
|
|
|
|
/* TODO: recursive realization */
|
2013-11-26 02:48:40 +04:00
|
|
|
} else if (!value && bus->realized) {
|
2014-06-11 16:52:09 +04:00
|
|
|
QTAILQ_FOREACH(kid, &bus->children, sibling) {
|
|
|
|
DeviceState *dev = kid->child;
|
|
|
|
object_property_set_bool(OBJECT(dev), false, "realized",
|
|
|
|
&local_err);
|
|
|
|
if (local_err != NULL) {
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
if (bc->unrealize && local_err == NULL) {
|
2013-11-26 02:48:40 +04:00
|
|
|
bc->unrealize(bus, &local_err);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2014-06-11 16:52:08 +04:00
|
|
|
if (local_err != NULL) {
|
|
|
|
error_propagate(errp, local_err);
|
|
|
|
return;
|
|
|
|
}
|
2013-11-26 02:48:40 +04:00
|
|
|
|
2014-06-11 16:52:08 +04:00
|
|
|
bus->realized = value;
|
2013-11-26 02:48:40 +04:00
|
|
|
}
|
|
|
|
|
2013-08-24 02:02:27 +04:00
|
|
|
void qbus_create_inplace(void *bus, size_t size, const char *typename,
|
2012-05-02 11:00:20 +04:00
|
|
|
DeviceState *parent, const char *name)
|
2009-09-17 00:25:27 +04:00
|
|
|
{
|
2013-08-23 21:37:12 +04:00
|
|
|
object_initialize(bus, size, typename);
|
2013-01-25 17:12:27 +04:00
|
|
|
qbus_realize(bus, parent, name);
|
2009-05-23 03:05:19 +04:00
|
|
|
}
|
2009-06-05 18:53:17 +04:00
|
|
|
|
2012-05-02 11:00:20 +04:00
|
|
|
BusState *qbus_create(const char *typename, DeviceState *parent, const char *name)
|
2011-08-02 05:59:13 +04:00
|
|
|
{
|
2009-09-17 00:25:27 +04:00
|
|
|
BusState *bus;
|
|
|
|
|
2012-05-02 11:00:20 +04:00
|
|
|
bus = BUS(object_new(typename));
|
2013-01-25 17:12:27 +04:00
|
|
|
qbus_realize(bus, parent, name);
|
2012-02-03 23:32:19 +04:00
|
|
|
|
2009-05-23 03:05:19 +04:00
|
|
|
return bus;
|
2011-08-02 05:59:13 +04:00
|
|
|
}
|
|
|
|
|
2012-05-02 11:00:20 +04:00
|
|
|
static char *bus_get_fw_dev_path(BusState *bus, DeviceState *dev)
|
|
|
|
{
|
|
|
|
BusClass *bc = BUS_GET_CLASS(bus);
|
|
|
|
|
|
|
|
if (bc->get_fw_dev_path) {
|
|
|
|
return bc->get_fw_dev_path(dev);
|
2009-09-25 23:42:34 +04:00
|
|
|
}
|
2012-05-02 11:00:20 +04:00
|
|
|
|
|
|
|
return NULL;
|
2009-09-25 23:42:34 +04:00
|
|
|
}
|
|
|
|
|
2014-03-17 06:40:23 +04:00
|
|
|
static char *qdev_get_fw_dev_path_from_handler(BusState *bus, DeviceState *dev)
|
|
|
|
{
|
|
|
|
Object *obj = OBJECT(dev);
|
|
|
|
char *d = NULL;
|
|
|
|
|
|
|
|
while (!d && obj->parent) {
|
|
|
|
obj = obj->parent;
|
|
|
|
d = fw_path_provider_try_get_dev_path(obj, bus, dev);
|
|
|
|
}
|
|
|
|
return d;
|
|
|
|
}
|
|
|
|
|
2010-12-08 14:35:05 +03:00
|
|
|
static int qdev_get_fw_dev_path_helper(DeviceState *dev, char *p, int size)
|
|
|
|
{
|
|
|
|
int l = 0;
|
|
|
|
|
|
|
|
if (dev && dev->parent_bus) {
|
|
|
|
char *d;
|
|
|
|
l = qdev_get_fw_dev_path_helper(dev->parent_bus->parent, p, size);
|
2014-03-17 06:40:23 +04:00
|
|
|
d = qdev_get_fw_dev_path_from_handler(dev->parent_bus, dev);
|
|
|
|
if (!d) {
|
|
|
|
d = bus_get_fw_dev_path(dev->parent_bus, dev);
|
|
|
|
}
|
2012-05-02 11:00:20 +04:00
|
|
|
if (d) {
|
2010-12-08 14:35:05 +03:00
|
|
|
l += snprintf(p + l, size - l, "%s", d);
|
2011-08-21 07:09:37 +04:00
|
|
|
g_free(d);
|
2010-12-08 14:35:05 +03:00
|
|
|
} else {
|
2013-05-29 11:56:42 +04:00
|
|
|
return l;
|
2010-12-08 14:35:05 +03:00
|
|
|
}
|
|
|
|
}
|
|
|
|
l += snprintf(p + l , size - l, "/");
|
|
|
|
|
|
|
|
return l;
|
|
|
|
}
|
|
|
|
|
|
|
|
char* qdev_get_fw_dev_path(DeviceState *dev)
|
|
|
|
{
|
|
|
|
char path[128];
|
|
|
|
int l;
|
|
|
|
|
|
|
|
l = qdev_get_fw_dev_path_helper(dev, path, 128);
|
|
|
|
|
|
|
|
path[l-1] = '\0';
|
|
|
|
|
scsi, pci, qdev, isa-bus, sysbus: don't let *_get_fw_dev_path return NULL
Use g_strdup rather than strdup, because the sole caller
(qdev_get_fw_dev_path_helper) assumes it gets non-NULL, and dereferences
it. Besides, in that caller, the allocated buffer is already freed with
g_free, so it's better to allocate with a matching g_strdup.
In one case, (scsi-bus.c) it was trivial, so I replaced an snprintf+
g_strdup combination with an equivalent g_strdup_printf use.
Signed-off-by: Jim Meyering <meyering@redhat.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
2012-10-04 15:09:44 +04:00
|
|
|
return g_strdup(path);
|
2010-12-08 14:35:05 +03:00
|
|
|
}
|
2011-12-13 00:29:25 +04:00
|
|
|
|
2012-02-03 22:28:43 +04:00
|
|
|
char *qdev_get_dev_path(DeviceState *dev)
|
2011-12-13 00:29:25 +04:00
|
|
|
{
|
2012-05-02 11:00:20 +04:00
|
|
|
BusClass *bc;
|
2012-02-03 22:28:43 +04:00
|
|
|
|
|
|
|
if (!dev || !dev->parent_bus) {
|
|
|
|
return NULL;
|
|
|
|
}
|
|
|
|
|
2012-05-02 11:00:20 +04:00
|
|
|
bc = BUS_GET_CLASS(dev->parent_bus);
|
|
|
|
if (bc->get_dev_path) {
|
|
|
|
return bc->get_dev_path(dev);
|
2012-02-03 22:28:43 +04:00
|
|
|
}
|
|
|
|
|
|
|
|
return NULL;
|
2011-12-13 00:29:26 +04:00
|
|
|
}
|
2011-12-13 00:29:27 +04:00
|
|
|
|
|
|
|
/**
|
|
|
|
* Legacy property handling
|
|
|
|
*/
|
|
|
|
|
2012-01-30 18:55:55 +04:00
|
|
|
static void qdev_get_legacy_property(Object *obj, Visitor *v, void *opaque,
|
2011-12-13 00:29:27 +04:00
|
|
|
const char *name, Error **errp)
|
|
|
|
{
|
2012-01-30 18:55:55 +04:00
|
|
|
DeviceState *dev = DEVICE(obj);
|
2011-12-13 00:29:27 +04:00
|
|
|
Property *prop = opaque;
|
|
|
|
|
2011-12-18 20:05:06 +04:00
|
|
|
char buffer[1024];
|
|
|
|
char *ptr = buffer;
|
2011-12-13 00:29:27 +04:00
|
|
|
|
2011-12-18 20:05:06 +04:00
|
|
|
prop->info->print(dev, prop, buffer, sizeof(buffer));
|
|
|
|
visit_type_str(v, &ptr, name, errp);
|
2011-12-13 00:29:27 +04:00
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* @qdev_add_legacy_property - adds a legacy property
|
|
|
|
*
|
|
|
|
* Do not use this is new code! Properties added through this interface will
|
2011-12-18 20:05:11 +04:00
|
|
|
* be given names and types in the "legacy" namespace.
|
2011-12-13 00:29:27 +04:00
|
|
|
*
|
2012-02-02 13:17:19 +04:00
|
|
|
* Legacy properties are string versions of other OOM properties. The format
|
|
|
|
* of the string depends on the property type.
|
2011-12-13 00:29:27 +04:00
|
|
|
*/
|
2014-05-03 00:22:57 +04:00
|
|
|
static void qdev_property_add_legacy(DeviceState *dev, Property *prop,
|
|
|
|
Error **errp)
|
2011-12-13 00:29:27 +04:00
|
|
|
{
|
2014-02-08 14:01:48 +04:00
|
|
|
gchar *name;
|
2011-12-13 00:29:27 +04:00
|
|
|
|
2012-05-02 15:31:07 +04:00
|
|
|
/* Register pointer properties as legacy properties */
|
2014-02-08 14:01:47 +04:00
|
|
|
if (!prop->info->print && prop->info->get) {
|
2012-02-02 13:17:19 +04:00
|
|
|
return;
|
|
|
|
}
|
2012-05-02 15:31:07 +04:00
|
|
|
|
2011-12-18 20:05:11 +04:00
|
|
|
name = g_strdup_printf("legacy-%s", prop->name);
|
2014-02-08 14:01:48 +04:00
|
|
|
object_property_add(OBJECT(dev), name, "str",
|
2012-02-02 13:17:19 +04:00
|
|
|
prop->info->print ? qdev_get_legacy_property : prop->info->get,
|
2014-02-08 14:01:47 +04:00
|
|
|
NULL,
|
2012-01-30 18:55:55 +04:00
|
|
|
NULL,
|
|
|
|
prop, errp);
|
2011-12-13 00:29:27 +04:00
|
|
|
|
2011-12-18 20:05:11 +04:00
|
|
|
g_free(name);
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* @qdev_property_add_static - add a @Property to a device.
|
|
|
|
*
|
|
|
|
* Static properties access data in a struct. The actual type of the
|
|
|
|
* property and the field depends on the property type.
|
|
|
|
*/
|
|
|
|
void qdev_property_add_static(DeviceState *dev, Property *prop,
|
|
|
|
Error **errp)
|
|
|
|
{
|
2012-04-03 00:40:26 +04:00
|
|
|
Error *local_err = NULL;
|
|
|
|
Object *obj = OBJECT(dev);
|
|
|
|
|
2012-02-02 12:47:13 +04:00
|
|
|
/*
|
|
|
|
* TODO qdev_prop_ptr does not have getters or setters. It must
|
|
|
|
* go now that it can be replaced with links. The test should be
|
|
|
|
* removed along with it: all static properties are read/write.
|
|
|
|
*/
|
|
|
|
if (!prop->info->get && !prop->info->set) {
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
2012-04-03 00:40:26 +04:00
|
|
|
object_property_add(obj, prop->name, prop->info->name,
|
2012-01-30 18:55:55 +04:00
|
|
|
prop->info->get, prop->info->set,
|
2012-02-02 16:08:48 +04:00
|
|
|
prop->info->release,
|
2012-04-03 00:40:26 +04:00
|
|
|
prop, &local_err);
|
|
|
|
|
|
|
|
if (local_err) {
|
|
|
|
error_propagate(errp, local_err);
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
if (prop->qtype == QTYPE_NONE) {
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (prop->qtype == QTYPE_QBOOL) {
|
2014-01-02 06:48:08 +04:00
|
|
|
object_property_set_bool(obj, prop->defval, prop->name, &error_abort);
|
2012-04-03 00:40:26 +04:00
|
|
|
} else if (prop->info->enum_table) {
|
|
|
|
object_property_set_str(obj, prop->info->enum_table[prop->defval],
|
2014-01-02 06:48:08 +04:00
|
|
|
prop->name, &error_abort);
|
2012-04-03 00:40:26 +04:00
|
|
|
} else if (prop->qtype == QTYPE_QINT) {
|
2014-01-02 06:48:08 +04:00
|
|
|
object_property_set_int(obj, prop->defval, prop->name, &error_abort);
|
2012-04-03 00:40:26 +04:00
|
|
|
}
|
2011-12-13 00:29:42 +04:00
|
|
|
}
|
2011-12-20 02:37:46 +04:00
|
|
|
|
2014-04-25 14:44:21 +04:00
|
|
|
static bool device_get_realized(Object *obj, Error **errp)
|
2013-01-09 06:58:11 +04:00
|
|
|
{
|
|
|
|
DeviceState *dev = DEVICE(obj);
|
|
|
|
return dev->realized;
|
|
|
|
}
|
|
|
|
|
2014-04-25 14:44:21 +04:00
|
|
|
static void device_set_realized(Object *obj, bool value, Error **errp)
|
2013-01-09 06:58:11 +04:00
|
|
|
{
|
|
|
|
DeviceState *dev = DEVICE(obj);
|
|
|
|
DeviceClass *dc = DEVICE_GET_CLASS(dev);
|
2014-03-13 00:02:12 +04:00
|
|
|
BusState *bus;
|
2013-01-09 06:58:11 +04:00
|
|
|
Error *local_err = NULL;
|
|
|
|
|
2014-02-05 19:36:46 +04:00
|
|
|
if (dev->hotplugged && !dc->hotpluggable) {
|
2014-04-25 14:44:21 +04:00
|
|
|
error_set(errp, QERR_DEVICE_NO_HOTPLUG, object_get_typename(obj));
|
2014-02-05 19:36:46 +04:00
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
2013-01-09 06:58:11 +04:00
|
|
|
if (value && !dev->realized) {
|
|
|
|
if (!obj->parent && local_err == NULL) {
|
|
|
|
static int unattached_count;
|
|
|
|
gchar *name = g_strdup_printf("device[%d]", unattached_count++);
|
|
|
|
|
|
|
|
object_property_add_child(container_get(qdev_get_machine(),
|
|
|
|
"/unattached"),
|
|
|
|
name, obj, &local_err);
|
|
|
|
g_free(name);
|
|
|
|
}
|
|
|
|
|
2013-04-11 18:51:56 +04:00
|
|
|
if (dc->realize) {
|
|
|
|
dc->realize(dev, &local_err);
|
|
|
|
}
|
|
|
|
|
2014-02-05 19:36:52 +04:00
|
|
|
if (dev->parent_bus && dev->parent_bus->hotplug_handler &&
|
|
|
|
local_err == NULL) {
|
|
|
|
hotplug_handler_plug(dev->parent_bus->hotplug_handler,
|
|
|
|
dev, &local_err);
|
2014-06-02 17:25:03 +04:00
|
|
|
} else if (local_err == NULL &&
|
|
|
|
object_dynamic_cast(qdev_get_machine(), TYPE_MACHINE)) {
|
|
|
|
HotplugHandler *hotplug_ctrl;
|
|
|
|
MachineState *machine = MACHINE(qdev_get_machine());
|
|
|
|
MachineClass *mc = MACHINE_GET_CLASS(machine);
|
|
|
|
|
|
|
|
if (mc->get_hotplug_handler) {
|
|
|
|
hotplug_ctrl = mc->get_hotplug_handler(machine, dev);
|
|
|
|
if (hotplug_ctrl) {
|
|
|
|
hotplug_handler_plug(hotplug_ctrl, dev, &local_err);
|
|
|
|
}
|
|
|
|
}
|
2014-02-05 19:36:52 +04:00
|
|
|
}
|
|
|
|
|
2013-01-09 06:58:11 +04:00
|
|
|
if (qdev_get_vmsd(dev) && local_err == NULL) {
|
|
|
|
vmstate_register_with_alias_id(dev, -1, qdev_get_vmsd(dev), dev,
|
|
|
|
dev->instance_id_alias,
|
|
|
|
dev->alias_required_for_version);
|
|
|
|
}
|
2014-03-13 00:02:12 +04:00
|
|
|
if (local_err == NULL) {
|
|
|
|
QLIST_FOREACH(bus, &dev->child_bus, sibling) {
|
|
|
|
object_property_set_bool(OBJECT(bus), true, "realized",
|
|
|
|
&local_err);
|
|
|
|
if (local_err != NULL) {
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
2013-01-09 06:58:11 +04:00
|
|
|
if (dev->hotplugged && local_err == NULL) {
|
|
|
|
device_reset(dev);
|
|
|
|
}
|
|
|
|
} else if (!value && dev->realized) {
|
2014-03-13 00:02:12 +04:00
|
|
|
QLIST_FOREACH(bus, &dev->child_bus, sibling) {
|
|
|
|
object_property_set_bool(OBJECT(bus), false, "realized",
|
|
|
|
&local_err);
|
|
|
|
if (local_err != NULL) {
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
if (qdev_get_vmsd(dev) && local_err == NULL) {
|
2013-04-15 20:34:10 +04:00
|
|
|
vmstate_unregister(dev, qdev_get_vmsd(dev), dev);
|
|
|
|
}
|
2014-03-13 00:02:12 +04:00
|
|
|
if (dc->unrealize && local_err == NULL) {
|
2013-01-09 06:58:11 +04:00
|
|
|
dc->unrealize(dev, &local_err);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
if (local_err != NULL) {
|
2014-04-25 14:44:21 +04:00
|
|
|
error_propagate(errp, local_err);
|
2013-01-09 06:58:11 +04:00
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
dev->realized = value;
|
|
|
|
}
|
|
|
|
|
2014-04-25 14:44:21 +04:00
|
|
|
static bool device_get_hotpluggable(Object *obj, Error **errp)
|
2014-02-05 19:36:46 +04:00
|
|
|
{
|
|
|
|
DeviceClass *dc = DEVICE_GET_CLASS(obj);
|
|
|
|
DeviceState *dev = DEVICE(obj);
|
|
|
|
|
2014-03-07 22:04:13 +04:00
|
|
|
return dc->hotpluggable && (dev->parent_bus == NULL ||
|
|
|
|
dev->parent_bus->allow_hotplug);
|
2014-02-05 19:36:46 +04:00
|
|
|
}
|
|
|
|
|
2014-06-02 17:25:04 +04:00
|
|
|
static bool device_get_hotplugged(Object *obj, Error **err)
|
|
|
|
{
|
|
|
|
DeviceState *dev = DEVICE(obj);
|
|
|
|
|
|
|
|
return dev->hotplugged;
|
|
|
|
}
|
|
|
|
|
|
|
|
static void device_set_hotplugged(Object *obj, bool value, Error **err)
|
|
|
|
{
|
|
|
|
DeviceState *dev = DEVICE(obj);
|
|
|
|
|
|
|
|
dev->hotplugged = value;
|
|
|
|
}
|
|
|
|
|
2011-12-23 01:06:37 +04:00
|
|
|
static void device_initfn(Object *obj)
|
|
|
|
{
|
|
|
|
DeviceState *dev = DEVICE(obj);
|
2012-03-28 20:12:47 +04:00
|
|
|
ObjectClass *class;
|
2011-12-23 01:06:37 +04:00
|
|
|
Property *prop;
|
|
|
|
|
|
|
|
if (qdev_hotplug) {
|
|
|
|
dev->hotplugged = 1;
|
|
|
|
qdev_hot_added = true;
|
|
|
|
}
|
|
|
|
|
|
|
|
dev->instance_id_alias = -1;
|
2013-01-09 06:58:10 +04:00
|
|
|
dev->realized = false;
|
2011-12-23 01:06:37 +04:00
|
|
|
|
2013-01-09 06:58:11 +04:00
|
|
|
object_property_add_bool(obj, "realized",
|
|
|
|
device_get_realized, device_set_realized, NULL);
|
2014-02-05 19:36:46 +04:00
|
|
|
object_property_add_bool(obj, "hotpluggable",
|
|
|
|
device_get_hotpluggable, NULL, NULL);
|
2014-06-02 17:25:04 +04:00
|
|
|
object_property_add_bool(obj, "hotplugged",
|
|
|
|
device_get_hotplugged, device_set_hotplugged,
|
|
|
|
&error_abort);
|
2013-01-09 06:58:11 +04:00
|
|
|
|
2012-03-28 20:12:47 +04:00
|
|
|
class = object_get_class(OBJECT(dev));
|
|
|
|
do {
|
|
|
|
for (prop = DEVICE_CLASS(class)->props; prop && prop->name; prop++) {
|
2014-01-02 06:48:08 +04:00
|
|
|
qdev_property_add_legacy(dev, prop, &error_abort);
|
|
|
|
qdev_property_add_static(dev, prop, &error_abort);
|
2012-03-28 20:12:47 +04:00
|
|
|
}
|
|
|
|
class = object_class_get_parent(class);
|
|
|
|
} while (class != object_class_by_name(TYPE_DEVICE));
|
2011-12-23 01:06:37 +04:00
|
|
|
|
2012-05-02 12:39:01 +04:00
|
|
|
object_property_add_link(OBJECT(dev), "parent_bus", TYPE_BUS,
|
2014-03-19 11:58:56 +04:00
|
|
|
(Object **)&dev->parent_bus, NULL, 0,
|
qom: Make QOM link property unref optional
Some object_property_add_link() callers expect property deletion to
unref the link property object. Other callers expect to manage the
refcount themselves. The former are currently broken and therefore leak
the link property object.
This patch adds a flags argument to object_property_add_link() so the
caller can specify which refcount behavior they require. The new
OBJ_PROP_LINK_UNREF_ON_RELEASE flag causes the link pointer to be
unreferenced when the property is deleted.
This fixes refcount leaks in qdev.c, xilinx_axidma.c, xilinx_axienet.c,
s390-virtio-bus.c, virtio-pci.c, virtio-rng.c, and ui/console.c.
Rationale for refcount behavior:
* hw/core/qdev.c
- bus children are explicitly unreferenced, don't interfere
- parent_bus is essentially a read-only property that doesn't hold a
refcount, don't unref
- hotplug_handler is leaked, do unref
* hw/dma/xilinx_axidma.c
- rx stream "dma" links are set using set_link, therefore they
need unref
- tx streams are set using set_link, therefore they need unref
* hw/net/xilinx_axienet.c
- same reasoning as hw/dma/xilinx_axidma.c
* hw/pcmcia/pxa2xx.c
- pxa2xx bypasses set_link and therefore does not use refcounts
* hw/s390x/s390-virtio-bus.c
* hw/virtio/virtio-pci.c
* hw/virtio/virtio-rng.c
* ui/console.c
- set_link is used and there is no explicit unref, do unref
Cc: Peter Crosthwaite <peter.crosthwaite@petalogix.com>
Cc: Alexander Graf <agraf@suse.de>
Cc: Anthony Liguori <aliguori@amazon.com>
Cc: "Michael S. Tsirkin" <mst@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Andreas Färber <afaerber@suse.de>
2014-03-19 11:58:55 +04:00
|
|
|
&error_abort);
|
2014-05-20 10:30:58 +04:00
|
|
|
QLIST_INIT(&dev->gpios);
|
2011-12-23 01:06:37 +04:00
|
|
|
}
|
|
|
|
|
2013-07-11 00:08:42 +04:00
|
|
|
static void device_post_init(Object *obj)
|
|
|
|
{
|
2014-01-02 06:48:08 +04:00
|
|
|
qdev_prop_set_globals(DEVICE(obj), &error_abort);
|
2013-07-11 00:08:42 +04:00
|
|
|
}
|
|
|
|
|
2011-12-23 18:38:56 +04:00
|
|
|
/* Unlink device from bus and free the structure. */
|
|
|
|
static void device_finalize(Object *obj)
|
|
|
|
{
|
2014-05-20 10:30:58 +04:00
|
|
|
NamedGPIOList *ngl, *next;
|
|
|
|
|
2011-12-23 18:38:56 +04:00
|
|
|
DeviceState *dev = DEVICE(obj);
|
2013-01-25 17:12:34 +04:00
|
|
|
if (dev->opts) {
|
|
|
|
qemu_opts_del(dev->opts);
|
2011-12-23 18:38:56 +04:00
|
|
|
}
|
2014-05-20 10:30:58 +04:00
|
|
|
|
|
|
|
QLIST_FOREACH_SAFE(ngl, &dev->gpios, node, next) {
|
|
|
|
QLIST_REMOVE(ngl, node);
|
2014-06-18 11:56:31 +04:00
|
|
|
qemu_free_irqs(ngl->in, ngl->num_in);
|
2014-05-20 10:30:58 +04:00
|
|
|
g_free(ngl->name);
|
|
|
|
g_free(ngl);
|
|
|
|
/* ngl->out irqs are owned by the other end and should not be freed
|
|
|
|
* here
|
|
|
|
*/
|
|
|
|
}
|
2011-12-23 18:38:56 +04:00
|
|
|
}
|
|
|
|
|
2012-03-28 20:12:47 +04:00
|
|
|
static void device_class_base_init(ObjectClass *class, void *data)
|
|
|
|
{
|
|
|
|
DeviceClass *klass = DEVICE_CLASS(class);
|
|
|
|
|
|
|
|
/* We explicitly look up properties in the superclasses,
|
|
|
|
* so do not propagate them to the subclasses.
|
|
|
|
*/
|
|
|
|
klass->props = NULL;
|
2011-12-23 18:38:56 +04:00
|
|
|
}
|
|
|
|
|
2013-01-04 21:13:00 +04:00
|
|
|
static void device_unparent(Object *obj)
|
2012-11-23 12:47:13 +04:00
|
|
|
{
|
|
|
|
DeviceState *dev = DEVICE(obj);
|
2013-01-25 17:12:34 +04:00
|
|
|
BusState *bus;
|
2013-03-27 20:36:14 +04:00
|
|
|
bool have_realized = dev->realized;
|
2012-11-23 12:47:13 +04:00
|
|
|
|
2014-03-13 00:02:12 +04:00
|
|
|
if (dev->realized) {
|
|
|
|
object_property_set_bool(obj, false, "realized", NULL);
|
|
|
|
}
|
2013-01-25 17:12:34 +04:00
|
|
|
while (dev->num_child_bus) {
|
|
|
|
bus = QLIST_FIRST(&dev->child_bus);
|
2013-12-18 20:15:51 +04:00
|
|
|
object_unparent(OBJECT(bus));
|
2013-01-25 17:12:34 +04:00
|
|
|
}
|
|
|
|
if (dev->parent_bus) {
|
2013-01-04 21:13:00 +04:00
|
|
|
bus_remove_child(dev->parent_bus, dev);
|
2013-01-25 17:12:35 +04:00
|
|
|
object_unref(OBJECT(dev->parent_bus));
|
|
|
|
dev->parent_bus = NULL;
|
2013-01-04 21:13:00 +04:00
|
|
|
}
|
2013-03-06 16:58:59 +04:00
|
|
|
|
2013-03-27 20:36:14 +04:00
|
|
|
/* Only send event if the device had been completely realized */
|
|
|
|
if (have_realized) {
|
|
|
|
gchar *path = object_get_canonical_path(OBJECT(dev));
|
|
|
|
|
2014-06-18 10:43:43 +04:00
|
|
|
qapi_event_send_device_deleted(!!dev->id, dev->id, path, &error_abort);
|
2013-03-27 20:36:14 +04:00
|
|
|
g_free(path);
|
2013-03-06 16:58:59 +04:00
|
|
|
}
|
2012-11-23 12:47:13 +04:00
|
|
|
}
|
|
|
|
|
|
|
|
static void device_class_init(ObjectClass *class, void *data)
|
|
|
|
{
|
2013-01-09 06:58:11 +04:00
|
|
|
DeviceClass *dc = DEVICE_CLASS(class);
|
|
|
|
|
2013-01-04 21:13:00 +04:00
|
|
|
class->unparent = device_unparent;
|
2013-01-09 06:58:11 +04:00
|
|
|
dc->realize = device_realize;
|
2013-04-15 20:34:10 +04:00
|
|
|
dc->unrealize = device_unrealize;
|
2014-02-18 20:56:53 +04:00
|
|
|
|
|
|
|
/* by default all devices were considered as hotpluggable,
|
|
|
|
* so with intent to check it in generic qdev_unplug() /
|
|
|
|
* device_set_realized() functions make every device
|
|
|
|
* hotpluggable. Devices that shouldn't be hotpluggable,
|
|
|
|
* should override it in their class_init()
|
|
|
|
*/
|
|
|
|
dc->hotpluggable = true;
|
2012-11-23 12:47:13 +04:00
|
|
|
}
|
|
|
|
|
2011-12-04 21:36:01 +04:00
|
|
|
void device_reset(DeviceState *dev)
|
|
|
|
{
|
|
|
|
DeviceClass *klass = DEVICE_GET_CLASS(dev);
|
|
|
|
|
|
|
|
if (klass->reset) {
|
|
|
|
klass->reset(dev);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2012-03-28 18:34:12 +04:00
|
|
|
Object *qdev_get_machine(void)
|
|
|
|
{
|
|
|
|
static Object *dev;
|
|
|
|
|
|
|
|
if (dev == NULL) {
|
2012-04-05 15:21:46 +04:00
|
|
|
dev = container_get(object_get_root(), "/machine");
|
2012-03-28 18:34:12 +04:00
|
|
|
}
|
|
|
|
|
|
|
|
return dev;
|
|
|
|
}
|
|
|
|
|
2013-01-10 19:19:07 +04:00
|
|
|
static const TypeInfo device_type_info = {
|
2011-12-17 00:34:46 +04:00
|
|
|
.name = TYPE_DEVICE,
|
|
|
|
.parent = TYPE_OBJECT,
|
|
|
|
.instance_size = sizeof(DeviceState),
|
2011-12-23 01:06:37 +04:00
|
|
|
.instance_init = device_initfn,
|
2013-07-11 00:08:42 +04:00
|
|
|
.instance_post_init = device_post_init,
|
2011-12-23 18:38:56 +04:00
|
|
|
.instance_finalize = device_finalize,
|
2012-03-28 20:12:47 +04:00
|
|
|
.class_base_init = device_class_base_init,
|
2012-11-23 12:47:13 +04:00
|
|
|
.class_init = device_class_init,
|
2011-12-17 00:34:46 +04:00
|
|
|
.abstract = true,
|
|
|
|
.class_size = sizeof(DeviceClass),
|
|
|
|
};
|
|
|
|
|
2012-02-03 23:32:19 +04:00
|
|
|
static void qbus_initfn(Object *obj)
|
|
|
|
{
|
|
|
|
BusState *bus = BUS(obj);
|
|
|
|
|
|
|
|
QTAILQ_INIT(&bus->children);
|
2014-02-05 19:36:45 +04:00
|
|
|
object_property_add_link(obj, QDEV_HOTPLUG_HANDLER_PROPERTY,
|
|
|
|
TYPE_HOTPLUG_HANDLER,
|
qom: Make QOM link property unref optional
Some object_property_add_link() callers expect property deletion to
unref the link property object. Other callers expect to manage the
refcount themselves. The former are currently broken and therefore leak
the link property object.
This patch adds a flags argument to object_property_add_link() so the
caller can specify which refcount behavior they require. The new
OBJ_PROP_LINK_UNREF_ON_RELEASE flag causes the link pointer to be
unreferenced when the property is deleted.
This fixes refcount leaks in qdev.c, xilinx_axidma.c, xilinx_axienet.c,
s390-virtio-bus.c, virtio-pci.c, virtio-rng.c, and ui/console.c.
Rationale for refcount behavior:
* hw/core/qdev.c
- bus children are explicitly unreferenced, don't interfere
- parent_bus is essentially a read-only property that doesn't hold a
refcount, don't unref
- hotplug_handler is leaked, do unref
* hw/dma/xilinx_axidma.c
- rx stream "dma" links are set using set_link, therefore they
need unref
- tx streams are set using set_link, therefore they need unref
* hw/net/xilinx_axienet.c
- same reasoning as hw/dma/xilinx_axidma.c
* hw/pcmcia/pxa2xx.c
- pxa2xx bypasses set_link and therefore does not use refcounts
* hw/s390x/s390-virtio-bus.c
* hw/virtio/virtio-pci.c
* hw/virtio/virtio-rng.c
* ui/console.c
- set_link is used and there is no explicit unref, do unref
Cc: Peter Crosthwaite <peter.crosthwaite@petalogix.com>
Cc: Alexander Graf <agraf@suse.de>
Cc: Anthony Liguori <aliguori@amazon.com>
Cc: "Michael S. Tsirkin" <mst@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Andreas Färber <afaerber@suse.de>
2014-03-19 11:58:55 +04:00
|
|
|
(Object **)&bus->hotplug_handler,
|
2014-03-19 11:58:56 +04:00
|
|
|
object_property_allow_set_link,
|
qom: Make QOM link property unref optional
Some object_property_add_link() callers expect property deletion to
unref the link property object. Other callers expect to manage the
refcount themselves. The former are currently broken and therefore leak
the link property object.
This patch adds a flags argument to object_property_add_link() so the
caller can specify which refcount behavior they require. The new
OBJ_PROP_LINK_UNREF_ON_RELEASE flag causes the link pointer to be
unreferenced when the property is deleted.
This fixes refcount leaks in qdev.c, xilinx_axidma.c, xilinx_axienet.c,
s390-virtio-bus.c, virtio-pci.c, virtio-rng.c, and ui/console.c.
Rationale for refcount behavior:
* hw/core/qdev.c
- bus children are explicitly unreferenced, don't interfere
- parent_bus is essentially a read-only property that doesn't hold a
refcount, don't unref
- hotplug_handler is leaked, do unref
* hw/dma/xilinx_axidma.c
- rx stream "dma" links are set using set_link, therefore they
need unref
- tx streams are set using set_link, therefore they need unref
* hw/net/xilinx_axienet.c
- same reasoning as hw/dma/xilinx_axidma.c
* hw/pcmcia/pxa2xx.c
- pxa2xx bypasses set_link and therefore does not use refcounts
* hw/s390x/s390-virtio-bus.c
* hw/virtio/virtio-pci.c
* hw/virtio/virtio-rng.c
* ui/console.c
- set_link is used and there is no explicit unref, do unref
Cc: Peter Crosthwaite <peter.crosthwaite@petalogix.com>
Cc: Alexander Graf <agraf@suse.de>
Cc: Anthony Liguori <aliguori@amazon.com>
Cc: "Michael S. Tsirkin" <mst@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Andreas Färber <afaerber@suse.de>
2014-03-19 11:58:55 +04:00
|
|
|
OBJ_PROP_LINK_UNREF_ON_RELEASE,
|
|
|
|
NULL);
|
2013-11-26 02:48:40 +04:00
|
|
|
object_property_add_bool(obj, "realized",
|
|
|
|
bus_get_realized, bus_set_realized, NULL);
|
2012-02-03 23:32:19 +04:00
|
|
|
}
|
|
|
|
|
2013-05-29 11:56:42 +04:00
|
|
|
static char *default_bus_get_fw_dev_path(DeviceState *dev)
|
|
|
|
{
|
|
|
|
return g_strdup(object_get_typename(OBJECT(dev)));
|
|
|
|
}
|
|
|
|
|
2013-01-25 17:12:33 +04:00
|
|
|
static void bus_class_init(ObjectClass *class, void *data)
|
|
|
|
{
|
2013-05-29 11:56:42 +04:00
|
|
|
BusClass *bc = BUS_CLASS(class);
|
|
|
|
|
2013-01-25 17:12:33 +04:00
|
|
|
class->unparent = bus_unparent;
|
2013-05-29 11:56:42 +04:00
|
|
|
bc->get_fw_dev_path = default_bus_get_fw_dev_path;
|
2013-01-25 17:12:33 +04:00
|
|
|
}
|
|
|
|
|
2012-02-03 23:32:19 +04:00
|
|
|
static void qbus_finalize(Object *obj)
|
|
|
|
{
|
|
|
|
BusState *bus = BUS(obj);
|
|
|
|
|
|
|
|
g_free((char *)bus->name);
|
|
|
|
}
|
|
|
|
|
2012-05-02 11:00:20 +04:00
|
|
|
static const TypeInfo bus_info = {
|
|
|
|
.name = TYPE_BUS,
|
|
|
|
.parent = TYPE_OBJECT,
|
|
|
|
.instance_size = sizeof(BusState),
|
|
|
|
.abstract = true,
|
|
|
|
.class_size = sizeof(BusClass),
|
2012-02-03 23:32:19 +04:00
|
|
|
.instance_init = qbus_initfn,
|
|
|
|
.instance_finalize = qbus_finalize,
|
2013-01-25 17:12:33 +04:00
|
|
|
.class_init = bus_class_init,
|
2012-05-02 11:00:20 +04:00
|
|
|
};
|
|
|
|
|
2012-02-09 18:20:55 +04:00
|
|
|
static void qdev_register_types(void)
|
2011-12-17 00:34:46 +04:00
|
|
|
{
|
2012-05-02 11:00:20 +04:00
|
|
|
type_register_static(&bus_info);
|
2011-12-17 00:34:46 +04:00
|
|
|
type_register_static(&device_type_info);
|
|
|
|
}
|
|
|
|
|
2012-02-09 18:20:55 +04:00
|
|
|
type_init(qdev_register_types)
|