mirrors/qemu
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

hw/qdev: Don't crash if qdev_create(NULL, ...) fails

Browse Source 
If an attempt to create a qdev device on the default sysbus (by passing
NULL as the bus to qdev_create) fails, print a useful error message
rather than crashing trying to dereference a NULL pointer.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
This commit is contained in:
Peter Maydell 2011-08-03 23:49:04 +01:00 committed by Stefan Hajnoczi
parent 645a8ad6e1
commit e92714c71a
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
hw/qdev.c
View File

@ -111,7 +111,12 @@ DeviceState *qdev_create(BusState *bus, const char *name)
dev = qdev_try_create(bus, name);
if (!dev) {
hw_error("Unknown device '%s' for bus '%s'\n", name, bus->info->name);
if (bus) {
hw_error("Unknown device '%s' for bus '%s'\n", name,
bus->info->name);
} else {
hw_error("Unknown device '%s' for default sysbus\n", name);
}
}
return dev;